Preserve authored projection content and contextual canvas selection

crates/oa-core/src/language.rs

@@ -340,6 +340,18 @@ pub(crate) fn diagnostic(source: &str, error: Error) -> Diagnostic {
         },
     }
 }
+pub(crate) fn diagnostic_with_issue(
+    source: &str,
+    error: Error,
+    issue: Option<validation::Issue>,
+) -> Diagnostic {
+    let mut result = diagnostic(source, error);
+    if let Some(issue) = issue {
+        result.object_id = issue.element;
+        result.field = issue.field;
+    }
+    result
+}
 fn reserved(word: &str) -> bool {
     crate::reserved_alias(word)
         || declaration_kind(word).is_some()
@@ -622,6 +634,7 @@ fn parse_document(source: &str, limits: ParseLimits) -> Result<ParsedDocument, V
     if tokens.get(1).is_some_and(|t| t.text(source) == "2") {
         return v2_source::parse(source, tokens, limits);
     }
+    let mut migration_issue = None;
     Parser {
         source,
         tokens,
@@ -629,8 +642,8 @@ fn parse_document(source: &str, limits: ParseLimits) -> Result<ParsedDocument, V
         value_depth: 0,
         limits,
     }
-    .document()
-    .map_err(|e| vec![diagnostic(source, e)])
+    .document(&mut migration_issue)
+    .map_err(|e| vec![diagnostic_with_issue(source, e, migration_issue)])
 }
 fn offset_for(source: &str, line: usize, column: usize) -> usize {
     let mut offset = 0;
@@ -1449,7 +1462,10 @@ impl Parser<'_> {
             },
         }
     }
-    fn document(&mut self) -> Result<ParsedDocument, Error> {
+    fn document(
+        &mut self,
+        migration_issue: &mut Option<validation::Issue>,
+    ) -> Result<ParsedDocument, Error> {
         let unit = self.unit(true, false)?;
         let header = unit.header.expect("entry header");
         let mut aliases = BTreeMap::from([(header.project.alias.clone(), header.project.id)]);
@@ -1476,9 +1492,14 @@ impl Parser<'_> {
                     .map(|(key, span)| ((d.id, key.clone()), span.start)),
             );
         }
-        let decoded =
-            resolve_declarations(header.project, &unit.declarations, &aliases, self.limits)
-                .map_err(|(_, error)| error)?;
+        let decoded = resolve_declarations(
+            header.project,
+            &unit.declarations,
+            &aliases,
+            self.limits,
+            migration_issue,
+        )
+        .map_err(|(_, error)| error)?;
         Ok(ParsedDocument {
             project: decoded.project,
             migration: decoded.migration,
@@ -1682,6 +1703,7 @@ pub(crate) fn resolve_declarations(
     declarations: &[Declaration],
     aliases: &BTreeMap<String, Id>,
     limits: ParseLimits,
+    migration_issue: &mut Option<validation::Issue>,
 ) -> Result<crate::persistence::DecodeResult, (usize, Error)> {
     let legacy = project.schema_version == 3;
     let mut legacy_elements = serde_json::Map::new();
@@ -1989,6 +2011,38 @@ pub(crate) fn resolve_declarations(
             crate::persistence::migrate_v6(project, limits)
         })
         .map_err(|error| {
+            // These frozen admission checks formerly ran in final validation.
+            // Keep their diagnostic code and reference location after moving
+            // them before schema normalization.
+            if let crate::persistence::FileError::Model { issues, .. } = &error
+                && let Some(issue) = issues.first()
+                && let Some(code) = match issue.code.as_str() {
+                    "diagram_layer" => Some("diagram_layer"),
+                    "view_options" => Some("view_options"),
+                    _ => None,
+                }
+            {
+                let index = issue
+                    .element
+                    .and_then(|id| declarations.iter().position(|d| d.id == id))
+                    .unwrap_or(usize::MAX);
+                let offset = declarations.get(index).map_or(0, |d| {
+                    issue
+                        .field
+                        .as_ref()
+                        .and_then(|field| d.field_spans.get(field))
+                        .map_or(d.offset, |span| span.start)
+                });
+                *migration_issue = Some(issue.clone());
+                return (
+                    index,
+                    Error {
+                        code,
+                        offset,
+                        message: issue.message.clone(),
+                    },
+                );
+            }
             (
                 usize::MAX,
                 Error {