Preserve authored projection content and contextual canvas selection

crates/oa-desktop/src/app.rs

@@ -4,6 +4,8 @@ pub(crate) mod architecture_authoring;
 mod architecture_authoring_tests;
 #[cfg(test)]
 mod behavior_removal_tests;
+#[cfg(test)]
+mod canvas_selection_tests;
 mod checkpoints;
 #[cfg(test)]
 mod diagram_focus_tests;
@@ -381,6 +383,7 @@ pub enum Message {
     Behavior(crate::behavior::Event),
     Layer(Layer),
     Select(Id),
+    CanvasSelect(crate::route_edit::Context, Id),
     EditProperties(Id),
     SelectNode(Id),
     DiagramSelection(multiselect::Event),
@@ -1217,6 +1220,24 @@ impl App {
         }
         self.refresh_draft();
     }
+    /// Inspect an already validated canvas target without following its model layer.
+    fn inspect_canvas_target(&mut self, id: Id) -> bool {
+        if self.selected == id {
+            return true;
+        }
+        if !self.project().contains(id) || !self.apply() {
+            return false;
+        }
+        if !self.project().contains(id) {
+            return false;
+        }
+        self.selected = id;
+        self.selected_node = None;
+        self.selected_attachment = None;
+        self.selected_bend = None;
+        self.refresh_draft();
+        true
+    }
     fn reveal_explorer_selection(&mut self) {
         if let Some(group) = self.explorer_index.group(self.selected) {
             self.explorer_groups_collapsed.remove(&group);
@@ -1363,6 +1384,11 @@ impl App {
         {
             return Task::none();
         }
+        if let Message::CanvasSelect(captured, _) = &message
+            && (self.page != Page::Diagram || self.route_context() != Some(*captured))
+        {
+            return Task::none();
+        }
         // Selection can change without advancing the captured canvas context.
         if let Message::Route(
             crate::route_edit::Event::Commit(captured, changed, ..)
@@ -2118,6 +2144,7 @@ impl App {
             Message::Command(Command::Layout(diagram)) => self.saved_scenario_diagram(*diagram),
             Message::Projection(projection) => active || projection.scenario().is_some(),
             Message::SelectNode(_)
+            | Message::CanvasSelect(..)
             | Message::PlaceSelected
             | Message::HideSelected
             | Message::ToggleCollapse
@@ -2718,10 +2745,10 @@ impl App {
                                         e.kind() != Kind::Port && d.projection.includes(e.kind())
                                     })
                         });
-                if show_in_mixed_view {
-                    self.selected = menu.request.object;
-                    self.selected_attachment = None;
-                    self.refresh_draft();
+                if show_in_mixed_view || menu.request.canvas.is_some() {
+                    if !self.inspect_canvas_target(menu.request.object) {
+                        return Task::none();
+                    }
                 } else {
                     self.select(menu.request.object);
                 }
@@ -2889,6 +2916,14 @@ impl App {
                 self.status = "Property draft reverted".into();
             }
             Message::Select(id) => self.select(id),
+            Message::CanvasSelect(context, id) => {
+                let view = project_view(self.project(), context.diagram);
+                if view.ports.iter().any(|port| port.element == id)
+                    || view.edges.iter().any(|edge| edge.id == id)
+                {
+                    self.inspect_canvas_target(id);
+                }
+            }
             Message::DiagramSelection(event) => self.multiselect_event(event),
             Message::EditProperties(id) => {
                 self.select(id);
@@ -5086,17 +5121,9 @@ impl App {
                         &project_view(self.project(), context.diagram),
                         id,
                     );
-                    if session.tool == crate::connection_tool::Tool::Allocation
-                        && self.project().diagrams[&context.diagram].projection
-                            == ProjectionKind::Traceability
-                    {
-                        // Mixed views can allocate either perspective. Choosing
-                        // a visible source must not navigate to its preferred view.
-                        self.selected = id;
-                        self.selected_attachment = None;
-                        self.refresh_draft();
-                    } else {
-                        self.select(id);
+                    if !self.inspect_canvas_target(id) {
+                        self.connection = Some(session);
+                        return;
                     }
                     self.status = if session.candidates.is_empty() {
                         "No compatible targets are visible. Expand containers or show a compatible endpoint in this view; Esc cancels drawing.".into()