feat: add exact saved-view multiselection and atomic group movement
This commit is contained in:
@@ -60,6 +60,7 @@ impl Root<'_> {
|
||||
return false;
|
||||
}
|
||||
let canvas = DiagramCanvas {
|
||||
selection: self.app.diagram_selection.as_ref(),
|
||||
allocation: Some(self.app.allocation_capability()),
|
||||
project: self.app.project(),
|
||||
view_index: Some(self.app.document.view_index()),
|
||||
|
||||
@@ -15,6 +15,9 @@ mod diagram_reveal;
|
||||
mod diagram_selection_tests;
|
||||
mod diagram_usages;
|
||||
mod hosted;
|
||||
pub(crate) mod multiselect;
|
||||
#[cfg(test)]
|
||||
mod multiselect_tests;
|
||||
mod reference_authoring;
|
||||
#[cfg(test)]
|
||||
mod review_navigation_tests;
|
||||
@@ -364,6 +367,7 @@ pub enum Message {
|
||||
Select(Id),
|
||||
EditProperties(Id),
|
||||
SelectNode(Id),
|
||||
DiagramSelection(multiselect::Event),
|
||||
SelectProject,
|
||||
Search(String),
|
||||
StartTransition,
|
||||
@@ -507,6 +511,7 @@ pub struct App {
|
||||
pub layer: Layer,
|
||||
pub selected: Id,
|
||||
pub selected_node: Option<Id>,
|
||||
pub diagram_selection: Option<crate::diagram_selection::Selection>,
|
||||
pub draft: Option<Draft>,
|
||||
pub active_diagram: Option<Id>,
|
||||
pub search: String,
|
||||
@@ -627,6 +632,7 @@ impl App {
|
||||
layer,
|
||||
selected,
|
||||
selected_node: None,
|
||||
diagram_selection: None,
|
||||
draft,
|
||||
active_diagram,
|
||||
search: String::new(),
|
||||
@@ -1284,6 +1290,13 @@ impl App {
|
||||
])
|
||||
}
|
||||
pub fn update(&mut self, message: Message) -> Task<Message> {
|
||||
let selection_boundary = self.multiselect_boundary();
|
||||
// Reject delayed gestures before they can retire newer input ownership.
|
||||
if let Message::DiagramSelection(event) = &message
|
||||
&& !self.multiselect_envelope(event)
|
||||
{
|
||||
return Task::none();
|
||||
}
|
||||
// Captured Text commands validate their origin before they can
|
||||
// invalidate that same origin or pass into existing command handlers.
|
||||
if let Message::TextWorkspace(event) = message {
|
||||
@@ -1336,7 +1349,11 @@ impl App {
|
||||
self.reconcile_pending_diagram_reveal(&message);
|
||||
self.allocation_before(&message);
|
||||
if let Message::WorkDrag(event) = message {
|
||||
return self.allocation_event(event);
|
||||
let task = self.allocation_event(event);
|
||||
if self.multiselect_boundary() != selection_boundary {
|
||||
self.reconcile_multiselect();
|
||||
}
|
||||
return task;
|
||||
}
|
||||
let allocation_before = self.allocation_boundary();
|
||||
if let Message::BehaviorControl(intent) = message {
|
||||
@@ -1369,6 +1386,11 @@ impl App {
|
||||
self.camera_epoch = self.camera_epoch.wrapping_add(1);
|
||||
self.camera_boundary_epoch = self.canvas_epoch;
|
||||
}
|
||||
if self.multiselect_boundary() != selection_boundary
|
||||
|| (self.diagram_selection.is_none() && self.page == Page::Diagram)
|
||||
{
|
||||
self.reconcile_multiselect();
|
||||
}
|
||||
task
|
||||
}
|
||||
fn behavior_control(&mut self, intent: behavior::canvas_workspace::Intent) -> Task<Message> {
|
||||
@@ -1732,6 +1754,7 @@ impl App {
|
||||
message,
|
||||
Message::Page(_) | Message::Layer(_) | Message::Diagram(_)
|
||||
) {
|
||||
self.diagram_selection = None;
|
||||
self.canvas_epoch = self.canvas_epoch.wrapping_add(1);
|
||||
self.selected_bend = None;
|
||||
}
|
||||
@@ -2310,8 +2333,12 @@ impl App {
|
||||
"Apply or revert pending edits before using modeling actions.".into();
|
||||
return Task::none();
|
||||
}
|
||||
if matches!(*action, Message::DiagramSelection(_)) {
|
||||
return self.update(*action);
|
||||
}
|
||||
self.select(menu.request.object);
|
||||
self.selected_node = menu.request.placement;
|
||||
self.reconcile_multiselect();
|
||||
self.selected_bend = menu.request.bend.map(|i| (menu.request.object, i));
|
||||
return self.update(*action);
|
||||
}
|
||||
@@ -2469,6 +2496,7 @@ impl App {
|
||||
self.status = "Property draft reverted".into();
|
||||
}
|
||||
Message::Select(id) => self.select(id),
|
||||
Message::DiagramSelection(event) => self.multiselect_event(event),
|
||||
Message::EditProperties(id) => {
|
||||
self.select(id);
|
||||
self.inspector_tab = crate::navigation::InspectorTab::Properties;
|
||||
@@ -3126,7 +3154,21 @@ impl App {
|
||||
}
|
||||
}
|
||||
}
|
||||
Message::DiagramRemove(intent) => self.remove_from_diagram(intent),
|
||||
Message::DiagramRemove(intent) => {
|
||||
if self
|
||||
.multiselect_snapshot()
|
||||
.is_some_and(|s| s.targets().len() > 1)
|
||||
{
|
||||
// A pre-redraw singleton Delete cannot remove just one
|
||||
// member of a selection changed earlier in the same batch.
|
||||
if Some(intent.context) == self.route_context() {
|
||||
self.status =
|
||||
"Selection changed. Use Hide selected or press Delete again.".into();
|
||||
}
|
||||
} else {
|
||||
self.remove_from_diagram(intent);
|
||||
}
|
||||
}
|
||||
Message::DiagramTraverse(back) => {
|
||||
return if back {
|
||||
iced::widget::operation::focus_previous()
|
||||
@@ -3135,6 +3177,13 @@ impl App {
|
||||
};
|
||||
}
|
||||
Message::Delete => {
|
||||
if self
|
||||
.multiselect_snapshot()
|
||||
.is_some_and(|s| s.targets().len() > 1)
|
||||
{
|
||||
self.status = "Group model-deletion review is not available yet. Select one element or use Hide selected.".into();
|
||||
return Task::none();
|
||||
}
|
||||
if self.selected != self.project().id && self.apply() {
|
||||
self.begin_model_delete(None);
|
||||
}
|
||||
@@ -3266,6 +3315,13 @@ impl App {
|
||||
}
|
||||
}
|
||||
Message::HideSelected => {
|
||||
if let Some(snapshot) = self
|
||||
.multiselect_snapshot()
|
||||
.filter(|s| s.targets().len() > 1)
|
||||
{
|
||||
self.multiselect_event(multiselect::Event::Hide(snapshot));
|
||||
return Task::none();
|
||||
}
|
||||
if self.apply()
|
||||
&& let Some(node) = self.selected_node
|
||||
{
|
||||
@@ -3295,6 +3351,13 @@ impl App {
|
||||
}
|
||||
Message::Route(event) => self.edit_route(event),
|
||||
Message::MoveNode(node, position) => {
|
||||
if self
|
||||
.multiselect_snapshot()
|
||||
.is_some_and(|s| s.targets().len() > 1)
|
||||
{
|
||||
self.status = "Selection changed. Start the group drag again.".into();
|
||||
return Task::none();
|
||||
}
|
||||
let original = self.selected;
|
||||
if self.apply()
|
||||
&& let Some(diagram) = self.active_diagram
|
||||
|
||||
@@ -59,6 +59,7 @@ fn fixture(layer: Layer) -> Fixture {
|
||||
}
|
||||
fn canvas(app: &App) -> DiagramCanvas<'_> {
|
||||
DiagramCanvas {
|
||||
selection: None,
|
||||
allocation: Some(app.allocation_capability()),
|
||||
project: app.project(),
|
||||
view_index: Some(app.document.view_index()),
|
||||
|
||||
@@ -66,6 +66,7 @@ fn architecture_f2_routes_selected_node_to_inline_rename_and_exact_undo() {
|
||||
let camera = (app.zoom, app.pan);
|
||||
let bounds = iced::Rectangle::new(iced::Point::ORIGIN, iced::Size::new(600., 380.));
|
||||
let canvas = crate::diagram::DiagramCanvas {
|
||||
selection: None,
|
||||
project: app.project(),
|
||||
view_index: None,
|
||||
diagram: app.active_diagram.unwrap(),
|
||||
|
||||
@@ -221,6 +221,7 @@ fn architecture_canvas_left_click_uses_world_coordinate_once_at_zoom_and_pan() {
|
||||
y: (local.y - app.pan.y) / app.zoom,
|
||||
};
|
||||
let canvas = crate::diagram::DiagramCanvas {
|
||||
selection: None,
|
||||
project: app.project(),
|
||||
view_index: None,
|
||||
diagram: app.active_diagram.unwrap(),
|
||||
@@ -298,6 +299,7 @@ fn architecture_f2_rename_preserves_identity_placement_and_atomic_history() {
|
||||
let diagrams = app.project().diagrams.clone();
|
||||
let camera = (app.zoom, app.pan);
|
||||
let canvas = crate::diagram::DiagramCanvas {
|
||||
selection: None,
|
||||
project: app.project(),
|
||||
view_index: None,
|
||||
diagram: app.active_diagram.unwrap(),
|
||||
|
||||
@@ -154,3 +154,347 @@ async fn mounted_f2_requires_canvas_focus_and_yields_to_clean_inspector() {
|
||||
}
|
||||
}
|
||||
}
|
||||
// Append to app/diagram_focus_tests.rs after the frozen desktop gate.
|
||||
// Reuses its imports and FocusField, plus Mounted/key from canvas_workspace tests.
|
||||
|
||||
async fn modifier_focus_fixture() -> (App, Mounted, Id, Id, Id) {
|
||||
let mut project = Project::empty();
|
||||
let a = project
|
||||
.add_element(Kind::Entity, Layer::Oa, "First team", None)
|
||||
.unwrap();
|
||||
let b = project
|
||||
.add_element(Kind::Entity, Layer::Oa, "Second team", None)
|
||||
.unwrap();
|
||||
let diagram = project.ensure_diagram(Layer::Oa);
|
||||
let first = project.place(diagram, a, Position { x: 80., y: 80. });
|
||||
let second = project.place(diagram, b, Position { x: 500., y: 80. });
|
||||
let mut app = App::with_project(project);
|
||||
app.page = Page::Diagram;
|
||||
app.layer = Layer::Oa;
|
||||
app.active_diagram = Some(diagram);
|
||||
app.window_size = Size::new(2000., 1400.);
|
||||
let _ = app.update(Message::Select(a));
|
||||
let mut mounted = Mounted::new(&mut app).await;
|
||||
app.zoom = 1.;
|
||||
app.pan = Vector::ZERO;
|
||||
app.fit_to_view = false;
|
||||
mounted.settle(&mut app).await;
|
||||
(app, mounted, diagram, first, second)
|
||||
}
|
||||
|
||||
fn modifier_node_point(mounted: &mut Mounted, app: &App, diagram: Id, placement: Id) -> Point {
|
||||
let bounds = mounted
|
||||
.geometry(app)
|
||||
.bounds(crate::allocation_input::CANVAS_ID);
|
||||
let node = projection::project_view(app.project(), diagram)
|
||||
.nodes
|
||||
.into_iter()
|
||||
.find(|n| n.id == placement)
|
||||
.unwrap();
|
||||
Point::new(
|
||||
bounds.x + node.position.x + 40.,
|
||||
bounds.y + node.position.y + 35.,
|
||||
)
|
||||
}
|
||||
|
||||
fn modifier_canvas_focused(mounted: &mut Mounted, app: &App) -> bool {
|
||||
mounted
|
||||
.geometry(app)
|
||||
.focused
|
||||
.iter()
|
||||
.find(|(id, _, _)| {
|
||||
id.as_ref() == Some(&iced::advanced::widget::Id::from("diagram-keyboard-owner"))
|
||||
})
|
||||
.expect("production focus::Owner is mounted")
|
||||
.2
|
||||
}
|
||||
|
||||
fn modifier_event(shift: bool) -> iced::Event {
|
||||
iced::Event::Keyboard(iced::keyboard::Event::ModifiersChanged(if shift {
|
||||
iced::keyboard::Modifiers::SHIFT
|
||||
} else {
|
||||
iced::keyboard::Modifiers::default()
|
||||
}))
|
||||
}
|
||||
|
||||
#[tokio::test]
|
||||
async fn mounted_shift_before_canvas_focus_toggles_exact_node_without_granting_keyboard_focus() {
|
||||
use crate::diagram_usage::Target;
|
||||
let (mut app, mut mounted, diagram, first, second) = modifier_focus_fixture().await;
|
||||
let before = app.document.snapshot();
|
||||
let field = mounted
|
||||
.geometry(&app)
|
||||
.text_inputs
|
||||
.into_iter()
|
||||
.filter(|bounds| bounds.x > app.window_size.width - 320.)
|
||||
.min_by(|a, b| a.y.total_cmp(&b.y))
|
||||
.expect("clean Inspector name input");
|
||||
mounted.operate(&app, &mut FocusField(field));
|
||||
assert!(!modifier_canvas_focused(&mut mounted, &app));
|
||||
assert_eq!(
|
||||
app.multiselect_snapshot().unwrap().targets(),
|
||||
&[Target::Placement(first)]
|
||||
);
|
||||
mounted
|
||||
.batch(
|
||||
&mut app,
|
||||
&[modifier_event(true)],
|
||||
mouse::Cursor::Unavailable,
|
||||
)
|
||||
.await;
|
||||
assert!(
|
||||
!modifier_canvas_focused(&mut mounted, &app),
|
||||
"modifier tracking must not acquire focus"
|
||||
);
|
||||
let at = modifier_node_point(&mut mounted, &app, diagram, second);
|
||||
let messages = mounted.click(&mut app, at).await;
|
||||
assert!(messages.iter().any(|m| matches!(m,
|
||||
Message::DiagramSelection(multiselect::Event::Choose(_, Target::Placement(id), multiselect::Choice::Toggle)) if *id == second
|
||||
)), "Shift already held before the first canvas press must reach its exact-target adapter");
|
||||
assert_eq!(
|
||||
app.multiselect_snapshot().unwrap().targets(),
|
||||
&[Target::Placement(first), Target::Placement(second)]
|
||||
);
|
||||
assert_eq!(app.selected_node, Some(second));
|
||||
assert_eq!(app.project(), &before.decoded.project);
|
||||
assert_eq!(app.document.bundle(), &before.bundle);
|
||||
assert!(!app.document.can_undo());
|
||||
assert!(!app.draft_dirty());
|
||||
}
|
||||
|
||||
#[tokio::test]
|
||||
async fn mounted_unfocused_typing_and_delete_remain_denied_after_passive_modifiers() {
|
||||
use crate::diagram_usage::Target;
|
||||
let (mut app, mut mounted, diagram, first, second) = modifier_focus_fixture().await;
|
||||
mounted
|
||||
.batch(
|
||||
&mut app,
|
||||
&[modifier_event(true)],
|
||||
mouse::Cursor::Unavailable,
|
||||
)
|
||||
.await;
|
||||
let at = modifier_node_point(&mut mounted, &app, diagram, second);
|
||||
mounted.click(&mut app, at).await;
|
||||
assert_eq!(
|
||||
app.multiselect_snapshot().unwrap().targets(),
|
||||
&[Target::Placement(first), Target::Placement(second)]
|
||||
);
|
||||
// Revoke every field's focus through the real widget operation. No widget
|
||||
// has this off-window rectangle, so neither Inspector nor canvas owns keys.
|
||||
mounted.operate(
|
||||
&app,
|
||||
&mut FocusField(Rectangle {
|
||||
x: -1000.,
|
||||
y: -1000.,
|
||||
width: 1.,
|
||||
height: 1.,
|
||||
}),
|
||||
);
|
||||
assert!(!modifier_canvas_focused(&mut mounted, &app));
|
||||
let before = app.document.snapshot();
|
||||
let selection = app.multiselect_snapshot().unwrap();
|
||||
let messages = mounted
|
||||
.batch(
|
||||
&mut app,
|
||||
&[
|
||||
modifier_event(false),
|
||||
crate::behavior::canvas_workspace::tests::character("x"),
|
||||
key(Named::Delete),
|
||||
key(Named::F2),
|
||||
],
|
||||
mouse::Cursor::Unavailable,
|
||||
)
|
||||
.await;
|
||||
assert!(!messages.iter().any(|m| matches!(
|
||||
m,
|
||||
Message::DiagramSelection(_)
|
||||
| Message::DiagramRemove(_)
|
||||
| Message::HideSelected
|
||||
| Message::Delete
|
||||
)));
|
||||
assert!(!rename_emitted(&messages));
|
||||
assert!(!modifier_canvas_focused(&mut mounted, &app));
|
||||
assert_eq!(
|
||||
app.multiselect_snapshot().unwrap().targets(),
|
||||
selection.targets()
|
||||
);
|
||||
assert_eq!(app.project(), &before.decoded.project);
|
||||
assert_eq!(app.document.bundle(), &before.bundle);
|
||||
assert!(!app.document.can_undo());
|
||||
assert!(!app.draft_dirty());
|
||||
assert!(!app.delete_pending);
|
||||
}
|
||||
|
||||
#[tokio::test]
|
||||
async fn mounted_suspended_modifiers_are_passive_and_survive_until_resumed_click() {
|
||||
use crate::diagram_usage::Target;
|
||||
let (mut app, mut mounted, diagram, first, second) = modifier_focus_fixture().await;
|
||||
let before = app.document.snapshot();
|
||||
let at = modifier_node_point(&mut mounted, &app, diagram, second);
|
||||
app.busy = true;
|
||||
mounted.settle(&mut app).await;
|
||||
assert!(!modifier_canvas_focused(&mut mounted, &app));
|
||||
mounted
|
||||
.batch(
|
||||
&mut app,
|
||||
&[modifier_event(true), key(Named::Delete)],
|
||||
mouse::Cursor::Unavailable,
|
||||
)
|
||||
.await;
|
||||
mounted.click(&mut app, at).await;
|
||||
assert!(
|
||||
!modifier_canvas_focused(&mut mounted, &app),
|
||||
"passive I/O cannot grant canvas focus"
|
||||
);
|
||||
assert_eq!(
|
||||
app.multiselect_snapshot().unwrap().targets(),
|
||||
&[Target::Placement(first)]
|
||||
);
|
||||
assert_eq!(app.document.bundle(), &before.bundle);
|
||||
app.busy = false;
|
||||
mounted.settle(&mut app).await;
|
||||
assert!(!modifier_canvas_focused(&mut mounted, &app));
|
||||
mounted.click(&mut app, at).await;
|
||||
assert_eq!(
|
||||
app.multiselect_snapshot().unwrap().targets(),
|
||||
&[Target::Placement(first), Target::Placement(second)]
|
||||
);
|
||||
assert_eq!(app.project(), &before.decoded.project);
|
||||
assert_eq!(app.document.bundle(), &before.bundle);
|
||||
assert!(!app.document.can_undo());
|
||||
}
|
||||
|
||||
#[tokio::test]
|
||||
async fn mounted_shift_held_before_suspension_survives_without_another_modifier_event() {
|
||||
use crate::diagram_usage::Target;
|
||||
let (mut app, mut mounted, diagram, first, second) = modifier_focus_fixture().await;
|
||||
let before = app.document.snapshot();
|
||||
let field = mounted
|
||||
.geometry(&app)
|
||||
.text_inputs
|
||||
.into_iter()
|
||||
.filter(|bounds| bounds.x > app.window_size.width - 320.)
|
||||
.min_by(|a, b| a.y.total_cmp(&b.y))
|
||||
.expect("clean Inspector name input");
|
||||
mounted.operate(&app, &mut FocusField(field));
|
||||
mounted
|
||||
.batch(
|
||||
&mut app,
|
||||
&[modifier_event(true)],
|
||||
mouse::Cursor::Unavailable,
|
||||
)
|
||||
.await;
|
||||
assert!(!modifier_canvas_focused(&mut mounted, &app));
|
||||
app.busy = true;
|
||||
mounted.settle(&mut app).await;
|
||||
assert!(!modifier_canvas_focused(&mut mounted, &app));
|
||||
app.busy = false;
|
||||
mounted.settle(&mut app).await;
|
||||
assert!(
|
||||
!modifier_canvas_focused(&mut mounted, &app),
|
||||
"restoring passive modifiers must not grant keyboard focus"
|
||||
);
|
||||
assert_eq!(
|
||||
app.multiselect_snapshot().unwrap().targets(),
|
||||
&[Target::Placement(first)]
|
||||
);
|
||||
// No modifier transition follows the subtree replacement during I/O.
|
||||
let at = modifier_node_point(&mut mounted, &app, diagram, second);
|
||||
let messages = mounted.click(&mut app, at).await;
|
||||
assert!(messages.iter().any(|m| matches!(m,
|
||||
Message::DiagramSelection(multiselect::Event::Choose(_, Target::Placement(id), multiselect::Choice::Toggle)) if *id == second
|
||||
)));
|
||||
assert_eq!(
|
||||
app.multiselect_snapshot().unwrap().targets(),
|
||||
&[Target::Placement(first), Target::Placement(second)]
|
||||
);
|
||||
assert_eq!(app.project(), &before.decoded.project);
|
||||
assert_eq!(app.document.bundle(), &before.bundle);
|
||||
assert!(!app.document.can_undo());
|
||||
assert!(!app.draft_dirty());
|
||||
}
|
||||
|
||||
#[tokio::test]
|
||||
async fn mounted_shift_release_or_window_unfocus_during_suspension_does_not_restore_stale_shift() {
|
||||
use crate::diagram_usage::Target;
|
||||
for release in [
|
||||
modifier_event(false),
|
||||
iced::Event::Window(iced::window::Event::Unfocused),
|
||||
] {
|
||||
let (mut app, mut mounted, diagram, first, second) = modifier_focus_fixture().await;
|
||||
let before = app.document.snapshot();
|
||||
mounted
|
||||
.batch(
|
||||
&mut app,
|
||||
&[modifier_event(true)],
|
||||
mouse::Cursor::Unavailable,
|
||||
)
|
||||
.await;
|
||||
app.busy = true;
|
||||
mounted.settle(&mut app).await;
|
||||
mounted
|
||||
.batch(&mut app, &[release], mouse::Cursor::Unavailable)
|
||||
.await;
|
||||
assert!(!modifier_canvas_focused(&mut mounted, &app));
|
||||
app.busy = false;
|
||||
mounted.settle(&mut app).await;
|
||||
// A further I/O cycle must restore the updated owner state too.
|
||||
app.busy = true;
|
||||
mounted.settle(&mut app).await;
|
||||
app.busy = false;
|
||||
mounted.settle(&mut app).await;
|
||||
assert!(!modifier_canvas_focused(&mut mounted, &app));
|
||||
assert_eq!(
|
||||
app.multiselect_snapshot().unwrap().targets(),
|
||||
&[Target::Placement(first)]
|
||||
);
|
||||
let at = modifier_node_point(&mut mounted, &app, diagram, second);
|
||||
let messages = mounted.click(&mut app, at).await;
|
||||
assert!(!messages.iter().any(|m| matches!(
|
||||
m,
|
||||
Message::DiagramSelection(multiselect::Event::Choose(
|
||||
_,
|
||||
_,
|
||||
multiselect::Choice::Toggle
|
||||
))
|
||||
)));
|
||||
assert_eq!(
|
||||
app.multiselect_snapshot().unwrap().targets(),
|
||||
&[Target::Placement(second)]
|
||||
);
|
||||
assert_eq!(app.project(), &before.decoded.project);
|
||||
assert_eq!(app.document.bundle(), &before.bundle);
|
||||
assert!(!app.document.can_undo());
|
||||
assert!(!app.draft_dirty());
|
||||
}
|
||||
}
|
||||
|
||||
#[tokio::test]
|
||||
async fn mounted_window_unfocus_resets_held_shift_before_next_canvas_press() {
|
||||
use crate::diagram_usage::Target;
|
||||
let (mut app, mut mounted, diagram, first, second) = modifier_focus_fixture().await;
|
||||
let at_first = modifier_node_point(&mut mounted, &app, diagram, first);
|
||||
mounted.click(&mut app, at_first).await;
|
||||
let before = app.document.snapshot();
|
||||
mounted
|
||||
.batch(
|
||||
&mut app,
|
||||
&[
|
||||
modifier_event(true),
|
||||
iced::Event::Window(iced::window::Event::Unfocused),
|
||||
],
|
||||
mouse::Cursor::Unavailable,
|
||||
)
|
||||
.await;
|
||||
assert!(!modifier_canvas_focused(&mut mounted, &app));
|
||||
// No ModifiersChanged(empty) follows: a lost window must itself reset it.
|
||||
let at_second = modifier_node_point(&mut mounted, &app, diagram, second);
|
||||
mounted.click(&mut app, at_second).await;
|
||||
assert_eq!(
|
||||
app.multiselect_snapshot().unwrap().targets(),
|
||||
&[Target::Placement(second)]
|
||||
);
|
||||
assert_eq!(app.project(), &before.decoded.project);
|
||||
assert_eq!(app.document.bundle(), &before.bundle);
|
||||
assert!(!app.document.can_undo());
|
||||
}
|
||||
|
||||
@@ -0,0 +1,337 @@
|
||||
//! Exact saved-view selection and atomic group commands.
|
||||
use super::*;
|
||||
use crate::diagram_selection::{Context, Scope, Selection, Snapshot};
|
||||
use crate::diagram_usage::{Surface, Target};
|
||||
|
||||
#[derive(Debug, Clone, Copy)]
|
||||
pub(crate) enum Choice {
|
||||
Replace,
|
||||
Add,
|
||||
Remove,
|
||||
Toggle,
|
||||
Inspect,
|
||||
}
|
||||
|
||||
#[derive(Debug, Clone)]
|
||||
pub(crate) enum Event {
|
||||
Choose(Context, Target, Choice),
|
||||
Collapse(Snapshot, Target),
|
||||
Clear(Context),
|
||||
Move(Snapshot, Position),
|
||||
Hide(Snapshot),
|
||||
Refuse(Snapshot, String),
|
||||
}
|
||||
|
||||
pub(crate) fn context(c: crate::route_edit::Context) -> Context {
|
||||
Context {
|
||||
scope: Scope {
|
||||
document: c.document,
|
||||
surface: Surface::Saved(c.diagram),
|
||||
},
|
||||
revision: c.revision,
|
||||
epoch: c.epoch,
|
||||
}
|
||||
}
|
||||
|
||||
/// The entire typed set must support a placement action. Never filter a mixture.
|
||||
pub(crate) fn placements(snapshot: &Snapshot) -> Option<std::collections::BTreeSet<Id>> {
|
||||
snapshot.primary()?;
|
||||
if snapshot.targets().is_empty() {
|
||||
return None;
|
||||
}
|
||||
snapshot
|
||||
.targets()
|
||||
.iter()
|
||||
.map(|target| match target {
|
||||
Target::Placement(id) => Some(*id),
|
||||
_ => None,
|
||||
})
|
||||
.collect()
|
||||
}
|
||||
|
||||
fn visible(view: &projection::ProjectedView, target: &Target) -> bool {
|
||||
match target {
|
||||
Target::Placement(id) => view.nodes.iter().any(|n| n.id == *id),
|
||||
Target::Port { port, placement } => view
|
||||
.ports
|
||||
.iter()
|
||||
.any(|p| p.element == *port && p.owner == *placement),
|
||||
Target::Edge(id) => view.edges.iter().any(|e| e.id == *id),
|
||||
_ => false,
|
||||
}
|
||||
}
|
||||
|
||||
impl App {
|
||||
pub(crate) fn multiselect_boundary(&self) -> impl PartialEq + use<> {
|
||||
(
|
||||
self.canvas_document,
|
||||
self.document.revision(),
|
||||
self.page,
|
||||
self.active_diagram,
|
||||
self.selected,
|
||||
self.selected_node,
|
||||
)
|
||||
}
|
||||
pub(crate) fn multiselect_context(&self) -> Option<Context> {
|
||||
// Other surfaces retain their existing adapters until their typed group
|
||||
// operations are implemented; never reuse an Architecture selection there.
|
||||
(self.page == Page::Diagram)
|
||||
.then(|| self.route_context().map(context))
|
||||
.flatten()
|
||||
}
|
||||
|
||||
pub(crate) fn multiselect_snapshot(&self) -> Option<Snapshot> {
|
||||
self.diagram_selection
|
||||
.as_ref()?
|
||||
.snapshot(self.multiselect_context()?)
|
||||
}
|
||||
|
||||
pub(crate) fn multiselect_envelope(&self, event: &Event) -> bool {
|
||||
let Some(current) = self.multiselect_context() else {
|
||||
return false;
|
||||
};
|
||||
match event {
|
||||
Event::Choose(c, ..) | Event::Clear(c) => *c == current,
|
||||
Event::Move(s, _) | Event::Hide(s) | Event::Refuse(s, _) | Event::Collapse(s, _) => {
|
||||
self.diagram_selection
|
||||
.as_ref()
|
||||
.is_some_and(|selection| selection.matches(s, current))
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
fn legacy_target(&self, view: &projection::ProjectedView) -> Option<Target> {
|
||||
if let Some(id) = self.selected_node
|
||||
&& view.nodes.iter().any(|node| {
|
||||
node.id == id && (node.element == self.selected || node.id == self.selected)
|
||||
})
|
||||
{
|
||||
return Some(Target::Placement(id));
|
||||
}
|
||||
if let Some(port) = view.ports.iter().find(|port| port.element == self.selected) {
|
||||
return Some(Target::Port {
|
||||
port: port.element,
|
||||
placement: port.owner,
|
||||
});
|
||||
}
|
||||
view.edges
|
||||
.iter()
|
||||
.any(|edge| edge.id == self.selected)
|
||||
.then_some(Target::Edge(self.selected))
|
||||
}
|
||||
|
||||
pub(crate) fn reconcile_multiselect(&mut self) {
|
||||
let Some(current) = self.multiselect_context() else {
|
||||
self.diagram_selection = None;
|
||||
return;
|
||||
};
|
||||
let Surface::Saved(diagram) = current.scope.surface else {
|
||||
return;
|
||||
};
|
||||
let view = projection::project_view_with_index(
|
||||
self.project(),
|
||||
diagram,
|
||||
self.document.view_index(),
|
||||
);
|
||||
let legacy = self.legacy_target(&view);
|
||||
let lost_primary = self
|
||||
.diagram_selection
|
||||
.as_ref()
|
||||
.filter(|s| s.scope() == current.scope)
|
||||
.and_then(|s| s.primary())
|
||||
.is_some_and(|target| !visible(&view, target));
|
||||
let held_primary = self
|
||||
.diagram_selection
|
||||
.as_ref()
|
||||
.filter(|s| s.scope() == current.scope)
|
||||
.and_then(|s| s.primary())
|
||||
.is_some_and(|target| match target {
|
||||
Target::Placement(id) => self.selected_node == Some(*id),
|
||||
Target::Port { port, .. } => self.selected == *port,
|
||||
Target::Edge(id) => self.selected == *id,
|
||||
_ => false,
|
||||
});
|
||||
let selection = self
|
||||
.diagram_selection
|
||||
.get_or_insert_with(|| Selection::new(current.scope));
|
||||
selection.reconcile(current.scope, |target| visible(&view, target));
|
||||
// Navigation/property selection remains explicit. A removed exact target
|
||||
// is never rebound through its semantic identity to a different placement.
|
||||
if held_primary || lost_primary {
|
||||
if selection.primary() != legacy.as_ref() {
|
||||
self.inspect_multiselect_primary();
|
||||
}
|
||||
} else if selection.primary() != legacy.as_ref() {
|
||||
if let Some(target) = legacy {
|
||||
selection.replace(target, |target| visible(&view, target));
|
||||
} else {
|
||||
selection.clear();
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
fn inspect_multiselect_primary(&mut self) {
|
||||
let primary = self
|
||||
.diagram_selection
|
||||
.as_ref()
|
||||
.and_then(|s| s.primary())
|
||||
.cloned();
|
||||
self.selected_node = None;
|
||||
match primary {
|
||||
Some(Target::Placement(id)) => {
|
||||
if let Some(node) = self
|
||||
.active_diagram
|
||||
.and_then(|d| self.project().diagrams.get(&d))
|
||||
.and_then(|d| d.nodes.get(&id))
|
||||
{
|
||||
self.selected = node.element;
|
||||
self.selected_node = Some(id);
|
||||
}
|
||||
}
|
||||
Some(Target::Port { port, .. }) => self.selected = port,
|
||||
Some(Target::Edge(id)) => self.selected = id,
|
||||
_ => self.selected = self.active_diagram.unwrap_or(self.project().id),
|
||||
}
|
||||
self.selected_bend = None;
|
||||
self.selected_attachment = None;
|
||||
self.refresh_draft();
|
||||
}
|
||||
|
||||
pub(crate) fn multiselect_event(&mut self, event: Event) {
|
||||
if !self.multiselect_envelope(&event) {
|
||||
return;
|
||||
}
|
||||
if !diagram_removal::enabled(self)
|
||||
|| self.architecture.is_some()
|
||||
|| self.connection.is_some()
|
||||
{
|
||||
self.status =
|
||||
"Finish or cancel the active edit before changing the diagram selection.".into();
|
||||
return;
|
||||
}
|
||||
let current = self.multiselect_context().unwrap();
|
||||
let Surface::Saved(diagram) = current.scope.surface else {
|
||||
return;
|
||||
};
|
||||
let view = projection::project_view_with_index(
|
||||
self.project(),
|
||||
diagram,
|
||||
self.document.view_index(),
|
||||
);
|
||||
match event {
|
||||
Event::Collapse(_, target) => {
|
||||
if !visible(&view, &target) {
|
||||
return;
|
||||
}
|
||||
self.diagram_selection
|
||||
.as_mut()
|
||||
.unwrap()
|
||||
.replace(target, |target| visible(&view, target));
|
||||
self.inspect_multiselect_primary();
|
||||
}
|
||||
Event::Choose(_, target, choice) => {
|
||||
if !visible(&view, &target) {
|
||||
return;
|
||||
}
|
||||
self.reconcile_multiselect();
|
||||
let selection = self.diagram_selection.as_mut().unwrap();
|
||||
let valid = |target: &Target| visible(&view, target);
|
||||
match choice {
|
||||
Choice::Replace => {
|
||||
selection.replace(target, valid);
|
||||
}
|
||||
Choice::Add => {
|
||||
selection.add(target, valid);
|
||||
}
|
||||
Choice::Remove => {
|
||||
selection.remove(&target);
|
||||
}
|
||||
Choice::Toggle => {
|
||||
selection.toggle(target, valid);
|
||||
}
|
||||
Choice::Inspect => {
|
||||
selection.set_primary(&target);
|
||||
}
|
||||
}
|
||||
self.inspect_multiselect_primary();
|
||||
}
|
||||
Event::Clear(_) => {
|
||||
if let Some(selection) = &mut self.diagram_selection {
|
||||
selection.clear();
|
||||
}
|
||||
self.inspect_multiselect_primary();
|
||||
}
|
||||
Event::Refuse(_, reason) => self.status = reason,
|
||||
Event::Move(snapshot, delta) => {
|
||||
let Some(ids) = placements(&snapshot) else {
|
||||
self.status = "Move requires only placed elements. Remove ports and connections from the selection.".into();
|
||||
return;
|
||||
};
|
||||
if !snapshot
|
||||
.targets()
|
||||
.iter()
|
||||
.all(|target| visible(&view, target))
|
||||
{
|
||||
return;
|
||||
}
|
||||
if self.project().diagrams[&diagram].projection == ProjectionKind::Allocation
|
||||
&& ids.iter().any(|id| {
|
||||
self.project().elements
|
||||
[&self.project().diagrams[&diagram].nodes[id].element]
|
||||
.kind()
|
||||
.is_work()
|
||||
})
|
||||
{
|
||||
self.status =
|
||||
"Group allocation drag is not available yet. The selection was retained."
|
||||
.into();
|
||||
return;
|
||||
}
|
||||
if delta.x == 0. && delta.y == 0. {
|
||||
return;
|
||||
}
|
||||
match oa_core::diagram_edit::translate_placements(
|
||||
self.project(),
|
||||
diagram,
|
||||
&ids,
|
||||
delta,
|
||||
) {
|
||||
Ok(command) => {
|
||||
if self.execute(command) {
|
||||
self.inspect_multiselect_primary();
|
||||
self.status = format!(
|
||||
"Moved {} selected elements · Undo restores the group",
|
||||
ids.len()
|
||||
);
|
||||
}
|
||||
}
|
||||
Err(error) => self.status = error.to_string(),
|
||||
}
|
||||
}
|
||||
Event::Hide(snapshot) => {
|
||||
let Some(ids) = placements(&snapshot) else {
|
||||
self.status =
|
||||
"Hide requires only placed elements. Model objects remain unchanged."
|
||||
.into();
|
||||
return;
|
||||
};
|
||||
if !snapshot
|
||||
.targets()
|
||||
.iter()
|
||||
.all(|target| visible(&view, target))
|
||||
{
|
||||
return;
|
||||
}
|
||||
if self.execute(Command::Batch(
|
||||
ids.iter().copied().map(Command::Delete).collect(),
|
||||
)) {
|
||||
if let Some(selection) = &mut self.diagram_selection {
|
||||
selection.clear();
|
||||
}
|
||||
self.inspect_multiselect_primary();
|
||||
self.status = format!("Hid {} placements · Model objects retained", ids.len());
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,602 @@
|
||||
//! Saved-view group operations through the real App message boundary.
|
||||
use super::multiselect::{Choice as GroupChoice, Event as GroupEvent};
|
||||
use super::*;
|
||||
use crate::diagram_usage::Target;
|
||||
|
||||
fn point(x: f32, y: f32) -> Position {
|
||||
Position { x, y }
|
||||
}
|
||||
|
||||
struct Fixture {
|
||||
app: App,
|
||||
diagram: Id,
|
||||
a: Id,
|
||||
b: Id,
|
||||
child: Id,
|
||||
edge: Id,
|
||||
}
|
||||
|
||||
fn fixture() -> Fixture {
|
||||
let mut p = Project::empty();
|
||||
let a = p
|
||||
.add_element(Kind::Function, Layer::Sa, "Send", None)
|
||||
.unwrap();
|
||||
let b = p
|
||||
.add_element(Kind::Function, Layer::Sa, "Receive", None)
|
||||
.unwrap();
|
||||
let child = p
|
||||
.add_element(Kind::Function, Layer::Sa, "Prepare", Some(a))
|
||||
.unwrap();
|
||||
let edge = p.relate(RelationKind::FunctionalExchange, "Signal", a, b);
|
||||
let diagram = p.ensure_diagram(Layer::Sa);
|
||||
p.diagrams.get_mut(&diagram).unwrap().projection = ProjectionKind::FunctionalDataflow;
|
||||
let a = p.place(diagram, a, point(10., 20.));
|
||||
let b = p.place(diagram, b, point(500., 20.));
|
||||
let child = p.place(diagram, child, point(40., 100.));
|
||||
p.diagrams
|
||||
.get_mut(&diagram)
|
||||
.unwrap()
|
||||
.routes
|
||||
.push(EdgeRoute {
|
||||
edge,
|
||||
source_attachment: Some(EdgeAttachment {
|
||||
side: PortAnchorSide::Bottom,
|
||||
offset: 0.3,
|
||||
}),
|
||||
target_attachment: Some(EdgeAttachment {
|
||||
side: PortAnchorSide::Top,
|
||||
offset: 0.7,
|
||||
}),
|
||||
waypoints: vec![point(370., 150.)],
|
||||
label: Some(EdgeLabel {
|
||||
fraction: 0.4,
|
||||
offset: point(5., -9.),
|
||||
}),
|
||||
});
|
||||
let other = p
|
||||
.add_element(Kind::Activity, Layer::Oa, "Operational work", None)
|
||||
.unwrap();
|
||||
let other_diagram = p.ensure_diagram(Layer::Oa);
|
||||
p.place(other_diagram, other, point(-50., -100.));
|
||||
let mut app = App::with_project(p);
|
||||
app.page = Page::Diagram;
|
||||
app.layer = Layer::Sa;
|
||||
app.active_diagram = Some(diagram);
|
||||
app.selected = diagram;
|
||||
app.selected_node = None;
|
||||
app.refresh_draft();
|
||||
app.reconcile_multiselect();
|
||||
Fixture {
|
||||
app,
|
||||
diagram,
|
||||
a,
|
||||
b,
|
||||
child,
|
||||
edge,
|
||||
}
|
||||
}
|
||||
|
||||
fn dispatch(app: &mut App, event: GroupEvent) {
|
||||
let _ = app.update(Message::DiagramSelection(event));
|
||||
}
|
||||
fn choose(app: &mut App, target: Target, choice: GroupChoice) {
|
||||
let context = app.multiselect_context().unwrap();
|
||||
dispatch(app, GroupEvent::Choose(context, target, choice));
|
||||
}
|
||||
fn select_pair(f: &mut Fixture) {
|
||||
choose(&mut f.app, Target::Placement(f.a), GroupChoice::Replace);
|
||||
choose(&mut f.app, Target::Placement(f.b), GroupChoice::Toggle);
|
||||
assert_eq!(
|
||||
f.app.multiselect_snapshot().unwrap().targets(),
|
||||
&[Target::Placement(f.a), Target::Placement(f.b)]
|
||||
);
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn queued_singleton_move_or_delete_cannot_partially_edit_a_new_group() {
|
||||
for model in [false, true] {
|
||||
let mut f = fixture();
|
||||
select_pair(&mut f);
|
||||
let before = f.app.document.snapshot();
|
||||
let selected = f.app.multiselect_snapshot().unwrap();
|
||||
let object = f.app.project().diagrams[&f.diagram].nodes[&f.b].element;
|
||||
for message in [
|
||||
Message::MoveNode(f.b, point(700., 600.)),
|
||||
Message::DiagramRemove(super::diagram_removal::Intent {
|
||||
context: f.app.route_context().unwrap(),
|
||||
object,
|
||||
placement: Some(f.b),
|
||||
model,
|
||||
}),
|
||||
Message::Delete,
|
||||
] {
|
||||
let _ = f.app.update(message);
|
||||
assert_eq!(f.app.project(), &before.decoded.project);
|
||||
assert_eq!(f.app.document.bundle(), &before.bundle);
|
||||
assert_eq!(
|
||||
f.app.multiselect_snapshot().unwrap().targets(),
|
||||
selected.targets()
|
||||
);
|
||||
assert!(!f.app.delete_pending);
|
||||
assert!(!f.app.document.can_undo());
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn legacy_hide_action_applies_to_the_complete_visible_group() {
|
||||
let mut f = fixture();
|
||||
select_pair(&mut f);
|
||||
let before = f.app.document.snapshot();
|
||||
let mut expected = f.app.project().clone();
|
||||
let view = expected.diagrams.get_mut(&f.diagram).unwrap();
|
||||
view.nodes.remove(&f.a);
|
||||
view.nodes.remove(&f.b);
|
||||
let _ = f.app.update(Message::HideSelected);
|
||||
assert_eq!(f.app.project(), &expected);
|
||||
assert_source_matches_model(&f.app);
|
||||
let _ = f.app.update(Message::Undo);
|
||||
assert_eq!(f.app.document.bundle(), &before.bundle);
|
||||
assert!(!f.app.document.can_undo());
|
||||
}
|
||||
fn assert_source_matches_model(app: &App) {
|
||||
let compiled = oa_core::source_project::compile_bundle(app.document.bundle(), LIMITS).unwrap();
|
||||
assert_eq!(&compiled.decoded.project, app.project());
|
||||
assert_eq!(&compiled.bundle, app.document.bundle());
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn toggled_group_moves_model_and_source_once_and_keeps_primary_through_history() {
|
||||
let mut f = fixture();
|
||||
select_pair(&mut f);
|
||||
let before = f.app.document.snapshot();
|
||||
let snapshot = f.app.multiselect_snapshot().unwrap();
|
||||
assert_eq!(snapshot.primary(), Some(&Target::Placement(f.b)));
|
||||
let mut expected = f.app.project().clone();
|
||||
let view = expected.diagrams.get_mut(&f.diagram).unwrap();
|
||||
view.nodes.get_mut(&f.a).unwrap().position = point(50., 80.);
|
||||
view.nodes.get_mut(&f.b).unwrap().position = point(540., 80.);
|
||||
view.nodes.get_mut(&f.child).unwrap().position = point(80., 160.);
|
||||
view.routes[0].waypoints = vec![point(410., 210.)];
|
||||
dispatch(
|
||||
&mut f.app,
|
||||
GroupEvent::Move(snapshot.clone(), point(40., 60.)),
|
||||
);
|
||||
assert_eq!(f.app.project(), &expected);
|
||||
assert_source_matches_model(&f.app);
|
||||
assert_eq!(f.app.selected_node, Some(f.b));
|
||||
assert_eq!(
|
||||
f.app.multiselect_snapshot().unwrap().targets(),
|
||||
snapshot.targets()
|
||||
);
|
||||
let after = f.app.document.snapshot();
|
||||
let _ = f.app.update(Message::Undo);
|
||||
assert_eq!(f.app.project(), &before.decoded.project);
|
||||
assert_eq!(f.app.document.bundle(), &before.bundle);
|
||||
assert!(!f.app.document.can_undo());
|
||||
let _ = f.app.update(Message::Redo);
|
||||
assert_eq!(f.app.project(), &expected);
|
||||
assert_eq!(f.app.document.bundle(), &after.bundle);
|
||||
assert!(!f.app.document.can_redo());
|
||||
assert_eq!(f.app.selected_node, Some(f.b));
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn ancestor_and_child_selection_moves_child_exactly_once() {
|
||||
let mut f = fixture();
|
||||
choose(&mut f.app, Target::Placement(f.a), GroupChoice::Replace);
|
||||
choose(&mut f.app, Target::Placement(f.child), GroupChoice::Toggle);
|
||||
let snapshot = f.app.multiselect_snapshot().unwrap();
|
||||
assert_eq!(snapshot.targets().len(), 2);
|
||||
let mut expected = f.app.project().clone();
|
||||
let view = expected.diagrams.get_mut(&f.diagram).unwrap();
|
||||
view.nodes.get_mut(&f.a).unwrap().position = point(0., 45.);
|
||||
view.nodes.get_mut(&f.child).unwrap().position = point(30., 125.);
|
||||
dispatch(&mut f.app, GroupEvent::Move(snapshot, point(-10., 25.)));
|
||||
assert_eq!(f.app.project(), &expected);
|
||||
assert_eq!(f.app.selected_node, Some(f.child));
|
||||
assert_source_matches_model(&f.app);
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn mixed_edge_or_port_selection_refuses_the_entire_move() {
|
||||
for include_port in [false, true] {
|
||||
let mut f = fixture();
|
||||
choose(&mut f.app, Target::Placement(f.a), GroupChoice::Replace);
|
||||
let extra = if include_port {
|
||||
let view = projection::project_view(f.app.project(), f.diagram);
|
||||
let port = view
|
||||
.ports
|
||||
.iter()
|
||||
.find(|p| p.owner == f.a)
|
||||
.expect("functional exchange exposes its typed owner port");
|
||||
Target::Port {
|
||||
port: port.element,
|
||||
placement: port.owner,
|
||||
}
|
||||
} else {
|
||||
Target::Edge(f.edge)
|
||||
};
|
||||
choose(&mut f.app, extra.clone(), GroupChoice::Toggle);
|
||||
let selection = f.app.multiselect_snapshot().unwrap();
|
||||
assert_eq!(selection.targets(), &[Target::Placement(f.a), extra]);
|
||||
let before = f.app.document.snapshot();
|
||||
let revision = f.app.document.revision();
|
||||
dispatch(
|
||||
&mut f.app,
|
||||
GroupEvent::Move(selection.clone(), point(40., 60.)),
|
||||
);
|
||||
assert_eq!(f.app.project(), &before.decoded.project);
|
||||
assert_eq!(f.app.document.bundle(), &before.bundle);
|
||||
assert_eq!(f.app.document.revision(), revision);
|
||||
assert!(!f.app.document.can_undo());
|
||||
assert_eq!(
|
||||
f.app.multiselect_snapshot().unwrap().targets(),
|
||||
selection.targets()
|
||||
);
|
||||
assert!(f.app.status.contains("Move requires only placed elements"));
|
||||
}
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn stale_operation_envelopes_have_no_selection_history_status_or_allocation_side_effects() {
|
||||
// Isolate each lifetime component, including the same visible set recreated
|
||||
// by a remove/re-add cycle. Accepted setup changes are outside the assertion.
|
||||
for stale_by in ["epoch", "revision", "document", "selection generation"] {
|
||||
for action in ["move", "hide", "refuse", "collapse"] {
|
||||
let mut f = fixture();
|
||||
select_pair(&mut f);
|
||||
let stale = f.app.multiselect_snapshot().unwrap();
|
||||
match stale_by {
|
||||
"epoch" => f.app.canvas_epoch += 1,
|
||||
"revision" => {
|
||||
let semantic = f.app.project().diagrams[&f.diagram].nodes[&f.a].element;
|
||||
// Advance only the document revision, retaining this canvas
|
||||
// and selection epoch to independently test revision checking.
|
||||
f.app
|
||||
.document
|
||||
.execute(Command::Describe(semantic, "New revision".into()))
|
||||
.unwrap();
|
||||
}
|
||||
"document" => f.app.canvas_document = Id::new_v4(),
|
||||
_ => {
|
||||
choose(&mut f.app, Target::Placement(f.b), GroupChoice::Toggle);
|
||||
choose(&mut f.app, Target::Placement(f.b), GroupChoice::Toggle);
|
||||
assert_eq!(
|
||||
f.app.multiselect_snapshot().unwrap().targets(),
|
||||
stale.targets()
|
||||
);
|
||||
}
|
||||
}
|
||||
f.app.status = "Current feedback must survive".into();
|
||||
f.app.allocation_drag.arrange_next = true;
|
||||
let before = f.app.document.snapshot();
|
||||
let selection = f.app.multiselect_snapshot();
|
||||
let legacy = (f.app.selected, f.app.selected_node);
|
||||
let revision = f.app.document.revision();
|
||||
let epochs = (
|
||||
f.app.canvas_epoch,
|
||||
f.app.camera_epoch,
|
||||
f.app.allocation_drag.epoch,
|
||||
);
|
||||
let history = (f.app.document.can_undo(), f.app.document.can_redo());
|
||||
let draft = f
|
||||
.app
|
||||
.draft
|
||||
.as_ref()
|
||||
.map(|d| serde_json::to_value(d.recovery_snapshot()).unwrap());
|
||||
let event = match action {
|
||||
"move" => GroupEvent::Move(stale, point(99., 100.)),
|
||||
"hide" => GroupEvent::Hide(stale),
|
||||
"collapse" => GroupEvent::Collapse(stale, Target::Placement(f.a)),
|
||||
_ => GroupEvent::Refuse(stale, "Obsolete refusal".into()),
|
||||
};
|
||||
dispatch(&mut f.app, event);
|
||||
assert_eq!(
|
||||
f.app.project(),
|
||||
&before.decoded.project,
|
||||
"{stale_by}/{action}"
|
||||
);
|
||||
assert_eq!(f.app.document.bundle(), &before.bundle);
|
||||
assert_eq!(f.app.document.revision(), revision);
|
||||
assert_eq!(f.app.multiselect_snapshot(), selection);
|
||||
assert_eq!((f.app.selected, f.app.selected_node), legacy);
|
||||
assert_eq!(
|
||||
(
|
||||
f.app.canvas_epoch,
|
||||
f.app.camera_epoch,
|
||||
f.app.allocation_drag.epoch
|
||||
),
|
||||
epochs
|
||||
);
|
||||
assert_eq!(
|
||||
(f.app.document.can_undo(), f.app.document.can_redo()),
|
||||
history
|
||||
);
|
||||
assert_eq!(f.app.status, "Current feedback must survive");
|
||||
assert!(f.app.allocation_drag.arrange_next);
|
||||
assert_eq!(
|
||||
f.app
|
||||
.draft
|
||||
.as_ref()
|
||||
.map(|d| serde_json::to_value(d.recovery_snapshot()).unwrap()),
|
||||
draft
|
||||
);
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn pending_valid_and_invalid_property_drafts_refuse_group_edits_without_applying_them() {
|
||||
for (path, value) in [("/name", "Unapplied name"), ("/id", "-")] {
|
||||
for hide in [false, true] {
|
||||
let mut f = fixture();
|
||||
select_pair(&mut f);
|
||||
let _ = f.app.update(Message::Field(path.into(), value.into()));
|
||||
assert!(f.app.draft_dirty());
|
||||
let snapshot = f.app.multiselect_snapshot().unwrap();
|
||||
let before = f.app.document.snapshot();
|
||||
let draft =
|
||||
serde_json::to_value(f.app.draft.as_ref().unwrap().recovery_snapshot()).unwrap();
|
||||
let event = if hide {
|
||||
GroupEvent::Hide(snapshot.clone())
|
||||
} else {
|
||||
GroupEvent::Move(snapshot.clone(), point(20., 30.))
|
||||
};
|
||||
dispatch(&mut f.app, event);
|
||||
assert_eq!(f.app.project(), &before.decoded.project);
|
||||
assert_eq!(f.app.document.bundle(), &before.bundle);
|
||||
assert!(!f.app.document.can_undo());
|
||||
assert_eq!(
|
||||
f.app.multiselect_snapshot().unwrap().targets(),
|
||||
snapshot.targets()
|
||||
);
|
||||
assert_eq!(
|
||||
serde_json::to_value(f.app.draft.as_ref().unwrap().recovery_snapshot()).unwrap(),
|
||||
draft
|
||||
);
|
||||
assert!(f.app.status.contains("Finish or cancel"));
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn hiding_a_group_removes_only_exact_placements_and_roundtrips_in_one_history_step() {
|
||||
let mut f = fixture();
|
||||
select_pair(&mut f);
|
||||
let snapshot = f.app.multiselect_snapshot().unwrap();
|
||||
let before = f.app.document.snapshot();
|
||||
let mut expected = f.app.project().clone();
|
||||
let view = expected.diagrams.get_mut(&f.diagram).unwrap();
|
||||
view.nodes.remove(&f.a);
|
||||
view.nodes.remove(&f.b);
|
||||
dispatch(&mut f.app, GroupEvent::Hide(snapshot));
|
||||
assert_eq!(
|
||||
f.app.project(),
|
||||
&expected,
|
||||
"engineering objects, descendant placement, authored route and opposite-layer view survive"
|
||||
);
|
||||
assert!(f.app.multiselect_snapshot().unwrap().targets().is_empty());
|
||||
assert_source_matches_model(&f.app);
|
||||
let after = f.app.document.snapshot();
|
||||
let _ = f.app.update(Message::Undo);
|
||||
assert_eq!(f.app.project(), &before.decoded.project);
|
||||
assert_eq!(f.app.document.bundle(), &before.bundle);
|
||||
assert!(!f.app.document.can_undo());
|
||||
let _ = f.app.update(Message::Redo);
|
||||
assert_eq!(f.app.project(), &expected);
|
||||
assert_eq!(f.app.document.bundle(), &after.bundle);
|
||||
assert!(!f.app.document.can_redo());
|
||||
}
|
||||
fn assert_surviving_primary(f: &Fixture) {
|
||||
let selection = f.app.multiselect_snapshot().unwrap();
|
||||
assert_eq!(selection.targets(), &[Target::Placement(f.a)]);
|
||||
assert_eq!(selection.primary(), Some(&Target::Placement(f.a)));
|
||||
assert_eq!(f.app.selected_node, Some(f.a));
|
||||
assert_eq!(
|
||||
f.app.selected,
|
||||
f.app.project().diagrams[&f.diagram].nodes[&f.a].element
|
||||
);
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn removing_primary_placement_from_model_preserves_exact_survivor_after_undo() {
|
||||
let mut f = fixture();
|
||||
select_pair(&mut f);
|
||||
let before = f.app.document.snapshot();
|
||||
let _ = f.app.update(Message::Command(Command::Delete(f.b)));
|
||||
assert!(
|
||||
!f.app.project().diagrams[&f.diagram]
|
||||
.nodes
|
||||
.contains_key(&f.b)
|
||||
);
|
||||
assert_surviving_primary(&f);
|
||||
let _ = f.app.update(Message::Undo);
|
||||
assert_eq!(f.app.project(), &before.decoded.project);
|
||||
assert_eq!(f.app.document.bundle(), &before.bundle);
|
||||
assert_surviving_primary(&f);
|
||||
let _ = f.app.update(Message::Redo);
|
||||
assert_surviving_primary(&f);
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn deleting_primary_model_object_then_undo_does_not_restore_removed_selection_membership() {
|
||||
let mut f = fixture();
|
||||
select_pair(&mut f);
|
||||
let before = f.app.document.snapshot();
|
||||
let semantic = f.app.project().diagrams[&f.diagram].nodes[&f.b].element;
|
||||
let _ = f.app.update(Message::Command(Command::Delete(semantic)));
|
||||
assert!(!f.app.project().elements.contains_key(&semantic));
|
||||
assert_surviving_primary(&f);
|
||||
let _ = f.app.update(Message::Undo);
|
||||
assert_eq!(f.app.project(), &before.decoded.project);
|
||||
assert_eq!(f.app.document.bundle(), &before.bundle);
|
||||
assert_surviving_primary(&f);
|
||||
let _ = f.app.update(Message::Redo);
|
||||
assert_surviving_primary(&f);
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn replacing_primary_occurrence_with_same_semantic_placement_does_not_retarget_selection() {
|
||||
let mut f = fixture();
|
||||
select_pair(&mut f);
|
||||
let mut candidate = f.app.project().clone();
|
||||
let view = candidate.diagrams.get_mut(&f.diagram).unwrap();
|
||||
let mut replacement = view.nodes.remove(&f.b).unwrap();
|
||||
let replacement_id = Id::new_v4();
|
||||
replacement.id = replacement_id;
|
||||
replacement.alias = "replacement_receive".into();
|
||||
replacement.position = point(800., 300.);
|
||||
view.nodes.insert(replacement_id, replacement);
|
||||
// Replace preserves the semantic inspector identity. Its normal sync used
|
||||
// to rediscover the new occurrence through that identity and steal the set.
|
||||
let _ = f
|
||||
.app
|
||||
.update(Message::Command(Command::Replace(candidate.clone())));
|
||||
assert_eq!(f.app.project(), &candidate);
|
||||
assert_surviving_primary(&f);
|
||||
assert!(
|
||||
!f.app
|
||||
.multiselect_snapshot()
|
||||
.unwrap()
|
||||
.targets()
|
||||
.contains(&Target::Placement(replacement_id))
|
||||
);
|
||||
assert_source_matches_model(&f.app);
|
||||
let _ = f.app.update(Message::Undo);
|
||||
assert!(
|
||||
f.app.project().diagrams[&f.diagram]
|
||||
.nodes
|
||||
.contains_key(&f.b)
|
||||
);
|
||||
assert_surviving_primary(&f);
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn explicit_surface_navigation_and_return_never_resurrect_the_group() {
|
||||
for destination in [Page::Catalog, Page::Behavior] {
|
||||
let mut f = fixture();
|
||||
select_pair(&mut f);
|
||||
let before = f.app.document.snapshot();
|
||||
let stale = f.app.multiselect_snapshot().unwrap();
|
||||
let _ = f.app.update(Message::Page(destination));
|
||||
assert!(f.app.multiselect_snapshot().is_none());
|
||||
let _ = f.app.update(Message::Page(Page::Diagram));
|
||||
let live = f.app.multiselect_snapshot().unwrap();
|
||||
assert!(
|
||||
live.targets().len() <= 1,
|
||||
"navigation may inspect one exact member but must not restore the group"
|
||||
);
|
||||
dispatch(&mut f.app, GroupEvent::Move(stale, point(400., 500.)));
|
||||
assert_eq!(f.app.project(), &before.decoded.project);
|
||||
assert_eq!(f.app.document.bundle(), &before.bundle);
|
||||
assert!(!f.app.document.can_undo());
|
||||
}
|
||||
}
|
||||
|
||||
fn open_placement_menu(f: &mut Fixture, placement: Id) {
|
||||
let semantic = f.app.project().diagrams[&f.diagram].nodes[&placement].element;
|
||||
let mut request = crate::model_menu::Request::object(semantic, iced::Point::new(100., 100.));
|
||||
request.placement = Some(placement);
|
||||
request.canvas = f.app.route_context();
|
||||
let _ = f
|
||||
.app
|
||||
.update(Message::Menu(crate::model_menu::Event::Open(request)));
|
||||
assert!(f.app.model_menu.is_some());
|
||||
}
|
||||
|
||||
fn menu_action(app: &App, caption: &str) -> Message {
|
||||
crate::model_menu::popup(app)
|
||||
.unwrap()
|
||||
.entries
|
||||
.into_iter()
|
||||
.find_map(|entry| match entry {
|
||||
crate::context_menu::Entry::Action { label, message, .. } if label == caption => {
|
||||
message
|
||||
}
|
||||
_ => None,
|
||||
})
|
||||
.unwrap_or_else(|| panic!("enabled menu action {caption:?} must exist"))
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn context_menu_dismissal_preserves_group_and_add_keeps_pre_menu_members() {
|
||||
let mut f = fixture();
|
||||
select_pair(&mut f);
|
||||
let before = f.app.document.snapshot();
|
||||
let selected = f.app.multiselect_snapshot().unwrap();
|
||||
let child = f.child;
|
||||
open_placement_menu(&mut f, child);
|
||||
assert_eq!(
|
||||
f.app.multiselect_snapshot().unwrap().targets(),
|
||||
selected.targets()
|
||||
);
|
||||
assert_eq!(
|
||||
f.app.multiselect_snapshot().unwrap().primary(),
|
||||
selected.primary()
|
||||
);
|
||||
let _ = f.app.update(Message::Menu(crate::model_menu::Event::Close));
|
||||
assert_eq!(
|
||||
f.app.multiselect_snapshot().unwrap().targets(),
|
||||
selected.targets()
|
||||
);
|
||||
assert_eq!(
|
||||
f.app.multiselect_snapshot().unwrap().primary(),
|
||||
selected.primary()
|
||||
);
|
||||
open_placement_menu(&mut f, child);
|
||||
let add = menu_action(&f.app, "Add to selection");
|
||||
let _ = f.app.update(add);
|
||||
let selected = f.app.multiselect_snapshot().unwrap();
|
||||
assert_eq!(
|
||||
selected.targets(),
|
||||
&[
|
||||
Target::Placement(f.a),
|
||||
Target::Placement(f.b),
|
||||
Target::Placement(child)
|
||||
]
|
||||
);
|
||||
assert_eq!(selected.primary(), Some(&Target::Placement(child)));
|
||||
assert_eq!(f.app.project(), &before.decoded.project);
|
||||
assert_eq!(f.app.document.bundle(), &before.bundle);
|
||||
assert!(!f.app.document.can_undo());
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn selected_member_context_menu_exposes_and_executes_group_hide_not_singleton_deletion() {
|
||||
let mut f = fixture();
|
||||
select_pair(&mut f);
|
||||
let before = f.app.document.snapshot();
|
||||
let member = f.a;
|
||||
open_placement_menu(&mut f, member);
|
||||
let popup = crate::model_menu::popup(&f.app).unwrap();
|
||||
for entry in &popup.entries {
|
||||
if let crate::context_menu::Entry::Action {
|
||||
message: Some(Message::Menu(crate::model_menu::Event::Invoke(_, action))),
|
||||
..
|
||||
} = entry
|
||||
{
|
||||
assert!(
|
||||
!matches!(
|
||||
action.as_ref(),
|
||||
Message::HideSelected | Message::Delete | Message::DiagramRemove(_)
|
||||
),
|
||||
"a selected-member group menu must not expose singleton removal"
|
||||
);
|
||||
}
|
||||
}
|
||||
let hide = menu_action(&f.app, "Hide selected placements");
|
||||
let _ = f.app.update(hide);
|
||||
let mut expected = before.decoded.project.clone();
|
||||
let view = expected.diagrams.get_mut(&f.diagram).unwrap();
|
||||
view.nodes.remove(&f.a);
|
||||
view.nodes.remove(&f.b);
|
||||
assert_eq!(f.app.project(), &expected);
|
||||
assert!(!f.app.delete_pending);
|
||||
assert!(f.app.model_menu.is_none());
|
||||
assert_source_matches_model(&f.app);
|
||||
let _ = f.app.update(Message::Undo);
|
||||
assert_eq!(f.app.project(), &before.decoded.project);
|
||||
assert_eq!(f.app.document.bundle(), &before.bundle);
|
||||
assert!(!f.app.document.can_undo());
|
||||
}
|
||||
@@ -39,12 +39,17 @@ mod port_labels;
|
||||
pub use port_labels::PortLabels;
|
||||
#[path = "diagram/focus.rs"]
|
||||
pub(crate) mod focus;
|
||||
mod group_gesture;
|
||||
mod multiselect;
|
||||
#[cfg(test)]
|
||||
mod multiselect_tests;
|
||||
#[path = "diagram/work_drag.rs"]
|
||||
mod work_drag;
|
||||
pub use work_drag::WorkFeedback;
|
||||
|
||||
#[derive(Clone, Copy)]
|
||||
pub struct DiagramCanvas<'a> {
|
||||
pub selection: Option<&'a crate::diagram_selection::Selection>,
|
||||
pub allocation: Option<crate::app::allocation_drag::Capability<'a>>,
|
||||
pub project: &'a Project,
|
||||
pub view_index: Option<&'a oa_core::view_options::ViewIndex>,
|
||||
@@ -63,6 +68,8 @@ pub struct DiagramCanvas<'a> {
|
||||
}
|
||||
#[derive(Default)]
|
||||
pub struct State {
|
||||
modifiers: iced::keyboard::Modifiers,
|
||||
group: Option<multiselect::Press>,
|
||||
work: Option<Arc<crate::app::allocation_drag::Press>>,
|
||||
work_cache: RefCell<Option<Arc<Scene>>>,
|
||||
pointer: Option<Point>,
|
||||
@@ -462,6 +469,7 @@ impl DiagramCanvas<'_> {
|
||||
}
|
||||
fn preview_diagram(&self, state: &State) -> Diagram {
|
||||
let mut diagram = self.project.diagrams[&self.diagram].clone();
|
||||
self.group_preview(state, &mut diagram);
|
||||
if let (Some((id, _, original)), Some(preview)) = (state.drag, state.preview) {
|
||||
let delta = Position {
|
||||
x: preview.x - original.x,
|
||||
@@ -604,6 +612,13 @@ impl canvas::Program<Message> for DiagramCanvas<'_> {
|
||||
bounds: Rectangle,
|
||||
cursor: mouse::Cursor,
|
||||
) -> Option<Action<Message>> {
|
||||
if let canvas::Event::Keyboard(iced::keyboard::Event::ModifiersChanged(modifiers)) = event {
|
||||
state.modifiers = *modifiers;
|
||||
return None;
|
||||
}
|
||||
if matches!(event, canvas::Event::Window(iced::window::Event::Unfocused)) {
|
||||
state.modifiers = iced::keyboard::Modifiers::default();
|
||||
}
|
||||
// An attachment belongs to the boundary geometry captured at press.
|
||||
// Camera/layout changes must not reinterpret its pointer in another space.
|
||||
if matches!(
|
||||
@@ -641,6 +656,7 @@ impl canvas::Program<Message> for DiagramCanvas<'_> {
|
||||
return Some(action);
|
||||
}
|
||||
if state.context != Some(self.context) {
|
||||
state.group = None;
|
||||
state.work = None;
|
||||
state.pointer = None;
|
||||
state.port_drag = None;
|
||||
@@ -707,6 +723,9 @@ impl canvas::Program<Message> for DiagramCanvas<'_> {
|
||||
let local = cursor
|
||||
.position()
|
||||
.map(|p| Point::new(p.x - bounds.x, p.y - bounds.y));
|
||||
if let Some(action) = self.group_input(state, event, bounds, cursor) {
|
||||
return Some(action);
|
||||
}
|
||||
match event {
|
||||
canvas::Event::Mouse(mouse::Event::ButtonPressed(mouse::Button::Right))
|
||||
if cursor.is_over(bounds) =>
|
||||
@@ -1262,7 +1281,17 @@ impl canvas::Program<Message> for DiagramCanvas<'_> {
|
||||
.collect::<BTreeSet<_>>();
|
||||
for n in &view.nodes {
|
||||
if containers.contains(&n.id) {
|
||||
paint_node(&mut f, project, n, self.selected, true);
|
||||
paint_node(
|
||||
&mut f,
|
||||
project,
|
||||
n,
|
||||
if self.selection_contains(crate::diagram_usage::Target::Placement(n.id)) {
|
||||
n.element
|
||||
} else {
|
||||
self.selected
|
||||
},
|
||||
true,
|
||||
);
|
||||
}
|
||||
}
|
||||
let highlighted = highlighted_exchanges(project, self.selected);
|
||||
@@ -1274,7 +1303,9 @@ impl canvas::Program<Message> for DiagramCanvas<'_> {
|
||||
continue;
|
||||
};
|
||||
let end = point(end);
|
||||
let active = edge.id == self.selected || highlighted.contains(&edge.id);
|
||||
let active = edge.id == self.selected
|
||||
|| highlighted.contains(&edge.id)
|
||||
|| self.selection_contains(crate::diagram_usage::Target::Edge(edge.id));
|
||||
let color = if active {
|
||||
style::TEAL
|
||||
} else if routed
|
||||
@@ -1370,17 +1401,42 @@ impl canvas::Program<Message> for DiagramCanvas<'_> {
|
||||
}
|
||||
for n in &view.nodes {
|
||||
if !containers.contains(&n.id) {
|
||||
paint_node(&mut f, project, n, self.selected, false);
|
||||
paint_node(
|
||||
&mut f,
|
||||
project,
|
||||
n,
|
||||
if self.selection_contains(crate::diagram_usage::Target::Placement(n.id)) {
|
||||
n.element
|
||||
} else {
|
||||
self.selected
|
||||
},
|
||||
false,
|
||||
);
|
||||
} else {
|
||||
// Container headers stay readable when relationships traverse
|
||||
// the allocation enclosure. Children remain on top.
|
||||
let mut header = n.clone();
|
||||
header.size.height = 62.;
|
||||
paint_node(&mut f, project, &header, self.selected, true);
|
||||
paint_node(
|
||||
&mut f,
|
||||
project,
|
||||
&header,
|
||||
if self.selection_contains(crate::diagram_usage::Target::Placement(n.id)) {
|
||||
n.element
|
||||
} else {
|
||||
self.selected
|
||||
},
|
||||
true,
|
||||
);
|
||||
}
|
||||
}
|
||||
for port in &view.ports {
|
||||
let color = if self.selected == port.element {
|
||||
let selected = self.selected == port.element
|
||||
|| self.selection_contains(crate::diagram_usage::Target::Port {
|
||||
port: port.element,
|
||||
placement: port.owner,
|
||||
});
|
||||
let color = if selected {
|
||||
style::TEAL
|
||||
} else {
|
||||
style::kind_color(
|
||||
@@ -1408,11 +1464,7 @@ impl canvas::Program<Message> for DiagramCanvas<'_> {
|
||||
let mut stroke =
|
||||
Stroke::default()
|
||||
.with_color(color)
|
||||
.with_width(if self.selected == port.element {
|
||||
2.5
|
||||
} else {
|
||||
1.5
|
||||
});
|
||||
.with_width(if selected { 2.5 } else { 1.5 });
|
||||
if glyph == PortGlyph::Legacy {
|
||||
stroke.line_dash = canvas::LineDash {
|
||||
segments: &[3., 2.],
|
||||
@@ -2179,6 +2231,7 @@ mod tests {
|
||||
y: original.y - 200.,
|
||||
};
|
||||
let canvas = DiagramCanvas {
|
||||
selection: None,
|
||||
project: &p,
|
||||
view_index: None,
|
||||
context: Context {
|
||||
@@ -2256,6 +2309,7 @@ mod tests {
|
||||
.unwrap()
|
||||
.id;
|
||||
let canvas = DiagramCanvas {
|
||||
selection: None,
|
||||
project: &p,
|
||||
view_index: None,
|
||||
context: Context {
|
||||
@@ -2384,6 +2438,7 @@ mod tests {
|
||||
};
|
||||
let session = Session::new(&p, &view, context, Tool::FunctionalExchange);
|
||||
let canvas = DiagramCanvas {
|
||||
selection: None,
|
||||
project: &p,
|
||||
view_index: None,
|
||||
diagram,
|
||||
@@ -2559,6 +2614,7 @@ mod tests {
|
||||
for zoom in [0.5, 1., 1.5] {
|
||||
let (p, diagram, edge) = route_fixture();
|
||||
let canvas = DiagramCanvas {
|
||||
selection: None,
|
||||
project: &p,
|
||||
view_index: None,
|
||||
diagram,
|
||||
@@ -2637,6 +2693,7 @@ mod tests {
|
||||
fn fast_drags_commit_the_release_cursor_without_a_final_motion_event() {
|
||||
let (p, diagram, edge) = route_fixture();
|
||||
let canvas = DiagramCanvas {
|
||||
selection: None,
|
||||
project: &p,
|
||||
view_index: None,
|
||||
diagram,
|
||||
@@ -2736,6 +2793,7 @@ mod tests {
|
||||
fn route_cache_ignores_pan_zoom_and_cancelled_drag_cannot_commit() {
|
||||
let (p, diagram, edge) = route_fixture();
|
||||
let mut canvas = DiagramCanvas {
|
||||
selection: None,
|
||||
project: &p,
|
||||
view_index: None,
|
||||
diagram,
|
||||
@@ -2866,6 +2924,7 @@ mod tests {
|
||||
assert!(!svg.contains("data-navigation=\"source\""));
|
||||
assert!(svg.contains("data-navigation=\"target\""));
|
||||
let mut canvas = DiagramCanvas {
|
||||
selection: None,
|
||||
project: &p,
|
||||
view_index: None,
|
||||
diagram,
|
||||
@@ -2922,6 +2981,7 @@ mod tests {
|
||||
offset: Position { x: 0., y: -160. },
|
||||
});
|
||||
let mut canvas = DiagramCanvas {
|
||||
selection: None,
|
||||
project: &p,
|
||||
view_index: None,
|
||||
diagram,
|
||||
@@ -2998,6 +3058,7 @@ mod tests {
|
||||
},
|
||||
});
|
||||
let canvas = DiagramCanvas {
|
||||
selection: None,
|
||||
project: &p,
|
||||
view_index: None,
|
||||
diagram,
|
||||
@@ -3033,6 +3094,7 @@ mod tests {
|
||||
routed.edges.insert(duplicate, duplicate_route);
|
||||
let selected = edge.max(duplicate); // UUID ordering must not override selection.
|
||||
let canvas = DiagramCanvas {
|
||||
selection: None,
|
||||
project: &p,
|
||||
view_index: None,
|
||||
diagram,
|
||||
|
||||
@@ -34,6 +34,7 @@ fn fixture() -> App {
|
||||
|
||||
fn canvas(app: &App, zoom: f32) -> DiagramCanvas<'_> {
|
||||
DiagramCanvas {
|
||||
selection: None,
|
||||
allocation: None,
|
||||
project: app.project(),
|
||||
view_index: None,
|
||||
|
||||
@@ -12,6 +12,8 @@ struct Input {
|
||||
suspended: bool,
|
||||
traversing: bool,
|
||||
pointer: Option<Point>,
|
||||
modifiers: iced::keyboard::Modifiers,
|
||||
restore_modifiers: bool,
|
||||
}
|
||||
impl operation::Focusable for Input {
|
||||
fn is_focused(&self) -> bool {
|
||||
@@ -95,6 +97,7 @@ impl<Message, R: renderer::Renderer> Widget<Message, Theme, R> for Owner<'_, Mes
|
||||
// canvas's transient gestures without retiring this focus owner.
|
||||
state.pointer = None;
|
||||
tree.children[0] = Tree::new(self.content.as_widget());
|
||||
state.restore_modifiers = true;
|
||||
} else {
|
||||
tree.diff_children(std::slice::from_ref(&self.content));
|
||||
}
|
||||
@@ -143,6 +146,14 @@ impl<Message, R: renderer::Renderer> Widget<Message, Theme, R> for Owner<'_, Mes
|
||||
viewport: &Rectangle,
|
||||
) {
|
||||
let state = tree.state.downcast_mut::<Input>();
|
||||
if let InputEvent::Keyboard(iced::keyboard::Event::ModifiersChanged(modifiers)) = event {
|
||||
state.modifiers = *modifiers;
|
||||
state.restore_modifiers = false;
|
||||
}
|
||||
if matches!(event, InputEvent::Window(iced::window::Event::Unfocused)) {
|
||||
state.modifiers = iced::keyboard::Modifiers::default();
|
||||
state.restore_modifiers = true;
|
||||
}
|
||||
if let InputEvent::Mouse(mouse::Event::CursorMoved { position }) = event {
|
||||
state.pointer = Some(*position);
|
||||
}
|
||||
@@ -171,7 +182,14 @@ impl<Message, R: renderer::Renderer> Widget<Message, Theme, R> for Owner<'_, Mes
|
||||
}
|
||||
// Save/export I/O denies commands and acquisition, while real focus
|
||||
// operations and outside clicks can still revoke the retained owner.
|
||||
if self.suspended && matches!(event, InputEvent::Keyboard(_) | InputEvent::Mouse(_)) {
|
||||
let passive_modifiers = matches!(
|
||||
event,
|
||||
InputEvent::Keyboard(iced::keyboard::Event::ModifiersChanged(_))
|
||||
);
|
||||
if self.suspended
|
||||
&& !passive_modifiers
|
||||
&& matches!(event, InputEvent::Keyboard(_) | InputEvent::Mouse(_))
|
||||
{
|
||||
return;
|
||||
}
|
||||
if let InputEvent::Keyboard(iced::keyboard::Event::KeyPressed {
|
||||
@@ -193,13 +211,30 @@ impl<Message, R: renderer::Renderer> Widget<Message, Theme, R> for Owner<'_, Mes
|
||||
return;
|
||||
}
|
||||
if matches!(event, InputEvent::Keyboard(_))
|
||||
&& !passive_modifiers
|
||||
&& (!state.focused || state.traversing || !self.enabled)
|
||||
{
|
||||
return;
|
||||
}
|
||||
if shell.is_event_captured() {
|
||||
if shell.is_event_captured() && !passive_modifiers {
|
||||
return;
|
||||
}
|
||||
if state.restore_modifiers {
|
||||
// Suspending I/O replaces the child to retire pointer gestures.
|
||||
// Held modifiers belong to this longer-lived passive owner, so
|
||||
// restore them before the first admitted event reaches the child.
|
||||
state.restore_modifiers = false;
|
||||
self.content.as_widget_mut().update(
|
||||
&mut tree.children[0],
|
||||
&InputEvent::Keyboard(iced::keyboard::Event::ModifiersChanged(state.modifiers)),
|
||||
layout,
|
||||
cursor,
|
||||
renderer,
|
||||
clipboard,
|
||||
shell,
|
||||
viewport,
|
||||
);
|
||||
}
|
||||
self.content.as_widget_mut().update(
|
||||
&mut tree.children[0],
|
||||
event,
|
||||
|
||||
@@ -0,0 +1,520 @@
|
||||
//! Saved-view pointer geometry. Selection, capability and model admission remain
|
||||
//! with the caller; this module never applies a selection or a model command.
|
||||
use crate::diagram_selection::Snapshot;
|
||||
use crate::diagram_usage::{Surface, Target};
|
||||
use iced::{Point, Rectangle, Vector};
|
||||
use oa_core::{Id, Position};
|
||||
|
||||
#[derive(Debug, Clone, Copy, PartialEq)]
|
||||
pub(crate) struct Viewport {
|
||||
pub zoom: f32,
|
||||
pub pan: Vector,
|
||||
pub bounds: Rectangle,
|
||||
}
|
||||
|
||||
#[derive(Debug)]
|
||||
pub(crate) struct Gesture {
|
||||
snapshot: Snapshot,
|
||||
anchor: Id,
|
||||
original: Position,
|
||||
press: Point,
|
||||
viewport: Viewport,
|
||||
crossed_threshold: bool,
|
||||
delta: Position,
|
||||
retired: bool,
|
||||
}
|
||||
|
||||
#[derive(Debug, PartialEq)]
|
||||
pub(crate) enum Outcome {
|
||||
Click(Id),
|
||||
Move(Snapshot, Position),
|
||||
}
|
||||
|
||||
impl Gesture {
|
||||
pub fn new(
|
||||
snapshot: Snapshot,
|
||||
anchor: Id,
|
||||
original: Position,
|
||||
press: Point,
|
||||
viewport: Viewport,
|
||||
) -> Option<Self> {
|
||||
if !matches!(snapshot.context().scope.surface, Surface::Saved(_))
|
||||
|| !snapshot.targets().contains(&Target::Placement(anchor))
|
||||
|| !snapshot
|
||||
.targets()
|
||||
.iter()
|
||||
.all(|target| matches!(target, Target::Placement(_)))
|
||||
|| !viewport.valid()
|
||||
|| !finite_position(original)
|
||||
|| !finite_point(press)
|
||||
|| !viewport.bounds.contains(press)
|
||||
{
|
||||
return None;
|
||||
}
|
||||
Some(Self {
|
||||
snapshot,
|
||||
anchor,
|
||||
original,
|
||||
press,
|
||||
viewport,
|
||||
crossed_threshold: false,
|
||||
delta: Position { x: 0., y: 0. },
|
||||
retired: false,
|
||||
})
|
||||
}
|
||||
|
||||
pub fn snapshot(&self) -> &Snapshot {
|
||||
&self.snapshot
|
||||
}
|
||||
|
||||
#[cfg(test)]
|
||||
pub fn anchor(&self) -> Id {
|
||||
self.anchor
|
||||
}
|
||||
|
||||
/// Compare before processing each event. On mismatch, the caller must drop
|
||||
/// this gesture, just as on Escape, focus loss or changed model authority.
|
||||
pub fn viewport_matches(&self, viewport: Viewport) -> bool {
|
||||
!self.retired && self.viewport == viewport
|
||||
}
|
||||
|
||||
pub fn crossed_threshold(&self) -> bool {
|
||||
self.crossed_threshold
|
||||
}
|
||||
|
||||
/// Common snapped world delta for preview and release; zero before a drag.
|
||||
pub fn delta(&self) -> Position {
|
||||
self.delta
|
||||
}
|
||||
|
||||
/// Process an absolute screen position. False permanently retires the
|
||||
/// gesture; the caller must remove its preview and produce no operation.
|
||||
pub fn move_to(&mut self, pointer: Point) -> bool {
|
||||
if self.retired {
|
||||
return false;
|
||||
}
|
||||
if !finite_point(pointer) || !self.viewport.bounds.contains(pointer) {
|
||||
self.retire();
|
||||
return false;
|
||||
}
|
||||
let screen = pointer - self.press;
|
||||
self.crossed_threshold |= screen.x.hypot(screen.y) > 3.;
|
||||
if !self.crossed_threshold {
|
||||
return true;
|
||||
}
|
||||
let desired = Position {
|
||||
x: self.original.x + screen.x / self.viewport.zoom,
|
||||
y: self.original.y + screen.y / self.viewport.zoom,
|
||||
};
|
||||
if !finite_position(desired) {
|
||||
self.retire();
|
||||
return false;
|
||||
}
|
||||
// Returning to the original position must not align an off-grid anchor
|
||||
// as an accidental edit. It is still a drag, so selection stays grouped.
|
||||
let delta = if desired == self.original {
|
||||
Position { x: 0., y: 0. }
|
||||
} else {
|
||||
Position {
|
||||
x: (desired.x / 10.).round() * 10. - self.original.x,
|
||||
y: (desired.y / 10.).round() * 10. - self.original.y,
|
||||
}
|
||||
};
|
||||
if !finite_position(delta) {
|
||||
self.retire();
|
||||
return false;
|
||||
}
|
||||
self.delta = delta;
|
||||
true
|
||||
}
|
||||
|
||||
/// Consume the final pointer too: a release can be the first displaced
|
||||
/// event. The caller must validate snapshot and viewport before acting on
|
||||
/// either outcome. Cancelling is dropping the gesture without calling this.
|
||||
pub fn release(mut self, pointer: Point) -> Option<Outcome> {
|
||||
if !self.move_to(pointer) {
|
||||
return None;
|
||||
}
|
||||
Some(if self.crossed_threshold {
|
||||
Outcome::Move(self.snapshot, self.delta)
|
||||
} else {
|
||||
Outcome::Click(self.anchor)
|
||||
})
|
||||
}
|
||||
|
||||
fn retire(&mut self) {
|
||||
self.retired = true;
|
||||
self.delta = Position { x: 0., y: 0. };
|
||||
}
|
||||
}
|
||||
|
||||
impl Viewport {
|
||||
fn valid(self) -> bool {
|
||||
self.zoom.is_finite()
|
||||
&& self.zoom > 0.
|
||||
&& self.pan.x.is_finite()
|
||||
&& self.pan.y.is_finite()
|
||||
&& self.bounds.x.is_finite()
|
||||
&& self.bounds.y.is_finite()
|
||||
&& self.bounds.width.is_finite()
|
||||
&& self.bounds.height.is_finite()
|
||||
&& self.bounds.width > 0.
|
||||
&& self.bounds.height > 0.
|
||||
&& (self.bounds.x + self.bounds.width).is_finite()
|
||||
&& (self.bounds.y + self.bounds.height).is_finite()
|
||||
}
|
||||
}
|
||||
|
||||
fn finite_point(point: Point) -> bool {
|
||||
point.x.is_finite() && point.y.is_finite()
|
||||
}
|
||||
|
||||
fn finite_position(position: Position) -> bool {
|
||||
position.x.is_finite() && position.y.is_finite()
|
||||
}
|
||||
|
||||
#[cfg(test)]
|
||||
mod tests {
|
||||
use super::*;
|
||||
use crate::diagram_selection::{Context, Scope, Selection};
|
||||
|
||||
fn id(value: u128) -> Id {
|
||||
Id::from_u128(value)
|
||||
}
|
||||
|
||||
fn context() -> Context {
|
||||
Context {
|
||||
scope: Scope {
|
||||
document: id(1),
|
||||
surface: Surface::Saved(id(2)),
|
||||
},
|
||||
revision: 3,
|
||||
epoch: 4,
|
||||
}
|
||||
}
|
||||
|
||||
fn snapshot(targets: impl IntoIterator<Item = Target>) -> Snapshot {
|
||||
let mut selection = Selection::new(context().scope);
|
||||
for target in targets {
|
||||
selection.add(target, |_| true);
|
||||
}
|
||||
selection.snapshot(context()).unwrap()
|
||||
}
|
||||
|
||||
fn viewport() -> Viewport {
|
||||
Viewport {
|
||||
zoom: 1.,
|
||||
pan: Vector::new(17., -8.),
|
||||
bounds: Rectangle {
|
||||
x: 100.,
|
||||
y: 50.,
|
||||
width: 400.,
|
||||
height: 300.,
|
||||
},
|
||||
}
|
||||
}
|
||||
|
||||
fn press() -> Point {
|
||||
Point::new(150., 120.)
|
||||
}
|
||||
|
||||
fn gesture(original: Position) -> Gesture {
|
||||
Gesture::new(
|
||||
snapshot([Target::Placement(id(10)), Target::Placement(id(11))]),
|
||||
id(10),
|
||||
original,
|
||||
press(),
|
||||
viewport(),
|
||||
)
|
||||
.unwrap()
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn stationary_or_exact_threshold_release_is_click_without_snapping() {
|
||||
for pointer in [press(), Point::new(153., 120.), Point::new(152., 122.)] {
|
||||
let mut gesture = gesture(Position { x: 13., y: -7. });
|
||||
assert!(gesture.move_to(pointer));
|
||||
assert!(!gesture.crossed_threshold());
|
||||
assert_eq!(gesture.delta(), Position { x: 0., y: 0. });
|
||||
assert_eq!(gesture.release(pointer), Some(Outcome::Click(id(10))));
|
||||
}
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn threshold_latches_and_return_to_offgrid_origin_is_zero_move() {
|
||||
let mut gesture = gesture(Position { x: 13., y: -7. });
|
||||
let captured = gesture.snapshot().clone();
|
||||
assert!(gesture.move_to(Point::new(170., 140.)));
|
||||
assert!(gesture.crossed_threshold());
|
||||
assert!(gesture.move_to(press()));
|
||||
assert!(gesture.crossed_threshold());
|
||||
assert_eq!(gesture.delta(), Position { x: 0., y: 0. });
|
||||
assert_eq!(
|
||||
gesture.release(press()),
|
||||
Some(Outcome::Move(captured, Position { x: 0., y: 0. }))
|
||||
);
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn release_only_displacement_that_snaps_to_zero_still_preserves_group() {
|
||||
let gesture = gesture(Position { x: 20., y: 40. });
|
||||
let captured = gesture.snapshot().clone();
|
||||
assert_eq!(
|
||||
gesture.release(Point::new(154., 120.)),
|
||||
Some(Outcome::Move(captured, Position { x: 0., y: 0. }))
|
||||
);
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn offgrid_anchor_yields_one_shared_delta_and_release_matches_preview() {
|
||||
let mut gesture = gesture(Position { x: 13., y: -7. });
|
||||
let captured = gesture.snapshot().clone();
|
||||
assert_eq!(gesture.anchor(), id(10));
|
||||
let pointer = Point::new(167., 133.);
|
||||
assert!(gesture.move_to(pointer));
|
||||
// Desired anchor (30,6) snaps to (30,10), hence shared delta (17,17).
|
||||
assert_eq!(gesture.delta(), Position { x: 17., y: 17. });
|
||||
let sibling = Position { x: -6., y: 24. };
|
||||
let translated = Position {
|
||||
x: sibling.x + gesture.delta().x,
|
||||
y: sibling.y + gesture.delta().y,
|
||||
};
|
||||
assert_eq!(translated, Position { x: 11., y: 41. });
|
||||
assert_eq!(
|
||||
gesture.release(pointer),
|
||||
Some(Outcome::Move(captured, Position { x: 17., y: 17. }))
|
||||
);
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn zoom_scales_world_delta_but_threshold_remains_in_screen_pixels() {
|
||||
let mut gesture = Gesture::new(
|
||||
snapshot([Target::Placement(id(10))]),
|
||||
id(10),
|
||||
Position { x: 20., y: 40. },
|
||||
press(),
|
||||
Viewport {
|
||||
zoom: 2.,
|
||||
..viewport()
|
||||
},
|
||||
)
|
||||
.unwrap();
|
||||
assert!(gesture.move_to(Point::new(153., 120.)));
|
||||
assert!(!gesture.crossed_threshold());
|
||||
assert!(gesture.move_to(Point::new(168., 112.)));
|
||||
// Screen (18,-8) means world (9,-4), snapped anchor (30,40).
|
||||
assert_eq!(gesture.delta(), Position { x: 10., y: 0. });
|
||||
assert!(gesture.crossed_threshold());
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn full_typed_selection_and_saved_surface_are_required() {
|
||||
for targets in [
|
||||
vec![],
|
||||
vec![Target::Placement(id(11))],
|
||||
vec![Target::Placement(id(10)), Target::Edge(id(20))],
|
||||
vec![
|
||||
Target::Placement(id(10)),
|
||||
Target::Port {
|
||||
port: id(20),
|
||||
placement: id(10),
|
||||
},
|
||||
],
|
||||
] {
|
||||
assert!(
|
||||
Gesture::new(
|
||||
snapshot(targets),
|
||||
id(10),
|
||||
Position { x: 0., y: 0. },
|
||||
press(),
|
||||
viewport()
|
||||
)
|
||||
.is_none()
|
||||
);
|
||||
}
|
||||
let other = Context {
|
||||
scope: Scope {
|
||||
surface: Surface::Process(id(2)),
|
||||
..context().scope
|
||||
},
|
||||
..context()
|
||||
};
|
||||
let mut selection = Selection::new(other.scope);
|
||||
selection.add(Target::Placement(id(10)), |_| true);
|
||||
assert!(
|
||||
Gesture::new(
|
||||
selection.snapshot(other).unwrap(),
|
||||
id(10),
|
||||
Position { x: 0., y: 0. },
|
||||
press(),
|
||||
viewport()
|
||||
)
|
||||
.is_none()
|
||||
);
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn any_frozen_viewport_change_is_detected() {
|
||||
let gesture = gesture(Position { x: 0., y: 0. });
|
||||
assert!(gesture.viewport_matches(viewport()));
|
||||
for changed in [
|
||||
Viewport {
|
||||
zoom: 2.,
|
||||
..viewport()
|
||||
},
|
||||
Viewport {
|
||||
pan: Vector::new(18., -8.),
|
||||
..viewport()
|
||||
},
|
||||
Viewport {
|
||||
pan: Vector::new(17., -7.),
|
||||
..viewport()
|
||||
},
|
||||
Viewport {
|
||||
bounds: Rectangle {
|
||||
x: 101.,
|
||||
..viewport().bounds
|
||||
},
|
||||
..viewport()
|
||||
},
|
||||
Viewport {
|
||||
bounds: Rectangle {
|
||||
y: 51.,
|
||||
..viewport().bounds
|
||||
},
|
||||
..viewport()
|
||||
},
|
||||
Viewport {
|
||||
bounds: Rectangle {
|
||||
width: 401.,
|
||||
..viewport().bounds
|
||||
},
|
||||
..viewport()
|
||||
},
|
||||
Viewport {
|
||||
bounds: Rectangle {
|
||||
height: 301.,
|
||||
..viewport().bounds
|
||||
},
|
||||
..viewport()
|
||||
},
|
||||
] {
|
||||
assert!(!gesture.viewport_matches(changed));
|
||||
}
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn invalid_initial_geometry_cannot_start() {
|
||||
let saved = snapshot([Target::Placement(id(10))]);
|
||||
for invalid in [
|
||||
Viewport {
|
||||
zoom: 0.,
|
||||
..viewport()
|
||||
},
|
||||
Viewport {
|
||||
zoom: -1.,
|
||||
..viewport()
|
||||
},
|
||||
Viewport {
|
||||
zoom: f32::NAN,
|
||||
..viewport()
|
||||
},
|
||||
Viewport {
|
||||
zoom: f32::INFINITY,
|
||||
..viewport()
|
||||
},
|
||||
Viewport {
|
||||
pan: Vector::new(f32::NAN, 0.),
|
||||
..viewport()
|
||||
},
|
||||
Viewport {
|
||||
bounds: Rectangle {
|
||||
width: 0.,
|
||||
..viewport().bounds
|
||||
},
|
||||
..viewport()
|
||||
},
|
||||
Viewport {
|
||||
bounds: Rectangle {
|
||||
height: -1.,
|
||||
..viewport().bounds
|
||||
},
|
||||
..viewport()
|
||||
},
|
||||
Viewport {
|
||||
bounds: Rectangle {
|
||||
x: f32::INFINITY,
|
||||
..viewport().bounds
|
||||
},
|
||||
..viewport()
|
||||
},
|
||||
] {
|
||||
assert!(
|
||||
Gesture::new(
|
||||
saved.clone(),
|
||||
id(10),
|
||||
Position { x: 0., y: 0. },
|
||||
press(),
|
||||
invalid
|
||||
)
|
||||
.is_none()
|
||||
);
|
||||
}
|
||||
assert!(
|
||||
Gesture::new(
|
||||
saved.clone(),
|
||||
id(10),
|
||||
Position { x: f32::NAN, y: 0. },
|
||||
press(),
|
||||
viewport()
|
||||
)
|
||||
.is_none()
|
||||
);
|
||||
for invalid in [Point::new(f32::NAN, 120.), Point::new(99., 120.)] {
|
||||
assert!(
|
||||
Gesture::new(
|
||||
saved.clone(),
|
||||
id(10),
|
||||
Position { x: 0., y: 0. },
|
||||
invalid,
|
||||
viewport()
|
||||
)
|
||||
.is_none()
|
||||
);
|
||||
}
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn invalid_pointer_permanently_retires_even_if_pointer_returns() {
|
||||
for invalid in [Point::new(f32::NAN, 120.), Point::new(501., 120.)] {
|
||||
let mut gesture = gesture(Position { x: 20., y: 40. });
|
||||
assert!(gesture.move_to(Point::new(170., 140.)));
|
||||
assert!(!gesture.move_to(invalid));
|
||||
assert_eq!(gesture.delta(), Position { x: 0., y: 0. });
|
||||
assert!(!gesture.move_to(press()));
|
||||
assert!(!gesture.viewport_matches(viewport()));
|
||||
assert_eq!(gesture.release(press()), None);
|
||||
}
|
||||
assert_eq!(
|
||||
gesture(Position { x: 20., y: 40. }).release(Point::new(501., 120.)),
|
||||
None
|
||||
);
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn finite_inputs_that_overflow_world_geometry_retire_without_an_operation() {
|
||||
let mut gesture = Gesture::new(
|
||||
snapshot([Target::Placement(id(10))]),
|
||||
id(10),
|
||||
Position { x: 0., y: 0. },
|
||||
press(),
|
||||
Viewport {
|
||||
zoom: f32::MIN_POSITIVE,
|
||||
..viewport()
|
||||
},
|
||||
)
|
||||
.unwrap();
|
||||
assert!(!gesture.move_to(Point::new(170., 140.)));
|
||||
assert_eq!(gesture.release(press()), None);
|
||||
}
|
||||
}
|
||||
@@ -53,6 +53,7 @@ fn bounds() -> Rectangle {
|
||||
}
|
||||
fn canvas(app: &App) -> DiagramCanvas<'_> {
|
||||
DiagramCanvas {
|
||||
selection: None,
|
||||
project: app.project(),
|
||||
view_index: None,
|
||||
diagram: app.active_diagram.unwrap(),
|
||||
|
||||
@@ -0,0 +1,297 @@
|
||||
use super::group_gesture::{Gesture as GroupGesture, Outcome, Viewport};
|
||||
use super::*;
|
||||
use crate::app::multiselect::{Choice, Event, context};
|
||||
use crate::diagram_selection::Snapshot;
|
||||
use crate::diagram_usage::Target;
|
||||
|
||||
/// Even an unsupported mixed group must retain an ordinary click lifecycle.
|
||||
pub(super) struct Press {
|
||||
snapshot: Snapshot,
|
||||
target: Target,
|
||||
start: Point,
|
||||
viewport: Viewport,
|
||||
movement: Option<GroupGesture>,
|
||||
reason: Option<String>,
|
||||
crossed: bool,
|
||||
retired: bool,
|
||||
}
|
||||
impl Press {
|
||||
fn snapshot(&self) -> &Snapshot {
|
||||
self.movement
|
||||
.as_ref()
|
||||
.map_or(&self.snapshot, GroupGesture::snapshot)
|
||||
}
|
||||
fn viewport_matches(&self, viewport: Viewport) -> bool {
|
||||
!self.retired
|
||||
&& self.viewport == viewport
|
||||
&& self
|
||||
.movement
|
||||
.as_ref()
|
||||
.is_none_or(|movement| movement.viewport_matches(viewport))
|
||||
}
|
||||
fn crossed_threshold(&self) -> bool {
|
||||
self.movement
|
||||
.as_ref()
|
||||
.map_or(self.crossed, GroupGesture::crossed_threshold)
|
||||
}
|
||||
fn delta(&self) -> Position {
|
||||
self.movement
|
||||
.as_ref()
|
||||
.map_or(Position { x: 0., y: 0. }, GroupGesture::delta)
|
||||
}
|
||||
fn move_to(&mut self, pointer: Point) {
|
||||
if self.retired {
|
||||
return;
|
||||
}
|
||||
if !pointer.x.is_finite()
|
||||
|| !pointer.y.is_finite()
|
||||
|| !self.viewport.bounds.contains(pointer)
|
||||
{
|
||||
self.retired = true;
|
||||
self.movement = None;
|
||||
return;
|
||||
}
|
||||
self.crossed |= pointer.distance(self.start) > 3.;
|
||||
if let Some(movement) = &mut self.movement
|
||||
&& !movement.move_to(pointer)
|
||||
{
|
||||
self.retired = true;
|
||||
}
|
||||
}
|
||||
fn release(mut self, pointer: Point) -> Option<Event> {
|
||||
self.move_to(pointer);
|
||||
if self.retired {
|
||||
return None;
|
||||
}
|
||||
if !self.crossed {
|
||||
return Some(Event::Collapse(self.snapshot, self.target));
|
||||
}
|
||||
if let Some(reason) = self.reason {
|
||||
return Some(Event::Refuse(self.snapshot, reason));
|
||||
}
|
||||
match self.movement?.release(pointer)? {
|
||||
Outcome::Click(id) => Some(Event::Collapse(self.snapshot, Target::Placement(id))),
|
||||
Outcome::Move(snapshot, delta) => Some(Event::Move(snapshot, delta)),
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
impl DiagramCanvas<'_> {
|
||||
pub(super) fn selection_contains(&self, target: Target) -> bool {
|
||||
self.selection
|
||||
.is_some_and(|s| s.scope() == context(self.context).scope && s.contains(&target))
|
||||
}
|
||||
|
||||
pub(super) fn group_input(
|
||||
&self,
|
||||
state: &mut State,
|
||||
event: &canvas::Event,
|
||||
bounds: Rectangle,
|
||||
cursor: mouse::Cursor,
|
||||
) -> Option<Action<Message>> {
|
||||
let viewport = Viewport {
|
||||
zoom: self.zoom,
|
||||
pan: self.pan,
|
||||
bounds,
|
||||
};
|
||||
if let Some(gesture) = &state.group {
|
||||
let valid = gesture.viewport_matches(viewport)
|
||||
&& self.editable
|
||||
&& self.connection.is_none()
|
||||
&& !self.placing
|
||||
&& self
|
||||
.selection
|
||||
.is_some_and(|s| s.matches(gesture.snapshot(), context(self.context)));
|
||||
let cancelled = matches!(
|
||||
event,
|
||||
canvas::Event::Window(
|
||||
iced::window::Event::Unfocused | iced::window::Event::Resized(_)
|
||||
) | canvas::Event::Mouse(
|
||||
mouse::Event::CursorLeft
|
||||
| mouse::Event::WheelScrolled { .. }
|
||||
| mouse::Event::ButtonPressed(mouse::Button::Right | mouse::Button::Middle)
|
||||
) | canvas::Event::Keyboard(iced::keyboard::Event::KeyPressed {
|
||||
key: iced::keyboard::Key::Named(iced::keyboard::key::Named::Escape),
|
||||
..
|
||||
})
|
||||
);
|
||||
if !valid || cancelled {
|
||||
state.group = None;
|
||||
*state.cache.borrow_mut() = None;
|
||||
return Some(Action::request_redraw().and_capture());
|
||||
}
|
||||
}
|
||||
if let Some(gesture) = &mut state.group {
|
||||
match event {
|
||||
canvas::Event::Mouse(mouse::Event::CursorMoved { position }) => {
|
||||
gesture.move_to(*position);
|
||||
*state.cache.borrow_mut() = None;
|
||||
return Some(Action::request_redraw().and_capture());
|
||||
}
|
||||
canvas::Event::Mouse(mouse::Event::ButtonReleased(mouse::Button::Left)) => {
|
||||
let gesture = state.group.take().unwrap();
|
||||
*state.cache.borrow_mut() = None;
|
||||
let outcome = cursor
|
||||
.position()
|
||||
.and_then(|pointer| gesture.release(pointer));
|
||||
return Some(match outcome {
|
||||
Some(event) => {
|
||||
Action::publish(Message::DiagramSelection(event)).and_capture()
|
||||
}
|
||||
None => Action::request_redraw().and_capture(),
|
||||
});
|
||||
}
|
||||
canvas::Event::Keyboard(_) => return Some(Action::capture()),
|
||||
_ => {}
|
||||
}
|
||||
}
|
||||
let selection = self
|
||||
.selection
|
||||
.filter(|s| s.scope() == context(self.context).scope)?;
|
||||
if state.pan_start.is_some() {
|
||||
return None;
|
||||
}
|
||||
if self.connection.is_some() || self.placing {
|
||||
return None;
|
||||
}
|
||||
if let canvas::Event::Keyboard(iced::keyboard::Event::KeyPressed {
|
||||
key, modifiers, ..
|
||||
}) = event
|
||||
{
|
||||
use iced::keyboard::{Key, key::Named};
|
||||
if *key == Key::Named(Named::Escape)
|
||||
&& state.drag.is_none()
|
||||
&& state.route_drag.is_none()
|
||||
&& state.port_drag.is_none()
|
||||
&& state.work.is_none()
|
||||
{
|
||||
return Some(
|
||||
Action::publish(Message::DiagramSelection(Event::Clear(context(
|
||||
self.context,
|
||||
))))
|
||||
.and_capture(),
|
||||
);
|
||||
}
|
||||
if selection.targets().len() > 1 && *key == Key::Named(Named::Delete) {
|
||||
let snapshot = selection.snapshot(context(self.context))?;
|
||||
let action = if modifiers.is_empty() {
|
||||
Event::Hide(snapshot)
|
||||
} else {
|
||||
Event::Refuse(snapshot, "Use Hide selected to remove placements. Group model-deletion review is not available yet.".into())
|
||||
};
|
||||
return Some(Action::publish(Message::DiagramSelection(action)).and_capture());
|
||||
}
|
||||
}
|
||||
if !matches!(
|
||||
event,
|
||||
canvas::Event::Mouse(mouse::Event::ButtonPressed(mouse::Button::Left))
|
||||
) || !cursor.is_over(bounds)
|
||||
{
|
||||
return None;
|
||||
}
|
||||
let pointer = cursor.position()?;
|
||||
let local = Point::new(pointer.x - bounds.x, pointer.y - bounds.y);
|
||||
let scene = self.scene(state);
|
||||
let target = if let Some(port) = self.hit_port(&scene.view, local) {
|
||||
Some(Target::Port {
|
||||
port: port.element,
|
||||
placement: port.owner,
|
||||
})
|
||||
} else if let Some(id) = self.hit(&scene.view, local) {
|
||||
Some(Target::Placement(id))
|
||||
} else {
|
||||
self.hit_label(&scene.routed, local)
|
||||
.or_else(|| self.hit_association_label(&scene.routed, local))
|
||||
.or_else(|| self.hit_edge(&scene.routed, local).map(|hit| hit.0))
|
||||
.map(Target::Edge)
|
||||
}?;
|
||||
if state.modifiers.shift() {
|
||||
state.drag = None;
|
||||
state.preview = None;
|
||||
state.port_drag = None;
|
||||
state.route_drag = None;
|
||||
return Some(
|
||||
Action::publish(Message::DiagramSelection(Event::Choose(
|
||||
context(self.context),
|
||||
target,
|
||||
Choice::Toggle,
|
||||
)))
|
||||
.and_capture(),
|
||||
);
|
||||
}
|
||||
if selection.targets().len() <= 1 || !selection.contains(&target) {
|
||||
return None;
|
||||
}
|
||||
let snapshot = selection.snapshot(context(self.context))?;
|
||||
if !self.editable {
|
||||
return Some(Action::capture());
|
||||
}
|
||||
let reason = if crate::app::multiselect::placements(&snapshot).is_none() {
|
||||
Some(
|
||||
"Move requires only placed elements. Remove ports and connections from the selection.",
|
||||
)
|
||||
} else if snapshot
|
||||
.targets()
|
||||
.iter()
|
||||
.any(|t| matches!(t, Target::Placement(id) if self.work_eligible(*id)))
|
||||
{
|
||||
Some("Group allocation drag is not available yet. The selection was retained.")
|
||||
} else {
|
||||
None
|
||||
};
|
||||
let movement = if reason.is_none()
|
||||
&& let Target::Placement(anchor) = target
|
||||
{
|
||||
let original = self.project.diagrams[&self.diagram].nodes[&anchor].position;
|
||||
GroupGesture::new(snapshot.clone(), anchor, original, pointer, viewport)
|
||||
} else {
|
||||
None
|
||||
};
|
||||
if movement.is_none() && reason.is_none() {
|
||||
return Some(Action::capture());
|
||||
}
|
||||
state.group = Some(Press {
|
||||
snapshot,
|
||||
target,
|
||||
start: pointer,
|
||||
viewport,
|
||||
movement,
|
||||
reason: reason.map(str::to_owned),
|
||||
crossed: false,
|
||||
retired: false,
|
||||
});
|
||||
*state.cache.borrow_mut() = None;
|
||||
Some(Action::request_redraw().and_capture())
|
||||
}
|
||||
|
||||
pub(super) fn group_preview(&self, state: &State, diagram: &mut Diagram) {
|
||||
let Some(gesture) = &state.group else {
|
||||
return;
|
||||
};
|
||||
if !gesture.crossed_threshold() {
|
||||
return;
|
||||
}
|
||||
let Some(ids) = crate::app::multiselect::placements(gesture.snapshot()) else {
|
||||
return;
|
||||
};
|
||||
let Ok(Command::Batch(commands)) = oa_core::diagram_edit::translate_placements(
|
||||
self.project,
|
||||
self.diagram,
|
||||
&ids,
|
||||
gesture.delta(),
|
||||
) else {
|
||||
return;
|
||||
};
|
||||
// Apply only the planner's presentation records. Full model validation
|
||||
// and source/history updates occur once, when App accepts the release.
|
||||
for command in commands {
|
||||
match command {
|
||||
Command::EditNode { node, .. } => {
|
||||
diagram.nodes.insert(node.id, node);
|
||||
}
|
||||
Command::SetEdgeRoute { route, .. } => route_edit::with_route(diagram, route),
|
||||
_ => unreachable!("placement planner returned a non-geometry command"),
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,758 @@
|
||||
//! Production canvas event regressions for exact multi-selection and group gestures.
|
||||
use super::{DiagramCanvas, State};
|
||||
use crate::app::{
|
||||
Message,
|
||||
multiselect::{Choice, Event as SelectionEvent, context},
|
||||
};
|
||||
use crate::diagram_selection::Selection;
|
||||
use crate::diagram_usage::Target;
|
||||
use iced::widget::canvas::{self, Program};
|
||||
use iced::{Point, Rectangle, Size, Vector, event::Status, keyboard, mouse};
|
||||
use oa_core::*;
|
||||
|
||||
fn position(x: f32, y: f32) -> Position {
|
||||
Position { x, y }
|
||||
}
|
||||
fn bounds() -> Rectangle {
|
||||
Rectangle::new(Point::new(260., 100.), Size::new(2400., 1800.))
|
||||
}
|
||||
|
||||
struct Fixture {
|
||||
project: Project,
|
||||
diagram: Id,
|
||||
a: Id,
|
||||
b: Id,
|
||||
child: Id,
|
||||
internal: Id,
|
||||
context: crate::route_edit::Context,
|
||||
}
|
||||
|
||||
impl Fixture {
|
||||
fn new() -> Self {
|
||||
let mut project = Project::empty();
|
||||
let a = project
|
||||
.add_element(Kind::Activity, Layer::Oa, "A", None)
|
||||
.unwrap();
|
||||
let b = project
|
||||
.add_element(Kind::Activity, Layer::Oa, "B", None)
|
||||
.unwrap();
|
||||
let c = project
|
||||
.add_element(Kind::Activity, Layer::Oa, "C", None)
|
||||
.unwrap();
|
||||
let child = project
|
||||
.add_element(Kind::Activity, Layer::Oa, "Child", Some(a))
|
||||
.unwrap();
|
||||
let internal = project.relate(RelationKind::Interaction, "Internal", a, b);
|
||||
let external = project.relate(RelationKind::Interaction, "External", b, c);
|
||||
let diagram = project.ensure_diagram(Layer::Oa);
|
||||
project.diagrams.get_mut(&diagram).unwrap().projection = ProjectionKind::Overview;
|
||||
let a = project.place(diagram, a, position(100., 200.));
|
||||
let b = project.place(diagram, b, position(500., 200.));
|
||||
let child = project.place(diagram, child, position(120., 280.));
|
||||
project.place(diagram, c, position(900., 200.));
|
||||
let view = project.diagrams.get_mut(&diagram).unwrap();
|
||||
view.nodes.get_mut(&a).unwrap().collapsed = true;
|
||||
view.routes = [
|
||||
(internal, position(400., 320.)),
|
||||
(external, position(800., 340.)),
|
||||
]
|
||||
.into_iter()
|
||||
.map(|(edge, point)| EdgeRoute {
|
||||
edge,
|
||||
source_attachment: None,
|
||||
target_attachment: None,
|
||||
waypoints: vec![point],
|
||||
label: Some(EdgeLabel {
|
||||
fraction: 0.4,
|
||||
offset: position(3., -9.),
|
||||
}),
|
||||
})
|
||||
.collect();
|
||||
validate_candidate(&project).unwrap();
|
||||
Self {
|
||||
project,
|
||||
diagram,
|
||||
a,
|
||||
b,
|
||||
child,
|
||||
internal,
|
||||
context: crate::route_edit::Context {
|
||||
document: Id::new_v4(),
|
||||
diagram,
|
||||
revision: 7,
|
||||
epoch: 11,
|
||||
},
|
||||
}
|
||||
}
|
||||
|
||||
fn selection(&self, targets: impl IntoIterator<Item = Target>) -> Selection {
|
||||
let mut selection = Selection::new(context(self.context).scope);
|
||||
for target in targets {
|
||||
assert!(selection.add(target, |_| true));
|
||||
}
|
||||
selection
|
||||
}
|
||||
|
||||
fn pair(&self) -> Selection {
|
||||
self.selection([Target::Placement(self.a), Target::Placement(self.b)])
|
||||
}
|
||||
|
||||
fn canvas<'a>(&'a self, selection: &'a Selection, zoom: f32) -> DiagramCanvas<'a> {
|
||||
let selected = match selection.primary() {
|
||||
Some(Target::Placement(id)) => self.project.diagrams[&self.diagram].nodes[id].element,
|
||||
Some(Target::Edge(id)) => *id,
|
||||
Some(Target::Port { port, .. }) => *port,
|
||||
_ => self.diagram,
|
||||
};
|
||||
DiagramCanvas {
|
||||
selection: Some(selection),
|
||||
project: &self.project,
|
||||
view_index: None,
|
||||
diagram: self.diagram,
|
||||
selected,
|
||||
navigation_focus: None,
|
||||
zoom,
|
||||
pan: Vector::new(20., 30.),
|
||||
context: self.context,
|
||||
selected_bend: None,
|
||||
selected_attachment: None,
|
||||
editable: true,
|
||||
placing: false,
|
||||
connection: None,
|
||||
allocation: None,
|
||||
}
|
||||
}
|
||||
|
||||
fn screen(&self, placement: Id, zoom: f32) -> Point {
|
||||
let p = self.project.diagrams[&self.diagram].nodes[&placement].position;
|
||||
Point::new(
|
||||
bounds().x + (p.x + 30.) * zoom + 20.,
|
||||
bounds().y + (p.y + 25.) * zoom + 30.,
|
||||
)
|
||||
}
|
||||
|
||||
fn expected_move(&self) -> Diagram {
|
||||
// Independent literal expectations: the folded child moves with A,
|
||||
// only the internal edge's authored world pin translates.
|
||||
let mut expected = self.project.diagrams[&self.diagram].clone();
|
||||
expected.nodes.get_mut(&self.a).unwrap().position = position(140., 260.);
|
||||
expected.nodes.get_mut(&self.b).unwrap().position = position(540., 260.);
|
||||
expected.nodes.get_mut(&self.child).unwrap().position = position(160., 340.);
|
||||
expected.routes[0].waypoints = vec![position(440., 380.)];
|
||||
expected
|
||||
}
|
||||
}
|
||||
|
||||
fn input(
|
||||
c: &DiagramCanvas<'_>,
|
||||
state: &mut State,
|
||||
event: canvas::Event,
|
||||
viewport: Rectangle,
|
||||
final_cursor: Point,
|
||||
) -> (Option<Message>, Status) {
|
||||
c.update(
|
||||
state,
|
||||
&event,
|
||||
viewport,
|
||||
mouse::Cursor::Available(final_cursor),
|
||||
)
|
||||
.map_or((None, Status::Ignored), |action| {
|
||||
let (message, _, status) = action.into_inner();
|
||||
(message, status)
|
||||
})
|
||||
}
|
||||
|
||||
fn pointer(
|
||||
c: &DiagramCanvas<'_>,
|
||||
state: &mut State,
|
||||
event: mouse::Event,
|
||||
final_cursor: Point,
|
||||
) -> (Option<Message>, Status) {
|
||||
input(
|
||||
c,
|
||||
state,
|
||||
canvas::Event::Mouse(event),
|
||||
bounds(),
|
||||
final_cursor,
|
||||
)
|
||||
}
|
||||
|
||||
fn start(c: &DiagramCanvas<'_>, state: &mut State, press: Point, final_cursor: Point) {
|
||||
assert!(
|
||||
pointer(
|
||||
c,
|
||||
state,
|
||||
mouse::Event::CursorMoved { position: press },
|
||||
final_cursor
|
||||
)
|
||||
.0
|
||||
.is_none()
|
||||
);
|
||||
let (message, status) = pointer(
|
||||
c,
|
||||
state,
|
||||
mouse::Event::ButtonPressed(mouse::Button::Left),
|
||||
final_cursor,
|
||||
);
|
||||
assert!(message.is_none());
|
||||
assert_eq!(status, Status::Captured);
|
||||
assert!(state.group.is_some());
|
||||
assert!(state.drag.is_none());
|
||||
}
|
||||
|
||||
fn key(named: keyboard::key::Named) -> canvas::Event {
|
||||
canvas::Event::Keyboard(keyboard::Event::KeyPressed {
|
||||
key: keyboard::Key::Named(named),
|
||||
modified_key: keyboard::Key::Named(named),
|
||||
physical_key: keyboard::key::Physical::Code(if named == keyboard::key::Named::Escape {
|
||||
keyboard::key::Code::Escape
|
||||
} else {
|
||||
keyboard::key::Code::Delete
|
||||
}),
|
||||
location: keyboard::Location::Standard,
|
||||
modifiers: keyboard::Modifiers::empty(),
|
||||
text: None,
|
||||
repeat: false,
|
||||
})
|
||||
}
|
||||
|
||||
fn expect_move(
|
||||
message: Option<Message>,
|
||||
selection: &Selection,
|
||||
current: crate::route_edit::Context,
|
||||
expected: Position,
|
||||
) -> crate::diagram_selection::Snapshot {
|
||||
let Some(Message::DiagramSelection(SelectionEvent::Move(snapshot, delta))) = message else {
|
||||
panic!("expected one captured group Move");
|
||||
};
|
||||
assert_eq!(delta, expected);
|
||||
assert!(selection.matches(&snapshot, context(current)));
|
||||
snapshot
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn shift_press_uses_ordered_hit_not_native_batch_final_cursor() {
|
||||
let f = Fixture::new();
|
||||
let selection = f.selection([Target::Placement(f.b)]);
|
||||
let before = selection.snapshot(context(f.context)).unwrap();
|
||||
let c = f.canvas(&selection, 1.);
|
||||
let mut state = State::default();
|
||||
let at_a = f.screen(f.a, 1.);
|
||||
let final_cursor = f.screen(f.b, 1.);
|
||||
assert!(
|
||||
input(
|
||||
&c,
|
||||
&mut state,
|
||||
canvas::Event::Keyboard(keyboard::Event::ModifiersChanged(
|
||||
keyboard::Modifiers::SHIFT
|
||||
)),
|
||||
bounds(),
|
||||
final_cursor
|
||||
)
|
||||
.0
|
||||
.is_none()
|
||||
);
|
||||
assert!(
|
||||
pointer(
|
||||
&c,
|
||||
&mut state,
|
||||
mouse::Event::CursorMoved { position: at_a },
|
||||
final_cursor
|
||||
)
|
||||
.0
|
||||
.is_none()
|
||||
);
|
||||
let (message, status) = pointer(
|
||||
&c,
|
||||
&mut state,
|
||||
mouse::Event::ButtonPressed(mouse::Button::Left),
|
||||
final_cursor,
|
||||
);
|
||||
assert_eq!(status, Status::Captured);
|
||||
assert!(
|
||||
matches!(message, Some(Message::DiagramSelection(SelectionEvent::Choose(captured, Target::Placement(id), Choice::Toggle))) if captured == context(f.context) && id == f.a)
|
||||
);
|
||||
assert!(
|
||||
state.group.is_none()
|
||||
&& state.drag.is_none()
|
||||
&& state.route_drag.is_none()
|
||||
&& state.port_drag.is_none()
|
||||
);
|
||||
assert!(
|
||||
pointer(
|
||||
&c,
|
||||
&mut state,
|
||||
mouse::Event::ButtonReleased(mouse::Button::Left),
|
||||
final_cursor
|
||||
)
|
||||
.0
|
||||
.is_none()
|
||||
);
|
||||
assert!(
|
||||
selection.matches(&before, context(f.context)),
|
||||
"canvas emits intent without mutating selection"
|
||||
);
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn group_canvas_preview_and_release_match_independent_expected_geometry() {
|
||||
for zoom in [0.5, 1., 2.] {
|
||||
let f = Fixture::new();
|
||||
let selection = f.pair();
|
||||
let captured = selection.snapshot(context(f.context)).unwrap();
|
||||
let c = f.canvas(&selection, zoom);
|
||||
let mut state = State::default();
|
||||
let press = f.screen(f.a, zoom);
|
||||
let end = press + Vector::new(40. * zoom, 60. * zoom);
|
||||
start(&c, &mut state, press, end);
|
||||
assert_eq!(c.preview_diagram(&state), f.project.diagrams[&f.diagram]);
|
||||
let (message, status) = pointer(
|
||||
&c,
|
||||
&mut state,
|
||||
mouse::Event::CursorMoved { position: end },
|
||||
end,
|
||||
);
|
||||
assert!(message.is_none());
|
||||
assert_eq!(status, Status::Captured);
|
||||
assert_eq!(c.preview_diagram(&state), f.expected_move());
|
||||
let (message, status) = pointer(
|
||||
&c,
|
||||
&mut state,
|
||||
mouse::Event::ButtonReleased(mouse::Button::Left),
|
||||
end,
|
||||
);
|
||||
assert_eq!(status, Status::Captured);
|
||||
let snapshot = expect_move(message, &selection, f.context, position(40., 60.));
|
||||
assert_eq!(snapshot, captured);
|
||||
assert!(state.group.is_none());
|
||||
let ids = crate::app::multiselect::placements(&snapshot).unwrap();
|
||||
let command =
|
||||
diagram_edit::translate_placements(&f.project, f.diagram, &ids, position(40., 60.))
|
||||
.unwrap();
|
||||
let actual = prepare_command(&f.project, &command).unwrap().project;
|
||||
let mut expected = f.project.clone();
|
||||
expected.diagrams.insert(f.diagram, f.expected_move());
|
||||
assert_eq!(actual, expected);
|
||||
assert!(selection.matches(&captured, context(f.context)));
|
||||
}
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn stationary_group_click_does_not_use_motion_after_release_in_same_batch() {
|
||||
let f = Fixture::new();
|
||||
let selection = f.pair();
|
||||
let c = f.canvas(&selection, 1.);
|
||||
let mut state = State::default();
|
||||
let press = f.screen(f.a, 1.);
|
||||
let end = press + Vector::new(80., 70.);
|
||||
start(&c, &mut state, press, end);
|
||||
let (message, _) = pointer(
|
||||
&c,
|
||||
&mut state,
|
||||
mouse::Event::ButtonReleased(mouse::Button::Left),
|
||||
end,
|
||||
);
|
||||
assert!(
|
||||
matches!(message, Some(Message::DiagramSelection(SelectionEvent::Collapse(captured, Target::Placement(id)))) if selection.matches(&captured, context(f.context)) && id == f.a)
|
||||
);
|
||||
assert!(
|
||||
pointer(
|
||||
&c,
|
||||
&mut state,
|
||||
mouse::Event::CursorMoved { position: end },
|
||||
end
|
||||
)
|
||||
.0
|
||||
.is_none()
|
||||
);
|
||||
assert_eq!(c.preview_diagram(&state), f.project.diagrams[&f.diagram]);
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn mixed_set_keeps_click_lifecycle_and_refuses_only_actual_drag() {
|
||||
for moved in [false, true] {
|
||||
let f = Fixture::new();
|
||||
let selection = f.selection([Target::Placement(f.a), Target::Edge(f.internal)]);
|
||||
let captured = selection.snapshot(context(f.context)).unwrap();
|
||||
let c = f.canvas(&selection, 1.);
|
||||
let mut state = State::default();
|
||||
let press = f.screen(f.a, 1.);
|
||||
let end = if moved {
|
||||
press + Vector::new(40., 60.)
|
||||
} else {
|
||||
press + Vector::new(2., 1.)
|
||||
};
|
||||
start(&c, &mut state, press, end);
|
||||
assert!(
|
||||
pointer(
|
||||
&c,
|
||||
&mut state,
|
||||
mouse::Event::CursorMoved { position: end },
|
||||
end
|
||||
)
|
||||
.0
|
||||
.is_none()
|
||||
);
|
||||
assert_eq!(c.preview_diagram(&state), f.project.diagrams[&f.diagram]);
|
||||
let (message, status) = pointer(
|
||||
&c,
|
||||
&mut state,
|
||||
mouse::Event::ButtonReleased(mouse::Button::Left),
|
||||
end,
|
||||
);
|
||||
assert_eq!(status, Status::Captured);
|
||||
if moved {
|
||||
assert!(
|
||||
matches!(message, Some(Message::DiagramSelection(SelectionEvent::Refuse(snapshot, reason))) if snapshot == captured && reason.contains("only placed elements"))
|
||||
);
|
||||
} else {
|
||||
assert!(
|
||||
matches!(message, Some(Message::DiagramSelection(SelectionEvent::Collapse(current, Target::Placement(id)))) if current == captured && id == f.a)
|
||||
);
|
||||
}
|
||||
assert!(state.group.is_none());
|
||||
assert!(selection.matches(&captured, context(f.context)));
|
||||
}
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn escape_cancels_live_group_without_clearing_or_publishing_a_model_intent() {
|
||||
let f = Fixture::new();
|
||||
let selection = f.pair();
|
||||
let captured = selection.snapshot(context(f.context)).unwrap();
|
||||
let c = f.canvas(&selection, 1.);
|
||||
let mut state = State::default();
|
||||
let press = f.screen(f.a, 1.);
|
||||
let end = press + Vector::new(40., 60.);
|
||||
start(&c, &mut state, press, end);
|
||||
assert!(
|
||||
pointer(
|
||||
&c,
|
||||
&mut state,
|
||||
mouse::Event::CursorMoved { position: end },
|
||||
end
|
||||
)
|
||||
.0
|
||||
.is_none()
|
||||
);
|
||||
assert_eq!(c.preview_diagram(&state), f.expected_move());
|
||||
let (message, status) = input(
|
||||
&c,
|
||||
&mut state,
|
||||
key(keyboard::key::Named::Escape),
|
||||
bounds(),
|
||||
end,
|
||||
);
|
||||
assert!(message.is_none());
|
||||
assert_eq!(status, Status::Captured);
|
||||
assert!(state.group.is_none());
|
||||
assert_eq!(c.preview_diagram(&state), f.project.diagrams[&f.diagram]);
|
||||
assert!(
|
||||
pointer(
|
||||
&c,
|
||||
&mut state,
|
||||
mouse::Event::ButtonReleased(mouse::Button::Left),
|
||||
end
|
||||
)
|
||||
.0
|
||||
.is_none()
|
||||
);
|
||||
assert!(selection.matches(&captured, context(f.context)));
|
||||
// A subsequent Escape, after the gesture is idle, may clear selection.
|
||||
assert!(matches!(
|
||||
input(
|
||||
&c,
|
||||
&mut state,
|
||||
key(keyboard::key::Named::Escape),
|
||||
bounds(),
|
||||
end
|
||||
)
|
||||
.0,
|
||||
Some(Message::DiagramSelection(SelectionEvent::Clear(_)))
|
||||
));
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn delete_is_captured_without_hiding_during_live_group_then_release_moves_once() {
|
||||
let f = Fixture::new();
|
||||
let selection = f.pair();
|
||||
let c = f.canvas(&selection, 1.);
|
||||
let mut state = State::default();
|
||||
let press = f.screen(f.a, 1.);
|
||||
let end = press + Vector::new(40., 60.);
|
||||
start(&c, &mut state, press, end);
|
||||
assert!(
|
||||
pointer(
|
||||
&c,
|
||||
&mut state,
|
||||
mouse::Event::CursorMoved { position: end },
|
||||
end
|
||||
)
|
||||
.0
|
||||
.is_none()
|
||||
);
|
||||
let (message, status) = input(
|
||||
&c,
|
||||
&mut state,
|
||||
key(keyboard::key::Named::Delete),
|
||||
bounds(),
|
||||
end,
|
||||
);
|
||||
assert!(message.is_none());
|
||||
assert_eq!(status, Status::Captured);
|
||||
assert!(state.group.is_some());
|
||||
assert_eq!(c.preview_diagram(&state), f.expected_move());
|
||||
expect_move(
|
||||
pointer(
|
||||
&c,
|
||||
&mut state,
|
||||
mouse::Event::ButtonReleased(mouse::Button::Left),
|
||||
end,
|
||||
)
|
||||
.0,
|
||||
&selection,
|
||||
f.context,
|
||||
position(40., 60.),
|
||||
);
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn middle_pan_excludes_group_start_and_delete_even_when_left_is_pressed() {
|
||||
let f = Fixture::new();
|
||||
let selection = f.pair();
|
||||
let captured = selection.snapshot(context(f.context)).unwrap();
|
||||
let c = f.canvas(&selection, 1.);
|
||||
let mut state = State::default();
|
||||
let press = f.screen(f.a, 1.);
|
||||
let end = press + Vector::new(40., 60.);
|
||||
assert!(
|
||||
pointer(
|
||||
&c,
|
||||
&mut state,
|
||||
mouse::Event::CursorMoved { position: press },
|
||||
end
|
||||
)
|
||||
.0
|
||||
.is_none()
|
||||
);
|
||||
assert!(
|
||||
pointer(
|
||||
&c,
|
||||
&mut state,
|
||||
mouse::Event::ButtonPressed(mouse::Button::Middle),
|
||||
end
|
||||
)
|
||||
.0
|
||||
.is_none()
|
||||
);
|
||||
let (message, status) = pointer(
|
||||
&c,
|
||||
&mut state,
|
||||
mouse::Event::ButtonPressed(mouse::Button::Left),
|
||||
end,
|
||||
);
|
||||
assert!(message.is_none());
|
||||
assert_eq!(status, Status::Captured);
|
||||
assert!(state.group.is_none() && state.drag.is_none());
|
||||
assert!(
|
||||
input(
|
||||
&c,
|
||||
&mut state,
|
||||
key(keyboard::key::Named::Delete),
|
||||
bounds(),
|
||||
end
|
||||
)
|
||||
.0
|
||||
.is_none()
|
||||
);
|
||||
assert!(
|
||||
matches!(pointer(&c, &mut state, mouse::Event::CursorMoved { position: end }, end).0, Some(Message::Pan(delta)) if delta == Vector::new(40., 60.))
|
||||
);
|
||||
assert!(
|
||||
pointer(
|
||||
&c,
|
||||
&mut state,
|
||||
mouse::Event::ButtonReleased(mouse::Button::Left),
|
||||
end
|
||||
)
|
||||
.0
|
||||
.is_none()
|
||||
);
|
||||
assert!(
|
||||
pointer(
|
||||
&c,
|
||||
&mut state,
|
||||
mouse::Event::ButtonReleased(mouse::Button::Middle),
|
||||
end
|
||||
)
|
||||
.0
|
||||
.is_none()
|
||||
);
|
||||
assert_eq!(c.preview_diagram(&state), f.project.diagrams[&f.diagram]);
|
||||
assert!(selection.matches(&captured, context(f.context)));
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn changed_viewport_or_context_retires_group_without_a_release_intent() {
|
||||
for change in 0..7 {
|
||||
let f = Fixture::new();
|
||||
let selection = f.pair();
|
||||
let c = f.canvas(&selection, 1.);
|
||||
let mut state = State::default();
|
||||
let press = f.screen(f.a, 1.);
|
||||
let end = press + Vector::new(40., 60.);
|
||||
start(&c, &mut state, press, end);
|
||||
assert!(
|
||||
pointer(
|
||||
&c,
|
||||
&mut state,
|
||||
mouse::Event::CursorMoved { position: end },
|
||||
end
|
||||
)
|
||||
.0
|
||||
.is_none()
|
||||
);
|
||||
let mut changed = c;
|
||||
let mut viewport = bounds();
|
||||
match change {
|
||||
0 => viewport.x += 1.,
|
||||
1 => viewport.width -= 1.,
|
||||
2 => changed.pan.x += 1.,
|
||||
3 => changed.zoom = 2.,
|
||||
4 => changed.context.epoch += 1,
|
||||
5 => changed.context.revision += 1,
|
||||
_ => changed.context.document = Id::new_v4(),
|
||||
}
|
||||
let (message, _) = input(
|
||||
&changed,
|
||||
&mut state,
|
||||
canvas::Event::Mouse(mouse::Event::ButtonReleased(mouse::Button::Left)),
|
||||
viewport,
|
||||
end,
|
||||
);
|
||||
assert!(
|
||||
message.is_none(),
|
||||
"changed viewport/context {change} must not publish a commit or click"
|
||||
);
|
||||
assert!(state.group.is_none());
|
||||
assert_eq!(
|
||||
changed.preview_diagram(&state),
|
||||
f.project.diagrams[&f.diagram]
|
||||
);
|
||||
}
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn changed_selection_generation_rejects_press_even_after_membership_is_restored() {
|
||||
let f = Fixture::new();
|
||||
let mut selection = f.pair();
|
||||
let press = f.screen(f.a, 1.);
|
||||
let end = press + Vector::new(40., 60.);
|
||||
let mut state = State::default();
|
||||
{
|
||||
let c = f.canvas(&selection, 1.);
|
||||
start(&c, &mut state, press, end);
|
||||
assert!(
|
||||
pointer(
|
||||
&c,
|
||||
&mut state,
|
||||
mouse::Event::CursorMoved { position: end },
|
||||
end
|
||||
)
|
||||
.0
|
||||
.is_none()
|
||||
);
|
||||
}
|
||||
assert!(selection.remove(&Target::Placement(f.b)));
|
||||
assert!(selection.add(Target::Placement(f.b), |_| true));
|
||||
let c = f.canvas(&selection, 1.);
|
||||
let (message, status) = pointer(
|
||||
&c,
|
||||
&mut state,
|
||||
mouse::Event::ButtonReleased(mouse::Button::Left),
|
||||
end,
|
||||
);
|
||||
assert!(message.is_none());
|
||||
assert_eq!(status, Status::Captured);
|
||||
assert!(state.group.is_none());
|
||||
assert_eq!(c.preview_diagram(&state), f.project.diagrams[&f.diagram]);
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn initial_press_without_pointer_history_consumes_release_only_displacement() {
|
||||
let f = Fixture::new();
|
||||
let selection = f.pair();
|
||||
let c = f.canvas(&selection, 1.);
|
||||
let mut state = State::default();
|
||||
let press = f.screen(f.a, 1.);
|
||||
let end = press + Vector::new(40., 60.);
|
||||
// With no earlier ordered move, the supplied release cursor is authoritative.
|
||||
assert!(
|
||||
pointer(
|
||||
&c,
|
||||
&mut state,
|
||||
mouse::Event::ButtonPressed(mouse::Button::Left),
|
||||
press
|
||||
)
|
||||
.0
|
||||
.is_none()
|
||||
);
|
||||
assert!(state.group.is_some());
|
||||
expect_move(
|
||||
pointer(
|
||||
&c,
|
||||
&mut state,
|
||||
mouse::Event::ButtonReleased(mouse::Button::Left),
|
||||
end,
|
||||
)
|
||||
.0,
|
||||
&selection,
|
||||
f.context,
|
||||
position(40., 60.),
|
||||
);
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn threshold_crossing_then_return_to_origin_emits_zero_move_not_singleton_click() {
|
||||
let f = Fixture::new();
|
||||
let selection = f.pair();
|
||||
let c = f.canvas(&selection, 1.);
|
||||
let mut state = State::default();
|
||||
let press = f.screen(f.a, 1.);
|
||||
let end = press + Vector::new(40., 60.);
|
||||
start(&c, &mut state, press, end);
|
||||
assert!(
|
||||
pointer(
|
||||
&c,
|
||||
&mut state,
|
||||
mouse::Event::CursorMoved { position: end },
|
||||
end
|
||||
)
|
||||
.0
|
||||
.is_none()
|
||||
);
|
||||
assert!(
|
||||
pointer(
|
||||
&c,
|
||||
&mut state,
|
||||
mouse::Event::CursorMoved { position: press },
|
||||
end
|
||||
)
|
||||
.0
|
||||
.is_none()
|
||||
);
|
||||
assert_eq!(c.preview_diagram(&state), f.project.diagrams[&f.diagram]);
|
||||
expect_move(
|
||||
pointer(
|
||||
&c,
|
||||
&mut state,
|
||||
mouse::Event::ButtonReleased(mouse::Button::Left),
|
||||
end,
|
||||
)
|
||||
.0,
|
||||
&selection,
|
||||
f.context,
|
||||
position(0., 0.),
|
||||
);
|
||||
assert_eq!(selection.targets().len(), 2);
|
||||
}
|
||||
@@ -61,6 +61,7 @@ fn screen(p: Position, zoom: f32) -> Point {
|
||||
}
|
||||
fn canvas(app: &App, zoom: f32) -> DiagramCanvas<'_> {
|
||||
DiagramCanvas {
|
||||
selection: None,
|
||||
project: app.project(),
|
||||
view_index: None,
|
||||
diagram: app.active_diagram.unwrap(),
|
||||
|
||||
@@ -2,6 +2,7 @@ use super::*;
|
||||
|
||||
fn canvas(project: &Project, diagram: Id, zoom: f32) -> DiagramCanvas<'_> {
|
||||
DiagramCanvas {
|
||||
selection: None,
|
||||
project,
|
||||
view_index: None,
|
||||
diagram,
|
||||
|
||||
@@ -177,6 +177,7 @@ mod tests {
|
||||
|
||||
fn program(app: &App) -> PortLabels<'_> {
|
||||
PortLabels(DiagramCanvas {
|
||||
selection: None,
|
||||
project: app.project(),
|
||||
view_index: None,
|
||||
diagram: app.active_diagram.unwrap(),
|
||||
|
||||
@@ -0,0 +1,416 @@
|
||||
//! Transient exact-target selection; admission and model operations belong to adapters.
|
||||
use crate::diagram_usage::{Surface, Target};
|
||||
use oa_core::Id;
|
||||
|
||||
#[derive(Debug, Clone, Copy, PartialEq, Eq)]
|
||||
pub(crate) struct Scope {
|
||||
/// Document-instance identity, not the persisted project UUID.
|
||||
pub document: Id,
|
||||
pub surface: Surface,
|
||||
}
|
||||
|
||||
#[derive(Debug, Clone, Copy, PartialEq, Eq)]
|
||||
pub(crate) struct Context {
|
||||
pub scope: Scope,
|
||||
pub revision: u64,
|
||||
pub epoch: u64,
|
||||
}
|
||||
|
||||
/// Insertion-ordered unique targets. Membership does not grant edit capability.
|
||||
#[derive(Debug)]
|
||||
pub(crate) struct Selection {
|
||||
scope: Scope,
|
||||
targets: Vec<Target>,
|
||||
primary: Option<Target>,
|
||||
generation: u64,
|
||||
}
|
||||
|
||||
/// Immutable operation input, including the selection lifetime that captured it.
|
||||
#[derive(Debug, Clone, PartialEq, Eq)]
|
||||
pub(crate) struct Snapshot {
|
||||
context: Context,
|
||||
generation: u64,
|
||||
targets: Vec<Target>,
|
||||
primary: Option<Target>,
|
||||
}
|
||||
|
||||
impl Selection {
|
||||
pub fn new(scope: Scope) -> Self {
|
||||
Self {
|
||||
scope,
|
||||
targets: Vec::new(),
|
||||
primary: None,
|
||||
generation: 0,
|
||||
}
|
||||
}
|
||||
|
||||
pub fn scope(&self) -> Scope {
|
||||
self.scope
|
||||
}
|
||||
|
||||
pub fn targets(&self) -> &[Target] {
|
||||
&self.targets
|
||||
}
|
||||
|
||||
pub fn primary(&self) -> Option<&Target> {
|
||||
self.primary.as_ref()
|
||||
}
|
||||
|
||||
pub fn contains(&self, target: &Target) -> bool {
|
||||
self.targets.contains(target)
|
||||
}
|
||||
|
||||
/// Replace with one valid target. Rejected admission preserves the old set.
|
||||
pub fn replace(&mut self, target: Target, valid: impl FnOnce(&Target) -> bool) -> bool {
|
||||
if !admitted(&target, valid) || (self.targets.len() == 1 && self.contains(&target)) {
|
||||
return false;
|
||||
}
|
||||
self.targets = vec![target.clone()];
|
||||
self.primary = Some(target);
|
||||
self.changed();
|
||||
true
|
||||
}
|
||||
|
||||
/// Add a new member as primary. Adding an existing exact target is a no-op.
|
||||
pub fn add(&mut self, target: Target, valid: impl FnOnce(&Target) -> bool) -> bool {
|
||||
if !admitted(&target, valid) || self.contains(&target) {
|
||||
return false;
|
||||
}
|
||||
self.targets.push(target.clone());
|
||||
self.primary = Some(target);
|
||||
self.changed();
|
||||
true
|
||||
}
|
||||
|
||||
/// Removal is allowed even if the target is no longer valid in the model.
|
||||
pub fn remove(&mut self, target: &Target) -> bool {
|
||||
let Some(index) = self.targets.iter().position(|member| member == target) else {
|
||||
return false;
|
||||
};
|
||||
self.targets.remove(index);
|
||||
if self.primary.as_ref() == Some(target) {
|
||||
self.primary = self.targets.last().cloned();
|
||||
}
|
||||
self.changed();
|
||||
true
|
||||
}
|
||||
|
||||
pub fn toggle(&mut self, target: Target, valid: impl FnOnce(&Target) -> bool) -> bool {
|
||||
if self.contains(&target) {
|
||||
self.remove(&target)
|
||||
} else {
|
||||
self.add(target, valid)
|
||||
}
|
||||
}
|
||||
|
||||
/// Inspect another selected member without changing membership or its order.
|
||||
pub fn set_primary(&mut self, target: &Target) -> bool {
|
||||
if !self.contains(target) || self.primary.as_ref() == Some(target) {
|
||||
return false;
|
||||
}
|
||||
self.primary = Some(target.clone());
|
||||
self.changed();
|
||||
true
|
||||
}
|
||||
|
||||
pub fn clear(&mut self) -> bool {
|
||||
if self.targets.is_empty() {
|
||||
return false;
|
||||
}
|
||||
self.targets.clear();
|
||||
self.primary = None;
|
||||
self.changed();
|
||||
true
|
||||
}
|
||||
|
||||
/// Change owner or prune exact targets against the current rendered surface.
|
||||
/// The predicate checks identity/visibility, not eligibility for one action.
|
||||
/// Revision-only changes may retain survivors; no semantic retargeting occurs.
|
||||
pub fn reconcile(&mut self, scope: Scope, valid: impl FnMut(&Target) -> bool) -> bool {
|
||||
if self.scope != scope {
|
||||
self.scope = scope;
|
||||
self.targets.clear();
|
||||
self.primary = None;
|
||||
self.changed();
|
||||
return true;
|
||||
}
|
||||
let previous_len = self.targets.len();
|
||||
self.targets.retain(valid);
|
||||
if self.targets.len() == previous_len {
|
||||
return false;
|
||||
}
|
||||
if !self
|
||||
.primary
|
||||
.as_ref()
|
||||
.is_some_and(|target| self.contains(target))
|
||||
{
|
||||
self.primary = self.targets.last().cloned();
|
||||
}
|
||||
self.changed();
|
||||
true
|
||||
}
|
||||
|
||||
/// Capture input, including an empty selection before a first pointer press.
|
||||
/// Does not grant permission to mutate; adapters still guard drafts, modals,
|
||||
/// capability and geometry. A mismatched owner cannot capture a snapshot.
|
||||
pub fn snapshot(&self, context: Context) -> Option<Snapshot> {
|
||||
if context.scope != self.scope {
|
||||
return None;
|
||||
}
|
||||
Some(Snapshot {
|
||||
context,
|
||||
generation: self.generation,
|
||||
targets: self.targets.clone(),
|
||||
primary: self.primary.clone(),
|
||||
})
|
||||
}
|
||||
|
||||
/// Check before any operation side effect, using the caller's live context.
|
||||
/// Generation rejects remove/re-add and primary-change/restore ABA cycles.
|
||||
pub fn matches(&self, snapshot: &Snapshot, current: Context) -> bool {
|
||||
snapshot.context == current
|
||||
&& current.scope == self.scope
|
||||
&& snapshot.generation == self.generation
|
||||
&& snapshot.targets == self.targets
|
||||
&& self.primary == snapshot.primary
|
||||
}
|
||||
|
||||
fn changed(&mut self) {
|
||||
self.generation = self
|
||||
.generation
|
||||
.checked_add(1)
|
||||
.expect("selection generation exhausted");
|
||||
}
|
||||
}
|
||||
|
||||
impl Snapshot {
|
||||
pub fn context(&self) -> Context {
|
||||
self.context
|
||||
}
|
||||
|
||||
pub fn targets(&self) -> &[Target] {
|
||||
&self.targets
|
||||
}
|
||||
|
||||
pub fn primary(&self) -> Option<&Target> {
|
||||
self.primary.as_ref()
|
||||
}
|
||||
}
|
||||
|
||||
fn admitted(target: &Target, valid: impl FnOnce(&Target) -> bool) -> bool {
|
||||
!matches!(target, Target::Whole) && valid(target)
|
||||
}
|
||||
|
||||
#[cfg(test)]
|
||||
mod tests {
|
||||
use super::*;
|
||||
use oa_core::OccurrenceEndpoint;
|
||||
|
||||
fn id(value: u128) -> Id {
|
||||
Id::from_u128(value)
|
||||
}
|
||||
|
||||
fn scope() -> Scope {
|
||||
Scope {
|
||||
document: id(1),
|
||||
surface: Surface::Saved(id(2)),
|
||||
}
|
||||
}
|
||||
|
||||
fn context() -> Context {
|
||||
Context {
|
||||
scope: scope(),
|
||||
revision: 7,
|
||||
epoch: 11,
|
||||
}
|
||||
}
|
||||
|
||||
fn node(value: u128) -> Target {
|
||||
Target::Placement(id(value))
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn exact_duplicates_are_noops_but_distinct_visual_identities_survive() {
|
||||
let mut selection = Selection::new(scope());
|
||||
let port_a = Target::Port {
|
||||
port: id(30),
|
||||
placement: id(3),
|
||||
};
|
||||
let port_b = Target::Port {
|
||||
port: id(30),
|
||||
placement: id(4),
|
||||
};
|
||||
assert!(selection.add(node(3), |_| true));
|
||||
assert!(selection.add(port_a.clone(), |_| true));
|
||||
let captured = selection.snapshot(context()).unwrap();
|
||||
assert!(!selection.add(node(3), |_| true));
|
||||
assert!(!selection.add(port_a.clone(), |_| true));
|
||||
assert!(selection.matches(&captured, context()));
|
||||
assert!(selection.add(port_b.clone(), |_| true));
|
||||
assert_eq!(selection.targets(), &[node(3), port_a, port_b.clone()]);
|
||||
assert_eq!(selection.primary(), Some(&port_b));
|
||||
assert_eq!(
|
||||
captured.targets(),
|
||||
&[
|
||||
node(3),
|
||||
Target::Port {
|
||||
port: id(30),
|
||||
placement: id(3)
|
||||
}
|
||||
]
|
||||
);
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn primary_removal_uses_latest_survivor_without_reordering() {
|
||||
let mut selection = Selection::new(scope());
|
||||
for value in [3, 4, 5] {
|
||||
selection.add(node(value), |_| true);
|
||||
}
|
||||
assert!(selection.set_primary(&node(3)));
|
||||
assert_eq!(selection.targets(), &[node(3), node(4), node(5)]);
|
||||
assert!(!selection.set_primary(&node(99)));
|
||||
assert!(selection.remove(&node(4)));
|
||||
assert_eq!(selection.primary(), Some(&node(3)));
|
||||
assert!(selection.remove(&node(3)));
|
||||
assert_eq!(selection.primary(), Some(&node(5)));
|
||||
// A now-invalid member remains removable; validity applies to additions.
|
||||
assert!(selection.toggle(node(5), |_| false));
|
||||
assert!(selection.targets().is_empty());
|
||||
assert_eq!(selection.primary(), None);
|
||||
let empty = selection.snapshot(context()).unwrap();
|
||||
assert!(empty.targets().is_empty());
|
||||
assert_eq!(empty.primary(), None);
|
||||
assert!(selection.matches(&empty, context()));
|
||||
selection.add(node(5), |_| true);
|
||||
assert!(!selection.matches(&empty, context()));
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn whole_and_rejected_targets_cannot_replace_an_existing_selection() {
|
||||
let mut selection = Selection::new(scope());
|
||||
selection.add(node(3), |_| true);
|
||||
let captured = selection.snapshot(context()).unwrap();
|
||||
assert!(!selection.replace(Target::Whole, |_| true));
|
||||
assert!(!selection.add(Target::Whole, |_| true));
|
||||
assert!(!selection.toggle(Target::Whole, |_| true));
|
||||
assert!(!selection.replace(node(4), |_| false));
|
||||
assert!(!selection.toggle(node(4), |_| false));
|
||||
assert!(selection.matches(&captured, context()));
|
||||
assert!(selection.replace(node(4), |_| true));
|
||||
assert_eq!(selection.targets(), &[node(4)]);
|
||||
assert_eq!(selection.primary(), Some(&node(4)));
|
||||
assert!(!selection.replace(node(4), |_| true));
|
||||
assert!(selection.clear());
|
||||
assert!(!selection.clear());
|
||||
assert_eq!(selection.primary(), None);
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn reused_process_occurrences_reconcile_by_full_path_never_definition() {
|
||||
let owner = Scope {
|
||||
surface: Surface::Process(id(2)),
|
||||
..scope()
|
||||
};
|
||||
let mut selection = Selection::new(owner);
|
||||
let occurrence = |path| {
|
||||
Target::ProcessOccurrence(OccurrenceEndpoint {
|
||||
references: vec![id(path), id(50)],
|
||||
occurrence: id(60),
|
||||
})
|
||||
};
|
||||
let first = occurrence(10);
|
||||
let second = occurrence(20);
|
||||
selection.add(first.clone(), |_| true);
|
||||
selection.add(second.clone(), |_| true);
|
||||
assert_eq!(selection.targets(), &[first.clone(), second.clone()]);
|
||||
assert!(selection.reconcile(owner, |target| target == &first));
|
||||
assert_eq!(selection.targets(), std::slice::from_ref(&first));
|
||||
assert_eq!(selection.primary(), Some(&first));
|
||||
// A new call path with the same definition is not a replacement identity.
|
||||
let replacement = occurrence(70);
|
||||
assert!(selection.reconcile(owner, |target| target == &replacement));
|
||||
assert!(selection.targets().is_empty());
|
||||
assert_eq!(selection.primary(), None);
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn revision_reconciliation_retains_exact_survivors_but_invalidates_operations() {
|
||||
let mut selection = Selection::new(scope());
|
||||
selection.add(node(3), |_| true);
|
||||
selection.add(node(4), |_| true);
|
||||
selection.set_primary(&node(3));
|
||||
let captured = selection.snapshot(context()).unwrap();
|
||||
let next = Context {
|
||||
revision: 8,
|
||||
..context()
|
||||
};
|
||||
assert!(!selection.reconcile(scope(), |_| true));
|
||||
assert_eq!(selection.targets(), &[node(3), node(4)]);
|
||||
assert_eq!(selection.primary(), Some(&node(3)));
|
||||
assert!(!selection.matches(&captured, next));
|
||||
let accepted = selection.snapshot(next).unwrap();
|
||||
assert!(selection.matches(&accepted, next));
|
||||
assert!(selection.reconcile(scope(), |target| target != &node(4)));
|
||||
assert_eq!(selection.primary(), Some(&node(3)));
|
||||
assert!(!selection.matches(&accepted, next));
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn changing_document_or_surface_clears_even_identical_target_ids() {
|
||||
for changed in [
|
||||
Scope {
|
||||
document: id(99),
|
||||
..scope()
|
||||
},
|
||||
Scope {
|
||||
surface: Surface::Saved(id(99)),
|
||||
..scope()
|
||||
},
|
||||
Scope {
|
||||
surface: Surface::Scenario(id(2)),
|
||||
..scope()
|
||||
},
|
||||
] {
|
||||
let mut selection = Selection::new(scope());
|
||||
selection.add(node(3), |_| true);
|
||||
let captured = selection.snapshot(context()).unwrap();
|
||||
assert!(selection.reconcile(changed, |_| true));
|
||||
assert_eq!(selection.scope(), changed);
|
||||
assert!(selection.targets().is_empty());
|
||||
assert_eq!(selection.primary(), None);
|
||||
assert!(!selection.matches(&captured, context()));
|
||||
assert!(selection.snapshot(context()).is_none());
|
||||
selection.reconcile(scope(), |_| true);
|
||||
selection.add(node(3), |_| true);
|
||||
assert!(!selection.matches(&captured, context()));
|
||||
}
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn stale_epoch_selection_and_primary_cycles_do_not_regain_authority() {
|
||||
let mut selection = Selection::new(scope());
|
||||
selection.add(node(3), |_| true);
|
||||
selection.add(node(4), |_| true);
|
||||
let captured = selection.snapshot(context()).unwrap();
|
||||
assert_eq!(captured.context(), context());
|
||||
assert_eq!(captured.primary(), Some(&node(4)));
|
||||
assert!(!selection.matches(
|
||||
&captured,
|
||||
Context {
|
||||
epoch: 12,
|
||||
..context()
|
||||
}
|
||||
));
|
||||
selection.set_primary(&node(3));
|
||||
selection.set_primary(&node(4));
|
||||
assert!(!selection.matches(&captured, context()));
|
||||
let restored_primary = selection.snapshot(context()).unwrap();
|
||||
selection.remove(&node(4));
|
||||
selection.add(node(4), |_| true);
|
||||
assert_eq!(selection.targets(), captured.targets());
|
||||
assert_eq!(selection.primary(), captured.primary());
|
||||
assert!(!selection.matches(&restored_primary, context()));
|
||||
assert!(selection.matches(&selection.snapshot(context()).unwrap(), context()));
|
||||
}
|
||||
}
|
||||
@@ -10,6 +10,7 @@ mod data_values;
|
||||
mod data_view;
|
||||
mod diagnostic_input;
|
||||
mod diagram;
|
||||
mod diagram_selection;
|
||||
mod diagram_usage;
|
||||
mod document;
|
||||
mod explorer;
|
||||
|
||||
@@ -193,6 +193,100 @@ pub fn popup(app: &App) -> Option<Menu<Message>> {
|
||||
return Some(menu);
|
||||
}
|
||||
let mut entries = vec![Entry::title(crate::views::short(p.named(id), 38))];
|
||||
if app.page == Page::Diagram
|
||||
&& request.canvas.is_some()
|
||||
&& let Some(context) = app.multiselect_context()
|
||||
{
|
||||
use crate::app::multiselect::{Choice, Event as SelectionEvent};
|
||||
use crate::diagram_usage::Target;
|
||||
let view = app
|
||||
.active_diagram
|
||||
.map(|d| projection::project_view_with_index(p, d, app.document.view_index()));
|
||||
let target = request
|
||||
.placement
|
||||
.map(Target::Placement)
|
||||
.or_else(|| {
|
||||
view.as_ref()?
|
||||
.ports
|
||||
.iter()
|
||||
.find(|port| port.element == id)
|
||||
.map(|port| Target::Port {
|
||||
port: port.element,
|
||||
placement: port.owner,
|
||||
})
|
||||
})
|
||||
.or_else(|| {
|
||||
view.as_ref()?
|
||||
.edges
|
||||
.iter()
|
||||
.any(|edge| edge.id == id)
|
||||
.then_some(Target::Edge(id))
|
||||
});
|
||||
if let Some(target) = target {
|
||||
let selected = app
|
||||
.diagram_selection
|
||||
.as_ref()
|
||||
.is_some_and(|s| s.contains(&target));
|
||||
entries.push(item(
|
||||
if selected {
|
||||
"Remove from selection"
|
||||
} else {
|
||||
"Add to selection"
|
||||
},
|
||||
Message::DiagramSelection(SelectionEvent::Choose(
|
||||
context,
|
||||
target.clone(),
|
||||
if selected {
|
||||
Choice::Remove
|
||||
} else {
|
||||
Choice::Add
|
||||
},
|
||||
)),
|
||||
true,
|
||||
));
|
||||
if let Some(snapshot) = app.multiselect_snapshot().filter(|s| s.targets().len() > 1)
|
||||
&& selected
|
||||
{
|
||||
entries.push(Entry::title(format!(
|
||||
"{} selected",
|
||||
snapshot.targets().len()
|
||||
)));
|
||||
entries.push(item(
|
||||
"Inspect this element",
|
||||
Message::DiagramSelection(SelectionEvent::Choose(
|
||||
context,
|
||||
target.clone(),
|
||||
Choice::Inspect,
|
||||
)),
|
||||
true,
|
||||
));
|
||||
entries.push(item(
|
||||
"Select only this element",
|
||||
Message::DiagramSelection(SelectionEvent::Choose(
|
||||
context,
|
||||
target,
|
||||
Choice::Replace,
|
||||
)),
|
||||
true,
|
||||
));
|
||||
entries.push(item(
|
||||
"Hide selected placements",
|
||||
Message::DiagramSelection(SelectionEvent::Hide(snapshot.clone())),
|
||||
crate::app::multiselect::placements(&snapshot).is_some(),
|
||||
));
|
||||
entries.push(Entry::disabled(
|
||||
"Delete selected from model (not yet available)",
|
||||
));
|
||||
return Some(Menu {
|
||||
token: opened.token,
|
||||
anchor: request.anchor,
|
||||
entries,
|
||||
on_close: Message::Menu(Event::Close),
|
||||
});
|
||||
}
|
||||
entries.push(Entry::separator());
|
||||
}
|
||||
}
|
||||
if !clean {
|
||||
entries.push(Entry::title("Apply or revert pending edits first"));
|
||||
}
|
||||
|
||||
@@ -429,7 +429,32 @@ fn diagram(app: &App) -> View<'_, Message> {
|
||||
chooser = chooser.push(action("View properties", Message::Select(id)));
|
||||
controls = controls.push(action("Auto-layout", Message::Command(Command::Layout(id))));
|
||||
}
|
||||
let toolbar = column![chooser, controls].spacing(6);
|
||||
let mut toolbar = column![chooser, controls].spacing(6);
|
||||
if let Some(snapshot) = app.multiselect_snapshot().filter(|s| s.targets().len() > 1) {
|
||||
let mut group_controls = row![label(format!("{} selected", snapshot.targets().len()))]
|
||||
.spacing(7)
|
||||
.align_y(iced::Center);
|
||||
if crate::app::multiselect::placements(&snapshot).is_some() {
|
||||
group_controls = group_controls.push(action(
|
||||
"Hide selected",
|
||||
Message::DiagramSelection(crate::app::multiselect::Event::Hide(snapshot.clone())),
|
||||
));
|
||||
}
|
||||
group_controls = group_controls.push(action(
|
||||
"Clear selection",
|
||||
Message::DiagramSelection(crate::app::multiselect::Event::Clear(snapshot.context())),
|
||||
));
|
||||
toolbar = toolbar.push(
|
||||
column![
|
||||
group_controls,
|
||||
label(format!(
|
||||
"Properties edit only {}",
|
||||
short(app.project().named(app.selected), 36)
|
||||
))
|
||||
]
|
||||
.spacing(3),
|
||||
);
|
||||
}
|
||||
let projection = app
|
||||
.active_diagram
|
||||
.and_then(|id| app.project().diagrams.get(&id))
|
||||
@@ -455,6 +480,7 @@ fn diagram(app: &App) -> View<'_, Message> {
|
||||
.align_y(iced::Center);
|
||||
let canvas: View<'_, Message> = if let Some(id) = app.active_diagram {
|
||||
let program = DiagramCanvas {
|
||||
selection: app.diagram_selection.as_ref(),
|
||||
allocation: Some(app.allocation_capability()),
|
||||
project: app.project(),
|
||||
view_index: Some(app.document.view_index()),
|
||||
|
||||
Reference in New Issue
Block a user