Fix scoped semantic drafts and dependent review controls
This commit is contained in:
@@ -42,7 +42,8 @@ Base: `d130013`. Dedicated build target:
|
||||
|
||||
## Verification
|
||||
|
||||
Verified against core `6bb2583`, using only the dedicated desktop target:
|
||||
Verified after the independent scalar review fixes on SEM `6ad3cb`, using only the
|
||||
dedicated desktop target (core behavior remains based on `6bb2583`):
|
||||
|
||||
```powershell
|
||||
$env:CARGO_TARGET_DIR='D:/CodexBuilds/Capella2-semantic-desktop-target'
|
||||
@@ -51,7 +52,8 @@ cargo clippy --locked -p oa-desktop --all-targets -- -D warnings
|
||||
cargo build --locked -p oa-desktop
|
||||
```
|
||||
|
||||
All **272 desktop tests passed**, including **11 new semantic review tests**.
|
||||
All **277 desktop tests passed**, including **11 original semantic review tests**
|
||||
and **5 scalar review regression tests**.
|
||||
Strict Clippy and the desktop build passed. The existing migration test's header
|
||||
assertion now follows `SCHEMA_VERSION` instead of expecting schema 4.
|
||||
|
||||
@@ -64,6 +66,25 @@ relationship role/bound candidates with retained identity/endpoints; and exact
|
||||
inherited-annotation cleanup approval, cleared when decisions change. Unselected
|
||||
invalid scalar drafts remain retained without contaminating another candidate.
|
||||
|
||||
The independent scalar review found three gaps, now corrected:
|
||||
|
||||
- Structural scalar edits replace only their authorized subtree. Clearing an
|
||||
invalid selected bound, changing a variant, and adding/removing/reordering a
|
||||
literal retain untouched raw inputs and editor buffers, including invalid
|
||||
inputs belonging to another decision.
|
||||
- Dependent default, reference and port controls read a noncommitting context
|
||||
composed by the same scalar Keep/Take/Candidate assembler as the request. Raw
|
||||
candidates remain separate. Incomplete inputs use their stored shape only for
|
||||
those controls; request creation and Apply still reject invalid selected input.
|
||||
The Boolean-source/Integer-target default reproduction now offers Boolean
|
||||
literals in both directions. Tests also cover Candidate type, Keep reversion,
|
||||
storage-dependent default controls and mechanism-dependent reference choices.
|
||||
- Keyed fact headings display live names with stable aliases or deleted UUIDs.
|
||||
Message annotation headings include the complete qualified path and field.
|
||||
|
||||
The regression tests exercise App events, the actual default-form helpers and
|
||||
button availability, exact source retention before Apply, and one-step undo.
|
||||
|
||||
Built executable:
|
||||
`D:/CodexBuilds/Capella2-semantic-desktop-target/debug/arcadia-studio.exe`.
|
||||
The build target is idle. No native application was launched by this task.
|
||||
|
||||
Reference in New Issue
Block a user