Freeze reviewed Windows prerelease source handoff
This commit is contained in:
+26
-6
@@ -1,14 +1,34 @@
|
||||
# Verified branch checkpoint — 2026-09-23 UTC
|
||||
# Integrated prerelease source checkpoint — 2026-09-24 UTC
|
||||
|
||||
This describes Codex-956atf's contribution, not a combined release.
|
||||
This branch assembles peer contributions for the Windows prerelease in issue37.
|
||||
[PROJECT_GOAL.md](../PROJECT_GOAL.md) remains authoritative. The complete OA/SA
|
||||
application is unfinished; published previews and finite prototypes are intermediate.
|
||||
|
||||
**Linux/WSL builds and checks remain deferred until the user explicitly reports
|
||||
networking resolved.** No guest setup, diagnosis, restart or cache transfer is
|
||||
active. The VPN remains untouched.
|
||||
**The current prerelease is Windows-only. Linux/WSL builds and checks remain
|
||||
excluded by the user's explicit request, including after networking recovers.**
|
||||
|
||||
## Current integrated candidate and evidence
|
||||
## Assembled source and acceptance boundary
|
||||
|
||||
Combined code **a6b9f6029aad618a84d136c5293353688d36809f** adds the reviewed
|
||||
Connection/Route early-admission correction to the assembled Scenario/Text,
|
||||
ordinary/State/Process/Allocation selection, direct drawing, Traceability and
|
||||
picker changes. The [source handoff](prerelease-integrated-source-20260924.md)
|
||||
identifies the incorporated commits, exact new test paths and required gates.
|
||||
The nine event regressions and existing completed-Text-Apply cases are retained.
|
||||
Direct formatting and whitespace checks pass; this source checkpoint does not
|
||||
claim combined Cargo, native, packaged or release acceptance. The independent
|
||||
[event-fix review](reviews/prerelease37-event-admission-20260924.md) found no
|
||||
further material source defect in its stated scope.
|
||||
|
||||
Live build, final-source and publication results belong in
|
||||
[issue37](http://217.177.34.108:3000/sorokin.oleg.edu/ARCADIA-Studio/issues/37).
|
||||
Human workflows are described in [the preview checklist](../docs/preview-human-checks.md).
|
||||
Private mixed-parser source is excluded from this application candidate.
|
||||
|
||||
## Contribution-specific verification
|
||||
|
||||
The following records retain their original source and runtime scope; they are
|
||||
not relabeled as acceptance of the combined source above.
|
||||
|
||||
Branch `codex/behavior-authoring-20260910`, published as `codex/release1-956atf`.
|
||||
Integrated code checkpoint **4ffff0d9d94bd1875e6b316b84ac11e5c5c9657c** combines
|
||||
|
||||
@@ -43,6 +43,43 @@ candidate: Allocation group `57aec979f640ba1b8aa6fcbb7d9e26b29cf51596`, drawing
|
||||
ancestry and is linked rather than merged for source. Private mixed-parser work,
|
||||
unfinished Scenario group reordering and aggregate removal are excluded.
|
||||
|
||||
## Captured event admission successor
|
||||
|
||||
Combined code `a6b9f6029aad618a84d136c5293353688d36809f` cherry-picks the narrow
|
||||
peer code commits `44217307`, `72b1bb7`, and `6f247af795b7bec1818c588b2dabf203f8f68d8a`.
|
||||
The peer's exact source and initial evidence are published at
|
||||
[`c655c5e`](http://217.177.34.108:3000/sorokin.oleg.edu/ARCADIA-Studio/src/commit/c655c5eeaaa32c1c21074a7543844ae99a1d6fd5/harness/prerelease37-connection-admission-20260924.md).
|
||||
Only `app.rs`, group-test registration and two new test modules change in this
|
||||
code integration. Historical evidence archives are linked rather than merged.
|
||||
|
||||
Captured Connection Endpoint/Restart now require the current route context and
|
||||
a matching live drawing session before shared Allocation retirement. Captured
|
||||
Route Commit/CommitAttachment require the current context and selected edge;
|
||||
selection may change without advancing the context. Stale packets preserve
|
||||
newer Arrange/drag state and feedback. Current route edits require no invented
|
||||
drawing session, and unscoped commands retain their existing behavior.
|
||||
|
||||
The three Connection and six Route regressions are in:
|
||||
|
||||
- `crates/oa-desktop/src/app/allocation_drag_tests/group/connection_lifetime.rs`
|
||||
- `crates/oa-desktop/src/app/allocation_drag_tests/group/route_lifetime.rs`
|
||||
|
||||
The real Text Apply cases added at `542b10ac` remain in:
|
||||
|
||||
- `crates/oa-desktop/src/app/process_multiselect/tests.rs`:
|
||||
`completed_text_apply_rejects_captured_process_reorder_without_retiring_current_state`
|
||||
- `crates/oa-desktop/src/app/allocation_drag_tests/group.rs`:
|
||||
`completed_text_apply_rejects_old_allocation_packets_without_retiring_a_new_drag`
|
||||
- Ordinary/State coverage is in `app/multiselect_tests.rs`; earlier navigation
|
||||
tests in `navigation_union.rs` are a separate scope.
|
||||
|
||||
Parent read the complete patch and tests, integrated without conflicts, and
|
||||
passed direct rustfmt and whitespace checks. A fresh independent
|
||||
[source review](reviews/prerelease37-event-admission-20260924.md) found no
|
||||
actionable defect in the stated boundary. These do not substitute for the final
|
||||
combined execution. The vendor patch-description correction is incorporated at
|
||||
`17eaa03fd69741dff746f21d150dc04c341411b3`.
|
||||
|
||||
## Combined gates and package handoff
|
||||
|
||||
Codex-ytr83r owns the exact-candidate Windows build/package on its separate
|
||||
|
||||
@@ -0,0 +1,15 @@
|
||||
# Prerelease 37 event guard integration review
|
||||
|
||||
2026-09-24. Independent source review; no confirmed actionable finding in the bounded change.
|
||||
|
||||
Reviewed exact delta `340a5c56b0783e22d7336a07ce96ddb7c2b79b0d..6f247af795b7bec1818c588b2dabf203f8f68d8a` (code commits `44217307`, `72b1bb7`, `6f247af`) against combined candidate `17eaa03fd69741dff746f21d150dc04c341411b3`. This is compatibility review before the parent's integration, not verification of an already integrated commit. Read AGENTS.md, App update/connection/route handlers, Allocation retirement adapter, both new regression modules, group fixtures/history evaluator, and existing combined Allocation connection regressions. Formed independent judgment before reading peer reviews at `c655c5eeaaa32c1c21074a7543844ae99a1d6fd5`.
|
||||
|
||||
The 21-line early guards precede pending-reveal reconciliation, allocation_before, inner dispatch and post-dispatch reconciliation. The preceding preview/selection-boundary computations are reads. Connection Endpoint/Restart require both current route Context and extant matching session; Choose/Begin retain their intentional new-owner behavior. Current Restart remains admitted and creates a fresh Choose session. Route Commit/CommitAttachment require current Context and payload edge equal to current selected edge, without incorrectly demanding a Connection session or armed attachment.
|
||||
|
||||
The combined candidate does not change allocation_before from the reviewed base; its default retirement of Connection/Route makes early rejection necessary. The combined Allocation drawing adapter retains captured context through first endpoint selection, including mixed-layer Traceability, and changes model revision only after completed pair execution. Nothing in the new guard rejects those valid paths. Combined saved-Scenario route_context returns None, so old captured architecture events are rejected consistently.
|
||||
|
||||
The connection regressions independently isolate missing session, live route mismatch with session equal to captured context, and session mismatch with live route equal to captured context. Both Endpoint and Restart traverse these cases. The field matrix checks document, diagram, revision and epoch. Current Choose/Begin retire a live Arrange preview, then current Restart and an endpoint pair commit with exact history.
|
||||
|
||||
The route regressions independently isolate context mismatch while edge selection remains valid and same-context changed selection for both commit variants. Both armed Arrange and active preview survive rejection and then complete. Literal expected placement and pin coordinates protect against merely retaining an unusable token; both moved route endpoints translate the pin once to (1100, 400). Positive commits independently specify bend/source-attachment changes and preserve other model fields. Whole-Project/source reopen and exact one-step Undo/Redo checks are meaningful oracles rather than implementation mirrors.
|
||||
|
||||
Coverage limits and remaining checks: this reviewer ran no compiler, tests, formatter, GUI, fetch or Gitea mutation. The parent must run the new regression modules and existing connection_edit Allocation/mixed-layer tests against the actual cherry-picked Windows candidate, plus required Windows build/package and native smoke gates. New retained-owner cases exercise Arrange; they do not independently exercise every reassignment drag mode, every connection tool, or broader same-edge selection-away-and-back lifetime semantics. Existing combined tests cover positive OA/SA Allocation pairs and mixed-layer views, but their passing execution after integration is not established by source review. Linux is excluded from this acceptance claim.
|
||||
Reference in New Issue
Block a user