diff --git a/AGENTS.md b/AGENTS.md index 767be18f..e76647f4 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -4,12 +4,12 @@ - Follow `PROJECT_GOAL.md` and the user's current instructions. Work autonomously within scope. Resolve discoverable questions yourself; record, test, and revise reversible assumptions. Ask only when a consequential decision needs information or authorization not already available. Continue independent useful work while blocked elsewhere. - Map unfamiliar domains through primary sources, comparable systems, and real user workflows. Identify underlying needs, valuable concepts, and avoidable friction; evaluate improvements rather than merely reproducing features. Synthesize findings into decisions or experiments, and stop research when another action offers greater value. -- Make specifications precise enough for compatible independent implementations: definitions, relationships, invariants, valid/invalid examples, and lifecycle or transformation rules where relevant. Trace important requirements and decisions to implementation and verification. Resolve specification ambiguity at its source when implementation exposes it. +- Make specifications precise enough for compatible independent implementations: definitions, relationships, invariants, valid / invalid examples, and lifecycle or transformation rules where relevant. Trace important requirements and decisions to implementation and verification. Resolve specification ambiguity at its source when implementation exposes it. - For consequential uncertain choices, compare materially different candidates against explicit user-derived criteria. Ask independent critics to challenge assumptions and attempt to falsify proposals; refine or replace candidates as evidence warrants. Record the choice, evidence, tradeoffs, rejected approaches, and reasons to revisit it. Use proportionate effort for reversible local choices. - Plan milestones that resolve uncertainty or deliver useful capability, with explicit dependencies. Test foundational assumptions before substantial downstream work. At checkpoints, assess progress toward the actual objective and replan when evidence invalidates the strategy or progress stalls. - Define observable success and suitable evaluators before repeated improvement: invariants, examples, round trips, transformations, performance checks, realistic user tasks, or explicit review rubrics. Ensure the evaluator measures the intended outcome. For experiments, record the question, expectations, method, result, and implications; isolate exploratory prototypes from production architecture. -- Build and run meaningful changes, exercise actual behavior, and inspect useful logs. Investigate crashes, serious warnings, corrupted state, and interaction defects. For GUI work, use Computer Use or equivalent tools to inspect realistic workflows, cognitive load, editing/selection, navigation, feedback, recovery, loading/empty/failure states, accessibility, layout, focus/disabled states, and responsiveness. -- Match independent reviews to the artifact and risks. For languages or formats, include ambiguity, round trips, human/AI editability, and version-control behavior where relevant. Verify findings, fix the appropriate conceptual, specification, architectural, implementation, or interaction layer, and recheck affected dependents. Reuse valid evidence; repeat checks for concrete risks, changes, findings, or required gates. Compilation, screenshots, and worker reports alone do not establish correctness or usability. +- Build and run meaningful changes, exercise actual behavior, and inspect useful logs. Investigate crashes, serious warnings, corrupted state, and interaction defects. For GUI work, use Computer Use or equivalent tools to inspect realistic workflows, cognitive load, editing / selection, navigation, feedback, recovery, loading / empty / failure states, accessibility, layout, focus / disabled states, and responsiveness. +- Match independent reviews to the artifact and risks. For languages or formats, include ambiguity, round trips, human / AI editability, and version-control behavior where relevant. Verify findings, fix the appropriate conceptual, specification, architectural, implementation, or interaction layer, and recheck affected dependents. Reuse valid evidence; repeat checks for concrete risks, changes, findings, or required gates. Compilation, screenshots, and worker reports alone do not establish correctness or usability. - Favor the simplest maintainable design satisfying known requirements and justified extensibility. Avoid speculative abstraction, unrelated refactoring, and repeating approaches already invalidated by evidence. ## User input @@ -24,10 +24,10 @@ Keep one authoritative home for each kind of information. Use links and brief sc | Information | Authoritative home | | --- | --- | -| Live plans, priorities, dependencies, ownership, status, blockers, and handoffs | Gitea issues/milestones; linked PRs hold change review and validation. | -| Specifications, architecture, interfaces, and build/run documentation | Established version-controlled project documents. | +| Live plans, priorities, dependencies, ownership, status, blockers, and handoffs | Gitea issues / milestones; linked PRs hold change review and validation. | +| Specifications, architecture, interfaces, and build / run documentation | Established version-controlled project documents. | | Durable decisions and reusable evidence | `harness/DECISIONS.md` and relevant topic notes, or existing equivalents. | -| Navigation and integrated-state checkpoint | `harness/STATE.md`: links, verified code commit/release, capabilities, and material limitations. No live task ledger. | +| Navigation and integrated-state checkpoint | `harness/STATE.md`: links, verified code commit / release, capabilities, and material limitations. No live task ledger. | | Shared entrypoint | Gitea Wiki: overview and links, without duplicating versioned documentation. | | Published deliverables | Gitea releases, tied to source commits and verification. | @@ -38,9 +38,9 @@ Use Gitea for live coordination and the relevant code version for implementation All independent agents coordinating through Gitea run on completely separate machines, each with its own clone, filesystem, tools, processes, and runtime. Gitea and pushed Git history are the shared communication and delivery channels. Local files (including `harness`), unpushed commits, worktrees, test results, and localhost services are not accessible to peers. Matching branch names or paths do not imply synchronized contents. 1. On starting or resuming, including after compaction, inspect the working branch, local changes, applicable instructions, relevant shared records, and existing implementation. Recover context from authoritative records. Check for newer shared instructions on the actual remote default branch without overwriting local work. Read what is relevant; avoid repeated full-history scans and constant polling. -2. Search before creating tasks. Claim a meaningful outcome in its Gitea issue with a stable session identity, scope, remote repository/branch, and acceptance criteria. Keep small steps within that task. Recheck after claiming; comments are not atomic locks. Respect existing ownership and resolve overlapping claims before overlapping work. -3. Independent sessions are peers. Each owns its contribution and delegated work on its own machine. Record one integration/release owner when a milestone needs shared coordination. Use distinct remote work branches, partition files/interfaces, and coordinate changes to shared specifications and documents. Worktrees provide local isolation only; they do not share work between machines. -4. At meaningful checkpoints or handoffs, record changed results, commit/PR links, verification commands and environment, blockers, and next actions. Identify the tested code version and label uncommitted or unpublished work as local-only. Before asking peers to consume results, push the required code and versioned documentation, including relevant `harness` updates; publish other required artifacts in Gitea and link them. Use repository-relative paths with commit references, reproducible commands, and necessary environment details; local paths and localhost URLs alone are not handoffs. Do not assume another agent is running or has read a message; silence alone does not establish abandonment. Record evidence and preserve existing work when reassigning a task. +2. Search before creating tasks. Claim a meaningful outcome in its Gitea issue with a stable session identity, scope, remote repository / branch, and acceptance criteria. Keep small steps within that task. Recheck after claiming; comments are not atomic locks. Respect existing ownership and resolve overlapping claims before overlapping work. +3. Independent sessions are peers. Each owns its contribution and delegated work on its own machine. Record one integration / release owner when a milestone needs shared coordination. Use distinct remote work branches, partition files / interfaces, and coordinate changes to shared specifications and documents. Worktrees provide local isolation only; they do not share work between machines. +4. At meaningful checkpoints or handoffs, record changed results, commit / PR links, verification commands and environment, blockers, and next actions. Identify the tested code version and label uncommitted or unpublished work as local-only. Before asking peers to consume results, push the required code and versioned documentation, including relevant `harness` updates; publish other required artifacts in Gitea and link them. Use repository-relative paths with commit references, reproducible commands, and necessary environment details; local paths and localhost URLs alone are not handoffs. Do not assume another agent is running or has read a message; silence alone does not establish abandonment. Record evidence and preserve existing work when reassigning a task. 5. Follow project review and merge conventions. Fetch the relevant remote branches and inspect the identified commits before reviewing or integrating another machine's work. Resolve conflicts while preserving others' edits, and verify the combined result locally; report material environment differences. Local instruction-file edits reach peers only after publication and retrieval. Do not overwrite others' work or force-push shared history to resolve coordination problems. 6. Close work when its acceptance criteria are met and the result is integrated or delivered as appropriate. Mark duplicates and superseded tasks explicitly with replacement links. Then choose further useful unowned work while the requested objective remains incomplete. @@ -64,10 +64,10 @@ Preserve concise records of decisions and rationale, useful experiments, failed Consolidate duplicates, repair stale guidance, and remove obsolete temporary files alongside useful project work. Before removing material, check references, active ownership, and ongoing use; preserve unique knowledge and update affected links. Prefer closing, superseding, or archiving history over deletion. User input is excluded from autonomous cleanup. -If legacy local task ledgers or plans duplicate Gitea, migrate their live content once into existing or appropriately scoped issues, preserve useful decisions/evidence, and mark the old records superseded. Record the migration so later sessions do not repeat it. Do not create empty documents or maintain records for ceremony. +If legacy local task ledgers or plans duplicate Gitea, migrate their live content once into existing or appropriately scoped issues, preserve useful decisions / evidence, and mark the old records superseded. Record the migration so later sessions do not repeat it. Do not create empty documents or maintain records for ceremony. ## Delivery -Publish versioned Gitea releases at meaningful working milestones; mark unfinished versions as prereleases. Check existing releases/tags and coordinate one owner and version before publishing. Build from an identified integrated commit and verify the packaged result and launch steps. +Publish versioned Gitea releases at meaningful working milestones; mark unfinished versions as prereleases. Check existing releases / tags and coordinate one owner and version before publishing. Build from an identified integrated commit and verify the packaged result and launch steps. -Include runnable builds or appropriate artifacts, concise release notes, build/run/deployment instructions as applicable, known limitations, tested platforms, and verification evidence. Confirm publication and artifact availability. Use existing authorized API access or project tooling when MCP lacks a needed release/upload operation. Do not silently replace published versions with different contents. +Include runnable builds or appropriate artifacts, concise release notes, build / run / deployment instructions as applicable, known limitations, tested platforms, and verification evidence. Confirm publication and artifact availability. Use existing authorized API access or project tooling when MCP lacks a needed release / upload operation. Do not silently replace published versions with different contents. diff --git a/crates/oa-core/src/language/analysis_source/index.rs b/crates/oa-core/src/language/analysis_source/index.rs index f22e4f0b..760905d8 100644 --- a/crates/oa-core/src/language/analysis_source/index.rs +++ b/crates/oa-core/src/language/analysis_source/index.rs @@ -237,55 +237,242 @@ impl<'s> Index<'s> { for element in lowered.elements.values() { insert_name(Target::Global(element.id), &element.alias)?; } - let mut index = Self { + let original = Original { + kind: OriginalKind::Typed { sources, witnesses }, + at: std::cell::Cell::new(None), + }; + let data = IndexData::build( + names, + units + .iter() + .flat_map(|u| u.declarations.iter().map(move |d| (u.file, d))), + &lowered.expressions, + &lowered.occurrences, + &original, + budget, + &mut Storage(None), + )?; + Ok(Self { sources, + names: data.names, + occurrences: data.occurrences, + expressions: data.expressions, + }) + } +} + +use super::mixed::project::{ + IndexInput, + accounting::{Ledger, Slots}, +}; + +/// Owned maps shared by the two nominal provenance wrappers. No edit authority. +#[derive(Debug)] +pub(super) struct IndexData { + pub(super) names: BTreeMap, + pub(super) occurrences: BTreeMap, + pub(super) expressions: BTreeMap, +} + +// Only project::index can mint IndexInput: its private seal is never exported. +pub(super) fn mixed_data( + input: IndexInput<'_>, + budget: &mut Budget, + ledger: &mut Ledger, +) -> Result { + let original = Original { + kind: OriginalKind::Mixed(&input), + at: std::cell::Cell::new(None), + }; + let mut storage = Storage(Some(ledger)); + let result = (|| { + budget.active()?; + let mut names = BTreeMap::new(); + let mut insert = |target, name: &str| -> Result<(), Error> { + storage.reserve(budget, 1, name.len(), Span::default())?; + if names.insert(target, name.to_owned()).is_some() { + return Err(error( + Span::default(), + "Duplicate qualified catalog identity.", + )); + } + Ok(()) + }; + let p = input.project; + insert(Target::Global(p.id), &p.alias)?; + for d in p.definitions.values() { + insert(Target::Global(d.id), &d.alias)?; + if let a::DefinitionBody::Calculation(c) = &d.body { + for parameter in &c.parameters { + insert( + Target::Parameter { + calculation: d.id, + parameter: parameter.id, + }, + ¶meter.name, + )?; + } + } + } + for v in p.elements.values() { + insert(Target::Global(v.id), &v.alias)?; + } + for v in p.relations.values() { + insert(Target::Global(v.id), &v.alias)?; + } + for v in p.diagrams.values() { + insert(Target::Global(v.id), &v.alias)?; + for n in v.nodes.values() { + insert(Target::Global(n.id), &n.alias)?; + } + } + for v in p.artifact_links.values() { + insert(Target::Global(v.id), &v.alias)?; + } + for v in p.traces.values() { + insert(Target::Global(v.id), &v.alias)?; + } + IndexData::build( + names, + input.declarations(), + input.expressions, + input.occurrences, + &original, + budget, + &mut storage, + ) + })(); + result.map_err(|error| lower::Failure { + file: original.at.get(), + error, + }) +} + +struct Storage<'a>(Option<&'a mut Ledger>); +impl Storage<'_> { + fn reserve( + &mut self, + budget: &Budget, + entries: usize, + text: usize, + at: Span, + ) -> Result<(), Error> { + if let Some(ledger) = &mut self.0 { + ledger.reserve( + budget, + Slots { + entries, + occurrences: 0, + text, + }, + at, + )?; + } + Ok(()) + } + fn release(&mut self, entries: usize) { + if let Some(ledger) = &mut self.0 { + ledger.release(Slots::entries(entries)); + } + } +} +struct Original<'a> { + kind: OriginalKind<'a>, + at: std::cell::Cell>, +} +enum OriginalKind<'a> { + Typed { + sources: &'a BTreeMap, + witnesses: &'a BTreeMap>, + }, + Mixed(&'a IndexInput<'a>), +} +impl Original<'_> { + fn checked(&self, location: Location) -> Result<&str, Error> { + self.at.set(Some(location.file)); + if location.span.start >= location.span.end { + return Err(error(location.span, "Empty or reversed source span.")); + } + let source = match &self.kind { + OriginalKind::Typed { sources, .. } => sources.get(&location.file).map(String::as_str), + OriginalKind::Mixed(input) => input.source(location.file), + }; + source + .and_then(|s| s.get(location.span.start..location.span.end)) + .ok_or_else(|| { + error( + location.span, + "Source span is outside its original UTF-8 file.", + ) + }) + } + fn tokens(&self, file: usize) -> Option<&[lex::Token]> { + match &self.kind { + OriginalKind::Typed { witnesses, .. } => witnesses.get(&file).map(Vec::as_slice), + OriginalKind::Mixed(input) => input.tokens(file), + } + } +} +impl IndexData { + fn build<'a>( + names: BTreeMap, + declarations: impl Iterator + Clone, + expressions: &[lower::ExpressionSite], + occurrences: &[lower::Occurrence], + sources: &Original<'_>, + budget: &mut Budget, + storage: &mut Storage<'_>, + ) -> Result { + let mut index = Self { names, occurrences: BTreeMap::new(), expressions: BTreeMap::new(), }; let mut owners = BTreeMap::new(); let mut physical = BTreeSet::new(); - for unit in units { - for declaration in &unit.declarations { - let owner = declaration.header.identity.value.ok_or_else(|| { - error( - declaration.span, - "Missing ID requires source stabilization.", - ) - })?; - let location = Location { - file: unit.file, - span: declaration.span, - }; - checked_source(sources, location)?; - budget.lowering_entries(owners.len() + 1, declaration.span)?; - if owners.insert(owner, location).is_some() { - return Err(error(declaration.span, "Duplicate source owner.")); - } - let key = OccurrenceKey { - owner, - field: None, - path: None, - role: TokenRole::Declaration, - target: Target::Global(owner), - }; - index.insert( - key, - Location { - file: unit.file, - span: declaration.header.alias.span, - }, - witnesses, - &mut physical, - budget, - )?; + for (file, declaration) in declarations.clone() { + sources.at.set(Some(file)); + let owner = declaration.header.identity.value.ok_or_else(|| { + error( + declaration.span, + "Missing ID requires source stabilization.", + ) + })?; + let location = Location { + file, + span: declaration.span, + }; + sources.checked(location)?; + budget.lowering_entries(owners.len() + 1, declaration.span)?; + storage.reserve(budget, 1, 0, declaration.span)?; + if owners.insert(owner, location).is_some() { + return Err(error(declaration.span, "Duplicate source owner.")); } + let key = OccurrenceKey { + owner, + field: None, + path: None, + role: TokenRole::Declaration, + target: Target::Global(owner), + }; + index.insert( + key, + Location { + file, + span: declaration.header.alias.span, + }, + sources, + &mut physical, + budget, + storage, + )?; } // Parent-before-child is part of the lowering contract. One forward // pass rejects forward, cyclic, cross-file/owner/field and duplicate // paths. Each node allocates one shared edge, not a copied path vector. let mut paths: Vec<(ExpressionKey, usize)> = Vec::new(); - for (position, site) in lowered.expressions.iter().enumerate() { + for (position, site) in expressions.iter().enumerate() { + sources.at.set(Some(site.file)); if !matches!( site.field, Field::Body | Field::Base | Field::Predicate | Field::Override(_) @@ -299,7 +486,7 @@ impl<'s> Index<'s> { file: site.file, span: site.span, }; - checked_source(sources, location)?; + sources.checked(location)?; let owner = owners .get(&site.owner) .ok_or_else(|| error(site.span, "Unknown expression owner."))?; @@ -311,7 +498,7 @@ impl<'s> Index<'s> { "Expression parent must precede its child.", )); } - let ancestor = &lowered.expressions[parent]; + let ancestor = &expressions[parent]; if ancestor.owner != site.owner || ancestor.field != site.field || ancestor.file != site.file @@ -336,6 +523,7 @@ impl<'s> Index<'s> { } let depth = paths[parent].1 + 1; budget.frame(depth, site.span)?; + storage.reserve(budget, 1, 0, site.span)?; ( Path(Some(Arc::new(Step { parent: paths[parent].0.path.clone(), @@ -352,12 +540,14 @@ impl<'s> Index<'s> { field: site.field, path, }; + storage.reserve(budget, 2, 0, site.span)?; if index.expressions.insert(key.clone(), location).is_some() { return Err(error(site.span, "Duplicate qualified expression path.")); } paths.push((key, depth)); } - for occurrence in &lowered.occurrences { + for occurrence in occurrences { + sources.at.set(Some(occurrence.file)); let location = Location { file: occurrence.file, span: occurrence.span, @@ -368,8 +558,7 @@ impl<'s> Index<'s> { contained(*owner, location)?; let path = match occurrence.expression { Some(site) => { - let expression = lowered - .expressions + let expression = expressions .get(site) .ok_or_else(|| error(occurrence.span, "Unknown occurrence expression."))?; if expression.owner != occurrence.owner @@ -420,20 +609,28 @@ impl<'s> Index<'s> { role: TokenRole::Use(occurrence.role), target: occurrence.target, }; - index.insert(key, location, witnesses, &mut physical, budget)?; + index.insert(key, location, sources, &mut physical, budget, storage)?; } + let owner_count = owners.len(); + let physical_count = physical.len(); + drop(owners); + drop(physical); + storage.release(owner_count + physical_count); // Argument labels belong to this precise call site and its callee, not // merely to a parameter UUID/name present somewhere in the catalog. let mut calls = BTreeMap::new(); for (key, at) in &index.occurrences { + sources.at.set(Some(at.file)); if key.role == TokenRole::Use(Role::CallTarget) { let site = (key.owner, key.field, key.path.clone()); + storage.reserve(budget, 1, 0, at.span)?; if calls.insert(site, key.target).is_some() { return Err(error(at.span, "Multiple callees at one expression site.")); } } } for (key, at) in &index.occurrences { + sources.at.set(Some(at.file)); if let (TokenRole::Use(Role::ArgumentLabel), Target::Parameter { calculation, .. }) = (key.role, key.target) && calls.get(&(key.owner, key.field, key.path.clone())) @@ -445,7 +642,8 @@ impl<'s> Index<'s> { )); } } - for (position, site) in lowered.expressions.iter().enumerate() { + for (position, site) in expressions.iter().enumerate() { + sources.at.set(Some(site.file)); if let Some((parent, Child::Argument(parameter))) = site.parent { let key = &paths[parent].0; let Some(Target::Global(calculation)) = @@ -468,7 +666,12 @@ impl<'s> Index<'s> { } } } - index.check_syntax_edges(units, lowered, budget)?; + let path_count = paths.len(); + let call_count = calls.len(); + drop(paths); + drop(calls); + storage.release(path_count + call_count); + index.check_syntax_edges(declarations, expressions, sources, budget, storage)?; Ok(index) } @@ -477,12 +680,16 @@ impl<'s> Index<'s> { /// with indexed span lookup; it does not lex or copy source/path strings. fn check_syntax_edges<'a>( &self, - units: &'a [Unit], - lowered: &Lowered, + declarations: impl Iterator + Clone, + expressions: &[lower::ExpressionSite], + sources: &Original<'_>, budget: &Budget, + storage: &mut Storage<'_>, ) -> Result<(), Error> { let mut globals = BTreeMap::new(); let mut parameters = BTreeMap::new(); + sources.at.set(None); + storage.reserve(budget, self.names.len(), 0, Span::default())?; for (target, name) in &self.names { match target { Target::Global(id) => { @@ -497,7 +704,9 @@ impl<'s> Index<'s> { } } let mut sites = BTreeMap::new(); - for (position, site) in lowered.expressions.iter().enumerate() { + for (position, site) in expressions.iter().enumerate() { + sources.at.set(Some(site.file)); + storage.reserve(budget, 1, 0, site.span)?; if sites .insert( ( @@ -518,39 +727,43 @@ impl<'s> Index<'s> { let mut root = |file, owner, field, binding: &'a super::Binding| -> Result<(), Error> { if let super::Binding::Expression(expression) = binding { budget.lowering_entries(work.len() + 1, expression.span)?; + sources.at.set(Some(file)); + storage.reserve(budget, 1, 0, expression.span)?; work.push((file, owner, field, expression, None)); } Ok(()) }; - for unit in units { - for declaration in &unit.declarations { - let owner = declaration.header.identity.value.expect("validated owner"); - match &declaration.body { - declarations::Body::Calculation { body, .. } => { - root(unit.file, owner, Field::Body, &body.value)? - } - declarations::Body::Property { base, .. } => { - root(unit.file, owner, Field::Base, &base.value)? - } - declarations::Body::Check { predicate, .. } => { - root(unit.file, owner, Field::Predicate, &predicate.value)? - } - declarations::Body::Case { overrides, .. } => { - for entry in &overrides.value { - let target = - *globals.get(entry.target.name.as_str()).ok_or_else(|| { - error(entry.target.span, "Unknown syntax override target.") - })?; - root(unit.file, owner, Field::Override(target), &entry.binding)?; - } - } - _ => {} + for (file, declaration) in declarations.clone() { + sources.at.set(Some(file)); + let owner = declaration.header.identity.value.expect("validated owner"); + match &declaration.body { + declarations::Body::Calculation { body, .. } => { + root(file, owner, Field::Body, &body.value)? } + declarations::Body::Property { base, .. } => { + root(file, owner, Field::Base, &base.value)? + } + declarations::Body::Check { predicate, .. } => { + root(file, owner, Field::Predicate, &predicate.value)? + } + declarations::Body::Case { overrides, .. } => { + for entry in &overrides.value { + let target = *globals.get(entry.target.name.as_str()).ok_or_else(|| { + error(entry.target.span, "Unknown syntax override target.") + })?; + root(file, owner, Field::Override(target), &entry.binding)?; + } + } + _ => {} } } let mut visited = 0usize; while let Some((file, owner, field, expression, parent)) = work.pop() { - budget.lowering_entries(visited + 1, expression.span)?; + storage.release(1); + sources.at.set(Some(file)); + if storage.0.is_none() { + budget.lowering_entries(visited + 1, expression.span)?; + } visited += 1; let site = *sites .get(&( @@ -566,7 +779,7 @@ impl<'s> Index<'s> { "Parsed expression is absent from the source arena.", ) })?; - if lowered.expressions[site].parent != parent { + if expressions[site].parent != parent { return Err(error( expression.span, "Arena parent/child edge differs from original syntax.", @@ -574,6 +787,7 @@ impl<'s> Index<'s> { } let mut child = |value: &'a super::Expression, edge| -> Result<(), Error> { budget.lowering_entries(work.len() + 1, value.span)?; + storage.reserve(budget, 1, 0, value.span)?; work.push((file, owner, field, value, Some((site, edge)))); Ok(()) }; @@ -623,7 +837,14 @@ impl<'s> Index<'s> { _ => {} } } - if visited != lowered.expressions.len() { + sources.at.set(None); + let scratch = globals.len() + parameters.len() + sites.len(); + drop(globals); + drop(parameters); + drop(sites); + drop(work); + storage.release(scratch); + if visited != expressions.len() { return Err(error( Span::default(), "Arena contains expressions absent from parsed syntax.", @@ -636,20 +857,24 @@ impl<'s> Index<'s> { &mut self, key: OccurrenceKey, location: Location, - witnesses: &BTreeMap>, + sources: &Original<'_>, physical: &mut BTreeSet<(usize, usize, usize)>, budget: &Budget, + storage: &mut Storage<'_>, ) -> Result<(), Error> { - budget.lowering_occurrences(self.occurrences.len() + 1, location.span)?; - let text = checked_source(self.sources, location)?; + if storage.0.is_none() { + budget.lowering_occurrences(self.occurrences.len() + 1, location.span)?; + } + storage.reserve(budget, 2, 0, location.span)?; + let text = sources.checked(location)?; if self.names.get(&key.target).is_none_or(|name| name != text) { return Err(error( location.span, "Token differs from its qualified target name.", )); } - let tokens = witnesses - .get(&location.file) + let tokens = sources + .tokens(location.file) .ok_or_else(|| error(location.span, "Missing lexical witness."))?; let token = tokens .binary_search_by_key(&location.span.start, |token| token.span.start) diff --git a/crates/oa-core/src/language/analysis_source/mixed/project.rs b/crates/oa-core/src/language/analysis_source/mixed/project.rs index f5b1dc6b..f34d37e0 100644 --- a/crates/oa-core/src/language/analysis_source/mixed/project.rs +++ b/crates/oa-core/src/language/analysis_source/mixed/project.rs @@ -1,5 +1,5 @@ //! Private complete-Project admission from the actual complete syntax witness. -//! No Index, update authority, public source8 dispatch or replacement policy. +//! Consumed read-only typed index; no update authority, public source8 dispatch or replacement policy. use super::super::{ Binding, Budget, Error as TypedError, Expression, ExpressionKind, Reference, Span, declarations as d, error, lower, @@ -9,7 +9,7 @@ use crate::language::{Ast, DeclKind}; use crate::source_project::{SourceDiagnostic, SourceLocation}; use crate::{Id, Kind, Project, RelationKind, analysis, language, validation}; use std::collections::BTreeMap; -mod accounting; +pub(in crate::language::analysis_source) mod accounting; use accounting::{Ledger, Slots, add}; /// Read-only authority: every component originates in the consumed syntax. @@ -32,6 +32,105 @@ impl ResolvedMixedProject<'_> { } } +/// Complete original bundle authority with a typed-only occurrence view. +/// Ordinary globals are catalogued, but their authored occurrences are not indexed. +/// This owner cannot be converted into the legacy typed-only edit authority. +pub(in crate::language::analysis_source) struct IndexedMixedProject<'s> { + resolved: ResolvedMixedProject<'s>, + data: super::super::index::IndexData, +} +impl<'s> ResolvedMixedProject<'s> { + pub fn index(mut self) -> Result, Failure> { + let input = IndexInput { + files: &self.syntax.files, + project: &self.project, + expressions: &self.expressions, + occurrences: &self.occurrences, + }; + let data = + super::super::index::mixed_data(input, &mut self.syntax.budget, &mut self.storage) + .map_err(|mut failure| { + // An invariant without a canonical file has no defensible source + // offset. Use the entry start explicitly, never a foreign span. + failure.file = failure.file.filter(|&f| f < self.syntax.files.len()); + if failure.file.is_none_or(|file| { + self.syntax.files[file] + .source + .get(failure.error.span.start..failure.error.span.end) + .is_none() + }) { + failure.error.span = Span::default(); + } + Failure::typed(&self.syntax, failure.file, failure.error) + })?; + Ok(IndexedMixedProject { + resolved: self, + data, + }) + } +} +impl IndexedMixedProject<'_> { + pub fn project(&self) -> &Project { + self.resolved.project() + } + pub fn warnings(&self) -> &[SourceDiagnostic] { + self.resolved.warnings() + } + pub fn bundle(&self) -> &crate::source_project::SourceBundle { + self.resolved.syntax.bundle + } + /// Canonical file key, canonical path, and the complete original bytes. + pub fn files(&self) -> impl Iterator { + self.resolved + .syntax + .files + .iter() + .enumerate() + .map(|(key, f)| (key, f.path, f.source)) + } + pub fn names(&self) -> &BTreeMap { + &self.data.names + } + pub fn occurrences( + &self, + ) -> &BTreeMap { + &self.data.occurrences + } + pub fn expressions( + &self, + ) -> &BTreeMap { + &self.data.expressions + } +} + +/// Constructor-only borrowed adapter. Its private file table prevents fabrication; +/// no API returns it and no alternative source/token table can be installed. +pub(in crate::language::analysis_source) struct IndexInput<'a> { + files: &'a [FileSyntax<'a>], + pub(in crate::language::analysis_source) project: &'a Project, + pub(in crate::language::analysis_source) expressions: &'a [lower::ExpressionSite], + pub(in crate::language::analysis_source) occurrences: &'a [lower::Occurrence], +} +impl IndexInput<'_> { + pub(in crate::language::analysis_source) fn declarations( + &self, + ) -> impl Iterator + Clone { + self.files + .iter() + .enumerate() + .flat_map(|(file, f)| f.typed.iter().map(move |d| (file, d))) + } + pub(in crate::language::analysis_source) fn source(&self, file: usize) -> Option<&str> { + self.files.get(file).map(|f| f.source) + } + pub(in crate::language::analysis_source) fn tokens( + &self, + file: usize, + ) -> Option<&[super::super::lex::Token]> { + self.files.get(file).map(|f| f.tokens.as_slice()) + } +} + #[derive(Debug)] pub(in crate::language::analysis_source) struct Failure { pub diagnostics: Vec, diff --git a/crates/oa-core/src/language/analysis_source/mixed/project/accounting.rs b/crates/oa-core/src/language/analysis_source/mixed/project/accounting.rs index 2f718597..7d6831f7 100644 --- a/crates/oa-core/src/language/analysis_source/mixed/project/accounting.rs +++ b/crates/oa-core/src/language/analysis_source/mixed/project/accounting.rs @@ -3,7 +3,7 @@ use super::*; use crate::language::{EditKind, EditValue}; #[derive(Clone, Copy, Debug, Default, PartialEq, Eq)] -pub(super) struct Slots { +pub(in crate::language::analysis_source) struct Slots { pub entries: usize, pub occurrences: usize, pub text: usize, @@ -39,7 +39,7 @@ pub(super) fn mul(a: usize, b: usize, at: Span) -> Result SourceBundle { + let mut bundle = bundle(layer); let main = bundle.files.get_mut("main.arcadia").unwrap(); *main = main .replace( @@ -269,8 +268,10 @@ fn complete_global_arena_scoped_calls_and_coincident_file_offsets() { ] { bundle.files.insert(file.into(), format!("calculation {alias} \"{name}\" id \"{}\" {{\ninput x id \"{}\" : Number;\ninput y id \"{}\" : Number;\nresult Number; body $x {op} $y;\n}}\n", id(n), id(1), id(12))); } - let resolved = accepted(&bundle); - let mut model = expected(Layer::Oa); + bundle +} +fn rich_model(layer: Layer) -> Project { + let mut model = expected(layer); for (alias, name, n, op) in [ ("f", "F", 10, a::BinaryOp::Add), ("g", "G", 11, a::BinaryOp::Subtract), @@ -315,6 +316,14 @@ fn complete_global_arena_scoped_calls_and_coincident_file_offsets() { call(10, call(11, number(3), number(4)), number(2)), call(10, number(5), number(6)), )); + model +} + +#[test] +fn complete_global_arena_scoped_calls_and_coincident_file_offsets() { + let bundle = rich_bundle(Layer::Oa); + let resolved = accepted(&bundle); + let model = rich_model(Layer::Oa); assert_eq!(resolved.project(), &model); assert_eq!( resolved @@ -1021,3 +1030,5 @@ fn incomplete_call_borrows_large_signature_and_refuses_at_single_admission() { assert_eq!(failure.diagnostics[0].diagnostic.code, "analysis_arguments"); assert_eq!(failure.diagnostics[0].diagnostic.object_id, Some(id(11))); } + +mod index_tests; diff --git a/crates/oa-core/src/language/analysis_source/mixed/project/tests/index_tests.rs b/crates/oa-core/src/language/analysis_source/mixed/project/tests/index_tests.rs new file mode 100644 index 00000000..9dc5b35c --- /dev/null +++ b/crates/oa-core/src/language/analysis_source/mixed/project/tests/index_tests.rs @@ -0,0 +1,479 @@ +use super::*; +use crate::language::analysis_source::index::{Location, TokenRole}; +use lower::{Child as C, Field as F, Role as R, Target as T}; + +fn parameter(n: usize) -> a::ParameterId { + a::ParameterId(id(n)) +} +fn q(c: usize, p: usize) -> T { + T::Parameter { + calculation: id(c), + parameter: parameter(p), + } +} +fn arg(n: usize) -> C { + C::Argument(parameter(n)) +} +fn mapped(original: &str, byte: usize, transformed: bool) -> usize { + if transformed { + 8 + byte + + original.as_bytes()[..byte] + .iter() + .filter(|&&b| b == b'\n') + .count() + } else { + byte + } +} + +#[test] +fn entire_authored_index_oa_sa_original_and_unicode_crlf() { + for layer in [Layer::Oa, Layer::Sa] { + for transformed in [false, true] { + let original = rich_bundle(layer); + let mut bundle = original.clone(); + if transformed { + for source in bundle.files.values_mut() { + *source = format!("// 雨\r\n{}", source.replace('\n', "\r\n")); + } + } + let resolved = accepted(&bundle); + let before = resolved.storage.live; + let usage = resolved.syntax.budget.usage; + let numeric = resolved.syntax.budget.numeric_units(); + let warnings = resolved.warnings.clone(); + let static_limits = resolved.static_limits; + let static_usage = resolved.static_usage; + let indexed = resolved.index().unwrap(); + assert_eq!(indexed.project(), &rich_model(layer)); + assert_eq!(indexed.warnings(), warnings); + assert!(std::ptr::eq(indexed.bundle(), &bundle)); + assert_eq!(indexed.resolved.syntax.budget.usage, usage); + assert_eq!(indexed.resolved.syntax.budget.numeric_units(), numeric); + assert_eq!(indexed.resolved.static_limits, static_limits); + assert_eq!(indexed.resolved.static_usage, static_usage); + assert_eq!( + indexed.files().collect::>(), + bundle + .files + .iter() + .enumerate() + .map(|(i, (p, s))| (i, p.as_str(), s.as_str())) + .collect::>() + ); + let mut names: BTreeMap<_, String> = [ + (1, "p"), + (2, "w"), + (3, "v"), + (4, "n"), + (5, "d"), + (10, "f"), + (11, "g"), + ] + .into_iter() + .map(|(n, s)| (T::Global(id(n)), s.into())) + .collect(); + for c in [10, 11] { + for (p, s) in [(1, "x"), (12, "y")] { + names.insert(q(c, p), s.into()); + } + } + if layer == Layer::Sa { + names.insert(T::Global(id(6)), "s".into()); + } + assert_eq!(indexed.names(), &names); + assert_eq!( + indexed.resolved.storage.live, + before + .add( + Slots { + entries: if layer == Layer::Sa { 60 } else { 59 }, + occurrences: 0, + text: names.len() + }, + Span::default() + ) + .unwrap() + ); + let at = |file: usize, start, end| { + let source = original.files.values().nth(file).unwrap(); + Location { + file, + span: Span { + start: mapped(source, start, transformed), + end: mapped(source, end, transformed), + }, + } + }; + let mut expressions = BTreeMap::new(); + for (file, owner) in [(0, 10), (1, 11)] { + for (path, start, end) in [ + (vec![], 202, 209), + (vec![C::Left], 202, 204), + (vec![C::Right], 207, 209), + ] { + expressions.insert((id(owner), F::Body, path), at(file, start, end)); + } + } + for (path, start, end) in [ + (vec![], 290, 334), + (vec![C::Left], 290, 317), + (vec![C::Left, arg(12)], 296, 297), + (vec![C::Left, arg(1)], 302, 316), + (vec![C::Left, arg(1), arg(1)], 308, 309), + (vec![C::Left, arg(1), arg(12)], 314, 315), + (vec![C::Right], 320, 334), + (vec![C::Right, arg(1)], 326, 327), + (vec![C::Right, arg(12)], 332, 333), + ] { + expressions.insert((id(3), F::Base, path), at(2, start, end)); + } + assert_eq!( + indexed + .expressions() + .iter() + .map(|(k, v)| ((k.owner, k.field, k.path.edges()), *v)) + .collect::>(), + expressions + ); + let mut occurrences = BTreeMap::new(); + for (file, owner, start) in [(0, 10, 12), (1, 11, 12), (2, 3, 206)] { + occurrences.insert( + ( + id(owner), + None, + None, + TokenRole::Declaration, + T::Global(id(owner)), + ), + at(file, start, start + 1), + ); + } + for (file, owner) in [(0, 10), (1, 11)] { + for (p, start) in [(1, 68), (12, 128)] { + occurrences.insert( + ( + id(owner), + Some(F::Input(parameter(p))), + None, + TokenRole::Use(R::ParameterDeclaration), + q(owner, p), + ), + at(file, start, start + 1), + ); + } + for (p, edge, start) in [(1, C::Left, 203), (12, C::Right, 208)] { + occurrences.insert( + ( + id(owner), + Some(F::Body), + Some(vec![edge]), + TokenRole::Use(R::ParameterUse), + q(owner, p), + ), + at(file, start, start + 1), + ); + } + } + occurrences.insert( + ( + id(3), + Some(F::Subject), + None, + TokenRole::Use(R::Reference), + T::Global(id(2)), + ), + at(2, 269, 270), + ); + for (path, role, target, start) in [ + (vec![C::Left], R::CallTarget, T::Global(id(10)), 291), + (vec![C::Left], R::ArgumentLabel, q(10, 12), 293), + (vec![C::Left], R::ArgumentLabel, q(10, 1), 299), + (vec![C::Left, arg(1)], R::CallTarget, T::Global(id(11)), 303), + (vec![C::Left, arg(1)], R::ArgumentLabel, q(11, 1), 305), + (vec![C::Left, arg(1)], R::ArgumentLabel, q(11, 12), 311), + (vec![C::Right], R::CallTarget, T::Global(id(10)), 321), + (vec![C::Right], R::ArgumentLabel, q(10, 1), 323), + (vec![C::Right], R::ArgumentLabel, q(10, 12), 329), + ] { + occurrences.insert( + ( + id(3), + Some(F::Base), + Some(path), + TokenRole::Use(role), + target, + ), + at(2, start, start + 1), + ); + } + assert_eq!( + indexed + .occurrences() + .iter() + .map(|(k, v)| ( + ( + k.owner, + k.field, + k.path.as_ref().map(|p| p.edges()), + k.role, + k.target + ), + *v + )) + .collect::>(), + occurrences + ); + for (key, at) in indexed.occurrences() { + let source = indexed.files().nth(at.file).unwrap().2; + assert_eq!(&source[at.span.start..at.span.end], names[&key.target]); + } + } + } +} + +fn reject(value: ResolvedMixedProject<'_>, message: &str, file: Option<&str>) -> Failure { + let failure = match value.index() { + Ok(_) => panic!("corrupt index accepted: {message}"), + Err(e) => e, + }; + assert_eq!(failure.diagnostics[0].diagnostic.message, message); + if let Some(file) = file { + assert_eq!(failure.diagnostics[0].path, file); + } + failure +} +#[test] +fn damage_reaches_structural_token_and_call_checks() { + let bundle = rich_bundle(Layer::Oa); + for case in 0..13 { + let mut value = accepted(&bundle); + let message = match case { + 0 => { + value.expressions[1].file = 1; + "Source span crosses its containing syntax." + } + 1 => { + value.expressions[1].owner = id(1); + "Unknown expression owner." + } + 2 => { + value.expressions[1].field = F::Predicate; + "Expression parent crosses its owner, field or file." + } + 3 => { + value.expressions[1].parent = Some((1, C::Left)); + "Expression parent must precede its child." + } + 4 => { + value.expressions[1].parent = Some((2, C::Left)); + "Expression parent must precede its child." + } + 5 => { + value.expressions[1].parent = Some((0, C::Operand)); + "Arena parent/child edge differs from original syntax." + } + 6 => { + value.occurrences[11].target = q(11, 1); + "Argument label crosses its called calculation." + } + 7 => { + value.occurrences.remove(11); + "Argument child has no qualified label." + } + 8 => { + value.expressions.pop(); + "Parsed expression is absent from the source arena." + } + 9 => { + value.occurrences[1].span = value.occurrences[0].span; + value.occurrences[1].target = q(10, 1); + value.occurrences[1].field = F::Input(parameter(1)); + "Duplicate qualified occurrence or token ownership." + } + 10 => { + value.occurrences[0].span = Span { start: 69, end: 70 }; + "Token differs from its qualified target name." + } + 11 => { + let token = value.syntax.files[0] + .tokens + .iter_mut() + .find(|t| t.span.start == 68) + .unwrap(); + token.class = super::super::super::super::lex::Class::String; + "Occurrence is not an original whole name token." + } + _ => { + value.expressions.push(lower::ExpressionSite { + file: 0, + owner: id(10), + field: F::Base, + parent: None, + span: Span { + start: 202, + end: 204, + }, + }); + "Arena contains expressions absent from parsed syntax." + } + }; + let file = if matches!(case, 6 | 7 | 8) { + Some("main.arcadia") + } else if case == 0 { + Some("b.arcadia") + } else if case == 12 { + None + } else { + Some("a.arcadia") + }; + reject(value, message, file); + } +} + +#[test] +fn new_maps_keep_baseline_and_scope_reservations_and_peak_scratch() { + let bundle = rich_bundle(Layer::Oa); + let baseline = accepted(&bundle).storage.live; + // Final new maps59; at the last occurrence, owners3+physical21+paths15 + // coexist. Subsequent call peak77 and syntax peak90 are smaller than98. + for (extra, fits) in [(97, false), (98, true)] { + let profile = super::super::super::super::budget::Limits { + entries: baseline.entries + extra, + ..super::super::super::super::budget::Limits::source8(language::ParseLimits::UNLIMITED) + }; + let resolved = + resolve(parse_with_profile(&bundle, ProjectLimits::default(), profile).unwrap()) + .unwrap(); + assert_eq!(resolved.storage.live, baseline); + if fits { + let indexed = resolved.index().unwrap(); + assert_eq!(indexed.resolved.storage.live.entries, baseline.entries + 59); + assert_eq!( + indexed.resolved.storage.live.occurrences, + baseline.occurrences + ); + } else { + let failure = reject( + resolved, + "Source8 lowering entry limit exceeded.", + Some("main.arcadia"), + ); + assert_eq!( + failure.diagnostics[0].diagnostic.span, + Span { + start: 329, + end: 330 + } + ); + } + } +} + +#[test] +fn copied_name_bytes_coexist_with_retained_warning_bytes() { + let mut bundle = single(""); + let source = bundle + .files + .remove("main.arcadia") + .unwrap() + .replace("\"Project\"", "\"\""); + bundle.entry = format!("{}.arcadia", "a".repeat(180)); + bundle.files.insert(bundle.entry.clone(), source); + for (bytes, fits) in [(236, false), (237, true)] { + let profile = super::super::super::super::budget::Limits { + bytes, + ..super::super::super::super::budget::Limits::source8(language::ParseLimits::UNLIMITED) + }; + let resolved = + resolve(parse_with_profile(&bundle, ProjectLimits::default(), profile).unwrap()) + .unwrap(); + assert_eq!(resolved.storage.live.text, 236); + if fits { + assert_eq!(resolved.index().unwrap().resolved.storage.live.text, 237); + } else { + reject(resolved, "Source8 index/output byte limit exceeded.", None); + } + } +} + +#[test] +fn success_and_late_failure_drop_on_small_stack() { + std::thread::Builder::new() + .stack_size(128 * 1024) + .spawn(|| { + let bundle = rich_bundle(Layer::Oa); + drop(accepted(&bundle).index().unwrap()); + let deep = single(&format!( + "calculation c \"C\" id \"{}\" {{ result Number; body {}1{}; }}", + id(2), + "abs(".repeat(127), + ")".repeat(127) + )); + drop(accepted(&deep).index().unwrap()); + let mut damaged = accepted(&deep); + damaged.expressions[127].parent = Some((126, C::Left)); + reject( + damaged, + "Arena parent/child edge differs from original syntax.", + Some("main.arcadia"), + ); + let mut value = accepted(&bundle); + value.expressions[1].parent = Some((0, C::Operand)); + reject( + value, + "Arena parent/child edge differs from original syntax.", + Some("a.arcadia"), + ); + }) + .unwrap() + .join() + .unwrap(); +} + +#[test] +fn invalid_file_and_utf8_span_use_explicit_safe_fallback() { + let mut bundle = rich_bundle(Layer::Oa); + *bundle.files.get_mut("a.arcadia").unwrap() = + bundle.files["a.arcadia"].replace("\"F\"", "\"雨\""); + let mut value = accepted(&bundle); + value.expressions[0].file = usize::MAX; + let failure = reject( + value, + "Source span is outside its original UTF-8 file.", + Some("main.arcadia"), + ); + assert_eq!(failure.diagnostics[0].diagnostic.span, Span::default()); + let mut value = accepted(&bundle); + let byte = bundle.files["a.arcadia"].find('雨').unwrap() + 1; + value.occurrences[0].span = Span { + start: byte, + end: byte + 1, + }; + let failure = reject( + value, + "Source span is outside its original UTF-8 file.", + Some("a.arcadia"), + ); + assert_eq!(failure.diagnostics[0].diagnostic.span, Span::default()); +} +#[test] +fn distinct_qualified_keys_cannot_share_one_physical_token() { + let bundle = rich_bundle(Layer::Oa); + let mut value = accepted(&bundle); + let original = &value.occurrences[2]; + value.occurrences.push(lower::Occurrence { + file: original.file, + owner: original.owner, + field: original.field, + expression: original.expression, + role: R::ArgumentLabel, + target: q(11, 1), + span: original.span, + }); + reject( + value, + "Duplicate qualified occurrence or token ownership.", + Some("a.arcadia"), + ); +} diff --git a/harness/analysis-mixed-index-implementation-20260924.md b/harness/analysis-mixed-index-implementation-20260924.md new file mode 100644 index 00000000..24f50523 --- /dev/null +++ b/harness/analysis-mixed-index-implementation-20260924.md @@ -0,0 +1,51 @@ +# Private mixed typed occurrence index + +Source checkpoint on `codex/analysis-mixed-index-956atf-20260924`, based on +`aaec78fcc9b273d1485497126392afdd1fb2e54e`. This records implemented structure; +compilation and runtime acceptance have not yet occurred at this checkpoint. +The accepted contract/review are published at +`7cfdd13d3a1472e63fd34b0080b2cfc4b921b23e:harness/analysis-mixed-index-contract-20260924.md`. +Independent exhaustive fixture data and its raw-byte checker are at +`ae6df4fa1f103ff9b14963731b2edd84e38738b1:harness/analysis-mixed-index-20260924/`. + +`ResolvedMixedProject::index` consumes the sealed complete-Project witness. +`IndexedMixedProject` owns it and shared `IndexData`; read-only methods expose +the Project, warnings, original bundle/canonical files, names and typed maps. +It has no conversion to the legacy numeric-source Index or its updater. The +constructor-only adapter keeps its file table private, so shared verification +does not accept caller-fabricated mixed source/token ownership. + +Shared verification preserves original token, owner, structural child-path, +qualified call-label and physical occurrence checks. Mixed catalog construction +streams complete Project globals and scoped parameters once. It does not +reparse, relower, duplicate model records or repeat admission. Ordinary globals +are names/targets here; ordinary source occurrences are not indexed by this view. +Complete non-expression occurrence emission remains the sealed lowerer's +invariant, checked by an independent exhaustive output oracle. + +Mixed allocations reserve against the retained aggregate ledger before growth. +New map/vector/set/Path entries charge entry slots; retained raw lowerer +occurrences keep occurrence slots. New names charge copied UTF-8 bytes. Owner +and physical-token scratch drop after occurrence checks; path/call scratch drop +before syntax-edge traversal. Shared Path nodes remain retained while map keys +own them. Legacy typed-only construction retains its original local policy. + +Precompile independent review found stale diagnostic file attribution in two +late verification loops and unsafe fallback for invalid file/UTF-8 spans. The +source now updates attribution for each checked record and maps invalid +locations explicitly to a safe start span, retaining a valid file when known. +Regression cases are authored; no passing runtime result is implied. + +Seven new tests cover complete OA/SA names/maps/model and Unicode/CRLF variants, +qualified corruption cases, inherited-plus-new storage and copied-name byte +boundaries, original provenance/admission metadata, and small-stack success and +late rejection. Existing rich fixture/model construction is factored without +removing its original full arena test. Actual test inventory, strict core lint, +focused checks, full private-library dispositions and formatting still require +current-source execution. Prior private source8 failures are not suppressed. + +The working agreement is synchronized to current main blob +`e76647f49913b314e1543c4464f6199533909bae`. This source remains separate from the +Windows prerelease. Public source8, ordinary occurrence composition, source +updates/output admission, migration, checked save/history, GUI and API parity +remain required subsequent work.