ARCADIA-Studio/harness/release-semantic-gui.md

Semantic desktop review — milestones 1 and 2

Status: milestones 1–2 implemented and desktop tests/build verified; not full GUI parity, native acceptance or release acceptance. Base: d130013. Dedicated build target: D:/CodexBuilds/Capella2-semantic-desktop-target. Native verification is root-owned.

Scope and decisions

• Add an explicit Review semantics action for existing traced counterparts, with canonical Operational/System comparisons in either application direction. Preserve the existing counterpart creation and prose workflow with clear labels.
• Review one explicitly selected trace per dialog. Display grouped current and historical facts, own/linked drift and incomplete review. Names never infer reference correspondence; provide explicit reference and trace choices.
• Support every applicable scalar leaf through Keep, Take and typed final-value forms. Candidate records contain the complete combined selected result. Identity, alias and layer are protected. The closed core remains the validation boundary.
• State.Kind is a single structural scalar. Other constructor switches, keyed membership/order/annotation/binding/attachment decisions and pairing resets belong to milestone 3; show them read-only with an honest explanation.
• Core 6bb2583 permits first equal constructor acknowledgment without descendant expansion. The GUI exposes Acknowledge equal kind only when applicable; previously reviewed constructors remain governed by the core's switch rules.
• Show exact additional prepared impacts and require explicit acceptance. Apply validates the stored semantic plan and executes its exact command batch through Document, preserving source, baselines and one-step undo/redo. Do not place or reveal diagram objects by mutating the model after preview.
• Retain typed drafts and review choices on invalid input, planning conflicts, stale plans and failed source writeback. Display actionable errors in the dialog.

Milestones and acceptance

1. Grouped read-only review, named trace/reference choices, exact comparisons and honest traceability rollups; compact layout usable at 1100 by 700.
2. Scalar decisions and typed candidates; immutable initial observations; combined final records; exact impact acceptance; atomic document/source commit. Focused App event/source/history tests, strict Clippy and a dedicated desktop build.
3. Constructor closure, keyed and ordered facts, reset, complete artifact lifecycle, multi-source review and remaining source/REST parity cases. Still outstanding.
4. Root-owned native review, cross-surface fixtures, package/release acceptance.

Verification

Verified after the independent scalar review fixes on SEM 6ad3cb, using only the dedicated desktop target (core behavior remains based on 6bb2583):

$env:CARGO_TARGET_DIR='D:/CodexBuilds/Capella2-semantic-desktop-target'
cargo test --locked -p oa-desktop --quiet
cargo clippy --locked -p oa-desktop --all-targets -- -D warnings
cargo build --locked -p oa-desktop

All 277 desktop tests passed, including 11 original semantic review tests and 5 scalar review regression tests. Strict Clippy and the desktop build passed. The existing migration test's header assertion now follows SCHEMA_VERSION instead of expecting schema 4.

Coverage includes both-direction Keep/Take/Candidate with exact comments and source/model/baseline undo/redo; independent selected trace semantic histories; invalid numeric and protected-property edits; stale-plan and source-writeback rejection; typed reference mapping mixed with candidates; honest partial rollups; equal-kind acknowledgment without implicit descendants; State.Kind candidates; relationship role/bound candidates with retained identity/endpoints; and exact inherited-annotation cleanup approval, cleared when decisions change. Unselected invalid scalar drafts remain retained without contaminating another candidate.

The independent scalar review found three gaps, now corrected:

• Structural scalar edits replace only their authorized subtree. Clearing an invalid selected bound, changing a variant, and adding/removing/reordering a literal retain untouched raw inputs and editor buffers, including invalid inputs belonging to another decision.
• Dependent default, reference and port controls read a noncommitting context composed by the same scalar Keep/Take/Candidate assembler as the request. Raw candidates remain separate. Incomplete inputs use their stored shape only for those controls; request creation and Apply still reject invalid selected input. The Boolean-source/Integer-target default reproduction now offers Boolean literals in both directions. Tests also cover Candidate type, Keep reversion, storage-dependent default controls and mechanism-dependent reference choices.
• Keyed fact headings display live names with stable aliases or deleted UUIDs. Message annotation headings include the complete qualified path and field.

The regression tests exercise App events, the actual default-form helpers and button availability, exact source retention before Apply, and one-step undo.

Built executable: D:/CodexBuilds/Capella2-semantic-desktop-target/debug/arcadia-studio.exe. The build target is idle. No native application was launched by this task.

Remaining work

Milestone 3 must add explicit constructor closure/replacement, keyed and ordered decisions, historical pairing reset, complete artifact lifecycle and multi-source review. These facts are currently inspectable, with unsupported writes visibly identified. The reference table supplies explicit mappings for scalar reference Take; it does not claim to complete a reset or establish keyed acknowledgments.

Fresh independent scalar GUI review and root-owned native verification are still required before merging this milestone into release acceptance. In particular, validate the 1100×700 layout, keyboard/focus continuity, long historical values, reference selection, source reopening and prepared-impact inspection in the app.