Files
ARCADIA-Studio/harness/experiments/scenario-details-full-strict-8bf7607-20260913/original/clippy.log
T

128 lines
5.6 KiB
Plaintext

Checking http v1.5.0
Checking http-body v1.1.0
Checking hyper v1.11.1
Checking http-body-util v0.1.5
Checking hyper-util v0.1.20
Compiling oa-core v0.2.0 (C:\Users\User\Documents\Git\ARCADIA-Studio\.local\scenario-spacing-ytr83r-20260913\crates\oa-core)
Checking tower-http v0.6.11
Checking axum-core v0.5.6
Compiling oa-server v0.2.0 (C:\Users\User\Documents\Git\ARCADIA-Studio\.local\scenario-spacing-ytr83r-20260913\crates\oa-server)
Checking axum v0.8.9
Checking hyper-rustls v0.27.9
Checking reqwest v0.12.28
Compiling oa-desktop v0.2.0 (C:\Users\User\Documents\Git\ARCADIA-Studio\.local\scenario-spacing-ytr83r-20260913\crates\oa-desktop)
error: this `if` statement can be collapsed
--> crates\oa-desktop\src\app\diagram_usages\tests.rs:1030:9
|
1030 | / if call == calls[1]
1031 | | && let Some((previous_call, previous)) = &previous_camera
1032 | | {
1033 | | if *previous_call != call {
... |
1036 | | }
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.98.0/index.html#collapsible_if
= note: `-D clippy::collapsible-if` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::collapsible_if)]`
help: collapse nested if block
|
1031 ~ && let Some((previous_call, previous)) = &previous_camera
1032 ~ && *previous_call != call {
1033 | assert!(&camera != previous);
1034 ~ }
|
error: manual `Range::contains` implementation
--> crates\oa-desktop\src\app\diagram_usages\tests.rs:1378:13
|
1378 | assert!(zoom < 0.05 && zoom >= 0.0001);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0.0001..0.05).contains(&zoom)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.98.0/index.html#manual_range_contains
= note: `-D clippy::manual-range-contains` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::manual_range_contains)]`
error: used `unwrap()` on `Some` value
--> crates\oa-desktop\src\behavior\scenario\camera.rs:187:35
|
187 | let start = fit(bounds(), viewport.unwrap()).unwrap();
| ^^^^^^^^^^^^^^^^^
|
help: remove the `Some` and `unwrap()`
--> crates\oa-desktop\src\behavior\scenario\camera.rs:186:24
|
186 | let viewport = Some(Size::new(700., 500.));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.98.0/index.html#unnecessary_literal_unwrap
= note: `-D clippy::unnecessary-literal-unwrap` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::unnecessary_literal_unwrap)]`
error: used `unwrap()` on `Some` value
--> crates\oa-desktop\src\behavior\scenario\camera.rs:241:35
|
241 | let start = fit(bounds(), viewport.unwrap()).unwrap();
| ^^^^^^^^^^^^^^^^^
|
help: remove the `Some` and `unwrap()`
--> crates\oa-desktop\src\behavior\scenario\camera.rs:221:24
|
221 | let viewport = Some(Size::new(700., 500.));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.98.0/index.html#unnecessary_literal_unwrap
error: large size difference between variants
--> crates\oa-desktop\src\behavior\scenario\spacing\controller.rs:88:1
|
88 | / pub(crate) enum Finish {
89 | | Click(Id),
| | --------- the second-largest variant contains at least 16 bytes
90 | | Noop,
91 | |/ Commit {
92 | || command: Command,
93 | || selected: Id,
94 | || scale: f32,
95 | || pan: Vector,
96 | || },
| ||_____- the largest variant contains at least 380 bytes
97 | | }
| |__^ the entire enum is at least 384 bytes
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.98.0/index.html#large_enum_variant
= note: `-D clippy::large-enum-variant` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::large_enum_variant)]`
help: consider boxing the large fields or introducing indirection in some other way to reduce the total size of the enum
|
92 - command: Command,
92 + command: Box<Command>,
|
error: this `if` statement can be collapsed
--> crates\oa-desktop\src\behavior\scenario\usage\tests.rs:13:5
|
13 | / if let Some(steps) = p.elements.get_mut(&owner).unwrap().steps_mut() {
14 | | if !steps.contains(&id) {
15 | | steps.push(id);
16 | | }
17 | | }
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.98.0/index.html#collapsible_if
help: collapse nested if block
|
13 ~ if let Some(steps) = p.elements.get_mut(&owner).unwrap().steps_mut()
14 ~ && !steps.contains(&id) {
15 | steps.push(id);
16 ~ }
|
error: manual `!Range::contains` implementation
--> crates\oa-desktop\src\behavior.rs:687:33
|
687 | vec![if change < 2 || change >= 4 {
| ^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `!(2..4).contains(&change)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.98.0/index.html#manual_range_contains
error: could not compile `oa-desktop` (bin "arcadia-studio" test) due to 7 previous errors