ARCADIA-Studio/harness/experiments/save-as-diagnostics-20261001/final-review.md

Independent final #46 contribution review

Bounded contribution acceptance for source 0e83157e09d52e6152df91208e41693b62da2d46: no material correctness blocker found in the protected-destination diagnostic change or reviewed validation evidence. This is not integration, publication, packaged-release, full-suite, Linux or complete OA/SA acceptance. Prototype B native reading/performance remains unrelated and open.

Read-only source, helpers, logs, native report, phase receipts, actual files and parser-envelope audit. No GUI, compiler, server launch, Gitea action or production edit. This review file is the only new artifact. The original source review was delivered in chat; no earlier source-review file was found under this worktree's .local directory. Its E0308 finding is preserved in the failed log and contribution note.

Source and executable identity

Rechecked the committed diff and corrected helper. write_snapshot_inner changes only messages for Conflict from new_project and expect_new_file; those functions refuse already-existing destinations before writing. save_project still performs observed-baseline conflict checks and keeps its external-change message. Non-conflict errors, recovery discovery, disk expectations, no-overwrite checks, save transactions, source relocation/history and API behavior are unchanged. The earlier helper type mismatch is corrected by returning error.message after dispatch and preservation assertions.

Current native executable SHA256 is e9cce9355525ecdc59bfae12608b1e0272167acef5a86b25368ef547e08886ff; runtime is f45604a12e8bcd839fd86f667c1be1cc7c4f9da2b3c69ff381ac708f0e1ae7d4. Both actual files match baseline and final receipts. PID 10012 finished with exit 0; actual stdout/stderr files are empty. The report has 16 screenshots, numbered 00 through 15.

Gates and native scope

Corrected test log reports 29 passed, zero failures/ignores, 1,520 filtered out. E0308 from the first candidate remains in save-diagnostics-first-failed.log. Clippy and GUI build logs finish successfully; their invocation scope is parent-reported strict all-target Clippy and the GUI build, since these stdout logs do not reproduce command-line flags. No final full-suite pass is implied.

The independent native report records same-root/new-entry collision refusal, preserved unsaved name, accurate protected-files wording, full pointer tooltip at normal and minimum sizes, successful existing Save All, successful fresh-folder Save As, clean-document external-change refusal, and success after exact external-byte restoration. The persistent long footer truncates; pointer tooltip is readable. Keyboard-only tooltip access is untested. Clean B's All changes saved header describes lack of local edits, not successful disk save; the conflict footer remains explicit. No new blocking native defect was reported.

Independent byte and model reconciliation

Read oracle.py as code without executing its mutating injection/restoration phases. Independently enumerated all 37 pristine files, checked baseline hashes, and reconstructed only the predeclared literal replacement and valid appended comment. All eight phase receipts match those independently expected full filename/byte-hash sets:

• collision: all baseline bytes; no collision-copy.arcadia.
• saved-a and saved-c: only Assess pressure alarm to Assess pressure alarm QA46 for Activity 61f7bbfb-74a4-5540-9182-2583dfb27a49 in the declared dependency.
• external-before, restore and external-recovered: exact pristine bytes.
• inject and external-refused: only the declared valid comment added; other 36 files identical.

Actual final A and C directory contents independently equal the renamed expected bundle; actual final B equals pristine. Each contains exactly 37 files. C contains 30 application-written source files and seven parent-copied companions; no application-managed companion-copy claim is accepted. Intermediate refusal states are supported by retained checkpoint receipts/native sequence, not reconstructed as if still present on disk.

Independently reconciled the complete native-model-oracle input requests, output source bundles, full model envelopes and actual stored envelopes. Pristine input exactly matches the unchanged packaged example and repository baseline. Saved input exactly matches actual C. Both source_project responses equal their complete 30-file requests. Modifying only the pristine model's declared activity name to QA46 makes it equal to the entire saved model; every other model field remains unchanged. Both persisted server envelopes equal their captured GET responses.

Actual parser server hash 6cebacc117e46fdab023c6402a5cebd6929fb55993ae8ff6b89cd1c6c1170237 and selected runtime match oracle pins. The server is reused unchanged from the separate package, not claimed rebuilt with #46. Its owned forced termination exits 1 after acknowledged import/read; this is not graceful-shutdown or power-loss evidence.

Delivery follow-up

At review time, the untracked harness/save-as-diagnostics-20261001.md still says Clippy, GUI build and native checks are pending. Update that historical checkpoint with these completed, explicitly scoped receipts before using it as the final handoff. This documentation refresh and integration/publication confirmation remain the parent's responsibility; neither is claimed complete here.