ARCADIA-Studio/harness/experiments/analysis-public-read-20260925/LAUNCHER-REVIEW.md

Public mixed-read launcher review

Read-only pre-execution review. Gate helper SHA256 fcc8bc586a0fe708fb0af958b8523e14ab71db503d1e107013ce5dac884a5edd; CLI helper SHA256 25ec9ab5aa22d7364169772eae2cc10d508415fada9845a5fb7f115e7dd3f3e0. Both were parsed as Python AST without execution and compared with the actually used ordinary checkpoint helpers c0126c93... and 308fdd08.... The gate source pin remains the deliberately unusable pending marker; no source/artifact/runtime acceptance is implied.

Narrow finding

The gate now checks tracked and nonignored untracked cleanliness before Cargo, but its post-run checks cover only declared existing-file hashes, HEAD and helper bytes. A new nonignored source file created during the run would not enter changed_inputs, so the receipt could appear clean. The CLI helper does check full status again at the end. Record post-run git status --porcelain --untracked-files=all and make a nonempty result a gate verification/exit failure before claiming full clean-source binding throughout the run. This is a bounded orchestration correction, not an observed source change or application defect. Sent to parent before execution.

Reviewed behavior

• The new external target mixed_source8_read runs as a normal Cargo integration test, with actual nonzero unique listing, exact same-source runtime names, all outcomes passing and the same Cargo-reported target artifact. Seven ordinary target/filter pairs remain unchanged; source7 selection is exact. Removed obsolete ad hoc integration mode is not part of the selected gate plan.
• Doc listing must be nonempty and unique. Doc execution must produce precisely that name set, no ignored/failed outcome, and successful group summaries whose passed counts sum to the exact unique outcome count. Multiple rustdoc groups are permitted without accepting missing or duplicated names. No imaginary persistent doctest executable is required; Cargo/rustdoc source/input/toolchain/environment/raw output supplies this gate's binding. The actual installed rustdoc listing/output spelling still needs observation during the first parent run; a mismatch must be investigated rather than silently normalized.
• RUSTDOC, RUSTDOCFLAGS and CARGO_ENCODED_RUSTDOCFLAGS must be absent and are recorded alongside the prior environment. CLI compares its whole environment to its checked build receipt, inheriting these absent settings. Jobs1 is enforced; the caller still supplies and final review verifies the established incremental0/toolchain environment. No larger stack or lifecycle override is permitted.
• Every declared input is read against immutable Git bytes before launch and rehashed afterward; source/head and exact captured helper bytes are bound. CLI verifies its build manifest/log hashes, actual single binary bytes and declared input bytes before/between/after operations. Assertions, malformed output, timeout or missing files can terminate without a complete receipt; such a termination remains failed/incomplete evidence, never a pass.
• CLI changes from its verified predecessor are confined to output folder/stems and full-clean checks. Its independent three-file UTF-8/CRLF literals, complete expected before/after reports and unchanged filesystem checks are unchanged. Actual commands remain ordinary check and rename preview, neither with --write; no public mixed CLI support is established. The standalone public-API whole-model test remains distinct from CLI JSON reports.
• New gate doc modes and existing integration modes perform count/inventory checks themselves. Core list/focused/full still record rather than fully reconcile acceptance expectations; final independent runtime review must compare all prior names, intended new names, complete outcomes and actual artifacts. Format exit1 must retain its explicit inherited disposition rather than being reported as passing.

Disposition: suitable after the narrow post-run cleanliness correction and reviewed source pin. No helper, compiler, test, product executable or network operation was run by this review.

Corrected recorder binding

Revised gate SHA256 9088952ca3fabf56ab4434273bf55c6ec6eb6139bc2452a7be7c66a4409e420d now captures full post-Cargo porcelain status, records source_status_after, and exits nonzero if it is nonempty. AST parsing succeeds without executing the helper. The reported finding is resolved; final runtime reconciliation must require this field to be empty. CLI helper remains exact 25ec9ab5.... Source pin is still pending; the recorders are suitable to bind to the reviewed committed source before parent execution.