per-session models: every session owns its model + thinking level from birth

The reported bug (2026-09-28): every chat ran glm-5.3-flash regardless of
any pick, while composer and settings UIs agreed with each other and lied
about the run. Root cause: a fossil default-settings record (settings.json
chat section, frozen pre-slots-wave) was stamped verbatim into every new
chat at birth by the new-session flow, and resolveConversationSpec prefers
the per-chat record over the strong slot forever.

Owner redesign — models are per session, always; the strong slot is the
new-session default:

- POST /api/chats stamps the newborn verbatim from the strong slot
  (model + thinking level); no client settings PUT on create anymore
- the composer control is dual-bound: in-session it reads/writes the
  session's own record (GET /api/chats/:id, PUT .../settings); on the
  draft surfaces it binds the strong slot (picking there = changing the
  default)
- thinking levels follow the identical mechanics (confirmed by owner)
- the zombie default-settings system dies whole: useDefaultSettings,
  /api/settings/defaults, src/store/default-settings.ts, the chat
  section of UserSettings (sanitizer strips fossil copies), the legacy
  default-settings.json fold, and DEFAULT_SETTINGS_FILE
- catalogDefaultsFor collapses to the strong slot alone
- thinking display for a legacy unstamped session resolves exactly like
  the engine (session ?? strong ?? model ladder)

Tests: new chat-birth-stamp suite pins the stamp, the unconfigured boot,
the unset level, and the copy-not-live-view regression; defaults pins
rewritten strong-only; legacy-migration suite deleted.
This commit is contained in:
amosblomqvist
2026-09-28 23:30:11 +03:00
parent 1f5e21a674
commit 3e9a85d60f
27 changed files with 336 additions and 491 deletions
+4 -14
View File
@@ -83,20 +83,10 @@ export const POSITIONS_FILE = path.join(PATHS.graph, "positions.json");
*/
export const RENDER_SETTINGS_FILE = path.join(PATHS.graph, "render-settings.json");
/**
* DEFAULT settings — THE default model + thinking level + knowledge-context
* budget (owner, 2026-09-18): the new-session surfaces' controls are the
* settings page for the default model. There is NO baked-in default —
* BYOK first boot shows "no model" until the user picks one, and their
* last choice IS the default from then on. One small JSON blob,
* read-modify-write, written only through app/api/settings/defaults.
*/
export const DEFAULT_SETTINGS_FILE = path.join(DATA_ROOT, "default-settings.json");
/**
* THE USER SETTINGS RECORD (settings-storage wave, 2026-09-19): one
* versioned, DELTA-shaped JSON blob at the data-dir seam holding every
* non-secret product preference — general, chat defaults, agent (background
* non-secret product preference — general, agent (background
* model/thinking overrides + tool toggles + prompt-override switches),
* appearance, graph. Explicit user choices only: ABSENT keys resolve to the
* factory defaults compiled into src/core/settings.ts (FACTORY_SETTINGS), so
@@ -105,9 +95,9 @@ export const DEFAULT_SETTINGS_FILE = path.join(DATA_ROOT, "default-settings.json
* version field is a PRIVATE schema counter for breaking shape changes
* only (field renamed/meaning changed), unrelated to the app release
* version. Secrets (API keys, login tokens) NEVER live here — auth.json /
* .env.local keep that role. Migrated FROM: default-settings.json folds
* into the record's `chat` section on first read (the old file is left in
* place, inert).
* .env.local keep that role. (The `chat` default-settings section died
* with per-session models, owner 2026-09-28 — sessions own their model
* from birth, stamped from the strong slot.)
*/
export const SETTINGS_FILE = path.join(DATA_ROOT, "settings.json");