Wave-5 chunk B: three model slots, search-engine row, first-run setup flow

Chunk B (owner-designed, model-slots wave) on the merged engine surface
(main 1d66a17):

AGENT SECTION — SLOTS ONLY (owner ruling)
- The six per-role model rows are GONE; three slot rows instead:
  Strong (Prober + Teacher), Cheap (five workhorse roles), Vision
  (visual maker + PDF reader), roster + resolved-default in every hint.
- Slot dropdowns share the app's menu language over the FEDERATED
  catalog (/api/models = keyed providers only, fresh per call — saving
  a key in Keys immediately widens the picker); the vision slot
  filters to image-capable models (Model.input); the menu's highlight
  now matches provider+id (ids can collide across providers).
- Slots write the new models section (PUT /api/settings/models) through
  the dialog's write seam; per-role overrides stay schema-only.
- ModelMenuList rows read 'provider · id' — federation makes the
  provider bookkeeping-relevant. Usage stamps render provider-qualified
  (prettyModel(qualified): 'Glm 5.3 Flash · openrouter') in the stats
  bar's turn lines.

SEARCH ENGINE (search wave: no default, owner)
- A row in Tools: Tavily/Brave via the shared-menu look, Automatic =
  the pin removed (auto-activation). The live reason line comes from
  /api/search; no engine key at all grays the whole row + disables the
  trigger (a keyless choice would only block auto-activation).

FIRST-RUN SETUP FLOW (owner design A: composer CTA + send interception)
- Chats cannot start until all three slots are picked — no defaults
  for 33 providers (slotsConfigured: all three slot models required).
- The graph view's new-session dock (home) shows a 'Set up your models'
  CTA while unconfigured; submitting a topic opens the SetupDialog WITH
  THE DRAFT PRESERVED; Save stores the models section and the queued
  message sends. Same interception on /chat/new sends.
- STAGED BY DEPENDENCY (owner: keys first, models after): no keyed
  provider → stage 1 deep-links the settings dialog on Keys (open now
  takes a section); a saved key reopens at stage 2 on the next submit.
- Stage 2: Strong → Cheap → Vision pickers (federated, vision-filtered,
  all three required). Closable without configuring — browsing stays
  possible; the gate is the send, not the dialog. Layered Esc: an open
  slot menu eats Esc before the dialog.
- Two closure bugs caught live: onDone→start/send captured the stale
  pre-save 'configured' (the flow now forces the replayed send); menu-Esc
  used to close the whole dialog.

Settings-dialog provider: open(section?) lands on a section (stage 1
deep-link). Tests: composeSlotModel/composeSearchEngine pure, slot SSR
replacing role rows, slotsConfigured/setupStage first-run gates,
provider-qualified prettyModel. Gates: typecheck, lint, 792/792, build.
This commit is contained in:
amosblomqvist
2026-09-22 13:54:29 +03:00
parent 21d288e9f9
commit 48fbd988f1
15 changed files with 814 additions and 155 deletions
+49 -2
View File
@@ -4,6 +4,8 @@ import { useState } from "react";
import { useRouter } from "next/navigation";
import { CornerDownLeftIcon } from "lucide-react";
import { GraphView } from "@/components/graph-view";
import { SetupDialog } from "@/components/setup-dialog";
import { useSettingsDialog } from "@/components/settings/settings-dialog.tsx";
import { GraphContextControl, effectiveContextTokens } from "@/components/graph-context-control";
import { useDefaultSettings } from "@/components/default-settings";
import { DictationBar, useDictation } from "@/components/dictation";
@@ -17,9 +19,17 @@ import type { ChatSettings, TurnUsage } from "@/src/core";
* under the header and the new-session dock, both of which float over it
* with no gradient scrims. Sessions live in the toggleable sidebar.
*/
export function Home({ initialSettings }: { initialSettings: ChatSettings | null }) {
export function Home({ initialSettings, initialConfigured }: { initialSettings: ChatSettings | null; initialConfigured: boolean }) {
const router = useRouter();
const [topic, setTopic] = useState("");
// First-run gate (model-slots wave, owner 2026-09-20): chats cannot
// start until the user has picked all three slots — no defaults for
// 33 providers. The dock shows the CTA while unconfigured; submitting
// a topic opens the setup dialog WITH THE DRAFT PRESERVED (Save
// stores the slots and the queued message sends).
const [configured, setConfigured] = useState(initialConfigured);
const [setupOpen, setSetupOpen] = useState(false);
const { open: openSettings } = useSettingsDialog();
// Voice dictation (STT wave, 2026-09-17): finals append at the end of the
// topic draft; the strip lives in the stats bar's middle slot.
const dictation = useDictation({
@@ -34,9 +44,17 @@ export function Home({ initialSettings }: { initialSettings: ChatSettings | null
// defers its save when chatId is empty; see components/model-picker).
const { settings, save: saveDraft } = useDefaultSettings(initialSettings);
const start = async () => {
const start = async (force = false) => {
const t = topic.trim();
if (!t || busy) return;
// Unconfigured: the send INTERCEPTS into the setup flow (the draft
// stays in the textarea; Save completes and this re-runs). `force`
// is the onDone path — the state this closure captured is still
// the pre-save `configured`, the state update hasn't landed yet.
if (!configured && !force) {
setSetupOpen(true);
return;
}
setBusy(true);
try {
const res = await fetch("/api/chats", {
@@ -96,6 +114,18 @@ export function Home({ initialSettings }: { initialSettings: ChatSettings | null
px-4) so nothing shifts when a session starts (owner). */}
<div className="pointer-events-none absolute inset-x-0 bottom-0 pb-5">
<div className="pointer-events-auto mx-auto w-full max-w-[46rem] px-4">
{!configured && (
<div className="mb-2 flex justify-center">
<button
type="button"
data-testid="setup-cta"
onClick={() => setSetupOpen(true)}
className="rounded-sm border border-border bg-card px-3 py-1.5 font-ui text-xs text-foreground transition-colors hover:border-muted-foreground/50"
>
Set up your models — chats start after the three picks
</button>
</div>
)}
<form
className="flex items-end gap-1.5 rounded-2xl border bg-card p-1.5 shadow-lg"
onSubmit={(e) => {
@@ -155,6 +185,23 @@ export function Home({ initialSettings }: { initialSettings: ChatSettings | null
/>
</div>
</div>
{/* First-run setup (unconfigured): the CTA's target and the send
interception's landing surface. onDone replays the intercepted
draft; onOpenKeys deep-links the settings dialog (stage 1). */}
<SetupDialog
open={setupOpen}
onClose={() => setSetupOpen(false)}
onDone={() => {
setConfigured(true);
setSetupOpen(false);
void start(true); // the queued draft sends
}}
onOpenKeys={() => {
setSetupOpen(false);
openSettings("keys");
}}
/>
</div>
);
}
+49 -11
View File
@@ -9,6 +9,8 @@ import { GraphContextControl, effectiveContextTokens } from "@/components/graph-
import { useDefaultSettings } from "@/components/default-settings";
import { PhaseChip } from "@/components/phase-divider";
import { SidebarToggle } from "@/components/sidebar";
import { SetupDialog } from "@/components/setup-dialog";
import { useSettingsDialog } from "@/components/settings/settings-dialog.tsx";
import { StatsBar } from "@/components/stats-bar";
import type { ChatSettings } from "@/src/core";
@@ -148,7 +150,13 @@ export function DraftShell({
);
}
export function NewSession({ initialSettings }: { initialSettings: ChatSettings | null }) {
export function NewSession({
initialSettings,
initialConfigured,
}: {
initialSettings: ChatSettings | null;
initialConfigured: boolean;
}) {
const router = useRouter();
const [text, setText] = useState("");
const [busy, setBusy] = useState(false);
@@ -160,8 +168,22 @@ export function NewSession({ initialSettings }: { initialSettings: ChatSettings
// hands the choice up; it still rides the session POST then PUT-on-create.
const { settings, save: saveDraft } = useDefaultSettings(initialSettings);
const send = useCallback(() => {
// First-run gate (model-slots wave, owner 2026-09-20): the send
// INTERCEPTS into the setup flow while unconfigured — no defaults for
// 33 providers, chats cannot start. The draft stays in the textarea;
// Save completes and the send replays.
const [configured, setConfigured] = useState(initialConfigured);
const [setupOpen, setSetupOpen] = useState(false);
const { open: openSettings } = useSettingsDialog();
const send = useCallback((force = false) => {
if (!text.trim() || busy) return;
// `force` is the onDone path — the captured `configured` is still
// the pre-save value; the state update hasn't landed yet.
if (!configured && !force) {
setSetupOpen(true);
return;
}
setBusy(true);
void startDraftSession(text, settings, fetch)
.then((target) => {
@@ -169,16 +191,32 @@ export function NewSession({ initialSettings }: { initialSettings: ChatSettings
else setBusy(false);
})
.catch(() => setBusy(false));
}, [text, busy, settings, router]);
}, [text, busy, settings, router, configured]);
return (
<DraftShell
busy={busy}
text={text}
onChange={setText}
onSend={send}
settings={settings}
onSettingsSaved={saveDraft}
/>
<>
<DraftShell
busy={busy}
text={text}
onChange={setText}
onSend={send}
settings={settings}
onSettingsSaved={saveDraft}
/>
{/* First-run setup: the send interception's landing surface. */}
<SetupDialog
open={setupOpen}
onClose={() => setSetupOpen(false)}
onDone={() => {
setConfigured(true);
setSetupOpen(false);
send(true); // the queued draft sends
}}
onOpenKeys={() => {
setSetupOpen(false);
openSettings("keys");
}}
/>
</>
);
}
+252 -95
View File
@@ -1,28 +1,40 @@
"use client";
/**
* The Agent section (settings-app wave): background-role model overrides,
* the tool toggles, and the prompt override switches — three GROUPS
* (owner, 2026-09-20: clear separation — Models / Tools / System prompts),
* ONE section (PUT /api/settings/agent replaces the whole agent object,
* so every change composes models+tools+prompts together from the record).
* The Agent section (settings-app wave): the THREE MODEL SLOTS, the tool
* toggles + the search-engine preference, and the prompt override
* switches — three GROUPS (owner, 2026-09-20: clear separation — Models /
* Tools / System prompts).
*
* The role selects (owner, 2026-09-20) are the EXACT same dropdown as the
* chat model selector — the shared ModelMenuList/ThinkingMenuList from
* ./model-menu.tsx (fuzzy search, arrow-walk, Enter pick). The collapsed
* trigger keeps the thin select look; the opened menu is the model
* picker's. Menus open DOWNWARD here (the dialog sits mid-screen); the
* chat control opens upward — the shell belongs to each mount, the body
* is shared.
* Model slots (model-slots wave, 2026-09-20, owner ruling: SLOTS ONLY —
* the six per-role rows disappeared; per-role overrides remain in the
* schema for a future advanced surface): Strong = Prober + Teacher, Cheap
* = the five workhorse roles, Vision = Visual maker + PDF reader. Each
* slot row carries the shared dropdown (fuzzy search, arrow-walk, Enter
* pick — ModelMenuList/ThinkingMenuList from ./model-menu.tsx) over the
* FEDERATED catalog (/api/models serves only keyed providers, fresh per
* call — saving a key in Keys immediately widens this picker). The
* vision slot filters to image-capable models (Model.input). The slots
* live in the `models` settings section (PUT /api/settings/models — slot
* pins are engine-level, not per-chat); the rest of the section writes
* the `agent` section as before. Resolution per tier: slot override →
* factory pin (GET /api/models' `slots` — resolved, cannot drift from
* what runs). The Default row clears the slot override; a stored id stays
* VISIBLE even when its provider's key lapsed out of the catalog — a
* trigger showing "Default" over a live override would lie about the
* record.
*
* Search engine (search wave, 2026-09-20, owner: no default — an engine
* is live iff its key is present; with a key the engine AUTO-activates,
* the explicit choice is only a preference between live engines): a row
* in the Tools group, Tavily / Brave via the same shared-menu look, with
* the live reason line from /api/search. No engine key at all → the row
* grays whole-row (a choice without a key would only BLOCK the other
* engine's auto-activation).
*
* Tools — the owner's final list (2026-09-19): research, demo, visual, pdf.
* Absent key = enabled in the schema; the UI writes explicit booleans for
* all four (simpler to reason about, sanitize-equivalent).
*
* Models: each of the six background roles defaults to config.ts's pin
* (no override). The Default row clears the model override; the stored id
* stays VISIBLE even when the catalog no longer contains it — a trigger
* showing "Default" over a live override would lie about the record.
*
* Prompts: GET /api/settings/prompts segments; the switch requires an
* override FILE (route-enforced), so a file-less row dims whole-row
* (graph-view graying) until one is written. Switch state lives in this
@@ -32,22 +44,29 @@
import { useEffect, useRef, useState } from "react";
import { createPortal } from "react-dom";
import type React from "react";
import { BACKGROUND_MODEL_ROLES, type AgentSettings, type BackgroundModelRole, type ModelCatalogEntry } from "@/src/core";
import {
MODEL_SLOTS,
type AgentSettings,
type ModelCatalogEntry,
type ModelSlotName,
type ModelsSettings,
} from "@/src/core";
import type { ThinkingLevel } from "@earendil-works/pi-agent-core";
import { prettyModel } from "@/components/usage-format";
import { SettingsGroup, SettingsRow, Toggle } from "./controls.tsx";
import { ModelMenuList, ThinkingMenuList } from "./model-menu";
/** The role's display label — schema ids are camelCase, the label is human. */
const ROLE_LABEL: Record<BackgroundModelRole, string> = {
researcher: "Researcher",
demoBuilder: "Demo builder",
visualMaker: "Visual maker",
extractor: "Extractor",
auditor: "Auditor",
labeler: "Labeler",
/** One slot's display identity — the tier's roster as the row hint rides
* with the resolved default (owner: the hint ALWAYS names the default). */
const SLOT_META: Record<ModelSlotName, { label: string; roster: string }> = {
strong: { label: "Strong", roster: "Prober + Teacher" },
cheap: { label: "Cheap", roster: "Researcher, demo builder, extractor, auditor, labeler" },
vision: { label: "Vision", roster: "Visual maker + PDF reader" },
};
/** The search engines this wave ships (src/core/search.ts) + their labels. */
const SEARCH_ENGINES = ["tavily", "brave"] as const;
/** The owner's final toggleable-tool list (confirm with the user before
* changing — the Teacher stream settled this 2026-09-19). */
export const TOGGLE_TOOLS = ["research", "demo", "visual", "pdf"] as const;
@@ -63,30 +82,57 @@ interface SegmentInfo {
shared: boolean;
}
/** The GET /api/models response fields this section consumes. */
interface ModelsBody {
models: ModelCatalogEntry[];
/** The three tiers' RESOLVED pins (override → factory) — the honest
* "what runs now" the Default rows and hints speak from. */
slots: Record<ModelSlotName, { model: { provider: string; id: string }; thinkingLevel?: string }>;
}
/** Compose: one tool toggled, the rest of the section carried verbatim.
* Pure — exported for tests. */
export function composeTool(agent: AgentSettings | undefined, id: string, on: boolean): AgentSettings {
return { ...agent, tools: { ...agent?.tools, [id]: on } };
}
/** Compose: one role's model/thinking override. Empty model = absent
* override (Default); empty thinking = thinking falls back. Pure — tests. */
export function composeRoleModel(
agent: AgentSettings | undefined,
role: BackgroundModelRole,
modelId: string,
/** Compose: one slot's model/thinking override. Empty model = absent
* override (Default — falls to the factory pin); empty thinking = the
* tier keeps its resolved thinking budget. Per-field independence, same
* as the schema's ModelSlot. Pure — exported for tests. */
export function composeSlotModel(
models: ModelsSettings | undefined,
slot: ModelSlotName,
provider: string,
id: string,
thinking: string,
): AgentSettings {
const prev = agent?.models?.[role];
const models = { ...agent?.models };
if (!modelId && !thinking) delete models[role];
else {
models[role] = {
...(modelId ? { model: { provider: "openrouter", id: modelId } } : {}),
...(thinking ? { thinkingLevel: thinking as ThinkingLevel } : {}),
};
): ModelsSettings {
const prev = models?.[slot];
const next = { ...models };
if (!provider && !id && !thinking) {
delete next[slot];
return next;
}
return { ...agent, models };
next[slot] = {
...(provider && id ? { model: { provider, id } } : prev?.model ? { model: prev.model } : {}),
...(thinking ? { thinkingLevel: thinking as ThinkingLevel } : {}),
};
return next;
}
/** Compose: the search-engine preference. null = the explicit pin is
* REMOVED (auto-activation takes over — the schema's resting state).
* Pure — exported for tests. */
export function composeSearchEngine(
agent: AgentSettings | undefined,
engine: (typeof SEARCH_ENGINES)[number] | null,
): AgentSettings {
if (engine === null) {
if (!agent?.search) return { ...agent };
const { search: _drop, ...rest } = agent;
return { ...rest } as AgentSettings;
}
return { ...agent, search: { engine } };
}
/** Compose: one prompt switch. on = explicit true; off = key REMOVED
@@ -109,6 +155,7 @@ function MenuTrigger({
open,
onClick,
widthClass,
disabled,
}: {
value: string;
/** What the trigger shows when there is no override ("Default"). */
@@ -122,6 +169,8 @@ function MenuTrigger({
* the model trigger takes the same width as a MINIMUM — its values
* genuinely vary in length. */
widthClass: string;
/** The no-key search state grays the whole row; the trigger follows. */
disabled?: boolean;
}) {
return (
<button
@@ -129,8 +178,12 @@ function MenuTrigger({
aria-label={ariaLabel}
aria-expanded={open}
data-testid={testid}
onClick={onClick}
className={`flex h-7 items-center gap-1 rounded-sm border border-border bg-background px-1.5 font-ui text-xs text-foreground transition-colors hover:border-muted-foreground/50 ${widthClass}`}
onClick={() => {
if (!disabled) onClick();
}}
className={`flex h-7 items-center gap-1 rounded-sm border border-border bg-background px-1.5 font-ui text-xs text-foreground transition-colors ${
disabled ? "cursor-not-allowed" : "hover:border-muted-foreground/50"
} ${widthClass}`}
>
<span className="min-w-0 flex-1 truncate">{value || emptyLabel}</span>
<span aria-hidden className="text-muted-foreground">
@@ -191,39 +244,69 @@ function AnchoredMenu({
export function AgentSection({
agent,
models,
onSectionChange,
onModelsChange,
}: {
agent: AgentSettings | undefined;
/** The `models` section (slot pins — engine-level, PUT /api/settings/models). */
models: ModelsSettings | undefined;
/** Writes the composed WHOLE agent section (replace-PUT discipline). */
onSectionChange: (next: AgentSettings) => void;
/** Writes the composed models section (slots — replace-PUT discipline). */
onModelsChange: (next: ModelsSettings) => void;
}) {
const [catalog, setCatalog] = useState<ModelCatalogEntry[] | null>(null);
/** The config-pinned model per background role — GET /api/models'
* rolePins (Platform stream, landing as a standalone commit; master
* routing 2026-09-20). Optional here: until the rebase the rows read
* "Default: config pin" and light up the moment the field arrives. */
const [rolePins, setRolePins] = useState<Record<string, { model: { provider: string; id: string }; thinkingLevel?: string }> | null>(null);
/** The three tiers' resolved pins — GET /api/models `slots`. The rows'
* Default hints and thinking lists resolve from it. */
const [slots, setSlots] = useState<ModelsBody["slots"] | null>(null);
/** The live search state (/api/search) — the row's reason line. */
const [search, setSearch] = useState<{ available: boolean; engine: string | null; reason: string } | null>(null);
/** Which search engines have a key (/api/keys) — the no-keys-anywhere
* state grays the row; per-engine marks ride the menu rows. */
const [engineKeys, setEngineKeys] = useState<Partial<Record<(typeof SEARCH_ENGINES)[number], boolean>>>({});
const [prompts, setPrompts] = useState<{ prober: SegmentInfo[]; teacher: SegmentInfo[] } | null>(null);
const [openSegment, setOpenSegment] = useState<string | null>(null);
const [segmentDraft, setSegmentDraft] = useState<Record<string, string>>({});
const [segmentStatus, setSegmentStatus] = useState<string | null>(null);
/** One open dropdown for the whole section: which role, which kind. */
const [openMenu, setOpenMenu] = useState<{ role: BackgroundModelRole; kind: "model" | "thinking" } | null>(null);
/** One open dropdown for the whole section: which slot (or the search
* row), which kind. */
const [openMenu, setOpenMenu] = useState<{ target: ModelSlotName | "search"; kind: "model" | "thinking" | "engine" } | null>(null);
const menuAnchorRef = useRef<HTMLSpanElement>(null);
// The catalog + the prompt segments — one fetch each per section mount.
const refreshSearch = () =>
fetch("/api/search")
.then((r) => r.json())
.then((body: { available: boolean; engine: string | null; reason: string }) => setSearch(body))
.catch(() => setSearch(null));
// The catalog (federated: keyed providers only), the resolved slots,
// the prompt segments, and the search engines' key presence — one
// fetch each per section mount.
useEffect(() => {
fetch("/api/models")
.then((r) => r.json())
.then((body: { models: ModelCatalogEntry[]; rolePins?: Record<string, { model: { provider: string; id: string }; thinkingLevel?: string }> }) => {
.then((body: ModelsBody) => {
setCatalog(body.models);
if (body.rolePins) setRolePins(body.rolePins);
setSlots(body.slots);
})
.catch(() => setCatalog(null));
fetch("/api/settings/prompts")
.then((r) => r.json())
.then((body: { prober: SegmentInfo[]; teacher: SegmentInfo[] }) => setPrompts(body))
.catch(() => setPrompts(null));
refreshSearch();
fetch("/api/keys")
.then((r) => r.json())
.then((body: { keys: { id: string; present: boolean }[] }) => {
const present: Partial<Record<(typeof SEARCH_ENGINES)[number], boolean>> = {};
for (const id of SEARCH_ENGINES) {
const envVar = id === "tavily" ? "TAVILY_API_KEY" : "BRAVE_API_KEY";
present[id] = body.keys.some((k) => k.id === envVar && k.present);
}
setEngineKeys(present);
})
.catch(() => {});
}, []);
// The dropdown contract (the chat model selector's, mirrored): any
@@ -256,8 +339,7 @@ export function AgentSection({
};
}, [openMenu]);
async function saveSegment(path: string, text: string) {
setSegmentStatus(null);
async function saveSegment(path: string, text: string) { setSegmentStatus(null);
const res = await fetch(`/api/settings/prompts/${path}`, {
method: "PUT",
headers: { "content-type": "application/json" },
@@ -287,7 +369,7 @@ export function AgentSection({
}
/** The pinned Default row — clears this control's override (absent key
* = config pin). Same row language as the shared menu's list rows. */
* = the factory pin). Same row language as the shared menu's list rows. */
const defaultRow = (active: boolean, onPick: () => void) => (
<button
type="button"
@@ -302,6 +384,29 @@ export function AgentSection({
</button>
);
/** The search-engine menu row — label + the quiet live-key mark. */
const engineOption = (
id: (typeof SEARCH_ENGINES)[number] | "auto",
label: string,
active: boolean,
live: boolean | null,
onPick: () => void,
) => (
<button
type="button"
data-testid={`engine-option-${id}`}
onClick={onPick}
className={`flex w-full items-center justify-between rounded-lg px-2 py-1.5 text-left transition-colors hover:bg-muted ${
active ? "bg-muted/60 text-card-foreground" : "text-card-foreground"
}`}
>
<span>{label}</span>
<span className="text-muted-foreground">
{live === null ? (active && <span aria-hidden>✓</span>) : live ? <span aria-hidden>✓ key</span> : <span aria-hidden>· no key</span>}
</span>
</button>
);
const segmentRow = (info: SegmentInfo) => {
const fileExists = info.overrideText !== null;
const open = openSegment === info.path;
@@ -378,35 +483,36 @@ export function AgentSection({
);
};
return (
<>
<SettingsGroup label="Models" testid="group-models">
{BACKGROUND_MODEL_ROLES.map((role) => {
const override = agent?.models?.[role];
{MODEL_SLOTS.map((slot) => {
const override = models?.[slot];
const modelId = override?.model?.id ?? "";
const provider = override?.model?.provider ?? "";
const thinking = override?.thinkingLevel ?? "";
// The tier's resolved pin (override → factory): the Default
// hint names it; the thinking list resolves from its levels.
const pin = slots?.[slot];
const defaultName = pin ? prettyModel(pin.model.id) : "config pin";
// The model whose levels govern the thinking list: the
// override, else the config pin (rolePins makes the
// default's levels resolvable when it's in the catalog);
// the standard ladder as the last fallback.
const effectiveId = modelId || rolePins?.[role]?.model.id || "";
const chosen = catalog?.find((m) => m.id === effectiveId);
// override, else the resolved pin (when it's in the federated
// catalog); the standard ladder as the last fallback.
const coord = override?.model ?? pin?.model;
const chosen = coord ? catalog?.find((m) => m.id === coord.id && m.provider === coord.provider) : undefined;
const levels = chosen ? chosen.supportedLevels : THINKING_LEVELS;
// The row ALWAYS names the default (owner, 2026-09-20: the
// old "config pin applies" hint said nothing). rolePins
// carries the resolved default; the fallback reads until
// Platform's rolePins lands on main.
const defaultName = rolePins?.[role]?.model.id
? prettyModel(rolePins[role].model.id)
: "config pin";
const thisMenuOpen =
openMenu?.role === role ? openMenu.kind : null;
const thisMenuOpen = openMenu?.target === slot ? openMenu.kind : null;
// Vision slots pick from image-capable models only.
const slotCatalog =
slot === "vision" ? catalog?.filter((m) => m.input.includes("image")) : catalog;
return (
<SettingsRow
key={role}
label={ROLE_LABEL[role]}
hint={`Default: ${defaultName}`}
testid={`role-row-${role}`}
key={slot}
label={SLOT_META[slot].label}
hint={`${SLOT_META[slot].roster} · default: ${defaultName}`}
testid={`slot-row-${slot}`}
>
{/* The anchor for the outside-click contract is the
span holding BOTH triggers of the open menu. */}
@@ -417,55 +523,60 @@ export function AgentSection({
<MenuTrigger
value={modelId ? prettyModel(modelId) : ""}
emptyLabel="Default"
ariaLabel={`${ROLE_LABEL[role]} model`}
testid={`role-model-${role}`}
ariaLabel={`${SLOT_META[slot].label} model`}
testid={`slot-model-${slot}`}
open={thisMenuOpen === "model"}
onClick={() => setOpenMenu(thisMenuOpen === "model" ? null : { role, kind: "model" })}
onClick={() => setOpenMenu(thisMenuOpen === "model" ? null : { target: slot, kind: "model" })}
widthClass="min-w-20"
/>
<MenuTrigger
value={thinking}
emptyLabel="Default"
ariaLabel={`${ROLE_LABEL[role]} thinking`}
testid={`role-thinking-${role}`}
ariaLabel={`${SLOT_META[slot].label} thinking`}
testid={`slot-thinking-${slot}`}
open={thisMenuOpen === "thinking"}
onClick={() => setOpenMenu(thisMenuOpen === "thinking" ? null : { role, kind: "thinking" })}
onClick={() => setOpenMenu(thisMenuOpen === "thinking" ? null : { target: slot, kind: "thinking" })}
widthClass="w-20"
/>
{thisMenuOpen === "model" && (
<AnchoredMenu
anchorTestid={`role-model-${role}`}
testid={`role-model-menu-${role}`}
anchorTestid={`slot-model-${slot}`}
testid={`slot-model-menu-${slot}`}
menuClass="flex w-[22rem] flex-col rounded-xl border border-border bg-card p-2 text-xs shadow-xl"
>
{defaultRow(
modelId === "",
() => {
onSectionChange(composeRoleModel(agent, role, "", thinking));
onModelsChange(composeSlotModel(models, slot, "", "", thinking));
setOpenMenu(null);
},
)}
<ModelMenuList
models={catalog ?? undefined}
effectiveId={modelId || undefined}
models={slotCatalog ?? undefined}
effectiveId={modelId || pin?.model.id}
effectiveProvider={provider || pin?.model.provider}
onPick={(entry) => {
onSectionChange(composeRoleModel(agent, role, entry.id, thinking));
onModelsChange(composeSlotModel(models, slot, entry.provider, entry.id, thinking));
setOpenMenu(null);
}}
footer="Applied to every run of this role"
footer={
catalog && catalog.length === 0
? "No models — add a provider key in Keys"
: "Runs every agent of this tier"
}
/>
</AnchoredMenu>
)}
{thisMenuOpen === "thinking" && (
<AnchoredMenu
anchorTestid={`role-thinking-${role}`}
testid={`role-thinking-menu-${role}`}
anchorTestid={`slot-thinking-${slot}`}
testid={`slot-thinking-menu-${slot}`}
menuClass="flex w-44 flex-col gap-0.5 rounded-xl border border-border bg-card p-2 text-xs shadow-xl"
>
{defaultRow(
thinking === "",
() => {
onSectionChange(composeRoleModel(agent, role, modelId, ""));
onModelsChange(composeSlotModel(models, slot, provider, modelId, ""));
setOpenMenu(null);
},
)}
@@ -473,7 +584,7 @@ export function AgentSection({
levels={levels.map(String)}
effectiveLevel={thinking || undefined}
onPick={(level) => {
onSectionChange(composeRoleModel(agent, role, modelId, level));
onModelsChange(composeSlotModel(models, slot, provider, modelId, level));
setOpenMenu(null);
}}
/>
@@ -495,6 +606,52 @@ export function AgentSection({
/>
</SettingsRow>
))}
{(() => {
const engine = agent?.search?.engine ?? null;
const anyKey = engineKeys.tavily === true || engineKeys.brave === true;
const open = openMenu?.target === "search";
return (
<SettingsRow
label="Search engine"
hint={search?.reason ?? undefined}
testid="search-engine-row"
dimmed={!anyKey}
>
<span ref={open ? menuAnchorRef : undefined} className="relative flex items-center gap-2">
<MenuTrigger
value={engine === "tavily" ? "Tavily" : engine === "brave" ? "Brave" : ""}
emptyLabel="Automatic"
ariaLabel="Search engine"
testid="search-engine-trigger"
open={open}
onClick={() => setOpenMenu(open ? null : { target: "search", kind: "engine" })}
widthClass="min-w-20"
disabled={!anyKey}
/>
{open && (
<AnchoredMenu
anchorTestid="search-engine-trigger"
testid="search-engine-menu"
menuClass="flex w-44 flex-col gap-0.5 rounded-xl border border-border bg-card p-2 text-xs shadow-xl"
>
{engineOption("auto", "Automatic", engine === null, null, () => {
onSectionChange(composeSearchEngine(agent, null));
setOpenMenu(null);
refreshSearch();
})}
{SEARCH_ENGINES.map((id) =>
engineOption(id, id === "tavily" ? "Tavily" : "Brave", engine === id, engineKeys[id] ?? false, () => {
onSectionChange(composeSearchEngine(agent, id));
setOpenMenu(null);
refreshSearch();
}),
)}
</AnchoredMenu>
)}
</span>
</SettingsRow>
);
})()}
</SettingsGroup>
<SettingsGroup label="System prompts" testid="group-prompts">
@@ -516,4 +673,4 @@ export function AgentSection({
</SettingsGroup>
</>
);
}
}
+8 -2
View File
@@ -31,6 +31,7 @@ function priceLabel(cost: ModelCatalogEntry["cost"]): string {
export function ModelMenuList({
models,
effectiveId,
effectiveProvider,
onPick,
footer,
}: {
@@ -38,6 +39,11 @@ export function ModelMenuList({
models: ModelCatalogEntry[] | undefined;
/** Currently effective id (the row gets the quiet highlight). */
effectiveId: string | undefined;
/** The effective id's provider (model-slots wave: the catalog
* federates multiple providers and ids can collide across them —
* the highlight must match BOTH coordinates or it lands on the
* wrong row). */
effectiveProvider?: string;
/** Receives the chosen entry. */
onPick: (entry: ModelCatalogEntry) => void;
/** Quiet footer note under the list (context-specific). */
@@ -111,7 +117,7 @@ export function ModelMenuList({
onClick={() => onPick(m)}
className={`flex w-full flex-col gap-0.5 rounded-lg px-2 py-1.5 text-left outline-none transition-colors hover:bg-muted ${
i === menuIdx ? "bg-accent/40 ring-1 ring-inset ring-border" : ""
}${m.id === effectiveId && i !== menuIdx ? " bg-muted/60" : ""}`}
}${m.id === effectiveId && m.provider === (effectiveProvider ?? m.provider) && i !== menuIdx ? " bg-muted/60" : ""}`}
>
<span className="flex items-center justify-between gap-2">
<span className="truncate text-card-foreground">{m.name}</span>
@@ -120,7 +126,7 @@ export function ModelMenuList({
</span>
</span>
<span className="flex items-center justify-between gap-2 text-muted-foreground">
<span className="truncate">{m.id}</span>
<span className="truncate">{m.provider} · {m.id}</span>
<span className="shrink-0 tabular-nums">{formatTokens(m.contextWindow)}</span>
</span>
</button>
+26 -9
View File
@@ -39,6 +39,7 @@ import {
import { useAppearance } from "./appearance.tsx";
import { SettingsSection, SettingsRow, Toggle } from "./controls.tsx";
import { AgentSection } from "./agent-section.tsx";
import type { ModelsSettings } from "@/src/core";
import { KeysSection } from "./keys-section.tsx";
import { AppearanceSection, GraphSection } from "./appearance-section.tsx";
import { KeyboardSection } from "./keyboard-section.tsx";
@@ -56,20 +57,26 @@ const SECTIONS = [
] as const;
type SectionId = (typeof SECTIONS)[number]["id"];
const DialogContext = createContext<{ open: () => void }>({ open: () => {} });
const DialogContext = createContext<{ open: (section?: string) => void }>({ open: () => {} });
/** AppShell-level mount: the sidebar row and the mod+, chord call this. */
/** AppShell-level mount: the sidebar row and the mod+, chord call this.
* `open(section)` lands the dialog on a specific section (the first-run
* setup flow deep-links to Keys when no provider key exists yet). */
export function SettingsDialogProvider({
children,
}: {
children: React.ReactNode;
}) {
const [show, setShow] = useState(false);
const open = useCallback(() => setShow(true), []);
const [landOn, setLandOn] = useState<SectionId>("general");
const open = useCallback((section?: string) => {
if (section) setLandOn(section as SectionId);
setShow(true);
}, []);
return (
<DialogContext.Provider value={{ open }}>
{children}
{show && <SettingsDialog onClose={() => setShow(false)} />}
{show && <SettingsDialog onClose={() => setShow(false)} initialSection={landOn} />}
</DialogContext.Provider>
);
}
@@ -78,7 +85,7 @@ export function useSettingsDialog() {
return useContext(DialogContext);
}
function SettingsDialog({ onClose }: { onClose: () => void }) {
function SettingsDialog({ onClose, initialSection }: { onClose: () => void; initialSection: SectionId }) {
// Plain dim backdrop (no blur — nothing decorative); the click
// closes, the dialog body stops propagation.
return createPortal(
@@ -87,7 +94,7 @@ function SettingsDialog({ onClose }: { onClose: () => void }) {
data-testid="settings-backdrop"
onClick={onClose}
>
<SettingsDialogBody onClose={onClose} />
<SettingsDialogBody onClose={onClose} initialSection={initialSection} />
</div>,
document.body,
);
@@ -95,13 +102,19 @@ function SettingsDialog({ onClose }: { onClose: () => void }) {
/** The dialog without the portal/backdrop — the SSR-testable frame
* (portals render nothing under renderToStaticMarkup). */
export function SettingsDialogBody({ onClose }: { onClose: () => void }) {
export function SettingsDialogBody({
onClose,
initialSection = "general",
}: {
onClose: () => void;
initialSection?: SectionId;
}) {
const { onAppearanceChange } = useAppearance();
const [record, setRecord] = useState<UserSettings | null | undefined>(
undefined,
);
const [error, setError] = useState<string | null>(null);
const [active, setActive] = useState<SectionId>("general");
const [active, setActive] = useState<SectionId>(initialSection);
// Fetch once per dialog mount. 200 {settings: null} is FIRST BOOT
// (no record = factory everything), not a failure — the error state is
@@ -133,7 +146,7 @@ export function SettingsDialogBody({ onClose }: { onClose: () => void }) {
* schema mistake caught by the validation surface). */
const write = useCallback(
async (
section: "general" | "agent" | "appearance" | "graph",
section: "general" | "agent" | "models" | "appearance" | "graph",
body: object,
) => {
setError(null);
@@ -271,6 +284,10 @@ export function SettingsDialogBody({ onClose }: { onClose: () => void }) {
>
<AgentSection
agent={record.agent}
models={record.models}
onModelsChange={(next: ModelsSettings) =>
void write("models", next)
}
onSectionChange={(next: AgentSettings) =>
void write("agent", next)
}
+261
View File
@@ -0,0 +1,261 @@
"use client";
/**
* The first-run setup flow (model-slots wave, 2026-09-20, owner design
* "A — composer CTA + send interception"): chats cannot start until the
* user has picked all three model slots — there are no defaults for 33
* providers. The graph view's new-session dock (the app's home, where
* chats start) shows a "Set up your models" CTA while unconfigured;
* submitting a topic — or sending on /chat/new — opens THIS dialog with
* the draft preserved; Save stores the slots and the queued message
* sends.
*
* STAGED BY DEPENDENCY (owner, 2026-09-20: "first keys, then models —
* there's no point presenting the model picker before the user has set a
* key because there are no models to pick then"):
* Stage 1 — no keyed provider: "add a provider key first" + a button
* that deep-links the settings dialog on Keys. The draft lives in
* the caller's state, untouched; after the key lands the next
* submit/CTA click reopens here at stage 2 (the /api/models check is
* fresh per open — saving a key immediately widens the pickers).
* Stage 2 — Strong → Cheap → Vision pickers over the FEDERATED catalog
* (keyed providers only), the vision slot filtered to image-capable
* models, in the app's shared dropdown language (ModelMenuList).
* All three required (owner: no skip, no defaults); Save PUTs the
* models section and reports onDone(models).
*
* Closable without configuring (Esc/backdrop/✕) — browsing the app stays
* possible; the GATE is the send interception, not the dialog. The
* settings-dialog visual language: dim backdrop, border rounded-md card,
* CMU title, z-50.
*/
import { useEffect, useState } from "react";
import { createPortal } from "react-dom";
import type React from "react";
import { type ModelCatalogEntry, type ModelSlotName, type ModelsSettings } from "@/src/core";
import { prettyModel } from "@/components/usage-format";
import { ModelMenuList } from "@/components/settings/model-menu";
/** The pickers' slot identity — same roster language as the Agent
* section's slot rows. */
const SLOT_META: Record<ModelSlotName, { label: string; roster: string }> = {
strong: { label: "Strong", roster: "Prober + Teacher" },
cheap: { label: "Cheap", roster: "Researcher, demo builder, extractor, auditor, labeler" },
vision: { label: "Vision", roster: "Visual maker + PDF reader" },
};
const SLOT_ORDER: readonly ModelSlotName[] = ["strong", "cheap", "vision"];
/** The GET /api/models response fields the flow consumes. */
interface ModelsBody {
models: ModelCatalogEntry[];
providers: { id: string; keyPresent: boolean }[];
}
/** Pure: which stage the flow opens at — no keyed provider = keys first
* (owner's dependency ordering). Exported for tests. */
export function setupStage(
providers: { id: string; keyPresent: boolean }[] | null,
): "keys" | "pickers" {
if (providers === null) return "keys"; // fetch failed → the honest fallback
return providers.some((p) => p.keyPresent) ? "pickers" : "keys";
}
export function SetupDialog({
open,
onClose,
/** Saved: the models section landed; the caller marks configured and
* replays the intercepted draft. */
onDone,
/** Deep-link to the Keys section ("add a provider key first"). */
onOpenKeys,
}: {
open: boolean;
onClose: () => void;
onDone: (models: ModelsSettings) => void;
onOpenKeys: () => void;
}) {
const [body, setBody] = useState<ModelsBody | null>(null);
const [failed, setFailed] = useState(false);
const [picked, setPicked] = useState<Partial<Record<ModelSlotName, ModelCatalogEntry>>>({});
const [saving, setSaving] = useState(false);
const [error, setError] = useState<string | null>(null);
const [openSlot, setOpenSlot] = useState<ModelSlotName | null>(null);
// Fresh /api/models per open — a key saved a moment ago (stage 1 →
// Keys → back) widens the pickers immediately, no restart.
useEffect(() => {
if (!open) return;
setPicked({});
setError(null);
fetch("/api/models")
.then((r) => r.json())
.then((b: ModelsBody) => {
setBody(b);
setFailed(false);
})
.catch(() => setFailed(true));
}, [open]);
// Esc + outside-click — layered dismissal, closable WITHOUT
// configuring (browsing stays possible; the gate is the send
// interception, not this dialog). An open slot menu eats Esc first
// (and any click outside it); only a bare Esc closes the dialog.
useEffect(() => {
if (!open) return;
const onKey = (e: KeyboardEvent) => {
if (e.key !== "Escape") return;
if (openSlot !== null) setOpenSlot(null);
else onClose();
};
const onPointerDown = (e: PointerEvent) => {
if (openSlot === null) return;
const t = e.target as Element;
if (t.closest("[data-lh-menu]") || t.closest(`[data-testid="setup-trigger-${openSlot}"]`)) return;
setOpenSlot(null);
};
window.addEventListener("keydown", onKey);
document.addEventListener("pointerdown", onPointerDown);
return () => {
window.removeEventListener("keydown", onKey);
document.removeEventListener("pointerdown", onPointerDown);
};
}, [open, onClose, openSlot]);
if (!open) return null;
const stage = failed ? "keys" : setupStage(body ? body.providers : null);
const allPicked = SLOT_ORDER.every((s) => picked[s]);
async function save() {
if (!allPicked || saving) return;
setSaving(true);
setError(null);
const models: ModelsSettings = {};
for (const slot of SLOT_ORDER) models[slot] = { model: { provider: picked[slot]!.provider, id: picked[slot]!.id } };
const res = await fetch("/api/settings/models", {
method: "PUT",
headers: { "content-type": "application/json" },
body: JSON.stringify(models),
}).catch(() => null);
if (!res || !res.ok) {
setSaving(false);
setError(res ? `Save failed: ${(await res.json().catch(() => ({}))).error ?? res.status}` : "Save failed — network");
return;
}
onDone(models);
}
return createPortal(
<div
className="fixed inset-0 z-50 flex items-center justify-center bg-background/80"
data-testid="setup-backdrop"
onClick={onClose}
>
<div
role="dialog"
aria-modal="true"
aria-label="Set up your models"
data-testid="setup-dialog"
className="settings-dialog-pop flex max-h-[85vh] w-[640px] max-w-[90vw] flex-col overflow-hidden rounded-md border border-border bg-card shadow-xl"
onClick={(e) => e.stopPropagation()}
>
<header className="flex h-15 shrink-0 items-center gap-3 border-b border-border px-5">
<h2 className="font-title text-2xl tracking-tight">Set up your models</h2>
<button
type="button"
aria-label="Close setup"
data-testid="setup-close"
onClick={onClose}
className="ml-auto text-muted-foreground transition-colors hover:text-foreground"
>
✕
</button>
</header>
{stage === "keys" ? (
<div className="flex flex-col gap-3 px-6 py-5" data-testid="setup-stage-keys">
<p className="text-sm text-foreground">
{failed ? "Model catalog could not be loaded — check the connection and retry." : "First, add a provider key."}
</p>
<p className="text-xs text-muted-foreground">
The model pickers list only what your keys unlock — there is nothing to pick until one exists.
</p>
<div>
<button
type="button"
data-testid="setup-open-keys"
onClick={onOpenKeys}
className="rounded-sm border border-border bg-background px-3 py-1.5 font-ui text-xs text-foreground transition-colors hover:border-muted-foreground/50"
>
Open Keys settings
</button>
</div>
</div>
) : (
<div className="flex flex-col gap-4 overflow-y-auto px-6 py-5" data-testid="setup-stage-pickers">
<p className="text-xs text-muted-foreground">
Pick the model for each tier — all three are required before chats can start.
</p>
{SLOT_ORDER.map((slot) => {
const entry = picked[slot];
const catalog =
slot === "vision" ? body?.models.filter((m) => m.input.includes("image")) : body?.models;
return (
<div key={slot} data-testid={`setup-slot-${slot}`} className="flex flex-col gap-1.5">
<span className="font-ui text-sm text-foreground">{SLOT_META[slot].label}</span>
<span className="text-xs text-muted-foreground/70">{SLOT_META[slot].roster}</span>
<div className="relative">
<button
type="button"
aria-label={`${SLOT_META[slot].label} model`}
data-testid={`setup-trigger-${slot}`}
aria-expanded={openSlot === slot}
onClick={() => setOpenSlot(openSlot === slot ? null : slot)}
className="flex h-7 min-w-40 items-center gap-1 rounded-sm border border-border bg-background px-1.5 font-ui text-xs text-foreground transition-colors hover:border-muted-foreground/50"
>
<span className="min-w-0 flex-1 truncate">{entry ? prettyModel(entry.id) : "Pick a model…"}</span>
<span aria-hidden className="text-muted-foreground">
▾
</span>
</button>
{openSlot === slot && (
<div
data-testid={`setup-menu-${slot}`}
data-lh-menu=""
className="absolute top-full left-0 z-40 flex max-h-96 w-[22rem] flex-col rounded-xl border border-border bg-card p-2 text-xs shadow-xl"
>
<ModelMenuList
models={catalog}
effectiveId={entry?.id}
effectiveProvider={entry?.provider}
onPick={(m) => {
setPicked((prev) => ({ ...prev, [slot]: m }));
setOpenSlot(null);
}}
footer={catalog && catalog.length === 0 ? "No image-capable models — widen the provider keys" : undefined}
/>
</div>
)}
</div>
</div>
);
})}
<div className="flex items-center gap-3">
<button
type="button"
data-testid="setup-save"
disabled={!allPicked || saving}
onClick={() => void save()}
className="rounded-sm border border-border bg-background px-3 py-1.5 font-ui text-xs text-foreground transition-colors hover:border-muted-foreground/50 disabled:cursor-not-allowed disabled:opacity-40"
>
{saving ? "Saving…" : "Save models"}
</button>
{error && <p className="text-xs text-red-400">{error}</p>}
</div>
</div>
)}
</div>
</div>,
document.body,
);
}
+1 -1
View File
@@ -491,7 +491,7 @@ function SessionsSidebar() {
<div className="px-3 pb-3 pt-1">
<button
type="button"
onClick={openSettings}
onClick={() => openSettings()}
data-testid="settings-entry"
className="flex items-center gap-1.5 rounded-md px-2 py-1.5 text-xs uppercase tracking-wider text-muted-foreground transition-colors hover:bg-accent hover:text-foreground"
>
+1 -1
View File
@@ -153,7 +153,7 @@ export function StatsBar({
return (
<li key={`${turn.messageId}-${i}`} className="flex items-center justify-between gap-2">
<span className="truncate text-muted-foreground">
#{i + 1} · {prettyModel(turn.model)}
#{i + 1} · {prettyModel(turn.model, true)}
</span>
<span className="flex shrink-0 items-center gap-2 tabular-nums text-card-foreground">
<span className="text-muted-foreground">{turn.steps.length} steps</span>
+19 -3
View File
@@ -15,14 +15,30 @@ export function formatTokens(n: number): string {
return String(n);
}
/** Split a provider-qualified stamp "provider:id" (the usage contracts'
* qualification, model-slots wave 2026-09-20) into its two coordinates.
* No colon = no provider qualification (a bare catalog id). */
export function splitQualified(id: string): { provider: string | null; id: string } {
const colon = id.indexOf(":");
if (colon === -1) return { provider: null, id };
return { provider: id.slice(0, colon), id: id.slice(colon + 1) };
}
/**
* "z-ai/glm-5.3-flash" → "Glm 5.3 Flash" — vendor prefix dropped, dashes to
* spaces, capitalized; a trailing all-digit segment (OpenRouter's date
* suffix, "qwen3.8-max-0902") is dropped. Quiet-chip friendly.
*
* With `qualified` (usage stamps are "provider:id", model-slots wave):
* the provider rides as a quiet suffix — "Glm 5.3 Flash · openrouter" —
* because with federation the same model via two providers is genuinely
* different bookkeeping. Bare catalog ids are unchanged.
*/
export function prettyModel(id: string): string {
const short = id.includes("/") ? id.slice(id.lastIndexOf("/") + 1) : id;
export function prettyModel(id: string, qualified = false): string {
const { provider, id: bare } = splitQualified(id);
const short = bare.includes("/") ? bare.slice(bare.lastIndexOf("/") + 1) : bare;
const parts = short.split("-");
const trimmed = /^\d+$/.test(parts[parts.length - 1] ?? "") ? parts.slice(0, -1) : parts;
return trimmed.map((p) => p.charAt(0).toUpperCase() + p.slice(1)).join(" ");
const pretty = trimmed.map((p) => p.charAt(0).toUpperCase() + p.slice(1)).join(" ");
return qualified && provider ? `${pretty} · ${provider}` : pretty;
}