fix: keep research available without search keys

This commit is contained in:
amosblomqvist
2026-10-24 06:52:36 +03:00
parent 6cba9c8c5a
commit 4bd20be529
11 changed files with 277 additions and 129 deletions
+14 -21
View File
@@ -23,11 +23,9 @@ export interface JobToolContext {
* input rides along because the spawn happens MID-STREAM, before
* onFinish persists the tool part — a transcript scan would race it. */
spawn: (job: JobRecord, input: ResearchInput | DemoInput | VisualInput | PdfInput) => void;
/** Search availability (search port wave, 2026-09-20): the honest
* disable signal for the research dispatch tool — no live engine
* means NO research tool in the registry (owner decision: registry-
* level drop, no doomed dispatch, no silent fallback). Absent =
* available (tests + any seam without search wiring). */
/** Search-provider availability, retained for existing composition seams.
* Research dispatch does not depend on it: web_fetch is keyless and
* web_search reports a missing provider as a recoverable tool result. */
searchAvailable?: () => boolean;
}
@@ -127,25 +125,20 @@ const PDF_DESCRIPTION =
* context (chatId + jobStore + the spawn seam), so concurrent chats never
* share state. chat-handler wires it each turn; tests wire their own.
*
* The research tool drops from the registry when ctx.searchAvailable reports
* no live engine (2026-09-20) — the teacher never sees it, so a keyless
* server can't dispatch doomed research jobs. Jobs ALREADY in flight when
* a key disappears still run to their honest failure (runner backstop).
* Research remains available without a search-provider key; the role's
* existing user-toggle filtering still applies outside this registry.
*/
export function jobTools(ctx: JobToolContext): Record<string, AgentTool<any>> {
const searchOn = ctx.searchAvailable?.() ?? true;
return {
...(searchOn && {
research: {
name: "research",
label: "research",
description: RESEARCH_DESCRIPTION,
parameters: researchInputSchema,
execute: serverExecute("research", researchInputSchema, (input, { toolCallId }) =>
dispatch(ctx, "research", toolCallId, RESEARCH_ACK, input),
),
},
}),
research: {
name: "research",
label: "research",
description: RESEARCH_DESCRIPTION,
parameters: researchInputSchema,
execute: serverExecute("research", researchInputSchema, (input, { toolCallId }) =>
dispatch(ctx, "research", toolCallId, RESEARCH_ACK, input),
),
},
demo: {
name: "demo",
label: "demo",
+4 -4
View File
@@ -40,8 +40,8 @@ export interface PracticeToolContext {
graphNodes?: () => ReadonlyArray<Pick<import("../../core/contracts/graph.ts").GraphNode, "id" | "name">>;
/** THE RARELY-NEEDED SET (owner round 10, 2026-10-05): the map readers
* behind the SAME settings gate as the prober's (graphToolsEnabled at
* the composition root); the research + pdf jobs with the honest
* searchAvailable drop. Each absent (tests) = absent from the registry. */
* the composition root); the research + pdf jobs (both keyless).
* Each absent context (tests) = absent from the registry. */
graph?: GraphToolContext;
jobs?: JobToolContext;
}
@@ -225,8 +225,8 @@ export function practiceTools(ctx: PracticeToolContext): Record<string, AgentToo
const gate = createPracticeGate(ctx);
// THE RARELY-NEEDED SET (owner round 10): read/ls/find/grep over the
// learner's files (always — the same read-only set the teacher and
// prober carry), the research + pdf jobs (research honestly absent
// when no search engine is live; demo/visual stay teach-only), and
// prober carry), the research + pdf jobs (available without search
// keys; demo/visual stay teach-only), and
// the prober's map readers when the settings gate opened. None are
// toggle-filtered: problem/conclude are the session; these are
// exceptions the doctrine says to reach for rarely.