sorokin.oleg.edu/learnharness
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 7 Wiki Activity

fix: steer delivery renders bare in the transcript — no bubble, no model glue

Browse Source 
Three refinements from live testing:

- Steer messages no longer sit inside the user Message container (the
  bubble background + right alignment it gave artifact cards). chat.tsx
  renders SubagentSteerCard directly in the transcript column — full
  width, centered, same register as the teacher's artifacts.
- Research steers render a quiet "Research complete · N sources" badge
  (the dispatch-settled idiom), not the full brief: briefs are long, the
  wake turn weaves them into the lesson anyway, and the full text stays
  persisted in the artifact part — a "view full research" affordance
  can be added later without any protocol change. Failures keep the
  failure card (the brief explains what went wrong).
- The sub-agents' verification notes (visual/demo builder notes) are
  model-facing glue and no longer render on success; failure notes
  remain the error explanation.

SSR-verified against a synthetic record: badge + SVG bare in the
transcript (no is-user wrapper), notes/brief confined to the RSC
payload. 229/229, typecheck, lint, build green.
This commit is contained in:
amosblomqvist
2026-09-02 02:58:37 +03:00
parent 2d7b004fda
commit 5a7e2748d7
5 changed files with 72 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files
components/artifacts/steer-card.tsx
+32 -6
View File
@@ -1,6 +1,8 @@
"use client";
import type { SubagentArtifactData, TeacherUIMessage } from "@/src/core";
import { CheckIcon } from "lucide-react";
import type { ResearchResult, SubagentArtifactData, TeacherUIMessage } from "@/src/core";
import { isSubagentFailure } from "@/src/core";
import { DemoOutputCard } from "@/components/artifacts/demo-card";
import { ResearchBriefCard } from "@/components/artifacts/job-card";
import { VisualOutputCard } from "@/components/artifacts/visual-card";
@@ -10,10 +12,17 @@ import { VisualOutputCard } from "@/components/artifacts/visual-card";
*
* When a background job completes, the wake pipeline injects a STEER message
* into the transcript: a user-role UIMessage whose data part
* ("data-subagent-artifact") carries the result. It must NEVER render as a
* learner bubble: the model-facing text part is protocol glue, and the
* artifact itself renders here, by kind, reusing the same artifact cards
* the result always used.
* ("data-subagent-artifact") carries the result. It renders as an artifact —
* NEVER a learner bubble, never wrapped in a message container:
*
* research — a quiet "Research complete" badge. The full brief is TOO LONG
* to inline and the teacher's wake turn weaves it into the lesson anyway;
* it stays persisted in the transcript (the artifact part), so a
* "view full research" affordance can be added later. Failures keep the
* failure card (the brief explains what went wrong).
* demo / visual — the artifact itself (sandboxed iframe / sanitized SVG).
* The sub-agent's verification notes are model-facing glue and do NOT
* render; only a failure note does.
*/
export function SubagentSteerCard({ message }: { message: TeacherUIMessage }) {
const artifactPart = message.parts.find((p) => p.type === "data-subagent-artifact");
@@ -27,10 +36,27 @@ export function SubagentSteerCard({ message }: { message: TeacherUIMessage }) {
}
switch (data.kind) {
case "research":
return <ResearchBriefCard output={data.result} />;
return isSubagentFailure("research", data.result as ResearchResult) ? (
<ResearchBriefCard output={data.result} />
) : (
<ResearchCompleteBadge result={data.result as ResearchResult} />
);
case "demo":
return <DemoOutputCard output={data.result} />;
case "visual":
return <VisualOutputCard output={data.result} />;
}
}
/** Quiet one-liner, the dispatch-settled idiom: the brief lives in the record,
* the lesson lives in the teacher's wake turn — the badge just marks delivery. */
function ResearchCompleteBadge({ result }: { result: ResearchResult }) {
return (
<div className="flex items-center gap-2 text-xs text-muted-foreground" data-testid="research-complete-badge">
<CheckIcon className="size-3.5" />
<span className="font-medium uppercase tracking-wide">Research</span>
<span>complete</span>
{result.sources.length > 0 && <span>· {result.sources.length} sources</span>}
</div>
);
}