Refinement round: ring popover down, menu order, tok unit, list indent, lowercase levels
Five small fixes (owner refinement round, 2026-09-24):
1. RING POPOVER OPENS DOWN: the ring lives in the chat top bar —
the window's top edge is right above it, so the upward popover was
clipped. top-full mt-1.5 now: it drops below the ring.
2. SESSION MENU ORDER FLIPPED: Rename/Delete first, hairline, then
the extraction coverage block + Extract at the bottom — the info
reads after the actions (was the reverse, the block on top).
3. UNIT TYPED OUT: the sidebar block reads "2k tok uncovered" now —
the tokens unit is explicit (owner: "tok").
4. MARKDOWN LIST INDENT: streamdown ships list-inside with no
container padding — top-level markers sat ON the text edge (only
nested lists got their pl-6 via [li_&]). .lh-prose :where(ul, ol)
{ padding-left: 1.5rem } indents both list kinds as blocks, 24px —
the same measure as the nested-case pl-6. Unlayered CSS beats the
utility layer; :where keeps specificity zero.
5. THINKING LEVELS LOWERCASE EVERYWHERE: the composer pill and setup
dialog rendered THINKING_LABEL (Off/Minimal/…/Max) while every
menu body renders the raw lowercase level — the map is now
lowercase, the level string IS the display form, everywhere.
Live-verified on :3001: list content inset 24px vs paragraphs
(padding-left computed 24px, nested fine); the composer pill reads
"low" with options low/high/max; menu order Rename → Delete… →
hairline → block. 901/901.
This commit is contained in:
@@ -197,6 +197,16 @@ body {
|
|||||||
color: var(--lh-ink-italic);
|
color: var(--lh-ink-italic);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/* Markdown lists indent from the prose edge (owner ask, 2026-09-24):
|
||||||
|
streamdown ships list-inside with no container padding (top-level
|
||||||
|
markers sit ON the text edge — nested lists get their pl-6 only via
|
||||||
|
[li_&]). 24px — the same measure as that nested-case pl-6 — pulls
|
||||||
|
the whole list right as a block. Unlayered CSS beats the utility
|
||||||
|
layer; :where keeps specificity zero. */
|
||||||
|
.lh-prose :where(ul, ol) {
|
||||||
|
padding-left: 1.5rem;
|
||||||
|
}
|
||||||
|
|
||||||
/* Markdown headings render at the font's BLACK weight (owner ask,
|
/* Markdown headings render at the font's BLACK weight (owner ask,
|
||||||
2026-09-19) — 900, not streamdown's font-semibold 600. The variable
|
2026-09-19) — 900, not streamdown's font-semibold 600. The variable
|
||||||
Source Sans 3 axis spans 200–900 (next/font loads the full range), so
|
Source Sans 3 axis spans 200–900 (next/font loads the full range), so
|
||||||
|
|||||||
@@ -97,7 +97,7 @@ async function requestExtract(chatId: string): Promise<boolean> {
|
|||||||
// ─── The sidebar context menu's coverage block ──────────────────────────────
|
// ─── The sidebar context menu's coverage block ──────────────────────────────
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* The info block at the top of the session context menu (owner-locked
|
* The info block at the bottom of the session context menu (owner-locked
|
||||||
* redesign): what the extractor hasn't covered yet, plus the manual Extract
|
* redesign): what the extractor hasn't covered yet, plus the manual Extract
|
||||||
* affordance — visually separated from Rename/Delete below (those stay the
|
* affordance — visually separated from Rename/Delete below (those stay the
|
||||||
* two session-management actions). Fetched ON MENU OPEN (the block mounts
|
* two session-management actions). Fetched ON MENU OPEN (the block mounts
|
||||||
@@ -191,7 +191,7 @@ export function CoverageMenuBody({
|
|||||||
) : (
|
) : (
|
||||||
<span className="flex flex-col">
|
<span className="flex flex-col">
|
||||||
<span className="tabular-nums text-foreground">
|
<span className="tabular-nums text-foreground">
|
||||||
{formatTokens(coverage.uncoveredTokens)} uncovered
|
{formatTokens(coverage.uncoveredTokens)} tok uncovered
|
||||||
</span>
|
</span>
|
||||||
<span className="tabular-nums text-muted-foreground">
|
<span className="tabular-nums text-muted-foreground">
|
||||||
{coverage.uncoveredCount} message{coverage.uncoveredCount === 1 ? "" : "s"} unextracted
|
{coverage.uncoveredCount} message{coverage.uncoveredCount === 1 ? "" : "s"} unextracted
|
||||||
@@ -305,7 +305,7 @@ export function CoverageRing({ chatId, refreshKey = 0 }: { chatId: string; refre
|
|||||||
{open && (
|
{open && (
|
||||||
<div
|
<div
|
||||||
data-testid="coverage-ring-popover"
|
data-testid="coverage-ring-popover"
|
||||||
className="absolute bottom-full right-0 z-40 mb-1.5 w-64 rounded-xl border bg-card p-3 text-xs shadow-xl"
|
className="absolute top-full right-0 z-40 mt-1.5 w-64 rounded-xl border bg-card p-3 text-xs shadow-xl"
|
||||||
>
|
>
|
||||||
<CoverageRingDetail coverage={coverage} chunkTokens={graph.chunkTokens} />
|
<CoverageRingDetail coverage={coverage} chunkTokens={graph.chunkTokens} />
|
||||||
</div>
|
</div>
|
||||||
|
|||||||
+13
-13
@@ -377,11 +377,11 @@ function SessionsSidebar() {
|
|||||||
const listRef = useRef<HTMLDivElement>(null);
|
const listRef = useRef<HTMLDivElement>(null);
|
||||||
|
|
||||||
/* ── Wave 6 chunk A: context menu + inline rename + deletion ──
|
/* ── Wave 6 chunk A: context menu + inline rename + deletion ──
|
||||||
Right-click a session row → MenuShell: the extraction coverage
|
Right-click a session row → MenuShell: the two management actions
|
||||||
block (owner-locked redesign, 2026-09-24 — numbers + the manual
|
first (owner ruling), then — below a hairline — the extraction
|
||||||
Extract affordance, separated by a hairline) above the two
|
coverage block (owner-locked redesign 2026-09-24, order refined
|
||||||
session-management actions (owner ruling): Rename (inline, below)
|
2026-09-24: Rename/Delete on top, the numbers + manual Extract
|
||||||
and Delete (the two-option dialog). The anchor is the row that was
|
affordance at the bottom). The anchor is the row that was
|
||||||
right-clicked — assigned into a ref before the state flip so the
|
right-clicked — assigned into a ref before the state flip so the
|
||||||
shell measures it on its first (hidden) pass. */
|
shell measures it on its first (hidden) pass. */
|
||||||
const [ctxChatId, setCtxChatId] = useState<string | null>(null);
|
const [ctxChatId, setCtxChatId] = useState<string | null>(null);
|
||||||
@@ -662,14 +662,12 @@ function SessionsSidebar() {
|
|||||||
preferredSide="down"
|
preferredSide="down"
|
||||||
menuClass="flex w-52 flex-col gap-0.5 rounded-xl border bg-card p-2 text-xs shadow-xl"
|
menuClass="flex w-52 flex-col gap-0.5 rounded-xl border bg-card p-2 text-xs shadow-xl"
|
||||||
>
|
>
|
||||||
{/* The extraction block (owner-locked redesign, 2026-09-24):
|
{/* The two management actions first, then the extraction block
|
||||||
what the extractor hasn't covered yet + the manual Extract
|
(owner refinement round, 2026-09-24): Rename/Delete stay at the
|
||||||
affordance — visually separated from the management
|
top, the coverage numbers + Extract affordance sit below the
|
||||||
actions below by a hairline. Fetched on menu open (the
|
hairline — the block is info + a stateful affordance, the
|
||||||
block mounts WITH the menu); 409 = benign (already
|
actions above it. Fetched on menu open (the block mounts WITH
|
||||||
running). Renders nothing on a failed read. */}
|
the menu); 409 = benign. Renders nothing on a failed read. */}
|
||||||
<CoverageMenuBlock chatId={ctxChatId} />
|
|
||||||
<div className="my-0.5 border-t border-border/60" aria-hidden="true" />
|
|
||||||
<button
|
<button
|
||||||
type="button"
|
type="button"
|
||||||
data-testid="ctx-rename"
|
data-testid="ctx-rename"
|
||||||
@@ -693,6 +691,8 @@ function SessionsSidebar() {
|
|||||||
>
|
>
|
||||||
Delete…
|
Delete…
|
||||||
</button>
|
</button>
|
||||||
|
<div className="my-0.5 border-t border-border/60" aria-hidden="true" />
|
||||||
|
<CoverageMenuBlock chatId={ctxChatId} />
|
||||||
</MenuShell>
|
</MenuShell>
|
||||||
)}
|
)}
|
||||||
|
|
||||||
|
|||||||
@@ -15,15 +15,19 @@
|
|||||||
import { DEFAULT_THINKING_ORDER } from "@/src/core";
|
import { DEFAULT_THINKING_ORDER } from "@/src/core";
|
||||||
import type { ThinkingLevel } from "@earendil-works/pi-agent-core";
|
import type { ThinkingLevel } from "@earendil-works/pi-agent-core";
|
||||||
|
|
||||||
/** Display labels for the levels (shared by every trigger that shows one). */
|
/** Display labels for the levels (shared by every trigger that shows
|
||||||
|
* one). Lowercase, always (owner refinement round, 2026-09-24): the
|
||||||
|
* level strings ARE the display form — the settings menus render them
|
||||||
|
* raw, so the composer pill and setup dialog must match, never Title
|
||||||
|
* Case. */
|
||||||
export const THINKING_LABEL: Record<string, string> = {
|
export const THINKING_LABEL: Record<string, string> = {
|
||||||
off: "Off",
|
off: "off",
|
||||||
minimal: "Minimal",
|
minimal: "minimal",
|
||||||
low: "Low",
|
low: "low",
|
||||||
medium: "Medium",
|
medium: "medium",
|
||||||
high: "High",
|
high: "high",
|
||||||
xhigh: "Xhigh",
|
xhigh: "xhigh",
|
||||||
max: "Max",
|
max: "max",
|
||||||
};
|
};
|
||||||
|
|
||||||
/** The level a fresh pick of `supported` populates with. Empty support
|
/** The level a fresh pick of `supported` populates with. Empty support
|
||||||
|
|||||||
@@ -54,7 +54,7 @@ describe("CoverageMenuBody — the context-menu block", () => {
|
|||||||
<CoverageMenuBody coverage={coverage()} extracting={false} onExtract={() => {}} />,
|
<CoverageMenuBody coverage={coverage()} extracting={false} onExtract={() => {}} />,
|
||||||
);
|
);
|
||||||
assert.ok(html.includes('data-testid="ctx-coverage"'), "the block carries its testid");
|
assert.ok(html.includes('data-testid="ctx-coverage"'), "the block carries its testid");
|
||||||
assert.match(html, /2k uncovered/);
|
assert.match(html, /2k tok uncovered/, "the unit is typed out — tok (owner refinement round)");
|
||||||
assert.match(html, /5 messages unextracted/);
|
assert.match(html, /5 messages unextracted/);
|
||||||
assert.ok(html.includes('data-testid="ctx-extract"'), "the Extract affordance");
|
assert.ok(html.includes('data-testid="ctx-extract"'), "the Extract affordance");
|
||||||
assert.ok(!html.includes('disabled=""'), "an uncovered session can extract (the disabled: utilities alone don't count)");
|
assert.ok(!html.includes('disabled=""'), "an uncovered session can extract (the disabled: utilities alone don't count)");
|
||||||
|
|||||||
Reference in New Issue
Block a user