Fix ⌘B: dispatch/listen event-name mismatch; thinking pill → "Thinking (⇧⇥)"

sorokin.oleg.edu/learnharness

Root cause (interlude, owner 2026-09-25): keyboard-shortcuts dispatches
registry actions on the lh:kbd-<action> convention, but the sidebar's
listener sat on the pre-convention name "lh:toggle-sidebar" — a name
nothing ever dispatches, so ⌘B silently did nothing while its tooltip
and cheat-sheet row kept claiming the binding. A sweep of every lh:
listener confirmed the sidebar was the lone stray (chat-renamed and
graph-revision are deliberate non-kbd events).

Fix, structural: kbdEventForAction(action) exported from
src/core/keyboard.ts — the ONE spelling — and both sides compose
through it (dispatcher's default branch, sidebar's toggle listener);
keyboard-shortcuts re-exports the helper so the contract pin can assert
no second spelling exists. The mismatch is now impossible by
construction.

Thinking pill: label trimmed to "Thinking" with its real shortcut via
the registry-composition path — "Thinking (⇧⇥)" (cycle-thinking,
rebind-live like every Hint suffix).

Pins (tests/keyboard-toggle-sidebar.test.ts): the full chain — mod+b →
actionForBinding → toggle-sidebar → kbdEventForAction →
lh:kbd-toggle-sidebar; formatBinding("shift+tab") → ⇧⇥; the
dispatcher-imports-the-same-helper contract.

Live-verified on :3001: ⌘B visually toggles on home, /chat/[id], and
/chat/new (sidebar 0↔288px, hamburger slot 0↔36); with the rebind
lh:keymap {"toggle-sidebar":"mod+j"}: ⌘J toggles and ⌘B is inert
(rebind-live); thinking pill renders "Thinking (⇧⇥)"; keymap restored,
sidebar left open.

This commit is contained in:

amosblomqvist

2026-09-25 02:39:11 +03:00

parent 6b83d3248b

commit b3c07f89f4

5 changed files with 85 additions and 7 deletions

									
										components/model-picker.tsx
									
		+5
		-2
	
												View File
												
				@@ -277,8 +277,11 @@ export function ModelControl() {

							</button>

							</Hint>

							<Hint

								// Trimmed (owner, subtlety round 2026-09-25).

								label="Thinking level"

								// "Thinking" + its real shortcut via the registry (owner interlude

								// 2026-09-25): ⇧⇥ cycles the level, so "Thinking (⇧⇥)" —

								// rebind-live like every Hint suffix.

								label="Thinking"

								action="cycle-thinking"

								side="bottom"

							>

								<button