Fix wave chunk 1: cross-surface settings signal, dialog scroll-lock, noneRow retired

- lh:settings-saved CustomEvent (the lh:chat-renamed pattern, owner
  ruling): every writer (composer save, SetupDialog save, the settings
  write seam — one dispatch point carrying the section) notifies after a
  successful PUT; every reader re-reads its own seam: ModelControl's
  record read, the Agent section's slots/catalog, and chat.tsx's
  configured state (clearing slots mid-session now surfaces the setup
  CTA without a reload). Self-notifications re-read idempotently.
- MenuShell now announces lh:menu-open/lh:menu-close (still placement-
  only); the settings dialog's content column locks (overflow-hidden,
  count-based) while any menu is open — wheel-scrolling with a dropdown
  down is dead; the re-place-on-scroll fallback stays for un-lockable
  surfaces.
- The settings thinking menus' 'Default' noneRow is retired (owner:
  the unset state can't re-enter once chunk 2's auto-populate lands; no
  unpin is needed).
- Live-caught regression from the MenuShell migration fixed: the
  composer's outside-click handler never learned the portaled menu body
  isn't a container descendant — menu-row pointerdowns counted as
  outside and ATE THE PICK (composer picks have been dead for pointer
  users since 221c99d); rows now carve out via [data-lh-menu], the
  settings sections' discipline.
- Item 4 (resolved-level display for legacy records) deferred to chunk 2
  per owner ruling — the payload omits the level for legacy no-level
  records and DEFAULT_THINKING_ORDER was server-only (now in the core
  barrel via bd68486, exactly the seam chunk 2 needs).
This commit is contained in:
amosblomqvist
2026-09-22 21:55:33 +03:00
parent 9387418864
commit e766a13eb1
8 changed files with 207 additions and 44 deletions
+15 -31
View File
@@ -41,8 +41,9 @@
* section's PUT; text writes through the segment route.
*/
import { useEffect, useRef, useState } from "react";
import { useCallback, useEffect, useRef, useState } from "react";
import { MenuShell } from "@/components/menu-shell";
import { useSettingsSaved } from "@/components/settings-signal";
import type React from "react";
import {
MODEL_SLOTS,
@@ -253,8 +254,10 @@ export function AgentSection({
// The catalog (federated: keyed providers only), the resolved slots,
// the prompt segments, and the search engines' key presence — one
// fetch each per section mount.
useEffect(() => {
// fetch each per section mount. The models read ALSO re-runs on the
// cross-surface signal (fix wave: another surface's write re-reads
// into the slot rows live).
const readModels = useCallback(() => {
fetch("/api/models")
.then((r) => r.json())
.then((body: ModelsBody) => {
@@ -262,6 +265,14 @@ export function AgentSection({
setSlots(body.slots);
})
.catch(() => setCatalog(null));
}, []);
useSettingsSaved((section) => {
if (section === "models") readModels();
});
useEffect(() => {
readModels();
fetch("/api/settings/prompts")
.then((r) => r.json())
.then((body: { prober: SegmentInfo[]; teacher: SegmentInfo[] }) => setPrompts(body))
@@ -346,27 +357,7 @@ export function AgentSection({
.then((body: { prober: SegmentInfo[]; teacher: SegmentInfo[] }) => setPrompts(body));
}
/** The "—" row — THINKING menus only: clears the thinking pin (the
* slot keeps its model; the tier's resolved budget takes over). Model
* menus carry no such row — unpicking a model would re-arm the
* first-run gate, and a "default" model is not a thing in this app
* (owner, fix wave: no factory fallback is ever presented as a
* choice; an unpicked slot just reads "—"). */
const noneRow = (active: boolean, onPick: () => void) => (
<button
type="button"
data-testid="menu-none"
onClick={onPick}
className={`flex w-full items-center justify-between rounded-lg px-2 py-1.5 text-left transition-colors hover:bg-muted ${
active ? "bg-muted/60 text-card-foreground" : "text-card-foreground"
}`}
>
<span>Default</span>
{active && <span aria-hidden>✓</span>}
</button>
);
/** The search-engine menu row — label + the quiet live-key mark. */
/** The search-engine menu row — label + the quiet live-key mark. */
const engineOption = (
id: (typeof SEARCH_ENGINES)[number] | "auto",
label: string,
@@ -553,13 +544,6 @@ export function AgentSection({
testid={`slot-thinking-menu-${slot}`}
menuClass="flex w-44 flex-col gap-0.5 rounded-xl border border-border bg-card p-2 text-xs shadow-xl"
>
{noneRow(
thinking === "",
() => {
onModelsChange(composeSlotModel(models, slot, provider, modelId, ""));
setOpenMenu(null);
},
)}
<ThinkingMenuList
levels={levels.map(String)}
effectiveLevel={thinking || undefined}