Fix wave chunk 1: cross-surface settings signal, dialog scroll-lock, noneRow retired

- lh:settings-saved CustomEvent (the lh:chat-renamed pattern, owner
  ruling): every writer (composer save, SetupDialog save, the settings
  write seam — one dispatch point carrying the section) notifies after a
  successful PUT; every reader re-reads its own seam: ModelControl's
  record read, the Agent section's slots/catalog, and chat.tsx's
  configured state (clearing slots mid-session now surfaces the setup
  CTA without a reload). Self-notifications re-read idempotently.
- MenuShell now announces lh:menu-open/lh:menu-close (still placement-
  only); the settings dialog's content column locks (overflow-hidden,
  count-based) while any menu is open — wheel-scrolling with a dropdown
  down is dead; the re-place-on-scroll fallback stays for un-lockable
  surfaces.
- The settings thinking menus' 'Default' noneRow is retired (owner:
  the unset state can't re-enter once chunk 2's auto-populate lands; no
  unpin is needed).
- Live-caught regression from the MenuShell migration fixed: the
  composer's outside-click handler never learned the portaled menu body
  isn't a container descendant — menu-row pointerdowns counted as
  outside and ATE THE PICK (composer picks have been dead for pointer
  users since 221c99d); rows now carve out via [data-lh-menu], the
  settings sections' discipline.
- Item 4 (resolved-level display for legacy records) deferred to chunk 2
  per owner ruling — the payload omits the level for legacy no-level
  records and DEFAULT_THINKING_ORDER was server-only (now in the core
  barrel via bd68486, exactly the seam chunk 2 needs).
This commit is contained in:
amosblomqvist
2026-09-22 21:55:33 +03:00
parent 9387418864
commit e766a13eb1
8 changed files with 207 additions and 44 deletions
+20 -2
View File
@@ -40,6 +40,8 @@ import { useAppearance } from "./appearance.tsx";
import { SettingsSection, SettingsRow, Toggle } from "./controls.tsx";
import { AgentSection } from "./agent-section.tsx";
import type { ModelsSettings } from "@/src/core";
import { MENU_CLOSE_EVENT, MENU_OPEN_EVENT } from "@/components/menu-shell";
import { notifySettingsSaved } from "@/components/settings-signal";
import { KeysSection } from "./keys-section.tsx";
import { AppearanceSection, GraphSection } from "./appearance-section.tsx";
import { KeyboardSection } from "./keyboard-section.tsx";
@@ -114,6 +116,18 @@ export function SettingsDialogBody({
undefined,
);
const [error, setError] = useState<string | null>(null);
// MenuShell open-count — drives the content column's scroll lock.
const [openMenus, setOpenMenus] = useState(0);
useEffect(() => {
const onOpen = () => setOpenMenus((n) => n + 1);
const onClose = () => setOpenMenus((n) => Math.max(0, n - 1));
window.addEventListener(MENU_OPEN_EVENT, onOpen);
window.addEventListener(MENU_CLOSE_EVENT, onClose);
return () => {
window.removeEventListener(MENU_OPEN_EVENT, onOpen);
window.removeEventListener(MENU_CLOSE_EVENT, onClose);
};
}, []);
const [active, setActive] = useState<SectionId>(initialSection);
// Fetch once per dialog mount. 200 {settings: null} is FIRST BOOT
@@ -165,6 +179,7 @@ export function SettingsDialogBody({
setRecord(
(prev) => ({ ...(prev ?? {}), [section]: body }) as UserSettings,
);
notifySettingsSaved(section);
if (section === "appearance")
onAppearanceChange(body as AppearanceSettings);
},
@@ -228,9 +243,12 @@ export function SettingsDialogBody({
))}
</nav>
{/* Content column — one section at a time, this scrolls. */}
{/* Content column — one section at a time, this scrolls — and
LOCKS while any MenuShell is open (owner ruling: no
scrolling with a dropdown down; MenuShell announces
open/close, the count keeps overlap honest). */}
<div
className="min-w-0 flex-1 overflow-y-auto"
className={`min-w-0 flex-1 ${openMenus > 0 ? "overflow-hidden" : "overflow-y-auto"}`}
data-testid="settings-content"
>
{error && (