push architecture slice 2: turn-started/turn-settled emit from the liveness seams (registry-first ordering, no-op paths silent)
This commit is contained in:
@@ -2,12 +2,15 @@
|
||||
* Turn liveness registry unit tests (src/server/turn-liveness.ts): one turn
|
||||
* per chat, ever — begin/end round trip, double-begin rejection, restart
|
||||
* after end. The 30-minute stale-eviction TTL is not tested (it is a leak
|
||||
* guard, not a behavior).
|
||||
* guard, not a behavior). The lifecycle-emitter pins ride the same seams:
|
||||
* turn-started on the accepted begin only, turn-settled on the live end
|
||||
* only, and the registry already consistent when the listener runs.
|
||||
*/
|
||||
|
||||
import assert from "node:assert/strict";
|
||||
import { describe, it } from "node:test";
|
||||
import { beginTurn, endTurn, isTurnRunning } from "../src/server/turn-liveness.ts";
|
||||
import { subscribe, type ServerEvent } from "../src/core/events.ts";
|
||||
|
||||
describe("turn liveness registry", () => {
|
||||
it("begin/end round trip; a second begin is rejected until the turn ends", () => {
|
||||
@@ -22,3 +25,36 @@ describe("turn liveness registry", () => {
|
||||
endTurn(id);
|
||||
});
|
||||
});
|
||||
|
||||
describe("turn lifecycle events", () => {
|
||||
it("beginTurn emits turn-started on success only — the 409 double-begin stays silent", () => {
|
||||
const id = "chat_events_begin";
|
||||
const got: ServerEvent[] = [];
|
||||
const off = subscribe((e) => got.push(e));
|
||||
assert.equal(beginTurn(id), true, "fresh chat accepts the turn");
|
||||
assert.equal(beginTurn(id), false, "the rejected double-begin");
|
||||
assert.deepEqual(got, [{ type: "turn-started", chatId: id }], "exactly one event");
|
||||
endTurn(id); // cleanup (its settle is asserted in the next case's terms)
|
||||
off();
|
||||
});
|
||||
|
||||
it("endTurn emits turn-settled only when a live entry was present", () => {
|
||||
const id = "chat_events_end";
|
||||
const got: ServerEvent[] = [];
|
||||
let runningAtSettle: boolean | undefined;
|
||||
const off = subscribe((e) => {
|
||||
got.push(e);
|
||||
// The settle must be observable as already-idle: the registry
|
||||
// write happens BEFORE the emit, so a listener that fetches truth
|
||||
// (the whole point of notify → fetch) reads consistent state.
|
||||
if (e.type === "turn-settled") runningAtSettle = isTurnRunning(id);
|
||||
});
|
||||
beginTurn(id);
|
||||
got.length = 0; // focus on the settle path
|
||||
endTurn(id); // live entry → settle
|
||||
endTurn(id); // absent entry → defensive no-op, must stay silent
|
||||
assert.deepEqual(got, [{ type: "turn-settled", chatId: id }]);
|
||||
assert.equal(runningAtSettle, false, "listener sees the registry already cleared");
|
||||
off();
|
||||
});
|
||||
});
|
||||
|
||||
Reference in New Issue
Block a user