amosblomqvist
26bc305d66
Plan canvas (owner report: arrows clipped at the viewBox edge in dist — measured 14px/20px cuts in the owner's real plans): blockLayout now unions node boxes with every edge path's control-point hull (a bezier never leaves it; the layout calls edgePathD with the renderer's exact inputs). Dagre's node extent stays the floor, so ordinary plans render byte-identical; the viewBox origin shifts only when ink bulges past zero. Verified on both real chats; pins use the owner's real linear-algebra tree (golden-real-data). Keyboard-first (owner's law: Enter always submits, arrows always cycle; text fields the only exception): - Enter guard split (enter-submits): a focused BUTTON keeps native Enter only when keyboard-walked (:focus-visible) or inside an open overlay (menus/dialogs); pointer-clicked transcript buttons submit, preventDefault suppressing the re-activation underneath. - Focus hygiene (focus-hygiene): pointer clicks on transient controls (agent/user thinking toggles, copy, mermaid expand, plan chip) blur to body — the state clicking empty space produces. - Session search owns the walk: Up/Down wrap-cycle the filtered rows, Enter opens the walked row or the first match (quick-open), then blurs and keeps the query. The Alt-arrow session cycle is RETIRED. - Registry: model-menu walk/pick entries removed (obvious in-field navigation, not settings material); question-dock keys stay displayOnly per owner ruling. Gates: 1489/1489, typecheck, lint. Verified live end-to-end.
75 lines
3.1 KiB
TypeScript
75 lines
3.1 KiB
TypeScript
import assert from "node:assert/strict";
|
|
import { describe, it } from "node:test";
|
|
import {
|
|
actionForBinding,
|
|
bindingForAction,
|
|
formatBinding,
|
|
kbdEventForAction,
|
|
KEYBOARD_ACTIONS,
|
|
} from "../src/core/keyboard.ts";
|
|
import { kbdEventForAction as kbdEventForActionFromUi } from "../components/keyboard-shortcuts.tsx";
|
|
|
|
/**
|
|
* The ⌘B sidebar bug interlude (owner, 2026-09-25): ⌘B did nothing because
|
|
* the sidebar listened on the pre-convention "lh:toggle-sidebar" while the
|
|
* dispatcher sent "lh:kbd-toggle-sidebar". The fix is structural — both
|
|
* sides compose the event name through the ONE helper — and these pins
|
|
* hold the chain together: the registry maps the keypress to the action,
|
|
* the helper spells the event, and the UI dispatcher imports the same
|
|
* helper (not its own copy).
|
|
*/
|
|
|
|
describe("kbdEventForAction — the one spelling for action events", () => {
|
|
it("dispatch and listen names are the helper's output", () => {
|
|
assert.equal(kbdEventForAction("toggle-sidebar"), "lh:kbd-toggle-sidebar");
|
|
assert.equal(kbdEventForAction("sessions-search"), "lh:kbd-sessions-search");
|
|
});
|
|
|
|
it("the dispatcher imports the same helper (no second spelling exists)", () => {
|
|
assert.equal(kbdEventForActionFromUi, kbdEventForAction);
|
|
});
|
|
});
|
|
|
|
describe("the ⌘B chain — keypress → binding → action → event", () => {
|
|
it("mod+t is the toggle-user-thinking action (owner round, 2026-10-07)", () => {
|
|
assert.equal(actionForBinding("mod+t"), "toggle-user-thinking");
|
|
assert.equal(bindingForAction("toggle-user-thinking"), "mod+t");
|
|
assert.equal(kbdEventForAction("toggle-user-thinking"), "lh:kbd-toggle-user-thinking");
|
|
});
|
|
|
|
it("mod+b is the toggle-sidebar action", () => {
|
|
assert.equal(actionForBinding("mod+b"), "toggle-sidebar");
|
|
assert.equal(bindingForAction("toggle-sidebar"), "mod+b");
|
|
assert.equal(formatBinding("mod+b"), "⌘B");
|
|
});
|
|
|
|
it("the event the chain ends in is the one the sidebar answers on", () => {
|
|
const action = actionForBinding("mod+b");
|
|
assert.equal(action, "toggle-sidebar");
|
|
assert.equal(kbdEventForAction(action), "lh:kbd-toggle-sidebar");
|
|
});
|
|
});
|
|
|
|
describe("the thinking pill suffix — ⇧⇥ via the registry", () => {
|
|
it("shift+tab formats as ⇧⇥ and maps to cycle-thinking", () => {
|
|
assert.equal(actionForBinding("shift+tab"), "cycle-thinking");
|
|
assert.equal(formatBinding("shift+tab"), "⇧⇥");
|
|
});
|
|
});
|
|
|
|
describe("the Alt session cycle is RETIRED (owner, 2026-10-10)", () => {
|
|
// Barely used, felt laggy — session navigation lives IN the search
|
|
// now (↑/↓ walk the filtered list, Enter opens; sidebar.tsx).
|
|
it("⌥↑ / ⌥↓ / ⌥↵ bind to NOTHING — no stray action fires", () => {
|
|
assert.equal(actionForBinding("alt+arrowup") ?? null, null);
|
|
assert.equal(actionForBinding("alt+arrowdown") ?? null, null);
|
|
assert.equal(actionForBinding("alt+enter") ?? null, null);
|
|
});
|
|
|
|
it("the actions are gone from the table (cheat sheet + settings render the registry)", () => {
|
|
const ids = KEYBOARD_ACTIONS.map((a) => a.id as string);
|
|
assert.ok(!ids.includes("cycle-session-prev"));
|
|
assert.ok(!ids.includes("cycle-session-next"));
|
|
assert.ok(!ids.includes("open-session"));
|
|
});
|
|
}); |