Owner-locked extraction-UX redesign (dispatch 2026-09-24), part 1 (data
layer; the UI chunk follows).
THRESHOLD -> SETTING
- config.ts's EXTRACTION.chunkTokens dies; the default moves into
FACTORY_SETTINGS.graph.extractionChunkTokens (4096, the old constant's
value). GraphSettings gains the optional field, Required at resolution
via the standard ?? FACTORY pattern — pre-redesign records resolve the
default cleanly.
- FLOOR 500 (the implementer's call, documented on the field): every run
pays the graph-carrying prompt overhead out of the write channel's
money — a smaller budget fires penny-batches that cost more per
extracted token than the content is worth. The sanitizer CLAMPS up
(bd68486 clamp-never-reject discipline: fractions floor, junk drops);
the settings PUT REJECTS below-floor with the rationale in the message.
No ceiling: a large budget just delays extraction — the user's stated
cost/thoroughness tradeoff, not a misconfiguration to police.
- The trigger (turn-service.triggerExtraction) takes the budget as a
parameter — chat-handler passes effective.graph.extractionChunkTokens,
the fresh per-turn read, same as every other gate.
- The pipeline's BATCH side threads through the same number:
ExtractionPipelineDeps gains an OPTIONAL getChunkTokens getter with the
factory default (Teacher's 24 test fixtures stay untouched; the two
call-site lines inside extraction.ts are the only cross-band edits,
flagged). chat-handler + backfill/import-notes wire the live
effectiveSettings — trigger and batches share one budget, always.
PER-SESSION COVERAGE READ
- sessionCoverage(chatId) (server/chats.ts): the chat view's ring-meter
block — totalMessages/coveredCount/uncoveredCount/coveredTokens/
uncoveredTokens (the same coverageOf derivation /api/graph/coverage
serves, scoped to one chat), running (chat-kind extraction registered
for this id), and lastFoldedAt (the chat's newest coverage row's fold
— a cheap single pass; null before any fold). GET /api/chats/[id]
carries it as coverage: {...}; unknown chat -> null (the route 404s
first).
- /api/graph/coverage (the all-sessions list) compiles untouched — the
per-session read is a scoping of it, not a supersession; the UI's
sidebar/ring chunk decides which surface it consumes.
Tests: factory/sanitizer pins (clamp-up, fraction-floor, junk-drop),
resolution pins (absent -> 4096, stored 2000 wins), settings-body pins
(valid/absent/fraction/below-floor 400/junk 400), sessionCoverage pins
(derived split, newest-fold scoping, cross-session isolation, running via
the registry, null on unknown chat). 893/893.
159 lines
6.7 KiB
TypeScript
159 lines
6.7 KiB
TypeScript
import { abortExtraction, extractionStatuses } from "../agent/subagents/extraction.ts";
|
|
import { coverageOf } from "../core/coverage.ts";
|
|
import { deleteChatTraces, type ChatDeleteMode, type ChatDeletionStats } from "../core/graph-deletion.ts";
|
|
import { titleFromPrompt } from "../core/contracts.ts";
|
|
import type { UIMessage } from "ai";
|
|
import { graphRevision } from "./graph.ts";
|
|
import { stores } from "./stores.ts";
|
|
import { isTurnRunning } from "./turn-liveness.ts";
|
|
|
|
/**
|
|
* Server-side chat entries for the transport layer (app/api/chats*,
|
|
* app/chat/[id]). Today these delegate straight to the ChatStore port; the
|
|
* services stage carves the real orchestration behind this same surface.
|
|
*
|
|
* deleteChatSession (wave 6, session deletion — the FIRST destructive
|
|
* operation on the graph ledgers) is the one real orchestration here:
|
|
* gates → extraction wind-down → one synchronous deletion block. See
|
|
* core/graph-deletion.ts for the ledger semantics and the atomicity
|
|
* argument.
|
|
*/
|
|
|
|
export const { createChat, getChat, listChats } = stores.chatStore;
|
|
export { titleFromPrompt };
|
|
export type { ChatDeleteMode, ChatDeletionStats } from "../core/graph-deletion.ts";
|
|
|
|
/** How long the wind-down wait may take before the caller gets a retryable
|
|
* 503 (an aborted extraction ends at its next model-call boundary —
|
|
* provider cancellation is normally sub-second, but a wedged provider
|
|
* must never wedge deletion). */
|
|
const WIND_DOWN_TIMEOUT_MS = 10_000;
|
|
const WIND_DOWN_POLL_MS = 50;
|
|
|
|
/** What deleteChatSession did — the route maps it straight to HTTP. */
|
|
export type ChatDeleteOutcome =
|
|
| { ok: false; status: 404; code: "not_found"; error: string }
|
|
| { ok: false; status: 409; code: "turn_in_flight" | "jobs_running"; error: string; jobIds: string[] }
|
|
| { ok: false; status: 503; code: "extraction_winding_down"; error: string }
|
|
| {
|
|
ok: true;
|
|
mode: ChatDeleteMode;
|
|
stats: ChatDeletionStats;
|
|
jobsRemoved: number;
|
|
graphRevision: number;
|
|
};
|
|
|
|
/**
|
|
* Delete a session (owner rulings 2026-09-22/23): gates first, then the
|
|
* purge. The owner-locked choreography:
|
|
*
|
|
* 1. GATES — a turn in flight or a running background job refuses with
|
|
* 409 (they write the chat record and steer into it; deleting
|
|
* mid-flight would corrupt the write-ahead flow). The UI retries once
|
|
* work drains.
|
|
* 2. EXTRACTION WIND-DOWN — the chat's own pipeline run is TRUE-
|
|
* CANCELLED (abortExtraction: spend stops, nothing merges), then
|
|
* awaited off the registry. A timeout is a retryable 503, never a
|
|
* forced race.
|
|
* 3. THE SYNC BLOCK — everything below runs without a single await:
|
|
* no extraction append can interleave (the event loop never yields
|
|
* mid-block), so the read-filter-write of the ledger rewrites is
|
|
* atomic against the pipeline. Ledgers first, jobs next, the chat
|
|
* record LAST (a crash mid-block leaves a deletable chat with a
|
|
* purged graph — re-running DELETE fixes it — never a deleted chat
|
|
* with live traces). The pipeline's per-batch liveness guard
|
|
* (extraction.ts) closes the last window: a run that slipped past
|
|
* the wind-down finds the chat gone at its merge and aborts with
|
|
* nothing merged.
|
|
*/
|
|
export async function deleteChatSession(chatId: string, mode: ChatDeleteMode): Promise<ChatDeleteOutcome> {
|
|
if (!stores.chatStore.getChat(chatId)) {
|
|
return { ok: false, status: 404, code: "not_found", error: "No such session" };
|
|
}
|
|
if (isTurnRunning(chatId)) {
|
|
return {
|
|
ok: false,
|
|
status: 409,
|
|
code: "turn_in_flight",
|
|
error: "A turn is running in this session — try again when it finishes",
|
|
jobIds: [],
|
|
};
|
|
}
|
|
const runningJobs = stores.jobStore.listJobs(chatId).filter((job) => job.status === "running");
|
|
if (runningJobs.length > 0) {
|
|
return {
|
|
ok: false,
|
|
status: 409,
|
|
code: "jobs_running",
|
|
error: "Background jobs are still running in this session — try again when they finish",
|
|
jobIds: runningJobs.map((job) => job.id),
|
|
};
|
|
}
|
|
if (extractionStatuses().some((run) => run.chatId === chatId)) {
|
|
abortExtraction(chatId); // true cancellation — spend stops, nothing merges
|
|
const deadline = Date.now() + WIND_DOWN_TIMEOUT_MS;
|
|
while (extractionStatuses().some((run) => run.chatId === chatId)) {
|
|
if (Date.now() > deadline) {
|
|
return {
|
|
ok: false,
|
|
status: 503,
|
|
code: "extraction_winding_down",
|
|
error: "The session's extraction is still winding down — try again in a moment",
|
|
};
|
|
}
|
|
await new Promise((resolve) => setTimeout(resolve, WIND_DOWN_POLL_MS));
|
|
}
|
|
}
|
|
|
|
// THE SYNC BLOCK — no awaits below (see the doc comment). Order:
|
|
// ledgers → jobs → the chat record.
|
|
const stats = deleteChatTraces(stores.graphStore, chatId, mode);
|
|
const jobsRemoved = stores.jobStore.deleteJobsForChat(chatId);
|
|
stores.chatStore.deleteChat(chatId);
|
|
return { ok: true, mode, stats, jobsRemoved, graphRevision: graphRevision() };
|
|
}
|
|
|
|
/** One session's coverage read (extraction-UX redesign, owner dispatch
|
|
* 2026-09-24): the chat view's ring meter + popover data — the same
|
|
* derivation the all-sessions list serves (/api/graph/coverage), scoped
|
|
* to one chat. "Uncovered" stays DERIVED per request (fingerprint the
|
|
* transcript, diff the coverage ledger — never dual-tracked).
|
|
*
|
|
* lastFoldedAt: the newest coverage row's fold timestamp — a cheap single
|
|
* pass over the chat's ledger rows (the ring popover's "last extraction"
|
|
* line); null before the session's first fold. */
|
|
export interface SessionCoverage {
|
|
totalMessages: number;
|
|
coveredCount: number;
|
|
uncoveredCount: number;
|
|
coveredTokens: number;
|
|
uncoveredTokens: number;
|
|
/** True while a chat-kind extraction run is registered for this session. */
|
|
running: boolean;
|
|
/** ISO of the newest fold in this session's coverage rows; null before any. */
|
|
lastFoldedAt: string | null;
|
|
}
|
|
|
|
/** The per-session coverage block (see SessionCoverage). Null when the
|
|
* chat doesn't exist — callers own the 404. */
|
|
export function sessionCoverage(chatId: string): SessionCoverage | null {
|
|
const record = stores.chatStore.getChat(chatId);
|
|
if (!record) return null;
|
|
const entries = stores.graphStore.readCoverage();
|
|
const cov = coverageOf(record.messages as UIMessage[], entries, chatId);
|
|
let lastFoldedAt: string | null = null;
|
|
for (const entry of entries) {
|
|
if (entry.chatId !== chatId) continue;
|
|
if (lastFoldedAt === null || entry.foldedAt > lastFoldedAt) lastFoldedAt = entry.foldedAt;
|
|
}
|
|
return {
|
|
totalMessages: cov.slots.length,
|
|
coveredCount: cov.coveredCount,
|
|
uncoveredCount: cov.uncoveredCount,
|
|
coveredTokens: cov.coveredTokens,
|
|
uncoveredTokens: cov.uncoveredTokens,
|
|
running: extractionStatuses().some((run) => run.kind === "chat" && run.chatId === chatId),
|
|
lastFoldedAt,
|
|
};
|
|
}
|