Owner rulings 2026-09-30: reasoning chains are the stored truth; the graph canvas renders a lossy derived image. No migration, no backcompat — old graph data was wiped. - contracts: GraphChain (arg_-minted id, premises, conclusion) replaces typed edges; GraphEdge survives only as the untyped derived arrow; GraphSnapshot carries stored chains; supports edges retired entirely - store: chains.jsonl ledger (edges.jsonl purged at load alongside legacy events.jsonl); readChains/appendChain seam; merge dedupes by (sorted premises, conclusion), re-assertions append under the same arg_ id - core: deriveView mints implication nodes (name ⟹, statement via formatChainLine) plus premise→imp→conclusion arrows; clusters stay proposition-only (birthSessionPartition); chainsForSelection now groups STORED chains (chain rides iff every member selected) — independent arguments for one conclusion never union; chainsToGraph/chainsToEdges die - extraction: extractor submits chains natively (expandFindings deleted); auditor receives propositions only; supports fan-out gone - deletion: full death of a proposition kills every referencing chain; arg_-prefixed node deletes kill that chain; chainsRemoved stats - UI: every arrow renders the ⟹ double shaft; supports toggle + thickness slider and detail-card edge sections deleted (card keeps name + proposition); chain table + practice pipeline read stored chains - tests: 1188 green across the new seams
335 lines
15 KiB
TypeScript
335 lines
15 KiB
TypeScript
/**
|
|
* Session deletion — the FIRST destructive operation on the append-only
|
|
* graph ledgers (owner ruling 2026-09-22, wave 6 chunk A).
|
|
*
|
|
* Until now mergeFindings has been the sole writer; deletion is the second,
|
|
* and it is held to the same discipline: PURE code over the storage ports
|
|
* (core/ports.ts), no LLM judgment anywhere, deterministic and idempotent.
|
|
* The caller (the DELETE /api/chats/[id] route through the server
|
|
* orchestration) owns the cross-store choreography (chat record, jobs,
|
|
* extraction wind-down); this module owns the LEDGERS.
|
|
*
|
|
* CHAINS-PRIMARY (owner, 2026-09-30): the stored truth is propositions +
|
|
* reasoning chains; edges are a derived view. Deletion therefore operates
|
|
* on CHAIN LINES where it used to operate on edge lines — a chain dies
|
|
* when its provenance empties or any member node died — and the derived
|
|
* view follows on the next read, never rewritten here.
|
|
*
|
|
* Two modes (owner-locked semantics):
|
|
*
|
|
* preserve-graph the chat's extraction bookkeeping dies — its coverage
|
|
* rows and its legacy checkpoint lines — and NOTHING else:
|
|
* nodes and chains stay byte-identical.
|
|
* The graph keeps the session's contributions; the
|
|
* snapshot simply no longer resolves the dead chatId to
|
|
* a title (nodeSessions filters unknown ids at read
|
|
* time — no UI ghosting).
|
|
*
|
|
* delete-nodes "this session never happened": every trace of the
|
|
* chat leaves the ledgers — its provenance points on
|
|
* every node and chain line, its link lines (their
|
|
* phrasings die with them), its coverage/checkpoint
|
|
* rows — and orphans die: a node
|
|
* whose references all came from this chat disappears
|
|
* entirely, pruned from the positions ledger too (dead
|
|
* members would break cluster hulls).
|
|
*
|
|
* Shared nodes survive automatically (the ruling): a node lives iff ANY
|
|
* surviving reference remains — a provenance point from another chat or
|
|
* notes source. The create line of a surviving node is special:
|
|
* name/statement/createdAt are the node's IDENTITY — the shared anchor
|
|
* other sessions' link verdicts recognized — so they stay even when the
|
|
* deleted chat created the node; but that session's phrasings (the line's
|
|
* aliases) are stripped and its provenance points removed (owner ruling
|
|
* 2026-09-23: all traces, identity survives).
|
|
*
|
|
* Not touched, by design:
|
|
* - imported-notes sources (src_…) — a different front door with its
|
|
* own lifecycle (re-import dedupes by path hash); this wave deletes
|
|
* CHATS.
|
|
*
|
|
* Resurrection safety: the deletion runs as ONE synchronous block (no
|
|
* awaits — atomic vs the event loop, so no extraction append can
|
|
* interleave), and the extraction pipeline re-checks the chat record
|
|
* before each batch's merge (a deleted chat never merges). Both seams
|
|
* together close every corrupt/resurrect path.
|
|
*/
|
|
|
|
import type {
|
|
CoverageEntry,
|
|
GraphChain,
|
|
GraphNode,
|
|
SessionCheckpoint,
|
|
} from "./contracts.ts";
|
|
import type { GraphStore } from "./ports.ts";
|
|
|
|
/** The two deletion modes (owner-locked 2026-09-22). Machine-checkable on
|
|
* the API as the required `mode` query param — no default, so no
|
|
* accidental destructive choice. */
|
|
export type ChatDeleteMode = "preserve-graph" | "delete-nodes";
|
|
|
|
/** What one deletion removed from the ledgers (the DELETE response's
|
|
* stats; the UI can show "3 topics, 2 links removed" from this). */
|
|
export interface ChatDeletionStats {
|
|
/** Distinct nodes that died entirely (all their lines). */
|
|
nodesRemoved: number;
|
|
/** Chain assertion LINES removed (empty-provenance or dead member). */
|
|
chainsRemoved: number;
|
|
/** Coverage rows removed. */
|
|
coverageRemoved: number;
|
|
/** Checkpoint lines removed. */
|
|
checkpointsRemoved: number;
|
|
}
|
|
|
|
const EMPTY_STATS: ChatDeletionStats = {
|
|
nodesRemoved: 0,
|
|
chainsRemoved: 0,
|
|
coverageRemoved: 0,
|
|
checkpointsRemoved: 0,
|
|
};
|
|
|
|
/**
|
|
* Remove one chat's traces from the graph ledgers. Synchronous by design
|
|
* (the atomicity argument above); idempotent (a second run finds nothing
|
|
* and returns zero stats).
|
|
*/
|
|
export function deleteChatTraces(graphStore: GraphStore, chatId: string, mode: ChatDeleteMode): ChatDeletionStats {
|
|
if (mode !== "preserve-graph" && mode !== "delete-nodes") {
|
|
throw new Error(`Unknown deletion mode: ${mode as string}`);
|
|
}
|
|
|
|
// The bookkeeping rows die in BOTH modes — coverage and checkpoints
|
|
// are extraction state, not graph content (owner semantics: even
|
|
// preserve-graph deletes "the chat's coverage rows").
|
|
const coverage = graphStore.readCoverage().filter((row) => row.chatId !== chatId);
|
|
const checkpoints = graphStore.readCheckpoints().filter((row) => row.chatId !== chatId);
|
|
const stats: ChatDeletionStats = {
|
|
...EMPTY_STATS,
|
|
coverageRemoved: graphStore.readCoverage().length - coverage.length,
|
|
checkpointsRemoved: graphStore.readCheckpoints().length - checkpoints.length,
|
|
};
|
|
|
|
if (mode === "preserve-graph") {
|
|
if (stats.coverageRemoved > 0 || stats.checkpointsRemoved > 0) {
|
|
graphStore.rewriteLedgers({ coverage, checkpoints });
|
|
}
|
|
return stats;
|
|
}
|
|
|
|
// ── delete-nodes: the full purge ──────────────────────────────────────
|
|
const nodeLines = graphStore.readNodes();
|
|
const chainLines = graphStore.readChains();
|
|
|
|
// Does the chat touch the graph at all? (A never-extracted chat still
|
|
// needs its coverage rows dropped above, but no ledger rewrite — keeps
|
|
// mtimes stable so the graph revision only moves when something really
|
|
// changed.)
|
|
const touched =
|
|
nodeLines.some((line) => line.provenance.some((pt) => pt.chatId === chatId)) ||
|
|
chainLines.some((line) => line.provenance.some((pt) => pt.chatId === chatId));
|
|
if (!touched) {
|
|
if (stats.coverageRemoved > 0 || stats.checkpointsRemoved > 0) {
|
|
graphStore.rewriteLedgers({ coverage, checkpoints });
|
|
}
|
|
return stats;
|
|
}
|
|
|
|
// 1. Survival: a node lives iff a reference from ANY surviving source
|
|
// remains — another chat/src's provenance point on any of its lines.
|
|
// (Chain members are deliberately NOT survival references: a
|
|
// chain's asserting session always left provenance on its endpoints,
|
|
// so endpoint-only liveness cannot occur in a consistent ledger —
|
|
// and counting it would keep nodes alive whose lines we would then
|
|
// drop, dangling the chain.)
|
|
const survives = (points: ReadonlyArray<{ chatId: string }>): boolean =>
|
|
points.some((pt) => pt.chatId !== chatId);
|
|
const live = new Set<string>();
|
|
for (const line of nodeLines) {
|
|
if (survives(line.provenance)) live.add(line.id);
|
|
}
|
|
|
|
// 2. Node lines. Per-line (each line is ONE extraction run's append, so
|
|
// per-session alias provenance exists at line granularity):
|
|
// dead node every line dies
|
|
// untouched line kept verbatim
|
|
// partially-deleted kept with the chat's points stripped
|
|
// (defensive — single-run lines never mix chats)
|
|
// all points deleted CREATE line: identity survives, aliases
|
|
// stripped (owner ruling 2026-09-23), points
|
|
// empty / LINK line: dies with its phrasings
|
|
const outNodes: GraphNode[] = [];
|
|
const seenIds = new Set<string>();
|
|
for (const line of nodeLines) {
|
|
if (!live.has(line.id)) continue; // the whole node dies
|
|
const first = !seenIds.has(line.id);
|
|
seenIds.add(line.id);
|
|
const points = line.provenance.filter((pt) => pt.chatId !== chatId);
|
|
if (points.length === line.provenance.length) {
|
|
outNodes.push(line); // untouched by this chat
|
|
continue;
|
|
}
|
|
if (points.length > 0) {
|
|
outNodes.push({ ...line, provenance: points });
|
|
continue;
|
|
}
|
|
if (first) {
|
|
// The create line of a surviving node the deleted chat minted:
|
|
// name/statement/createdAt are the shared identity other
|
|
// sessions recognized — they stay; the session's phrasings and
|
|
// provenance die (all traces, owner 2026-09-23).
|
|
outNodes.push({ ...line, provenance: [], aliases: [] });
|
|
}
|
|
// else: the deleted chat's link line — dies with its phrasings.
|
|
}
|
|
|
|
// 3. Chains: strip the chat's points; an assertion dies when its
|
|
// provenance empties or ANY member node (premise or conclusion)
|
|
// died IN THIS DELETION. (Only nodes that existed and died count —
|
|
// a chain whose members never resolved as nodes is foreign data the
|
|
// deletion leaves alone: destructive rewriting may not exceed the
|
|
// deleted chat's blast radius.)
|
|
const deadNodes = new Set([...new Set(nodeLines.map((line) => line.id))].filter((id) => !live.has(id)));
|
|
const outChains: GraphChain[] = [];
|
|
for (const line of chainLines) {
|
|
if (deadNodes.has(line.conclusion) || line.premises.some((premise) => deadNodes.has(premise))) continue;
|
|
const points = line.provenance.filter((pt) => pt.chatId !== chatId);
|
|
// An assertion dies when THIS deletion empties its provenance — a
|
|
// line that already had no points is foreign/legacy data, not this
|
|
// chat's trace; it rides untouched.
|
|
if (line.provenance.length > 0 && points.length === 0) continue;
|
|
outChains.push(points.length === line.provenance.length ? line : { ...line, provenance: points });
|
|
}
|
|
|
|
stats.nodesRemoved = [...new Set(nodeLines.map((line) => line.id))].filter((id) => !live.has(id)).length;
|
|
stats.chainsRemoved = chainLines.length - outChains.length;
|
|
|
|
graphStore.rewriteLedgers({
|
|
nodes: outNodes,
|
|
chains: outChains,
|
|
coverage,
|
|
checkpoints,
|
|
});
|
|
|
|
// 4. Positions: prune dead nodes AND dead chains (an argument's derived
|
|
// implication node carries the chain's arg_ id — stale resting spots
|
|
// would pin nothing; pruning keeps the ledger honest and the
|
|
// revision moving for exactly the right reason).
|
|
const deadChainIds = new Set(
|
|
chainLines
|
|
.filter((line) => !outChains.includes(line))
|
|
.map((line) => line.id),
|
|
);
|
|
const positions = graphStore.readPositions();
|
|
const knownNodeIds = new Set(nodeLines.map((line) => line.id));
|
|
const prunedPositions = Object.fromEntries(
|
|
Object.entries(positions).filter(
|
|
([id]) => (live.has(id) || !knownNodeIds.has(id)) && !deadChainIds.has(id),
|
|
),
|
|
);
|
|
if (Object.keys(prunedPositions).length !== Object.keys(positions).length) {
|
|
graphStore.writePositions(prunedPositions);
|
|
}
|
|
|
|
return stats;
|
|
}
|
|
|
|
// ─── single-node deletion (node interlude, owner-locked full-death) ───────────
|
|
|
|
/**
|
|
* FULL DEATH for one node, by id (owner ruling 2026-09-23): the user
|
|
* pointing at the node IS the intent — references from other sessions do
|
|
* NOT preserve it. The remedy for undeletable nodes (preserve-graph
|
|
* orphans from session deletion; notes-import nodes with no chat behind
|
|
* them), and the deliberate inverse of the chat cascade above: that one
|
|
* deletes a SESSION and lets nodes survive on foreign references; this
|
|
* one deletes a NODE and takes its every trace —
|
|
*
|
|
* - every line of the node (create + link lines)
|
|
* - every CHAIN referencing it (as premise or conclusion), whatever
|
|
* session asserted it — a chain with a dead member is not a chain
|
|
* - its resting position (and every dead chain's)
|
|
*
|
|
* An ARGUMENT deletion is the same call with an arg_-prefixed id (owner,
|
|
* 2026-09-30: the chain table's fenced delete kills chains): the "node"
|
|
* is the derived implication node whose id IS the chain's id.
|
|
*
|
|
* The blast radius is exactly the rows naming the id: other nodes'
|
|
* provenance, aliases, and sessions are untouched (full death is
|
|
* NODE-scoped, not session-scoped), and the source records of notes
|
|
* imports stay (the import's bookkeeping; deleting one proposition is not
|
|
* deleting the file). Derived data needs no pruning: the birth partition
|
|
* derives on read (the cluster shrinks below MIN_CLUSTER_SIZE and stops
|
|
* rendering — fine), and no other consumer indexes nodes by id across
|
|
* ledgers.
|
|
*
|
|
* Synchronous, one rewriteLedgers call, no awaits (the same atomicity
|
|
* argument as the chat cascade); idempotent in the wave-6 sense — a
|
|
* second run finds no lines and changes nothing.
|
|
*/
|
|
export interface NodeDeletionStats {
|
|
/** Chain assertion LINES removed (every chain referencing the node). */
|
|
chainsRemoved: number;
|
|
}
|
|
|
|
function nodeLinesOf(graphStore: GraphStore, nodeId: string): GraphNode[] {
|
|
return graphStore.readNodes().filter((line) => line.id === nodeId);
|
|
}
|
|
|
|
function chainLinesOf(graphStore: GraphStore, chainId: string): GraphChain[] {
|
|
return graphStore.readChains().filter((line) => line.id === chainId);
|
|
}
|
|
|
|
/**
|
|
* Full-death one node (or one argument, by its arg_ id). Returns null
|
|
* when no such node/chain exists (the orchestration maps that to 404);
|
|
* rewrites only the ledgers that changed (unchanged files keep their
|
|
* mtimes — the version stamp moves only when something really did).
|
|
*/
|
|
export function deleteNodeTraces(graphStore: GraphStore, nodeId: string): NodeDeletionStats | null {
|
|
const chainLines = graphStore.readChains();
|
|
|
|
// The argument branch: an arg_ id names a CHAIN, not a proposition —
|
|
// its lines die, and that is the whole death (the member propositions
|
|
// survive: deleting an argument spares its premises/conclusion).
|
|
if (nodeId.startsWith("arg_")) {
|
|
const outChains = chainLines.filter((line) => line.id !== nodeId);
|
|
if (outChains.length === chainLines.length) return null; // unknown argument
|
|
graphStore.rewriteLedgers({ chains: outChains });
|
|
const positions = graphStore.readPositions();
|
|
if (positions[nodeId] !== undefined) {
|
|
const { [nodeId]: _dead, ...rest } = positions;
|
|
graphStore.writePositions(rest);
|
|
}
|
|
return { chainsRemoved: chainLines.length - outChains.length };
|
|
}
|
|
|
|
const nodeLines = nodeLinesOf(graphStore, nodeId);
|
|
if (nodeLines.length === 0) return null;
|
|
|
|
const outChains = chainLines.filter(
|
|
(line) => line.conclusion !== nodeId && !line.premises.includes(nodeId),
|
|
);
|
|
|
|
// Only the touched ledgers: the node's own lines always die (its file
|
|
// must move), everything else rewrites only when rows actually drop.
|
|
const outNodes = graphStore.readNodes().filter((line) => line.id !== nodeId);
|
|
graphStore.rewriteLedgers({
|
|
nodes: outNodes,
|
|
...(outChains.length !== chainLines.length ? { chains: outChains } : {}),
|
|
});
|
|
|
|
// The resting positions die with the node and every dead chain.
|
|
const deadChainIds = new Set(chainLines.filter((line) => !outChains.includes(line)).map((line) => line.id));
|
|
const positions = graphStore.readPositions();
|
|
const prunedPositions = Object.fromEntries(
|
|
Object.entries(positions).filter(([id]) => id !== nodeId && !deadChainIds.has(id)),
|
|
);
|
|
if (Object.keys(prunedPositions).length !== Object.keys(positions).length) {
|
|
graphStore.writePositions(prunedPositions);
|
|
}
|
|
|
|
return {
|
|
chainsRemoved: chainLines.length - outChains.length,
|
|
};
|
|
}
|