Amos
59e1fee850
The chat turn is now composed, not implemented, by chat-handler.ts:
- src/server/turn-service.ts: one named, error-contained seam per turn
responsibility — buildTeacherContext (W8 read channel), persistTurn
(canonical state write), spawnTurnJobs (async protocol kick-off),
foldTurnIntoGraph (session→graph consolidation; the extraction-pipeline
stage swaps this body behind the same seam). Each takes its deps
explicitly; failures log one [chat <id>] line and never touch the
response.
- chat-handler.ts wires: storage ports (stores), the job runner, the
teacher tools (ctx = chatId + injected ChatStore), and the services.
It no longer contains any logic beyond request validation.
Agent layer now receives dependencies instead of importing them — a new
lint zone enforces it (src/agent never imports src/server or src/store;
verified to fire both ways):
- runner.ts: createJobRunner({ chatStore, jobStore }) factory returning
the spawn hook + the three job runners; the model-override test seam
stays module-level. Bodies otherwise verbatim.
- plan tools: persist through the ctx-injected ChatStore
(TeacherToolContext = { chatId, chatStore }).
- teacher-agent's dependency-free default registry is now the true
client-side set: questionTools + jobTools (jobTools was ctx-parameter-
shaped but never used its ctx — now honestly context-free). Production
always passes createTeacherTools({ chatId, chatStore }); tests that
drive a bare mock model get the client-side set unchanged.
Zero behavior change: tsc clean, 190/190 tests, eslint clean, production
build clean. Tests inject the same fs ports the chat-handler does.
73 lines
2.7 KiB
JavaScript
73 lines
2.7 KiB
JavaScript
import { defineConfig, globalIgnores } from "eslint/config";
|
|
import nextPlugin from "@next/eslint-plugin-next";
|
|
import tsParser from "@typescript-eslint/parser";
|
|
import importPlugin from "eslint-plugin-import";
|
|
|
|
/**
|
|
* ESLint with one job here: ENFORCE THE IMPORT LAW (the shell/core
|
|
* architecture, docs/architecture.md). Everything else stays out of the
|
|
* way — this is not a style linter.
|
|
*
|
|
* components/** → "@/src/core" (the pure core barrel) — ONLY
|
|
* app/** → "@/src/core" + "@/src/server" (the server barrel) — ONLY
|
|
* src/core/** → never imports src/agent, src/server, src/store (pure
|
|
* core: adapters implement core/ports.ts, never the reverse)
|
|
* src/agent/** → never imports src/server, src/store (dependencies —
|
|
* the storage ports, the composition — arrive via
|
|
* factories/closures from the chat-handler)
|
|
*
|
|
* tests/ and scripts/ are internal — unrestricted.
|
|
*/
|
|
|
|
export default defineConfig([
|
|
globalIgnores([".next/**", "node_modules/**", "data/**", "next-env.d.ts", "scripts/**"]),
|
|
{
|
|
files: ["**/*.{js,mjs,ts,tsx}"],
|
|
languageOptions: {
|
|
parser: tsParser,
|
|
parserOptions: { ecmaVersion: "latest", sourceType: "module" },
|
|
},
|
|
plugins: { "@next/next": nextPlugin, import: importPlugin },
|
|
settings: {
|
|
"import/resolver": { typescript: { alwaysTryTypes: true } },
|
|
},
|
|
rules: {
|
|
...nextPlugin.configs.recommended.rules,
|
|
"import/no-restricted-paths": [
|
|
"error",
|
|
{
|
|
zones: [
|
|
{
|
|
target: "./components",
|
|
from: "./src",
|
|
// NOTE: the plugin resolves `except` relative to the zone's `from` path.
|
|
except: ["./core/index.ts"],
|
|
message:
|
|
"Browser shell imports ONLY the pure core barrel: `from \"@/src/core\"` (architecture: docs/architecture.md).",
|
|
},
|
|
{
|
|
target: "./app",
|
|
from: "./src",
|
|
except: ["./core/index.ts", "./server/index.ts"],
|
|
message:
|
|
"app/ (transport + server components) imports ONLY the barrels: `@/src/core` and `@/src/server` (architecture: docs/architecture.md).",
|
|
},
|
|
{
|
|
target: "./src/core",
|
|
from: ["./src/agent", "./src/server", "./src/store"],
|
|
message:
|
|
"Pure core never imports IO layers (agent/server/store): adapters implement core/ports.ts, and the composition root (src/server/stores.ts) passes them in (architecture: docs/architecture.md).",
|
|
},
|
|
{
|
|
target: "./src/agent",
|
|
from: ["./src/server", "./src/store"],
|
|
message:
|
|
"The agent layer receives its dependencies (storage ports via factories/closures) — it never imports the server layer or store adapters (architecture: docs/architecture.md).",
|
|
},
|
|
],
|
|
},
|
|
],
|
|
},
|
|
},
|
|
]);
|