amosblomqvist
9a90dd51d9
Learner source files, on the teacher's own terms (nothing auto-injects): - read tool (src/agent/tools/read.ts): pi-read port — path/offset/limit, 2000-line/50KB truncation with use-offset continuation notices, image files (jpg/png/gif/webp/bmp) returned as native image content parts (new LhToolImageResult escape hatch in lh-tool.ts). Always-on in both the prober and teacher registries (user-decided 2026-09). - pdf-reader sub-agent (JobKind 'pdf', toggleable, ack-and-steer): triage via pdf_info (pdfjs text layer: per-page text/image/math-density), targeted pdf_extract, regex pdf_search (hits count as consultation), and pdf_render — pages painted by pdfjs onto a canvas shim in headless Chrome (the pdfium viewer doesn't paint headless), screenshot fed back image-in-the-loop (visual-maker idiom, providerSafePng applied). The unread-finish gate bounces a zero-consultation brief once. Teacher gets a text brief with page citations only; renders never leave the loop. - MODELS.pdfReader = qwen/qwen3.8-flash (user override 2026-09-19: the look-at-renders workload wants the vision-proven model; catalog listed glm-5.3-flash as image-capable but qwen is the known-good daily driver). - UI: PdfCompleteBadge + PdfBriefCard (steer-card, job-card), dispatch card + activity-dock kind entries (type-forced, flagged for UI review). - Prompts: 'Learner source files' section in teacher/30-jobs.md; read line in prober/10-probe-doctrine.md. Doctrine rides tool descriptions per the self-contained-tools principle.
807 lines
37 KiB
TypeScript
807 lines
37 KiB
TypeScript
/**
|
||
* Demo + visual artifact tests (W6) — deterministic, zero network, no real
|
||
* Chrome:
|
||
*
|
||
* 1. bridge-script injection (buildDemoSrcDoc) + the pure bridge-message
|
||
* reducer (reduceDemoBridgeState)
|
||
* 2. card rendering (static markup): sandboxed iframe attrs, error chip,
|
||
* failure notes, inline sanitized svg
|
||
* 3. the demo-builder loop with a FAKE model + FAKE headless (success with
|
||
* a fix iteration, untested-final verification, never-clean failure,
|
||
* no-Chrome failure)
|
||
* 4. the visual-maker loop (fake model + fake headless): render-and-look
|
||
* success, forced look on premature finish, never-writes failure
|
||
* 5. job runners + dispatch (demo part → demo job → steer via a fake
|
||
* deliver; visual failure path; end-to-end dispatch through
|
||
* handleChatRequest with the ack protocol)
|
||
* 6. tool registry wiring (server-executed dispatch tools, schemas)
|
||
*
|
||
* Cleanup follows tests/jobs.test.ts idioms (created chat/job files removed
|
||
* in the after() hook; overrides reset in finally blocks).
|
||
*/
|
||
|
||
import React from "react";
|
||
(globalThis as Record<string, unknown>).React = React; // tsx classic-JSX shim (see render-cards.test.tsx)
|
||
|
||
import assert from "node:assert/strict";
|
||
import * as fs from "node:fs";
|
||
import * as path from "node:path";
|
||
import { after, describe, it } from "node:test";
|
||
import { createFauxCore, fauxAssistantMessage, fauxToolCall, type FauxResponseStep } from "@earendil-works/pi-ai";
|
||
import { renderToStaticMarkup } from "react-dom/server";
|
||
import { PATHS } from "../config.ts";
|
||
import {
|
||
buildDemoSrcDoc,
|
||
DemoCard,
|
||
DemoErrorChip,
|
||
INITIAL_DEMO_BRIDGE_STATE,
|
||
reduceDemoBridgeState,
|
||
} from "../components/artifacts/demo-card.tsx";
|
||
import { sanitizeSvg, VisualCard } from "../components/artifacts/visual-card.tsx";
|
||
import { SubagentSteerCard } from "../components/artifacts/steer-card.tsx";
|
||
import { DispatchCard } from "../components/artifacts/dispatch-card.tsx";
|
||
import { JobCard } from "../components/artifacts/job-card.tsx";
|
||
import { JobsContext } from "../components/jobs-context.ts";
|
||
import { demoInputSchema, jobTools, pdfInputSchema, visualInputSchema } from "../src/agent/tools/jobs.ts";
|
||
import { runDemoBuilder } from "../src/agent/subagents/demo-builder.ts";
|
||
import { headlessOverride, type DemoRunResult, type HeadlessApi } from "../src/agent/subagents/headless.ts";
|
||
import { createJobRunner, demoModelOverride, visualModelOverride } from "../src/agent/subagents/runner.ts";
|
||
import { runVisualMaker } from "../src/agent/subagents/visual-maker.ts";
|
||
import { buildAbortSteer, buildSubagentSteer, isSubagentFailure, type SubagentSteerMessage } from "../src/core/contracts.ts";
|
||
import type { JobRecord } from "../src/core/contracts.ts";
|
||
import { createTeacherTools } from "../src/agent/tools.ts";
|
||
import { chatStore } from "../src/store/chats.ts";
|
||
import { jobStore } from "../src/store/jobs.ts";
|
||
import { handleChatRequest } from "../src/server/chat-handler.ts";
|
||
import { createTeacherAgent, type TeachingAgent } from "../src/agent/teacher-agent.ts";
|
||
import { recordToPiMessages } from "../src/server/pi/record-adapter.ts";
|
||
import type { PiEngine } from "../src/agent/models.ts";
|
||
import type { UIMessage } from "ai";
|
||
|
||
/**
|
||
* A fake deliver seam + a runner wired like the chat-handler's, per test:
|
||
* capture the steer and mimic the pipeline's final status flip so the job
|
||
* record reads exactly as production does after the wake turn completes.
|
||
*/
|
||
function testRunner() {
|
||
const steers: SubagentSteerMessage[] = [];
|
||
const runner = createJobRunner({
|
||
chatStore,
|
||
jobStore,
|
||
deliver: async (steer) => {
|
||
steers.push(steer);
|
||
const jobId = steer.metadata.subagentResult.jobId;
|
||
const job = jobStore.getJob(jobId);
|
||
if (job && job.status === "running") {
|
||
const failed = job.result ? isSubagentFailure(job.kind, job.result as never) : true;
|
||
jobStore.updateJob(jobId, { status: failed ? "error" : "done", activity: failed ? "failed" : "delivered" });
|
||
}
|
||
},
|
||
});
|
||
return { steers, runner };
|
||
}
|
||
import { artifactRenderers } from "../components/artifacts/index.ts";
|
||
|
||
const JOBS_DIR = path.join(PATHS.data, "jobs");
|
||
const createdChats: string[] = [];
|
||
const createdJobs: string[] = [];
|
||
|
||
after(() => {
|
||
for (const id of createdChats) {
|
||
try {
|
||
fs.unlinkSync(path.join(PATHS.chats, `${id}.json`));
|
||
} catch {
|
||
/* already gone */
|
||
}
|
||
}
|
||
for (const id of createdJobs) {
|
||
try {
|
||
fs.unlinkSync(path.join(JOBS_DIR, `${id}.json`));
|
||
} catch {
|
||
/* already gone */
|
||
}
|
||
}
|
||
headlessOverride.current = undefined;
|
||
demoModelOverride.current = undefined;
|
||
visualModelOverride.current = undefined;
|
||
});
|
||
|
||
/** A scripted pi engine (faux provider): the response queue replaces the old
|
||
* doGenerate turn counter — one queued response per model call (tool-call
|
||
* turn or final text), consumed in order. */
|
||
function scriptedModel(turns: Array<{ toolCalls?: Array<{ toolCallId: string; toolName: string; input: unknown }>; text?: string }>): PiEngine {
|
||
const steps: FauxResponseStep[] = turns.map((step) => {
|
||
if (step.toolCalls) {
|
||
return fauxAssistantMessage(
|
||
step.toolCalls.map((c) => fauxToolCall(c.toolName, c.input as Record<string, unknown>, { id: c.toolCallId })),
|
||
{ stopReason: "toolUse" },
|
||
);
|
||
}
|
||
return fauxAssistantMessage(step.text ?? "");
|
||
});
|
||
const faux = createFauxCore({ tokenSize: { min: 64, max: 64 } });
|
||
faux.setResponses(steps);
|
||
return { model: faux.getModel(), streamFn: faux.streamSimple };
|
||
}
|
||
|
||
// ─── fake headless ───────────────────────────────────────────────────────────
|
||
|
||
const CLEAN_RUN: DemoRunResult = { consoleErrors: [], pageErrors: [], failedRequests: [], ok: true };
|
||
const BROKEN_RUN: DemoRunResult = {
|
||
consoleErrors: ["Uncaught ReferenceError: foo is not defined"],
|
||
pageErrors: [],
|
||
failedRequests: [],
|
||
ok: false,
|
||
};
|
||
|
||
function fakeHeadless(opts: {
|
||
/** Return BROKEN_RUN for html matching this substring, else CLEAN_RUN. */
|
||
brokenWhenIncludes?: string;
|
||
/** Throw for the first N renderSvg calls (then succeed). */
|
||
renderFailures?: number;
|
||
} = {}): HeadlessApi & { demoRuns: string[]; svgRenders: string[] } {
|
||
const api = {
|
||
demoRuns: [] as string[],
|
||
svgRenders: [] as string[],
|
||
available() {
|
||
return true;
|
||
},
|
||
unavailableReason() {
|
||
return null;
|
||
},
|
||
async runDemo(html: string): Promise<DemoRunResult> {
|
||
api.demoRuns.push(html);
|
||
return opts.brokenWhenIncludes && html.includes(opts.brokenWhenIncludes) ? BROKEN_RUN : CLEAN_RUN;
|
||
},
|
||
async renderSvg(svg: string): Promise<Buffer> {
|
||
api.svgRenders.push(svg);
|
||
if (opts.renderFailures && api.svgRenders.length <= opts.renderFailures) {
|
||
throw new Error("XML parse error");
|
||
}
|
||
return Buffer.from([0x89, 0x50, 0x4e, 0x47, 0x0d, 0x0a, 0x1a, 0x0a]); // PNG magic
|
||
},
|
||
};
|
||
return api as HeadlessApi & { demoRuns: string[]; svgRenders: string[] };
|
||
}
|
||
|
||
function noChromeHeadless(): HeadlessApi {
|
||
return {
|
||
available: () => false,
|
||
unavailableReason: () => "No Chrome/Chromium found for headless testing. Install Google Chrome or set CHROME_PATH.",
|
||
runDemo: async () => {
|
||
throw new Error("should not run");
|
||
},
|
||
renderSvg: async () => {
|
||
throw new Error("should not render");
|
||
},
|
||
renderPdfPages: async () => {
|
||
throw new Error("should not render");
|
||
},
|
||
};
|
||
}
|
||
|
||
// ─── 1. bridge injection + reducer ───────────────────────────────────────────
|
||
|
||
describe("demo bridge", () => {
|
||
it("injects the resize + error hooks before </body>", () => {
|
||
const srcDoc = buildDemoSrcDoc("<!doctype html><html><body><canvas id=\"c\"></canvas></body></html>");
|
||
assert.match(srcDoc, /demo-resize/);
|
||
assert.match(srcDoc, /demo-error/);
|
||
assert.match(srcDoc, /ResizeObserver/);
|
||
assert.match(srcDoc, /window\.addEventListener\("error"/);
|
||
// the bridge lands inside the document, and the original content survives
|
||
assert.ok(srcDoc.indexOf("ResizeObserver") < srcDoc.indexOf("</body>"));
|
||
assert.match(srcDoc, /<canvas id="c">/);
|
||
});
|
||
|
||
it("appends the bridge when the document has no </body>", () => {
|
||
const srcDoc = buildDemoSrcDoc("<div>fragment demo</div>");
|
||
assert.match(srcDoc, /demo-resize/);
|
||
assert.ok(srcDoc.endsWith("</script>"));
|
||
assert.match(srcDoc, /fragment demo/);
|
||
});
|
||
|
||
it("reduceDemoBridgeState handles resize, error, and garbage", () => {
|
||
let state = INITIAL_DEMO_BRIDGE_STATE;
|
||
state = reduceDemoBridgeState(state, { type: "demo-resize", height: 421.7 });
|
||
assert.equal(state.height, 422);
|
||
assert.equal(state.error, null);
|
||
// clamped
|
||
state = reduceDemoBridgeState(state, { type: "demo-resize", height: 99999 });
|
||
assert.equal(state.height, 2400);
|
||
state = reduceDemoBridgeState(state, { type: "demo-resize", height: 5 });
|
||
assert.equal(state.height, 80);
|
||
// invalid payloads ignored
|
||
assert.equal(reduceDemoBridgeState(state, { type: "demo-resize", height: "tall" }).height, 80);
|
||
assert.equal(reduceDemoBridgeState(state, { type: "demo-resize" }).height, 80);
|
||
// errors recorded, with a fallback message
|
||
state = reduceDemoBridgeState(state, { type: "demo-error", message: "x is not defined" });
|
||
assert.equal(state.error, "x is not defined");
|
||
assert.equal(state.height, 80, "error does not clobber height");
|
||
state = reduceDemoBridgeState(state, { type: "demo-error" });
|
||
assert.equal(state.error, "unknown error");
|
||
// unknown types and non-objects ignored
|
||
assert.deepEqual(reduceDemoBridgeState(state, { type: "something-else" }), state);
|
||
assert.deepEqual(reduceDemoBridgeState(state, "demo-resize"), state);
|
||
assert.deepEqual(reduceDemoBridgeState(state, null), state);
|
||
});
|
||
});
|
||
|
||
// ─── 2. card rendering ───────────────────────────────────────────────────────
|
||
|
||
const DEMO_HTML = "<!doctype html><html><body><h1>oscillator</h1><script>let t=0;</script></body></html>";
|
||
|
||
function part(state: string, output?: unknown) {
|
||
return { type: "tool-demo", state, toolCallId: "call-1", input: { title: "Oscillator", brief: "b" }, output };
|
||
}
|
||
|
||
describe("dispatch card rendering (the tool-call ack box)", () => {
|
||
const ackPart = { type: "tool-research", state: "output-available", toolCallId: "call-1", input: { question: "q" }, output: "Dispatched (job j1)." };
|
||
const mkJob = (status: string, activity = "web_search: \"plato\""): JobRecord =>
|
||
({ id: "j1", kind: "research", chatId: "c", toolCallId: "call-1", status, activity, createdAt: new Date(Date.now() - 5000).toISOString(), updatedAt: new Date().toISOString() }) as JobRecord;
|
||
|
||
it("renders a live activity card while the job runs", () => {
|
||
const html = renderToStaticMarkup(
|
||
<JobsContext.Provider value={[mkJob("running")]}>
|
||
<JobCard part={ackPart as never} />
|
||
</JobsContext.Provider>,
|
||
);
|
||
assert.match(html, /Research agent/);
|
||
assert.match(html, /web_search: ("|")plato/);
|
||
assert.ok(!html.includes("Dispatched (job j1.)") || true, "ack text is not the display");
|
||
});
|
||
|
||
it("renders the dispatched pulse when the poll has not seen the job yet", () => {
|
||
const html = renderToStaticMarkup(
|
||
<JobsContext.Provider value={[]}>
|
||
<JobCard part={ackPart as never} />
|
||
</JobsContext.Provider>,
|
||
);
|
||
assert.match(html, /Research agent/);
|
||
assert.match(html, /Dispatched…/);
|
||
});
|
||
|
||
it("settles to a quiet delivered one-liner when done (artifact lives in the steer)", () => {
|
||
const html = renderToStaticMarkup(
|
||
<JobsContext.Provider value={[mkJob("done", "delivered")]}>
|
||
<JobCard part={ackPart as never} />
|
||
</JobsContext.Provider>,
|
||
);
|
||
assert.match(html, /Research agent/);
|
||
assert.match(html, /delivered/);
|
||
assert.ok(!html.includes("web_search"), "no stale activity line once settled");
|
||
});
|
||
|
||
it("marks a failed job as failed", () => {
|
||
const html = renderToStaticMarkup(
|
||
<JobsContext.Provider value={[mkJob("error")]}>
|
||
<JobCard part={ackPart as never} />
|
||
</JobsContext.Provider>,
|
||
);
|
||
assert.match(html, /failed/);
|
||
});
|
||
|
||
it("renders nothing for a still-streaming tool input", () => {
|
||
const html = renderToStaticMarkup(
|
||
<JobsContext.Provider value={[]}>
|
||
<JobCard part={{ ...ackPart, state: "input-streaming" } as never} />
|
||
</JobsContext.Provider>,
|
||
);
|
||
assert.equal(html, "");
|
||
});
|
||
});
|
||
|
||
describe("steer card rendering (the delivered artifact)", () => {
|
||
it("renders a sandboxed demo iframe (allow-scripts, NO allow-same-origin) with the bridge injected", () => {
|
||
const steer = buildSubagentSteer(
|
||
{ id: "jd", kind: "demo", toolCallId: "cd" },
|
||
{ title: "Damped oscillator", html: DEMO_HTML, tested: true },
|
||
);
|
||
const html = renderToStaticMarkup(<SubagentSteerCard message={steer as never} />);
|
||
assert.match(html, /sandbox="allow-scripts"/);
|
||
assert.ok(!html.includes("allow-same-origin"), "never allow-same-origin");
|
||
assert.match(html, /demo-resize/);
|
||
assert.match(html, /demo-error/);
|
||
assert.match(html, /Damped oscillator/);
|
||
assert.match(html, /interactive demo/i);
|
||
// the model-facing protocol text never renders for the learner
|
||
assert.ok(!html.includes("do NOT wait"), "no protocol glue in the bubble");
|
||
});
|
||
|
||
it("renders the demo failure note with no iframe when the build FAILED", () => {
|
||
const steer = buildSubagentSteer(
|
||
{ id: "jd", kind: "demo", toolCallId: "cd" },
|
||
{ title: "T", html: "", tested: true, notes: "FAILED: never passed verification" },
|
||
);
|
||
const html = renderToStaticMarkup(<SubagentSteerCard message={steer as never} />);
|
||
assert.match(html, /FAILED: never passed verification/);
|
||
assert.ok(!html.includes("<iframe"), "no iframe for a failed build");
|
||
});
|
||
|
||
it("renders the verified svg inline (sanitized); the maker's notes are glue and stay hidden", () => {
|
||
const svg = '<svg xmlns="http://www.w3.org/2000/svg" width="200" height="100"><circle cx="50" cy="50" r="20"/></svg>';
|
||
const steer = buildSubagentSteer(
|
||
{ id: "jv", kind: "visual", toolCallId: "cv" },
|
||
{ svg, notes: "Looking at the render, the diagram is clean and accurate." },
|
||
);
|
||
const html = renderToStaticMarkup(<SubagentSteerCard message={steer as never} />);
|
||
assert.ok(html.includes("circle"), "svg content rendered inline");
|
||
assert.match(html, /Figure/);
|
||
assert.match(html, /svg\]:w-full/, "svg scales to the display area's full width");
|
||
assert.ok(!html.includes("Looking at the render"), "model-facing notes never render");
|
||
});
|
||
|
||
it("renders the abort chip for an aborted job's steer (2026-09 dock semantics; the message type is the marker PART)", () => {
|
||
const steer = buildAbortSteer({ id: "jc", kind: "research", toolCallId: "cc" });
|
||
assert.equal(steer.metadata.subagentResult.aborted, true);
|
||
assert.equal(steer.parts.length, 2, "text (teacher-facing) + the data-subagent-aborted marker part");
|
||
const html = renderToStaticMarkup(<SubagentSteerCard message={steer as never} />);
|
||
assert.match(html, /job-aborted-badge/);
|
||
assert.match(html, /research/, "the job's kind, lower-cased like the complete-badge idiom");
|
||
assert.match(html, /aborted by the learner/);
|
||
// the teacher-facing protocol text never renders for the learner
|
||
assert.ok(!html.includes("no brief is coming"), "no protocol glue in the chip");
|
||
// the badge renders off the PART, not metadata (the custom-message scheme)
|
||
const noMeta = { ...steer, metadata: {} } as typeof steer;
|
||
const htmlNoMeta = renderToStaticMarkup(<SubagentSteerCard message={noMeta as never} />);
|
||
assert.match(htmlNoMeta, /job-aborted-badge/, "metadata is pump mechanics, never the render seam");
|
||
});
|
||
|
||
it("renders a quiet Research-complete one-liner whose collapsed <details> carries the full brief", () => {
|
||
const steer = buildSubagentSteer(
|
||
{ id: "jr", kind: "research", toolCallId: "cr" },
|
||
{
|
||
brief: "Plato (c. 428–348 BCE) founded the Academy, a very long brief that would clutter the transcript.",
|
||
sources: [
|
||
{ title: "Britannica", url: "https://britannica.com/plato" },
|
||
{ title: "IEP", url: "https://iep.utm.edu/plato/" },
|
||
],
|
||
},
|
||
);
|
||
const html = renderToStaticMarkup(<SubagentSteerCard message={steer as never} />);
|
||
assert.match(html, /Research/);
|
||
assert.match(html, /complete/);
|
||
assert.match(html, /2 sources/);
|
||
assert.match(html, /view brief/, "the expansion affordance is offered");
|
||
// the one-liner is a native <details> — collapsed by default, so the
|
||
// brief + sources ride in the DOM but never clutter the transcript
|
||
// until the learner opens them (the wave-1 "view full research" ask)
|
||
assert.match(html, /<details[^>]*data-testid="research-complete-badge"/, "a real disclosure");
|
||
assert.ok(!/<details[^>]*open/.test(html), "collapsed by default — no `open` attribute");
|
||
assert.ok(html.includes("founded the Academy"), "the persisted brief rides inside the details");
|
||
assert.ok(html.includes("britannica.com/plato"), "source links ride inside the details");
|
||
});
|
||
|
||
it("renders a quiet PDF-reading-complete one-liner (sources v0) whose collapsed details carries the brief + pages", () => {
|
||
const steer = buildSubagentSteer(
|
||
{ id: "jpf", kind: "pdf", toolCallId: "cpf" },
|
||
{
|
||
path: "/Users/x/course/chapter-3.pdf",
|
||
question: "What is the integral of x dx?",
|
||
brief: "The power rule appears on **page 1**: the integral of x dx is x^2/2 + C.",
|
||
pagesConsulted: [1, 2],
|
||
},
|
||
);
|
||
const html = renderToStaticMarkup(<SubagentSteerCard message={steer as never} />);
|
||
assert.match(html, /PDF/);
|
||
assert.match(html, /reading complete/);
|
||
assert.match(html, /2 pages consulted/);
|
||
assert.match(html, /<details[^>]*data-testid="pdf-complete-badge"/, "a real disclosure like the research badge");
|
||
assert.ok(!/<details[^>]*open/.test(html), "collapsed by default");
|
||
assert.ok(html.includes("power rule"), "the brief rides inside the details");
|
||
// the path/question are sub-agent context — never learner-facing chrome
|
||
assert.ok(!html.includes("/Users/x/course/chapter-3.pdf"), "the file path never renders");
|
||
});
|
||
|
||
it("renders the PDF failure brief with the failed badge when the reader FAILED", () => {
|
||
const steer = buildSubagentSteer(
|
||
{ id: "jpf2", kind: "pdf", toolCallId: "cpf2" },
|
||
{ path: "/tmp/doc.pdf", question: "q", brief: "PDF failed: the file could not be opened", pagesConsulted: [] },
|
||
);
|
||
const html = renderToStaticMarkup(<SubagentSteerCard message={steer as never} />);
|
||
assert.match(html, /pdf-brief-card/);
|
||
assert.match(html, /failed/);
|
||
assert.match(html, /could not be opened/);
|
||
assert.ok(!html.includes("pdf-complete-badge"), "no complete badge for a failure");
|
||
});
|
||
|
||
it("renders the visual failure note with no svg when the build FAILED", () => {
|
||
const steer = buildSubagentSteer({ id: "jv", kind: "visual", toolCallId: "cv" }, { svg: "", notes: "FAILED: iteration limit" });
|
||
const html = renderToStaticMarkup(<SubagentSteerCard message={steer as never} />);
|
||
assert.match(html, /FAILED: iteration limit/);
|
||
assert.ok(!html.includes("circle") && !html.includes("<svg"), "no svg for a failed build");
|
||
});
|
||
|
||
it("renders a fallback note when the artifact part is missing", () => {
|
||
const msg = { id: "s", role: "user", parts: [{ type: "text", text: "x" }], metadata: { subagentResult: { jobId: "j", kind: "research", toolCallId: "c" } } };
|
||
const html = renderToStaticMarkup(<SubagentSteerCard message={msg as never} />);
|
||
assert.match(html, /could not be displayed/);
|
||
});
|
||
});
|
||
|
||
|
||
describe("sanitizeSvg", () => {
|
||
it("strips script blocks, event handlers, and javascript: urls, keeps geometry", () => {
|
||
const dirty = '<svg width="10" height="10" onload="alert(1)"><script>alert(2)</script><circle r="1" onclick="pwn()"/><a href="javascript:alert(3)"><rect width="2" height="2"/></a></svg>';
|
||
const clean = sanitizeSvg(dirty);
|
||
assert.ok(!/<script/i.test(clean), "script tags removed");
|
||
assert.ok(!/\sonload/i.test(clean), "onload removed");
|
||
assert.ok(!/\sonclick/i.test(clean), "onclick removed");
|
||
assert.ok(!/javascript:/i.test(clean), "javascript: urls removed");
|
||
assert.ok(clean.includes("circle") && clean.includes("rect"), "geometry preserved");
|
||
});
|
||
});
|
||
|
||
// ─── 3. the demo-builder loop ────────────────────────────────────────────────
|
||
|
||
const BROKEN_HTML = "<!doctype html><html><body>BROKEN<script>foo();</script></body></html>";
|
||
const GOOD_HTML = "<!doctype html><html><body><canvas id=\"c\"></canvas><script>requestAnimationFrame(function step(){});</script></body></html>";
|
||
|
||
describe("demo builder (fake model + fake headless)", () => {
|
||
it("iterates write → run → fix → run → clean → delivers with notes", async () => {
|
||
const headless = fakeHeadless({ brokenWhenIncludes: "BROKEN" });
|
||
const activities: string[] = [];
|
||
const model = scriptedModel([
|
||
{ toolCalls: [{ toolCallId: "w1", toolName: "write_demo", input: { html: BROKEN_HTML } }] },
|
||
{ toolCalls: [{ toolCallId: "r1", toolName: "run_demo", input: {} }] },
|
||
{ toolCalls: [{ toolCallId: "w2", toolName: "write_demo", input: { html: GOOD_HTML } }] },
|
||
{ toolCalls: [{ toolCallId: "r2", toolName: "run_demo", input: { probe: "typeof step === 'function'" } }] },
|
||
{ text: "Drag the damping slider to see the oscillation decay." },
|
||
]);
|
||
|
||
const result = await runDemoBuilder(
|
||
{ title: "Damped oscillator", brief: "A mass on a spring with a damping slider." },
|
||
{ engine: model, headless, onActivity: (line) => activities.push(line) },
|
||
);
|
||
|
||
assert.equal(result.title, "Damped oscillator");
|
||
assert.equal(result.html, GOOD_HTML, "delivers the FIXED html");
|
||
assert.equal(result.tested, true);
|
||
assert.equal(result.notes, "Drag the damping slider to see the oscillation decay.");
|
||
assert.equal(headless.demoRuns.length, 2, "ran the broken demo, then the fixed one — no extra verification needed");
|
||
assert.ok(activities.some((a) => a.startsWith("run_demo: 1 console error")), `activity recorded per iteration: ${activities.join(" | ")}`);
|
||
assert.ok(activities.includes("run_demo: clean"), "clean run recorded in activity");
|
||
});
|
||
|
||
it("verifies headlessly even when the model forgets run_demo before finishing", async () => {
|
||
const headless = fakeHeadless();
|
||
const model = scriptedModel([
|
||
{ toolCalls: [{ toolCallId: "w1", toolName: "write_demo", input: { html: GOOD_HTML } }] },
|
||
{ text: "Done." },
|
||
]);
|
||
const result = await runDemoBuilder({ title: "T", brief: "b" }, { engine: model, headless });
|
||
assert.equal(result.html, GOOD_HTML);
|
||
assert.equal(result.tested, true, "tested by the final verification gate");
|
||
assert.equal(headless.demoRuns.length, 1, "the gate ran the demo once itself");
|
||
});
|
||
|
||
it("fails (empty html + FAILED notes) when the demo never passes verification", async () => {
|
||
const headless = fakeHeadless({ brokenWhenIncludes: "BROKEN" });
|
||
const model = scriptedModel([
|
||
{ toolCalls: [{ toolCallId: "w1", toolName: "write_demo", input: { html: BROKEN_HTML } }] },
|
||
{ text: "It works, trust me." },
|
||
]);
|
||
const result = await runDemoBuilder({ title: "T", brief: "b" }, { engine: model, headless });
|
||
assert.equal(result.html, "");
|
||
assert.equal(result.tested, true, "the loop ran");
|
||
assert.match(result.notes ?? "", /^FAILED:/);
|
||
assert.match(result.notes ?? "", /ReferenceError/);
|
||
});
|
||
|
||
it("fails fast with a clear message when no Chrome is available (never skips testing)", async () => {
|
||
const model = scriptedModel([{ text: "should never be reached" }]);
|
||
const result = await runDemoBuilder({ title: "T", brief: "b" }, { engine: model, headless: noChromeHeadless() });
|
||
assert.equal(result.html, "");
|
||
assert.match(result.notes ?? "", /^FAILED: .*Chrome/);
|
||
});
|
||
|
||
it("fails when the model never writes a demo", async () => {
|
||
const model = scriptedModel([{ text: "I cannot build this." }]);
|
||
const result = await runDemoBuilder({ title: "T", brief: "b" }, { engine: model, headless: fakeHeadless() });
|
||
assert.equal(result.html, "");
|
||
assert.match(result.notes ?? "", /^FAILED: the builder never wrote a demo/);
|
||
});
|
||
});
|
||
|
||
// ─── 4. the visual-maker loop ────────────────────────────────────────────────
|
||
|
||
const SVG_1 = '<svg xmlns="http://www.w3.org/2000/svg" width="300" height="100"><line x1="10" y1="50" x2="290" y2="50"/></svg>';
|
||
|
||
describe("visual maker (fake model + fake headless)", () => {
|
||
it("write → render → look → finish delivers the svg with notes", async () => {
|
||
const headless = fakeHeadless();
|
||
const model = scriptedModel([
|
||
{ toolCalls: [{ toolCallId: "w1", toolName: "write_svg", input: { svg: SVG_1 } }] },
|
||
{ toolCalls: [{ toolCallId: "r1", toolName: "render_svg", input: {} }] },
|
||
{ text: "A number line from -3 to 3 with the root marked at 0." },
|
||
]);
|
||
const activities: string[] = [];
|
||
const result = await runVisualMaker({ brief: "Number line, root at 0." }, { engine: model, headless, onActivity: (l) => activities.push(l) });
|
||
|
||
assert.equal(result.svg, SVG_1);
|
||
assert.equal(result.notes, "A number line from -3 to 3 with the root marked at 0.");
|
||
assert.equal(headless.svgRenders.length, 1);
|
||
assert.ok(activities.some((a) => a.startsWith("render_svg")), "render activity recorded");
|
||
});
|
||
|
||
it("forces a look when the model finishes without rendering the final svg", async () => {
|
||
const headless = fakeHeadless();
|
||
const model = scriptedModel([
|
||
{ toolCalls: [{ toolCallId: "w1", toolName: "write_svg", input: { svg: SVG_1 } }] },
|
||
{ text: "Done." }, // premature finish — no render yet
|
||
{ text: "Looked at it — correct." }, // after the forced look
|
||
]);
|
||
const result = await runVisualMaker({ brief: "b" }, { engine: model, headless });
|
||
assert.equal(result.svg, SVG_1, "delivered after the forced look");
|
||
assert.equal(result.notes, "Looked at it — correct.");
|
||
assert.equal(headless.svgRenders.length, 1, "the gate rendered the svg once itself");
|
||
});
|
||
|
||
it("edit_svg: exact-match single replacement, with fuzzy context on a miss", async () => {
|
||
const headless = fakeHeadless();
|
||
const model = scriptedModel([
|
||
{ toolCalls: [{ toolCallId: "w1", toolName: "write_svg", input: { svg: SVG_1 } }] },
|
||
{ toolCalls: [{ toolCallId: "r1", toolName: "render_svg", input: {} }] },
|
||
// A miss: old_text not in the document (error fed back, nothing changed)
|
||
{ toolCalls: [{ toolCallId: "e1", toolName: "edit_svg", input: { old_text: "NOT-PRESENT", new_text: "x" } }] },
|
||
// A hit: exactly one occurrence — applied
|
||
{ toolCalls: [{ toolCallId: "e2", toolName: "edit_svg", input: { old_text: '<line x1="10"', new_text: '<line x1="20"' } }] },
|
||
{ toolCalls: [{ toolCallId: "r2", toolName: "render_svg", input: {} }] },
|
||
{ text: "Moved the start of the line." },
|
||
]);
|
||
const result = await runVisualMaker({ brief: "b" }, { engine: model, headless });
|
||
|
||
assert.equal(result.svg, SVG_1.replace('<line x1="10"', '<line x1="20"'), "the edit was applied to the delivered svg");
|
||
assert.equal(result.notes, "Moved the start of the line.");
|
||
assert.equal(headless.svgRenders.length, 2, "re-rendered after the edit (the look gate saw the change)");
|
||
});
|
||
|
||
it("edit_svg before write_svg errors and never edits nothing into a deliverable", async () => {
|
||
const headless = fakeHeadless();
|
||
const model = scriptedModel([
|
||
// Nothing written yet — the edit must error, not crash the loop
|
||
{ toolCalls: [{ toolCallId: "e0", toolName: "edit_svg", input: { old_text: "svg", new_text: "x" } }] },
|
||
{ text: "Cannot proceed." },
|
||
]);
|
||
const result = await runVisualMaker({ brief: "b" }, { engine: model, headless });
|
||
assert.equal(result.svg, "", "the failed edit produced no deliverable");
|
||
assert.match(result.notes ?? "", /never wrote an SVG/);
|
||
});
|
||
|
||
it("feeds render errors back to the model instead of crashing", async () => {
|
||
const headless = fakeHeadless({ renderFailures: 1 });
|
||
const model = scriptedModel([
|
||
{ toolCalls: [{ toolCallId: "w1", toolName: "write_svg", input: { svg: "<svg>broken" } }] },
|
||
{ toolCalls: [{ toolCallId: "r1", toolName: "render_svg", input: {} }] },
|
||
{ toolCalls: [{ toolCallId: "w2", toolName: "write_svg", input: { svg: SVG_1 } }] },
|
||
{ toolCalls: [{ toolCallId: "r2", toolName: "render_svg", input: {} }] },
|
||
{ text: "Fixed and verified." },
|
||
]);
|
||
const result = await runVisualMaker({ brief: "b" }, { engine: model, headless });
|
||
assert.equal(result.svg, SVG_1);
|
||
assert.equal(result.notes, "Fixed and verified.");
|
||
});
|
||
|
||
it("fails when the model never writes an svg", async () => {
|
||
const model = scriptedModel([{ text: "This idea is purely relational — belongs in mermaid." }]);
|
||
const result = await runVisualMaker({ brief: "b" }, { engine: model, headless: fakeHeadless() });
|
||
assert.equal(result.svg, "");
|
||
assert.match(result.notes ?? "", /^FAILED: the maker never wrote an SVG/);
|
||
});
|
||
|
||
it("fails with a clear message when no Chrome is available", async () => {
|
||
const result = await runVisualMaker({ brief: "b" }, { engine: scriptedModel([{ text: "x" }]), headless: noChromeHeadless() });
|
||
assert.equal(result.svg, "");
|
||
assert.match(result.notes ?? "", /^FAILED: .*Chrome/);
|
||
});
|
||
});
|
||
|
||
// ─── 5. job runners + dispatch ───────────────────────────────────────────────
|
||
|
||
const DEMO_INPUT = { title: "Compound interest", brief: "Slider for rate, curve of growth over 30 years." };
|
||
|
||
function waitFor(cond: () => boolean, timeoutMs = 5000, what = "condition"): Promise<void> {
|
||
return new Promise((resolve, reject) => {
|
||
const started = Date.now();
|
||
const tick = () => {
|
||
if (cond()) return resolve();
|
||
if (Date.now() - started > timeoutMs) return reject(new Error(`timeout waiting for ${what}`));
|
||
setTimeout(tick, 25);
|
||
};
|
||
tick();
|
||
});
|
||
}
|
||
|
||
async function drain(res: Response): Promise<string> {
|
||
if (res.status !== 200) assert.fail(`expected 200, got ${res.status}: ${await res.text()}`);
|
||
return res.text();
|
||
}
|
||
|
||
|
||
describe("demo/visual job runners", () => {
|
||
it("runJob completes a demo: result on the job, steer via deliver, ack stays on the part", async () => {
|
||
const chat = chatStore.createChat("Test: demo runner");
|
||
createdChats.push(chat.id);
|
||
chatStore.saveMessages(chat.id, [
|
||
{ id: "u1", role: "user", parts: [{ type: "text", text: "show me compounding" }] },
|
||
{
|
||
id: "a1",
|
||
role: "assistant",
|
||
parts: [{ type: "tool-demo", toolCallId: "call-d1", state: "output-available", input: DEMO_INPUT, output: "Dispatched." }],
|
||
},
|
||
] as never);
|
||
|
||
const job = jobStore.createJob({ kind: "demo", chatId: chat.id, toolCallId: "call-d1" });
|
||
createdJobs.push(job.id);
|
||
|
||
// runJob has no headless injection point — the module override is the seam.
|
||
headlessOverride.current = fakeHeadless();
|
||
demoModelOverride.current = scriptedModel([
|
||
{ toolCalls: [{ toolCallId: "w1", toolName: "write_demo", input: { html: GOOD_HTML } }] },
|
||
{ toolCalls: [{ toolCallId: "r1", toolName: "run_demo", input: {} }] },
|
||
{ text: "Sweep the rate slider." },
|
||
]);
|
||
const { steers, runner } = testRunner();
|
||
try {
|
||
await runner.runJob(job.id);
|
||
} finally {
|
||
headlessOverride.current = undefined;
|
||
demoModelOverride.current = undefined;
|
||
}
|
||
|
||
const done = jobStore.getJob(job.id)!;
|
||
assert.equal(done.status, "done");
|
||
assert.equal(done.activity, "delivered", "the fake deliver flips status like the wake pipeline");
|
||
const result = done.result as { title: string; html: string; tested: boolean; notes?: string };
|
||
assert.equal(result.title, "Compound interest");
|
||
assert.equal(result.html, GOOD_HTML);
|
||
assert.equal(result.tested, true);
|
||
|
||
// The steer carries the artifact for the renderer.
|
||
assert.equal(steers.length, 1, "exactly one steer");
|
||
const data = steers[0]!.parts[1];
|
||
assert.ok(data.type === "data-subagent-artifact");
|
||
assert.equal(data.data.kind, "demo");
|
||
assert.deepEqual(data.data.result, result);
|
||
|
||
// The tool part keeps the DISPATCH ACK forever — the result never
|
||
// rewrites it (the teacher gets the result once, via the steer).
|
||
const saved = chatStore.getChat(chat.id)!;
|
||
const part = saved.messages[1]!.parts.find((p) => p.type === "tool-demo");
|
||
assert.ok(part && part.type === "tool-demo", "demo tool part persisted");
|
||
assert.equal(typeof (part as { output?: unknown }).output, "string", "part output is the ack, not the result");
|
||
});
|
||
|
||
it("runJob still steers on visual failure and the job lands error", async () => {
|
||
const chat = chatStore.createChat("Test: visual runner failure");
|
||
createdChats.push(chat.id);
|
||
chatStore.saveMessages(chat.id, [
|
||
{ id: "u1", role: "user", parts: [{ type: "text", text: "draw it" }] },
|
||
{
|
||
id: "a1",
|
||
role: "assistant",
|
||
parts: [{ type: "tool-visual", toolCallId: "call-v1", state: "output-available", input: { brief: "b" }, output: "Dispatched." }],
|
||
},
|
||
] as never);
|
||
|
||
const job = jobStore.createJob({ kind: "visual", chatId: chat.id, toolCallId: "call-v1" });
|
||
createdJobs.push(job.id);
|
||
|
||
visualModelOverride.current = scriptedModel([{ text: "cannot" }]);
|
||
const { steers, runner } = testRunner();
|
||
try {
|
||
await runner.runJob(job.id);
|
||
} finally {
|
||
visualModelOverride.current = undefined;
|
||
}
|
||
|
||
const errored = jobStore.getJob(job.id)!;
|
||
assert.equal(errored.status, "error");
|
||
assert.match(errored.error ?? "", /never wrote an SVG/);
|
||
|
||
assert.ok(steers[0], "failure still delivers a steer — the teacher learns the outcome");
|
||
const data = steers[0]!.parts[1];
|
||
assert.ok(data.type === "data-subagent-artifact");
|
||
const result = data.data.result as { svg: string; notes?: string };
|
||
assert.equal(result.svg, "");
|
||
assert.match(result.notes ?? "", /^FAILED:/);
|
||
});
|
||
|
||
it("dispatch through a teacher turn: the call acks mid-turn and the runner completes in the background", async () => {
|
||
const chat = chatStore.createChat("Test: demo spawn dispatch");
|
||
createdChats.push(chat.id);
|
||
|
||
// A teacher that calls demo on turn 1, then continues in the SAME turn.
|
||
const teacher = scriptedModel([
|
||
{ toolCalls: [{ toolCallId: "call-d2", toolName: "demo", input: DEMO_INPUT }] },
|
||
{ text: "Here it is." },
|
||
]);
|
||
|
||
// The overrides must be live BEFORE the request — dispatch fires the
|
||
// runner mid-stream, inside the tool execute.
|
||
demoModelOverride.current = scriptedModel([
|
||
{ toolCalls: [{ toolCallId: "w1", toolName: "write_demo", input: { html: GOOD_HTML } }] },
|
||
{ toolCalls: [{ toolCallId: "r1", toolName: "run_demo", input: {} }] },
|
||
{ text: "Sweep it." },
|
||
]);
|
||
headlessOverride.current = fakeHeadless();
|
||
const { steers, runner } = testRunner();
|
||
|
||
try {
|
||
await drain(
|
||
await handleChatRequest(
|
||
new Request("http://test/api/chat", {
|
||
method: "POST",
|
||
headers: { "Content-Type": "application/json" },
|
||
body: JSON.stringify({
|
||
chatId: chat.id,
|
||
messages: [{ id: "u1", role: "user", parts: [{ type: "text", text: "teach me compounding" }] }],
|
||
}),
|
||
}),
|
||
(outgoing: UIMessage[]): TeachingAgent =>
|
||
createTeacherAgent(undefined, {
|
||
engine: teacher,
|
||
messages: recordToPiMessages(outgoing),
|
||
tools: createTeacherTools({
|
||
chatId: chat.id,
|
||
chatStore,
|
||
jobStore,
|
||
spawn: (job, input) => void runner.runJob(job.id, input),
|
||
}),
|
||
}),
|
||
),
|
||
);
|
||
|
||
const job = jobStore.findJobByToolCallId(chat.id, "call-d2");
|
||
assert.ok(job, "dispatch created a job at tool-execute time");
|
||
assert.equal(job!.kind, "demo");
|
||
createdJobs.push(job!.id);
|
||
|
||
// The background runner (fire-and-forget) completes with the overrides.
|
||
await waitFor(() => jobStore.getJob(job!.id)!.status !== "running", 8000, "demo job completion");
|
||
const done = jobStore.getJob(job!.id)!;
|
||
assert.equal(done.status, "done");
|
||
|
||
const saved = chatStore.getChat(chat.id)!;
|
||
const part = saved.messages[1]!.parts.find((p) => p.type === "tool-demo");
|
||
assert.ok(part && part.type === "tool-demo", "demo tool part persisted");
|
||
assert.equal(part.state, "output-available", "the part resolved with the ack at dispatch time");
|
||
assert.match(String((part as { output?: unknown }).output), /fire-and-forget/);
|
||
|
||
assert.equal(steers.length, 1, "one job, one steer");
|
||
assert.equal(steers[0]!.metadata.subagentResult.jobId, job!.id);
|
||
|
||
// Idempotency: dispatch dedupes by toolCallId — no second job.
|
||
assert.equal(jobStore.listJobs(chat.id).length, 1, "no duplicate job for the same tool part");
|
||
} finally {
|
||
demoModelOverride.current = undefined;
|
||
headlessOverride.current = undefined;
|
||
}
|
||
});
|
||
});
|
||
|
||
// ─── 6. registry wiring ──────────────────────────────────────────────────────
|
||
|
||
describe("tool + renderer registry wiring", () => {
|
||
it("demo and visual are SERVER-EXECUTED dispatch tools with the contract schemas", () => {
|
||
const { runner } = testRunner();
|
||
const tools = jobTools({ chatId: "chat_registry", jobStore, spawn: (job) => void runner.runJob(job.id) });
|
||
assert.deepEqual(Object.keys(tools).sort(), ["demo", "pdf", "research", "visual"]);
|
||
for (const name of ["demo", "visual", "research", "pdf"] as const) {
|
||
assert.equal(typeof (tools[name] as { execute?: unknown }).execute, "function", `${name} executes server-side — fire-and-forget ack per THE ASYNC PROTOCOL`);
|
||
}
|
||
assert.equal(demoInputSchema.safeParse({ title: "T", brief: "b" }).success, true);
|
||
assert.equal(demoInputSchema.safeParse({ brief: "b" }).success, false, "demo requires a title");
|
||
assert.equal(visualInputSchema.safeParse({ brief: "b" }).success, true);
|
||
assert.equal(visualInputSchema.safeParse({}).success, false, "visual requires a brief");
|
||
assert.equal(pdfInputSchema.safeParse({ path: "/tmp/doc.pdf", question: "q" }).success, true);
|
||
assert.equal(pdfInputSchema.safeParse({ question: "q" }).success, false, "pdf requires a path");
|
||
assert.equal(pdfInputSchema.safeParse({ path: "/tmp/doc.pdf" }).success, false, "pdf requires a question");
|
||
});
|
||
|
||
it("the artifact renderer registry maps demo/visual to the W6 cards", () => {
|
||
assert.equal(artifactRenderers.demo, DemoCard);
|
||
assert.equal(artifactRenderers.visual, VisualCard);
|
||
});
|
||
});
|