amosblomqvist
b2c89b8c91
The accept-plan UI lands (docs/probe-teach-split.md §4, formerly the interim rule): presenting the plan no longer moves the phase — the learner's ACCEPT does. While the presented plan awaits its verdict, the composer's send square becomes two stacked buttons (green Accept plan / red Decline); typed text rides the verdict as his note, Enter keeps sending plain side questions (phase unmoved), decline asks for a revision and the buttons stay. The seam: accept sends a user message carrying a data-plan-accepted part (PlanAcceptedData in contracts/chat.ts, TeacherUIDataParts 'plan-accepted'); phaseAt3 reads it as the plan→teach event (plan_init demoted to presentation-only); convertToModelMessages drops data parts, so the teacher sees only the text. Mid-lesson rewrites need no fresh verdict — acceptance happens once, at the first presentation. The teacher's planning prompt now ends the turn at presentation and waits for the verdict (never teaches into an unaccepted plan). Gates: tsc clean, 304/304 (phases tests rewritten to the acceptance seam incl. decline/side-question/failed-init cases; composer verdict render tests), lint, build. Live GLM smoke ALL PASS: phase pinned at 'plan' after plan_init, presentation turn carried NO check, accept click flipped the summary to 'teach', then tagged checks moved the map (current=rates, visited=composite); zero console errors.
54 lines
1.7 KiB
TypeScript
54 lines
1.7 KiB
TypeScript
import { renderToStaticMarkup } from "react-dom/server";
|
|
import { describe, it } from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import { Composer } from "../components/composer.tsx";
|
|
|
|
// The plan verdict gate (docs/probe-teach-split.md §4): while the presented
|
|
// plan awaits the learner's word, the composer's send square becomes two
|
|
// stacked buttons — green Accept plan, red Decline.
|
|
|
|
describe("Composer verdict buttons", () => {
|
|
const noop = () => {};
|
|
|
|
it("no verdict: the normal send square renders", () => {
|
|
const html = renderToStaticMarkup(
|
|
<Composer busy={false} value="" onChange={noop} onSend={noop} onStop={noop} canSend />,
|
|
);
|
|
assert.ok(!html.includes("plan-verdict-buttons"));
|
|
assert.ok(html.includes('aria-label="Send"'));
|
|
});
|
|
|
|
it("verdict pending: two stacked buttons replace the send square; stop square gone", () => {
|
|
const html = renderToStaticMarkup(
|
|
<Composer
|
|
busy={false}
|
|
value=""
|
|
onChange={noop}
|
|
onSend={noop}
|
|
onStop={noop}
|
|
canSend
|
|
verdict={{ onAccept: noop, onDecline: noop }}
|
|
/>,
|
|
);
|
|
assert.ok(html.includes('data-testid="plan-verdict-buttons"'));
|
|
assert.ok(html.includes("Accept plan"));
|
|
assert.ok(html.includes("Decline"));
|
|
assert.ok(!html.includes('aria-label="Send"'), "no send square while the verdict pends");
|
|
});
|
|
|
|
it("busy: the stop square wins even while a verdict pends (no verdict mid-turn)", () => {
|
|
const html = renderToStaticMarkup(
|
|
<Composer
|
|
busy
|
|
value=""
|
|
onChange={noop}
|
|
onSend={noop}
|
|
onStop={noop}
|
|
canSend={false}
|
|
verdict={{ onAccept: noop, onDecline: noop }}
|
|
/>,
|
|
);
|
|
assert.ok(html.includes('aria-label="Stop"'));
|
|
assert.ok(!html.includes("plan-verdict-buttons"));
|
|
});
|
|
}); |