amosblomqvist
06032769d2
- dialog: optional 'Anything else?' textarea (typing-only, 2000-char mirror) - API: body gains note? — trimmed, whitespace-only omitted, hard 400 over 2000 - pipeline: note persisted on the set and threaded to both agent stages - agents: THE LEARNER'S NOTE prompt block (present only when set) + the weighed-never-owed stance pinned in both doctrines - fix en route: doubled THE PARAMETERS heading in both prompts since slice 3 (renderParams owns the heading; the literal blocks removed)
70 lines
3.2 KiB
TypeScript
70 lines
3.2 KiB
TypeScript
import { describe, it } from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import { createPracticeSetResponse } from "../src/server/practice.ts";
|
|
|
|
/**
|
|
* The practice create-route's parameter validation (owner, 2026-09-29):
|
|
* the three axes are NAMED LEVELS — exact unions, nothing between. A
|
|
* rung is a rung; a float between rungs, a wrong string, or a missing
|
|
* field is a 400 BEFORE the pipeline is ever reached (these pins only
|
|
* exercise the rejecting paths — the accepting path runs the real
|
|
* pipeline and belongs to the pipeline suite).
|
|
*/
|
|
|
|
const NODE_IDS = { nodeIds: ["n1", "n2", "n3"], title: "Ethics cluster" };
|
|
|
|
async function statusOf(params: unknown): Promise<number> {
|
|
const res = await createPracticeSetResponse({ ...NODE_IDS, params });
|
|
return res.status;
|
|
}
|
|
|
|
describe("createPracticeSetResponse — strict named-level params", () => {
|
|
it("floats between levels → 400", async () => {
|
|
assert.equal(await statusOf({ ladderRung: 2.5, cueDistance: 1, presentation: "theory" }), 400);
|
|
assert.equal(await statusOf({ ladderRung: 2, cueDistance: 1.5, presentation: "theory" }), 400);
|
|
});
|
|
|
|
it("out-of-range integers → 400", async () => {
|
|
assert.equal(await statusOf({ ladderRung: 5, cueDistance: 1, presentation: "theory" }), 400);
|
|
assert.equal(await statusOf({ ladderRung: -1, cueDistance: 1, presentation: "theory" }), 400);
|
|
assert.equal(await statusOf({ ladderRung: 2, cueDistance: 3, presentation: "theory" }), 400);
|
|
});
|
|
|
|
it("wrong presentation → 400", async () => {
|
|
assert.equal(await statusOf({ ladderRung: 2, cueDistance: 1, presentation: "real-world" }), 400);
|
|
assert.equal(await statusOf({ ladderRung: 2, cueDistance: 1, presentation: 1 }), 400);
|
|
});
|
|
|
|
it("missing / legacy float fields → 400", async () => {
|
|
assert.equal(await statusOf({ ladderRung: 2, cueDistance: 1 }), 400);
|
|
assert.equal(await statusOf({ searchSolutionRatio: 0.7, cueDistance: 0.4, presentation: 0.6 }), 400, "legacy dials are dead");
|
|
assert.equal(await statusOf("high"), 400);
|
|
});
|
|
});
|
|
|
|
describe("createPracticeSetResponse — the learner's note (owner, 2026-09-29)", () => {
|
|
const PARAMS = { ladderRung: 2, cueDistance: 1, presentation: "theory" } as const;
|
|
|
|
it("non-string note → 400", async () => {
|
|
const res = await createPracticeSetResponse({ ...NODE_IDS, params: PARAMS, note: 42 });
|
|
assert.equal(res.status, 400);
|
|
});
|
|
|
|
it("over 2000 characters → 400 (the API is the law; the textarea's maxLength mirrors it)", async () => {
|
|
const res = await createPracticeSetResponse({ ...NODE_IDS, params: PARAMS, note: "x".repeat(2001) });
|
|
assert.equal(res.status, 400);
|
|
const body = (await res.json()) as { error: string };
|
|
assert.match(body.error, /over 2000 characters/);
|
|
});
|
|
|
|
it("exactly 2000 passes the note check (boundary — the next check, not the note, refuses)", async () => {
|
|
// Malformed nodeIds AFTER a max-length note: reaching the nodeIds
|
|
// error proves the note check passed (all checks are rejecting-path;
|
|
// the pipeline is never reached — this suite's doctrine).
|
|
const res = await createPracticeSetResponse({ nodeIds: 5, params: PARAMS, note: "x".repeat(2000) });
|
|
assert.equal(res.status, 400);
|
|
const body = (await res.json()) as { error: string };
|
|
assert.match(body.error, /Body must be/);
|
|
});
|
|
});
|