Files
learnharness/tests/render-chain-table.test.tsx
T
amosblomqvist d6a7228b15 chain table round 3: waypoints icons gone + the alignment staircase (owner refinements)
- chain rows lose the WaypointsIcon (owner: not needed — the chips +
  connectors already read as chains); folders keep their icons.
- THE ALIGNMENT STAIRCASE: every level's checkbox sits directly under
  its parent's expander arrow. The expander now shares the checkbox's
  14px width (h-5 w-3.5), making each nesting step exactly 18px —
  clusters pl-3 (12px) → chains pl-7.5 (30px, the cluster expander) →
  statements pl-12 (48px, the chain expander). Live-measured: 318=318,
  336=336.
2026-09-30 00:15:47 +03:00

280 lines
14 KiB
TypeScript

/**
* THE CHAIN TABLE — SSR render pins (the render-suite discipline: pure
* bodies, renderToStaticMarkup, testids). The owner redesign
* (2026-09-29 evening): full-bleed table (blur + translucency IS the
* surface), cluster → chain → statement hierarchy (a chain lives in its
* CONCLUSION's birth cluster; expanding a chain reveals statements
* directly — names live in the line, never twice), proposition CHIPS +
* → connectors (a lonely chip = a standalone proposition; the "(no
* premises)" annotation is dead), rotating chevrons, folder/waypoints
* icons, a floating bottom selection bar that never shifts layout, and
* a fuzzy search that auto-expands matching clusters.
*
* ROUND 2 (owner refinements, 2026-09-29 late): the top bar is THE
* shared TopBar (h-15, lh-drag + select-none, sidebar reopen, standard
* title size); PROMINENT indentation carries the hierarchy — the ONLY
* lines left are the separators between cluster groups (vertical column
* hairlines and per-row lines are gone); statement rows are PLAIN (no
* conclusion marker); ALL THREE columns sort (Props too — consistency)
* with a SMALL chevron on the active header.
*/
import React from "react";
(globalThis as Record<string, unknown>).React = React;
import assert from "node:assert/strict";
import { renderToStaticMarkup } from "react-dom/server";
import { describe, it } from "node:test";
import { ChainTableBody } from "../components/chain-table.tsx";
import type { ChainSort } from "../components/chain-table.tsx";
import type { GraphEdge, GraphNode } from "../src/core/contracts.ts";
/** The fixture graph — two follows-chains + one standalone:
* a → c1 ← b (chain one, conclusion born chat1), d → e (chain two,
* conclusion born notes1), solo (singleton born chat1). b is born
* chat2 — a PREMISE-only birth: no chain concludes there, so chat2
* never appears as a group (the conclusion's-cluster law). */
function node(id: string, name: string, statement: string, chatId: string | null): GraphNode {
return {
id,
name,
statement,
aliases: [] as string[],
state: "new",
createdAt: "2026-09-20T10:00:00.000Z",
provenance: chatId === null ? [] : [{ chatId, messageId: `m_${id}` }],
} as unknown as GraphNode;
}
const NODES: GraphNode[] = [
node("a", "Premise one", "Statement A.", "chat1"),
node("b", "Premise two", "Statement B.", "chat2"),
node("c1", "Conclusion", "Statement C.", "chat1"),
node("d", "Support", "Statement D.", null),
node("e", "Follow-up", "Statement E with keyword zebra.", "notes1"),
node("solo", "Standalone", "Statement S.", "chat1"),
node("orphan", "Orphan", "Statement O.", null),
];
const EDGES: GraphEdge[] = [
{ from: "a", to: "c1", type: "follows" },
{ from: "b", to: "c1", type: "follows" },
{ from: "d", to: "e", type: "follows" },
] as GraphEdge[];
const BASE = {
nodes: NODES,
edges: EDGES,
sessions: { chat1: "Ethics lesson", chat2: "Second chat" },
fileSources: { notes1: "notes/raw/ethics.md" },
query: "",
onQuery: () => {},
sort: { col: "name", dir: 1 } as ChainSort,
onSort: () => {},
selection: new Set<string>(),
expandedClusters: new Set<string>(),
expandedChains: new Set<string>(),
onToggleCluster: () => {},
onToggleChain: () => {},
onToggleNodes: () => {},
onClear: () => {},
onGenerate: () => {},
onClose: () => {},
};
function render(props: Partial<typeof BASE> = {}) {
return renderToStaticMarkup(React.createElement(ChainTableBody, { ...BASE, ...props }));
}
describe("ChainTableBody — clusters (the outermost layer)", () => {
it("collapsed by default: cluster rows render, chain rows do not", () => {
const html = render();
assert.ok(html.includes('data-testid="cluster-group-chat1"'), "the chat cluster");
assert.ok(html.includes('data-testid="cluster-group-notes1"'), "the notes cluster");
assert.ok(html.includes("Ethics lesson"), "chat label");
assert.ok(html.includes("notes/raw/ethics.md"), "notes label");
assert.ok(html.includes("lucide-folder"), "the closed folder icon");
assert.ok(!html.includes('data-testid="chain-row-c1"'), "no chain row when collapsed");
assert.ok(!html.includes("Premise one"), "no chips when collapsed");
});
it("a premise-only birth never becomes a group — chains live in their CONCLUSION's cluster", () => {
const html = render();
assert.ok(!html.includes("cluster-group-chat2"), "chat2 births only a premise");
assert.ok(!html.includes("Second chat"), "its label never renders");
});
it("an unnameable CONCLUSION birth forms one honest muted unlabeled group", () => {
const html = render();
assert.ok(html.includes("unlabeled"), "the muted label");
// orphan (birth null) concludes its own singleton chain → the group exists;
// d (also birth null) is a premise of e and never forms one
assert.ok(html.includes('data-testid="chain-row-orphan"') === false, "collapsed, like every group");
});
it("cluster rows carry checkbox + counts + newest date; notes kind marked", () => {
const html = render();
assert.ok(html.includes('data-testid="cluster-checkbox-chat1"'));
// chat1: chains c1 (a, b, c1) + solo (solo) → 4 member ids
assert.ok(html.includes(">4</span>"), "chat1's proposition count");
assert.ok(html.includes("2026-09-20"), "the newest-member date");
assert.ok(html.includes(">notes</span>"), "the notes kind tag");
});
});
describe("ChainTableBody — THE shared TopBar + the lines law (owner, round 2)", () => {
it("the body renders the standardized top bar: h-15, lh-drag, select-none, standard title size, close X", () => {
const html = render();
assert.ok(html.includes("lh-drag"), "the window-drag band");
assert.ok(html.includes("select-none"), "dragging never highlights the title");
assert.ok(html.includes("h-15"), "the standard height");
assert.ok(html.includes('font-title text-3xl tracking-tight">Chains<'), "the standard title size");
assert.ok(html.includes('data-testid="chain-table-close"'), "the close X");
assert.ok(html.includes('data-testid="chain-table-search"'), "the search input");
});
it("the ONLY lines are the separators between cluster groups — no per-row or vertical lines", () => {
const html = render({ expandedClusters: new Set(["chat1"]) });
// group wrappers: every group but the last carries the separator
const sep = html.split("border-b border-border/60").length - 1;
assert.ok(sep >= 2, "separators between groups");
// chain rows themselves carry NO border — their entire class list is
// the staircase law (pl-7.5 = under the cluster's expander arrow);
// the chip outlines' border-border/70 is an outline, not a row line
assert.ok(html.includes('class="flex items-center gap-1 py-1 pl-7.5 pr-3"'), "the chain row: staircase indent, no border");
});
});
describe("ChainTableBody — chain rows (chips + connectors)", () => {
it("names render as outlined chips with → connectors BETWEEN them", () => {
const html = render({ expandedClusters: new Set(["chat1"]) });
assert.ok(html.includes('data-testid="chain-row-c1"'));
assert.ok(html.includes('data-testid="prop-chip-a"'), "premise chip");
assert.ok(html.includes('data-testid="prop-chip-c1"'), "conclusion chip");
assert.ok(html.includes("Premise one"), "chip text");
assert.ok(html.includes('data-testid="chain-arrow-c1-1"'), "the connector");
assert.ok(html.includes("→"), "the arrow glyph");
// owner ruling (round 3): the chain waypoints icons are GONE — the
// chips + connectors already read as chains; only folders keep icons
assert.ok(!html.includes("lucide-waypoints"), "no chain icon");
});
it("a singleton renders ONE lonely chip, no connector; the annotation survives only for screen readers", () => {
const html = render({ expandedClusters: new Set(["chat1"]) });
assert.ok(html.includes('data-testid="chain-row-solo"'));
assert.ok(html.includes('data-testid="prop-chip-solo"'));
assert.ok(!html.includes('data-testid="chain-arrow-solo-1"'), "no connector on a singleton");
// the visible line is the chip alone; "(no premises)" exists ONLY as the
// row's aria-label (the a11y one-liner) — exactly one occurrence
assert.equal(html.split("no premises").length - 1, 1, "aria-label only, never visible text");
assert.ok(html.includes('aria-label="Standalone (no premises)"'));
});
it("the row carries the one-line derivation as its aria-label (core formatChainLine)", () => {
const html = render({ expandedClusters: new Set(["chat1"]) });
assert.ok(html.includes('aria-label="Premise one, Premise two → Conclusion"'));
});
it("expanding a chain reveals member STATEMENTS directly — PLAIN rows, no conclusion marker (owner, round 2)", () => {
const html = render({
expandedClusters: new Set(["chat1"]),
expandedChains: new Set(["c1"]),
});
assert.ok(html.includes('data-testid="prop-row-a"'), "premise statement row");
assert.ok(html.includes("Statement A."), "the statement text, one click deep");
assert.ok(html.includes("Statement C."), "the conclusion statement");
// owner ruling: the derivation is already encoded in the chain line —
// no conclusion marker down here
assert.ok(!html.includes("prop-conclusion"), "no conclusion marker anywhere");
// THE ALIGNMENT STAIRCASE (owner ruling, round 3): each level's
// checkbox sits under its parent's expander arrow. The expander
// shares the checkbox's 14px width, so each step is 18px: clusters
// pl-3 (12) → chains pl-7.5 (30 = the cluster expander) →
// statements pl-12 (48 = the chain expander)
assert.ok(html.includes("pl-12"), "statements under the chain's expander");
assert.ok(html.includes("pl-7.5"), "chains under the cluster's expander");
assert.ok(html.includes("h-5 w-3.5"), "the expander shares the checkbox's 14px width");
});
});
describe("ChainTableBody — the sortable table headers", () => {
it("ALL THREE columns are sort controls with aria-sort (owner: consistency is key)", () => {
const html = render();
assert.ok(html.includes('data-testid="sort-name"'));
assert.ok(html.includes('data-testid="sort-props"'));
assert.ok(html.includes('data-testid="sort-created"'));
assert.ok(html.includes('aria-sort="ascending"'), "default name A→Z");
// the small chevron (size-3 lucide) marks the ACTIVE header only —
// no giant text triangles (owner, round 2)
assert.ok(html.includes('lucide-chevron-up size-3'), "small up chevron on active name");
assert.ok(html.includes('lucide-chevron-down') === false, "no down chevron while ascending");
});
it("descending state shows on the active header only", () => {
const html = render({ sort: { col: "created", dir: -1 } });
assert.ok(html.includes('data-testid="sort-created"'));
assert.ok(html.includes('aria-sort="descending"'));
assert.ok(html.includes('aria-sort="none"'), "the inactive column");
assert.ok(html.includes('lucide-chevron-down size-3'), "small down chevron");
});
it("Props sort orders cluster rows AND chains within (largest-first by default)", () => {
const html = render({ sort: { col: "props", dir: 1 }, expandedClusters: new Set(["chat1"]) }); // ascending: smallest first
const unlabeled = html.indexOf("cluster-group-\0unlabeled");
const notes = html.indexOf('data-testid="cluster-group-notes1"');
const chat = html.indexOf('data-testid="cluster-group-chat1"');
assert.ok(unlabeled > 0 && notes > 0 && chat > 0, "all three groups render");
assert.ok(unlabeled < notes && notes < chat, "1 < 2 < 4 member ids ascending");
// within chat1: the singleton (1) sorts before the three-member chain
const soloRow = html.indexOf('data-testid="chain-row-solo"');
const c1Row = html.indexOf('data-testid="chain-row-c1"');
assert.ok(soloRow > 0 && c1Row > 0 && soloRow < c1Row, "chain sizes ascending within the cluster");
});
});
describe("ChainTableBody — the floating selection bar (never shifts layout)", () => {
it("absent when nothing is selected", () => {
const html = render({ expandedClusters: new Set(["chat1"]) });
assert.ok(!html.includes('data-testid="chain-selection-bar"'));
});
it("appears with the derived N propositions → M chains + Clear + Generate", () => {
const html = render({ selection: new Set(["a", "b", "c1"]) });
assert.ok(html.includes('data-testid="chain-selection-bar"'));
assert.ok(html.includes('data-testid="chain-selected-summary"'));
assert.ok(html.includes("3 propositions → 1 chain"));
assert.ok(html.includes('data-testid="chain-clear"'));
assert.ok(html.includes('data-testid="chain-generate"'));
});
it("a premise WITHOUT its conclusion derives as the singleton it becomes", () => {
const html = render({ selection: new Set(["a", "d"]) });
assert.ok(html.includes("2 propositions → 2 chains"), "no follows-edge survives inside the selection");
});
});
describe("ChainTableBody — the fuzzy search (grouped + auto-expand)", () => {
it("matching clusters auto-expand to reveal their chains; others hide; the bar is unaffected", () => {
const aliased = NODES.map((n) => (n.id === "b" ? { ...n, aliases: ["zebra alias"] } : n));
const html = render({
nodes: aliased,
query: "zebra",
selection: new Set(["a", "b", "c1"]), // selection spans BOTH chains
});
// zebra hits: chain e (statement) + chain c1 (alias on b)
assert.ok(html.includes('data-testid="chain-row-c1"'), "auto-expanded cluster reveals the chain");
assert.ok(html.includes('data-testid="chain-row-e"'), "statement match");
assert.ok(!html.includes('data-testid="chain-row-solo"'), "non-matching chain hidden");
assert.ok(!html.includes("cluster-group-notes1") === false, "notes1 still renders (it has a match)");
assert.ok(!html.includes("Ethics lesson") === false, "chat1 still renders (it has a match)");
// the floating bar is never search-filtered
assert.ok(html.includes("3 propositions → 1 chain"));
});
it("no matches: the honest empty line", () => {
const html = render({ query: "qqqq" });
assert.ok(html.includes('data-testid="chain-table-nomatch"'));
assert.ok(html.includes("No matching chains."));
});
});