Files
learnharness/tests/clusters.test.ts
T
amosblomqvist f0267a5fd9 Clusters phases B+C: labeling records, the naming call, snapshot payload
Core-survival labelings (vision section 1, DECIDED 2026-09-13):
ClusterLabeling records in a new append-only ledger
(data/graph/cluster-labels.jsonl), immutable, id = clu_ + sha256 of the
sorted core so re-naming races and re-runs dedupe at the store seam.
matchClusterLabelings (core/clusters.ts, pure): a community keeps a
record's label while at least half its core survives in it; both sides
single-successor (a split keeps one name; greedy by overlap, ties to
the newer record).

The namer (src/agent/subagents/cluster-namer.ts): ONE singular cheap LLM
call (new 'labeler' role, glm-flash/low) names every new/changed
community at once, given member names + statements (capped at 12
members per cluster). refreshClusterLabels runs POST-EXTRACTION
(user-decided) from both front doors, fire-and-forget — naming failure
never fails the run; refreshes serialize behind a chain so parallel
imports never mint duplicate labels. import-notes.ts awaits
clusterNamingSettled before exit.

Payload: GraphSnapshot.clusters (>= MIN_CLUSTER_SIZE 3) joins detection
with labelings at read time — claimed clusters carry the record's label
and id; unlabeled ones carry a member-hash id and null label. Detection
is deterministic so no memo in v1 (ms at current scale; revisit at
vault scale).

Tests (372/372): matcher half-rule/split/merge/greedy/tie cases; naming
end-to-end through importNotes (one call, one record, claim on
re-refresh), naming failure non-fatal; snapshot derivation with
labeling join; 11 test pipelines now pin an explicit labeler seam.
2026-09-13 03:59:48 +03:00

161 lines
7.0 KiB
TypeScript

/**
* Community detection tests (vision §1, DECIDED 2026-09-13) — pure
* structural Louvain over follows+supports, deterministic via seed.
* Assertions are on SHAPE and MEMBER SETS, never community indices
* (indices reshuffle; member sets are what labelings key to).
*/
import { strict as assert } from "node:assert";
import { describe, test } from "node:test";
import { detectCommunities, matchClusterLabelings, MIN_CLUSTER_SIZE } from "../src/core/clusters.ts";
import type { Community } from "../src/core/clusters.ts";
import type { ClusterLabeling } from "../src/core/contracts.ts";
const ids = (n: number, prefix = "n") => [...Array(n).keys()].map((i) => `${prefix}${i}`);
/** A clique on the given ids. */
const clique = (nodeIds: string[]) =>
nodeIds.flatMap((a, i) => nodeIds.slice(i + 1).map((b) => ({ from: a, to: b })));
const labeling = (id: string, core: string[], createdAt = "2026-09-01T00:00:00.000Z"): ClusterLabeling => ({
id,
label: `label-${id}`,
core,
createdAt,
});
describe("matchClusterLabelings", () => {
test("claims a labeling while at least half its core survives in the community", () => {
const community: Community = { members: ["a", "b", "c", "d", "e"] };
const records = [labeling("clu_1", ["a", "b", "x", "y"])]; // 2 of 4 survive — exactly half
const [claim] = matchClusterLabelings([community], records);
assert.equal(claim?.id, "clu_1");
// One fewer survivor: under half → relabel.
const [dead] = matchClusterLabelings([{ members: ["a", "c", "d", "e", "f"] }], records);
assert.equal(dead, null);
});
test("single successor: a split core keeps its label in only one community", () => {
const records = [labeling("clu_1", ["a", "b", "c", "d"])];
const left: Community = { members: ["a", "b", "z"] }; // 2 of 4 — half
const right: Community = { members: ["c", "d", "w"] }; // 2 of 4 — half
// Tie: larger overlap wins; equal → both eligible, greedy takes first come.
const claims = matchClusterLabelings([left, right], records);
const claimed = claims.filter((c) => c !== null);
assert.equal(claimed.length, 1);
assert.equal(claimed[0]?.id, "clu_1");
});
test("greedy: the best-overlapping community wins the record", () => {
const records = [labeling("clu_1", ["a", "b", "c", "d"])];
const weak: Community = { members: ["a", "b", "q", "r", "s"] }; // 2/4
const strong: Community = { members: ["a", "b", "c", "x", "y"] }; // 3/4
const claims = matchClusterLabelings([weak, strong], records);
assert.equal(claims[0], null);
assert.equal(claims[1]?.id, "clu_1");
});
test("one record per community; newest record breaks ties", () => {
const oldR = labeling("clu_old", ["a", "b"], "2026-09-01T00:00:00.000Z");
const newR = labeling("clu_new", ["a", "b"], "2026-09-02T00:00:00.000Z");
const community: Community = { members: ["a", "b", "c"] };
const [claim] = matchClusterLabelings([community], [oldR, newR]);
assert.equal(claim?.id, "clu_new");
});
test("no labelings: every community unclaimed; empty communities array ok", () => {
assert.deepEqual(matchClusterLabelings([{ members: ["a", "b"] }], []), [null]);
assert.deepEqual(matchClusterLabelings([], [labeling("clu_1", ["a"])]), []);
});
test("MIN_CLUSTER_SIZE is 3 (the render/naming threshold)", () => {
assert.equal(MIN_CLUSTER_SIZE, 3);
});
});
describe("detectCommunities", () => {
test("two dense cliques joined by a single bridge split into two communities", () => {
const left = ids(4, "L");
const right = ids(4, "R");
const bridge = { from: "L0", to: "R0" };
const result = detectCommunities([...left, ...right].map((id) => ({ id })), [...clique(left), ...clique(right), bridge]);
assert.equal(result.communities.length, 2);
assert.equal(result.modularity > 0.3, true);
// Member sets, not order: the two big communities are exactly the cliques.
const big = result.communities.filter((c) => c.members.length === 4);
assert.deepEqual(big.map((c) => c.members.sort()).sort(), [left.slice().sort(), right.slice().sort()]);
});
test("deterministic: same graph, same seed → identical partition", () => {
const nodes = ids(10).map((id) => ({ id }));
const edges = [...clique(ids(5)), ...clique(ids(5, "n").slice().reverse().slice(0, 5)), { from: "n0", to: "n9" }];
const a = detectCommunities(nodes, edges);
const b = detectCommunities(nodes, edges);
assert.deepEqual(a.communities, b.communities);
assert.equal(a.modularity, b.modularity);
});
test("no edges: every node is its own singleton community", () => {
const result = detectCommunities(ids(3).map((id) => ({ id })), []);
assert.equal(result.communities.length, 3);
for (const c of result.communities) assert.equal(c.members.length, 1);
assert.equal(result.modularity, 0);
});
test("empty graph: zero communities", () => {
assert.deepEqual(detectCommunities([], []), { communities: [], modularity: 0 });
});
test("duplicate and reversed pairs collapse to one edge (undirected, unweighted)", () => {
const nodes = ["a", "b", "c"].map((id) => ({ id }));
// follows a→b AND supports b→a — same pair twice, both directions.
const result = detectCommunities(nodes, [
{ from: "a", to: "b" },
{ from: "b", to: "a" },
{ from: "b", to: "c" },
]);
assert.equal(result.communities.length, 1);
assert.deepEqual(result.communities[0]!.members.sort(), ["a", "b", "c"]);
});
test("self-loops and unknown-endpoint edges are skipped defensively", () => {
const nodes = ["a", "b"].map((id) => ({ id }));
const result = detectCommunities(nodes, [
{ from: "a", to: "a" }, // self-loop
{ from: "a", to: "ghost" }, // dangling
{ from: "ghost1", to: "ghost2" },
{ from: "a", to: "b" }, // the one real edge
]);
assert.equal(result.communities.length, 1);
assert.deepEqual(result.communities[0]!.members.sort(), ["a", "b"]);
});
test("members are sorted; communities ordered by size then id", () => {
const left = ids(4, "L");
const right = ids(4, "R");
const result = detectCommunities(
[...left, ...right, "iso"].map((id) => ({ id })),
[...clique(left), ...clique(right), { from: "L0", to: "R0" }],
);
for (const c of result.communities as Community[]) {
const sorted = c.members.slice().sort();
assert.deepEqual(c.members, sorted);
}
// iso (isolated) is last: size 1 < 4.
const last = result.communities[result.communities.length - 1]!;
assert.deepEqual(last.members, ["iso"]);
});
test("seed override changes nothing structurally but stays deterministic", () => {
const nodes = ids(8).map((id) => ({ id }));
const edges = [...clique(["n0", "n1", "n2", "n3"]), ...clique(["n4", "n5", "n6", "n7"]), { from: "n0", to: "n4" }];
const a = detectCommunities(nodes, edges, { seed: "one" });
const b = detectCommunities(nodes, edges, { seed: "one" });
const c = detectCommunities(nodes, edges, { seed: "two" });
assert.deepEqual(a.communities, b.communities);
// A different seed partitions the same graph into member sets that
// may or may not coincide — but both runs are 2 communities here,
// because the structure dominates.
assert.equal(c.communities.length, 2);
});
});