sorokin.oleg.edu
9fd76aef3a
Preserve raw include diagnostic provenance and derive bands from the existing shaped editor. Retain deferred tooltip paragraphs through rendering. Include source, regression, failure and native-trial evidence; corrected native acceptance remains pending.
39 lines
5.0 KiB
Markdown
39 lines
5.0 KiB
Markdown
# Final source delta and native recorder review
|
|
|
|
**PASS, bounded static/evidence review.** No source edit, Cargo invocation, UI action, or post was performed. The new final desktop/CLI gate remains outside this result.
|
|
|
|
Compared `annotation-projection-cost-2`, `desktop-full-1`, and `strict-clippy-3` under `C:/ar-text-9e8r6t/.local/text-diagnostic-gates`. Receipt-pinned manifest, archive, stdout and stderr bytes/hashes match originals. The first two runs have identical 604-input manifests and ZIP bytes. Strict Clippy has the same 604-member set; every final ZIP member's uncompressed bytes/hash matches the manifest, and all 604 currently frozen source files match it.
|
|
|
|
The exact changed inputs are only:
|
|
|
|
- `crates/oa-desktop/src/source_annotations.rs`: nested successful-intersection and positive-bound checks become one `if let ... && ...` chain. Both intersections are still evaluated as the same tuple; positivity is still evaluated only after both match, in the same short-circuit order. The identical Band is pushed under the identical conditions. No anchor, admission, projection skip, cache, or authority change.
|
|
- `crates/oa-desktop/src/source_annotations/layout_tests.rs`: seven singleton `&[range]` arguments become `std::slice::from_ref(&(range))`, with formatting. Each argument remains a one-element slice of the same Range value, valid for the same call. No oracle or test-scope change.
|
|
|
|
`strict-clippy-3` completed `cargo clippy --locked --offline --workspace --all-targets -- -D warnings` at 2026-09-13 07:11:37.366532 UTC, exit 0, unchanged inputs. The prior exact-optimized-source `desktop-full-1` reports 892 passed, zero failed, six ignored, 249.02s. That is not the still-running final-source desktop/CLI result.
|
|
|
|
The prior manual anchor/geometry and performance evidence remains applicable to this mechanical semantic-equivalent delta. Retain its original measured source hash and raw samples: this review justifies reuse, not a claim that final-byte performance was remeasured. The earlier limits remain, including unmeasured dense empty-span fallback, Windows debug timing scope, and pending native acceptance. No additional manual performance run is justified by this delta alone.
|
|
|
|
## Recorder
|
|
|
|
Read the corrected `.local/text-diagnostic-native/native-recorder.js`. The earlier `{window:s.window, ...args}` override issue is fixed to `{...args, window:s.window}`. Each allowed action now uses the observed target; coordinate actions also take their screenshot ID from that observation. State is cleared before exactly one `sky[kind]` call and restored only after an awaited fresh `get_window_state`. An action/refresh failure leaves state unavailable, requiring reobservation. Exclusive `wx` writes preserve existing captures; metadata retains observed window/accessibility and screenshot metadata. Partial archival failure is possible and does not silently replace old evidence.
|
|
|
|
The helper archives after an action only when given a label. Pre-action archival is a separate explicit `recordDiagnosticTrial` call, as parent plans; the code does not enforce that sequencing by itself. The metadata timestamp is archival time, not an independently established pixel-acquisition timestamp.
|
|
|
|
There is no hover method in the supplied Sky API. Proposed `scroll({scrollX:0,scrollY:0,x,y})` must be treated as an experiment until actual observation shows pointer movement and diagnostic feedback, with before/after viewport, focus and selected-byte checks. Even unchanged visible state cannot establish that it emitted only CursorMoved: a delivered WheelScrolled event can invalidate the existing raw interaction clock. A successful workaround can support native geometry/feedback observations, not a claim that the workaround is passive or preserves navigation tickets. The recorder itself makes no unsupported hover call.
|
|
|
|
## Exact bindings
|
|
|
|
| Artifact | SHA-256 |
|
|
| --- | --- |
|
|
| Optimized/desktop-full-1 inputs manifest | `076377a1a48c4c3a4b176073ca96e79fd1ec300b22fe1ab1abfc5dd68c46fffe` |
|
|
| Optimized/desktop-full-1 inputs ZIP | `c5a6e697e1490a0be7af39c30b926a31e09a42e5a4120b40157d807eca7e7a70` |
|
|
| `desktop-full-1/result.json` | `16038532298031435222bd09142b8bc7a958ec10f616d1f1a19fb057f22f21aa` |
|
|
| Final strict inputs manifest | `1483d0d67756ee6c6b4dff640150a71a87b4fc9e842bbfd22a1e2388e9bf1000` |
|
|
| Final strict inputs ZIP | `b860a8fd4cb733540290faa4bcf5c805e207f23e595fe56e708199a3b4e82b84` |
|
|
| `strict-clippy-3/result.json` | `2438d897d1f2688d4c3cbf1f23c33faafdd11f975d27509a5f4d159ae030cfc3` |
|
|
| Final `source_annotations.rs` (12,005 bytes) | `cb96e3a06ac2dd7e255f488d7cbe3387082a8505ce0de269ef34371d376acd8c` |
|
|
| Final `layout_tests.rs` (11,345 bytes) | `234c72d925f96de43e41c9231b01e2b80f68ffc3519d052bac5f248092f9ff50` |
|
|
| Corrected native recorder | `ce04a2fa7f511c24891af63577a1cf03e9fa620eccd4bed845ebfd2dd83692fd` |
|
|
|
|
The captures describe working-tree candidate bytes. Their recorded base HEAD does not establish that these changes are committed or published. Related prior evidence and timing caveats: `final-annotation-geometry-review.md` in this private directory.
|