64 lines
3.7 KiB
Markdown
64 lines
3.7 KiB
Markdown
# Text integration source review
|
|
|
|
The isolated candidate **554cfbd9fe6fd64f0eb3012bcbb3efd7a95f7424** combines the
|
|
compact Text workspace and source diagnostics with the root's newer chooser,
|
|
selection, rename-preview and navigation boundaries. It is accepted for fresh
|
|
compilation and interaction checks; **no combined runtime acceptance is claimed**.
|
|
|
|
The base is `feab2020d8e5b6bfdb59c86ab4aee161617b8b6f`. Earlier peer production
|
|
`9fd76aef3ae2810667d3f2b031fc43692fc04c89` is a source comparator, not evidence
|
|
that this combined candidate passed its tests. Gitea issue27 owns integration
|
|
and verification. Linux remains deferred by the user.
|
|
|
|
## Decisions and review
|
|
|
|
- Retain the latest admitted References result across hiding and departure;
|
|
retention alone must not authorize navigation, reopen a drawer, or replace
|
|
the current selection. Exact result snapshot bytes and captured interaction
|
|
context remain necessary for navigation. See the
|
|
[retention review](text-retained-results-independent-review-20260913.md).
|
|
- Keep the editor, diagnostic sensor/guard and owned tooltip paragraphs mounted
|
|
while combining root chooser/input admission. Accepted local Text actions must
|
|
retire pending diagram navigation and allocation intent; passive scroll reports
|
|
must remain inert. The [full source review](text-union-final-independent-review-20260913.md)
|
|
documents exact scope and test-inventory checks.
|
|
- That review found a recovery defect at immutable `92ff99eb`: filtering a
|
|
pending-save notice also made previously stale warnings current. Correction
|
|
`554cfbd` captures the old diagnostic publication's freshness first, retains
|
|
warning data, and republishes only previously current diagnostics. The
|
|
[independent correction review](text-recovery-publication-fix-independent-review-20260913.md)
|
|
accepts the source repair and its two discriminating authored tests.
|
|
|
|
The parent inspected the complete recovery diff and both independent reviews.
|
|
The current/stale controls preserve applied drafts, the accepted Project, source
|
|
bytes, cursor and history, and exercise a real recovery journal plus an explicitly
|
|
injected reload-error result. These tests remain unrun at this checkpoint.
|
|
|
|
## Verification required
|
|
|
|
Obtain the actual desktop listing and reconcile it with the source inventory,
|
|
then run the Text, diagnostics, local-boundary, lifecycle/recovery and retained
|
|
root selection/rename checks. Run the combined full desktop suite, changed core
|
|
include-provenance checks and affected consumers, strict checks and a matching GUI
|
|
build. Inspect the actual native editor, tooltips, drawers, chooser/rename blocking,
|
|
stale actions, navigation and recovery workflows. Validate the vendored dependency
|
|
and notices in the package. Preserve exact ignored-case scope and all failures.
|
|
|
|
Old 581/615-input build records do not cover this candidate: the Cargo patch,
|
|
71 vendored files, scripts and changed core provenance must be included in fresh
|
|
input capture. Source-level inventory counts are not test results.
|
|
|
|
## Preserved records
|
|
|
|
`manifest.json` binds the original local review records, handoffs and source
|
|
inventories copied byte-for-byte into this directory. Original absolute paths or
|
|
`.local/` references describe the review machine, not a shared filesystem. For a
|
|
record named in that manifest, use its basename in this directory. Production
|
|
paths are repository-relative at their explicitly identified source commits.
|
|
The immutable review of `92ff99eb` intentionally keeps its original repair-required
|
|
disposition; the later correction review supersedes only that finding.
|
|
|
|
These records are reusable source-review evidence, not a live task ledger, a
|
|
full requirements review or a release. The complete application objective and
|
|
public source8/analysis work remain unfinished.
|