Minimal-color round 2 (owner): the chip is label-only — spinner out of the top bar
The round-1 experiment put the braille spinner in the chip's old dot slot; rejected live: the pill's curve and the square braille cell fought for space (visually squeezed), and the chat surface already shows in-flight work (thinking shimmer, the dock) — the chip stating the phase is its whole job. PhaseChip back to a label-only pill (busy prop removed, single-child gap dropped); work-state lives in exactly one place: the sidebar row's spinner. Doc note + test pin the decision so it doesn't get re-tried blind. Gates: typecheck, lint, 469/469, build.
This commit is contained in:
@@ -30,16 +30,10 @@ describe("PhaseChip (header)", () => {
|
||||
}
|
||||
});
|
||||
|
||||
it("busy: the old dot slot becomes the braille spinner (motion = turn in flight)", () => {
|
||||
const html = renderToStaticMarkup(<PhaseChip phase="teach" busy />);
|
||||
assert.ok(html.includes('data-testid="braille-spinner"'), "spinner in the chip");
|
||||
assert.ok(html.includes("Teaching"), "label stays");
|
||||
assert.ok((html.match(/class="braille-frame"/g) ?? []).length === 10, "all ten frames");
|
||||
});
|
||||
|
||||
it("idle: no spinner — the chip is the label alone", () => {
|
||||
it("NEVER shows a working spinner — the pill's curve suits text, not glyph cells (owner, round 2)", () => {
|
||||
const html = renderToStaticMarkup(<PhaseChip phase="teach" />);
|
||||
assert.ok(!html.includes("braille-spinner"));
|
||||
assert.ok(!html.includes("braille-spinner"), "the chip is label-only by design");
|
||||
assert.ok(!html.includes("braille-frame"), "no spinner frames leak in");
|
||||
});
|
||||
});
|
||||
|
||||
|
||||
Reference in New Issue
Block a user