Files
learnharness/components/settings/settings-dialog.tsx
T
amosblomqvist 48fbd988f1 Wave-5 chunk B: three model slots, search-engine row, first-run setup flow
Chunk B (owner-designed, model-slots wave) on the merged engine surface
(main 1d66a17):

AGENT SECTION — SLOTS ONLY (owner ruling)
- The six per-role model rows are GONE; three slot rows instead:
  Strong (Prober + Teacher), Cheap (five workhorse roles), Vision
  (visual maker + PDF reader), roster + resolved-default in every hint.
- Slot dropdowns share the app's menu language over the FEDERATED
  catalog (/api/models = keyed providers only, fresh per call — saving
  a key in Keys immediately widens the picker); the vision slot
  filters to image-capable models (Model.input); the menu's highlight
  now matches provider+id (ids can collide across providers).
- Slots write the new models section (PUT /api/settings/models) through
  the dialog's write seam; per-role overrides stay schema-only.
- ModelMenuList rows read 'provider · id' — federation makes the
  provider bookkeeping-relevant. Usage stamps render provider-qualified
  (prettyModel(qualified): 'Glm 5.3 Flash · openrouter') in the stats
  bar's turn lines.

SEARCH ENGINE (search wave: no default, owner)
- A row in Tools: Tavily/Brave via the shared-menu look, Automatic =
  the pin removed (auto-activation). The live reason line comes from
  /api/search; no engine key at all grays the whole row + disables the
  trigger (a keyless choice would only block auto-activation).

FIRST-RUN SETUP FLOW (owner design A: composer CTA + send interception)
- Chats cannot start until all three slots are picked — no defaults
  for 33 providers (slotsConfigured: all three slot models required).
- The graph view's new-session dock (home) shows a 'Set up your models'
  CTA while unconfigured; submitting a topic opens the SetupDialog WITH
  THE DRAFT PRESERVED; Save stores the models section and the queued
  message sends. Same interception on /chat/new sends.
- STAGED BY DEPENDENCY (owner: keys first, models after): no keyed
  provider → stage 1 deep-links the settings dialog on Keys (open now
  takes a section); a saved key reopens at stage 2 on the next submit.
- Stage 2: Strong → Cheap → Vision pickers (federated, vision-filtered,
  all three required). Closable without configuring — browsing stays
  possible; the gate is the send, not the dialog. Layered Esc: an open
  slot menu eats Esc before the dialog.
- Two closure bugs caught live: onDone→start/send captured the stale
  pre-save 'configured' (the flow now forces the replayed send); menu-Esc
  used to close the whole dialog.

Settings-dialog provider: open(section?) lands on a section (stage 1
deep-link). Tests: composeSlotModel/composeSearchEngine pure, slot SSR
replacing role rows, slotsConfigured/setupStage first-run gates,
provider-qualified prettyModel. Gates: typecheck, lint, 792/792, build.
2026-09-22 13:54:29 +03:00

339 lines
10 KiB
TypeScript

"use client";
/**
* THE SETTINGS DIALOG (settings-app wave, 2026-09-20): the thin settings
* page graduated into the designed surface — a centered modal over
* everything, left section nav + one scrolling content column.
*
* Owner decisions this wave:
* - Dialog, not a page: opens over whatever screen you're on (the payoff:
* appearance edits restyle the chat LIVE behind the dialog). Escape,
* backdrop, and ✕ all close. Modal-only — /settings redirects, so
* nothing links into a dead surface.
* - Left section nav in the app's mono chrome (text-only, session-list
* language — active = bg-accent), no icons, matching the minimal-color
* doctrine.
* - The dialog is surface-agnostic by construction: the sections talk to
* /api/settings* and localStorage only, so this shell can be re-mounted
* as a true OS window in the Electron round with near-zero churn.
*
* The record + the single `write` seam moved here from the thin page:
* one record instance for the whole dialog, sections write through it,
* switching sections never refetches.
*/
import {
createContext,
useCallback,
useContext,
useEffect,
useState,
} from "react";
import { createPortal } from "react-dom";
import {
CURRENT_SETTINGS_VERSION,
type AgentSettings,
type AppearanceSettings,
type GraphSettings,
type UserSettings,
} from "@/src/core";
import { useAppearance } from "./appearance.tsx";
import { SettingsSection, SettingsRow, Toggle } from "./controls.tsx";
import { AgentSection } from "./agent-section.tsx";
import type { ModelsSettings } from "@/src/core";
import { KeysSection } from "./keys-section.tsx";
import { AppearanceSection, GraphSection } from "./appearance-section.tsx";
import { KeyboardSection } from "./keyboard-section.tsx";
/** Owner (2026-09-20): hints earn their place — mechanics-explaining
* prose is out; only the keyboard note stays (storage location is a
* real question users ask). */
const SECTIONS = [
{ id: "general", label: "General" },
{ id: "keys", label: "Keys" },
{ id: "agent", label: "Agent" },
{ id: "appearance", label: "Appearance" },
{ id: "graph", label: "Graph" },
{ id: "keyboard", label: "Keyboard", hint: "Stored on this device" },
] as const;
type SectionId = (typeof SECTIONS)[number]["id"];
const DialogContext = createContext<{ open: (section?: string) => void }>({ open: () => {} });
/** AppShell-level mount: the sidebar row and the mod+, chord call this.
* `open(section)` lands the dialog on a specific section (the first-run
* setup flow deep-links to Keys when no provider key exists yet). */
export function SettingsDialogProvider({
children,
}: {
children: React.ReactNode;
}) {
const [show, setShow] = useState(false);
const [landOn, setLandOn] = useState<SectionId>("general");
const open = useCallback((section?: string) => {
if (section) setLandOn(section as SectionId);
setShow(true);
}, []);
return (
<DialogContext.Provider value={{ open }}>
{children}
{show && <SettingsDialog onClose={() => setShow(false)} initialSection={landOn} />}
</DialogContext.Provider>
);
}
export function useSettingsDialog() {
return useContext(DialogContext);
}
function SettingsDialog({ onClose, initialSection }: { onClose: () => void; initialSection: SectionId }) {
// Plain dim backdrop (no blur — nothing decorative); the click
// closes, the dialog body stops propagation.
return createPortal(
<div
className="fixed inset-0 z-50 flex items-center justify-center bg-background/80"
data-testid="settings-backdrop"
onClick={onClose}
>
<SettingsDialogBody onClose={onClose} initialSection={initialSection} />
</div>,
document.body,
);
}
/** The dialog without the portal/backdrop — the SSR-testable frame
* (portals render nothing under renderToStaticMarkup). */
export function SettingsDialogBody({
onClose,
initialSection = "general",
}: {
onClose: () => void;
initialSection?: SectionId;
}) {
const { onAppearanceChange } = useAppearance();
const [record, setRecord] = useState<UserSettings | null | undefined>(
undefined,
);
const [error, setError] = useState<string | null>(null);
const [active, setActive] = useState<SectionId>(initialSection);
// Fetch once per dialog mount. 200 {settings: null} is FIRST BOOT
// (no record = factory everything), not a failure — the error state is
// a non-200 or a network throw only.
useEffect(() => {
fetch("/api/settings")
.then((r) =>
r.ok ? r.json() : Promise.reject(new Error(`status ${r.status}`)),
)
.then((body: { settings: UserSettings | null }) =>
setRecord(body.settings ?? { version: CURRENT_SETTINGS_VERSION }),
)
.catch(() => setRecord(null));
}, []);
// Escape closes — the layered-dismiss convention (Esc is dead for the
// sections' own editors while they hold focus; this listener is the
// dialog's outer layer).
useEffect(() => {
const onKey = (e: KeyboardEvent) => {
if (e.key === "Escape") onClose();
};
window.addEventListener("keydown", onKey);
return () => window.removeEventListener("keydown", onKey);
}, [onClose]);
/** ONE writer for the whole dialog: PUT the whole section, keep the
* record mirror in sync, surface route errors inline (a 400 is a
* schema mistake caught by the validation surface). */
const write = useCallback(
async (
section: "general" | "agent" | "models" | "appearance" | "graph",
body: object,
) => {
setError(null);
const res = await fetch(`/api/settings/${section}`, {
method: "PUT",
headers: { "content-type": "application/json" },
body: JSON.stringify(body),
});
if (!res.ok) {
const detail = (await res.json().catch(() => ({}))) as {
error?: string;
};
setError(`${section}: ${detail.error ?? res.status}`);
return;
}
setRecord(
(prev) => ({ ...(prev ?? {}), [section]: body }) as UserSettings,
);
if (section === "appearance")
onAppearanceChange(body as AppearanceSettings);
},
[onAppearanceChange],
);
return (
<div
role="dialog"
aria-modal="true"
aria-label="Settings"
data-testid="settings-dialog"
className="settings-dialog-pop flex h-[620px] max-h-[85vh] w-[920px] max-w-[90vw] flex-col overflow-hidden rounded-md border border-border bg-card shadow-xl"
onClick={(e) => e.stopPropagation()}
>
{/* Header — the app's quiet CMU title language. */}
<header className="flex h-15 shrink-0 items-center gap-3 border-b border-border px-5">
<h2 className="font-title text-2xl tracking-tight">Settings</h2>
<button
type="button"
aria-label="Close settings"
data-testid="settings-close"
className="ml-auto size-7 rounded-sm text-muted-foreground transition-colors hover:bg-accent hover:text-foreground"
onClick={onClose}
>
<svg
viewBox="0 0 16 16"
className="mx-auto size-3.5"
fill="none"
stroke="currentColor"
strokeWidth="1.5"
>
<path d="M4 4l8 8M12 4l-8 8" />
</svg>
</button>
</header>
<div className="flex min-h-0 flex-1">
{/* Left nav — text-only, the session-list mono language,
active = bg-accent. */}
<nav
aria-label="Settings sections"
data-testid="settings-nav"
className="flex w-44 shrink-0 flex-col gap-1 border-r border-border p-2"
>
{SECTIONS.map((s) => (
<button
key={s.id}
type="button"
data-testid={`settings-nav-${s.id}`}
aria-current={active === s.id}
className={`rounded-sm px-3 py-1.5 text-left font-ui text-sm transition-colors ${
active === s.id
? "bg-accent text-foreground"
: "text-muted-foreground hover:bg-accent hover:text-foreground"
}`}
onClick={() => setActive(s.id)}
>
{s.label}
</button>
))}
</nav>
{/* Content column — one section at a time, this scrolls. */}
<div
className="min-w-0 flex-1 overflow-y-auto"
data-testid="settings-content"
>
{error && (
<p
role="alert"
className="m-4 rounded-sm border border-red-500/40 px-3 py-2 text-xs text-red-500"
data-testid="settings-error"
>
{error}
</p>
)}
{record === undefined ? (
<p className="px-6 py-5 text-xs text-muted-foreground/70">
Loading settings…
</p>
) : record === null ? (
<p className="px-6 py-5 text-xs text-muted-foreground/70">
Settings could not be loaded — refresh to retry.
</p>
) : (
<div>
{active === "general" && (
<SettingsSection
title="General"
testid="section-general"
>
<SettingsRow
label="Auto-update"
hint="The update mechanism ships in a later wave"
testid="row-auto-update"
>
<Toggle
checked={record.general?.autoUpdate ?? true}
label="auto update"
onChange={(on) =>
void write("general", { autoUpdate: on })
}
/>
</SettingsRow>
</SettingsSection>
)}
{active === "keys" && (
<SettingsSection title="Keys" testid="section-keys">
<KeysSection />
</SettingsSection>
)}
{active === "agent" && (
<SettingsSection
title="Agent"
testid="section-agent"
>
<AgentSection
agent={record.agent}
models={record.models}
onModelsChange={(next: ModelsSettings) =>
void write("models", next)
}
onSectionChange={(next: AgentSettings) =>
void write("agent", next)
}
/>
</SettingsSection>
)}
{active === "appearance" && (
<SettingsSection
title="Appearance"
testid="section-appearance"
>
<AppearanceSection
appearance={record.appearance}
onSectionChange={(next: AppearanceSettings) =>
void write("appearance", next)
}
/>
</SettingsSection>
)}
{active === "graph" && (
<SettingsSection
title="Graph"
testid="section-graph"
>
<GraphSection
graph={record.graph}
onSectionChange={(next: GraphSettings) =>
void write("graph", next)
}
/>
</SettingsSection>
)}
{active === "keyboard" && (
<SettingsSection
title="Keyboard"
hint="Stored on this device"
testid="section-keyboard"
>
<KeyboardSection />
</SettingsSection>
)}
</div>
)}
</div>
</div>
</div>
);
}