amosblomqvist
976be50a81
Owner polish dispatch (2026-09-23): - Right-click no longer pins a node or opens the detail card: the canvas pointerdown/up handlers now gate on the primary button, so the context menu arrives alone. - Node context menu: label is just "Delete" and the shell hugs its content (w-44 -> w-fit); the menu body keeps focus for arrow cycling but never shows the browser's default focus ring (outline-none on the MenuShell body - applies to every menu). - Delete confirm: "Delete node?" title in CMU Serif, red (text-destructive); the node name sits below in JetBrains Mono inline-code; the Delete button carries the destructive treatment (border + tint, fill deepens on hover). Rest of the dialog stays neutral. - Sidebar rename row: text and metadata stay at the idle row's x - the status spacer and the input's border/padding are gone; the underline is the only editing cue.
76 lines
3.4 KiB
TypeScript
76 lines
3.4 KiB
TypeScript
import React from "react";
|
|
(globalThis as Record<string, unknown>).React = React;
|
|
|
|
import { renderToStaticMarkup } from "react-dom/server";
|
|
import { describe, it } from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import { RenameRow, SessionRow } from "../components/sidebar.tsx";
|
|
import { DELETE_OPTIONS, DeleteSessionDialog } from "../components/delete-session-dialog.tsx";
|
|
import type { ChatListItem } from "../src/core/index.ts";
|
|
|
|
/**
|
|
* Wave 6 chunk A — the deletion + context-menu seams on the sidebar:
|
|
* SessionRow's right-click seam (always carries the row testid now), the
|
|
* inline RenameRow (same geometry, select-all entry), and the two-option
|
|
* delete dialog's plain-language copy (the locked design: both options
|
|
* name their reach, the graph-touching one says so).
|
|
*/
|
|
|
|
const chat: ChatListItem = {
|
|
id: "c1",
|
|
title: "Wave mechanics",
|
|
updatedAt: new Date().toISOString(),
|
|
busy: false,
|
|
} as unknown as ChatListItem;
|
|
|
|
describe("SessionRow — the right-click seam", () => {
|
|
it("rows carry the session-row testid (context menu anchors to it)", () => {
|
|
const html = renderToStaticMarkup(<SessionRow chat={chat} active={false} onOpen={() => {}} />);
|
|
assert.ok(html.includes('data-testid="session-row"'));
|
|
});
|
|
});
|
|
|
|
describe("RenameRow — the inline rename surface", () => {
|
|
it("renders the draft input with the current title, keeping the meta line", () => {
|
|
const html = renderToStaticMarkup(
|
|
<RenameRow chat={chat} onCommit={() => {}} onCancel={() => {}} />,
|
|
);
|
|
assert.ok(html.includes('data-testid="session-rename-input"'));
|
|
// controlled draft starts from the current title
|
|
assert.ok(html.includes(`value="${chat.title}"`));
|
|
// the meta line rides along (row never changes height mid-edit)
|
|
assert.ok(html.includes("session-rename-row"));
|
|
// (owner, polish round) NOTHING MOVES: no status spacer, no input
|
|
// border/padding — the draft text sits at the idle row's title x,
|
|
// and the input is the ONLY shift-proof editing cue (underline).
|
|
assert.ok(!html.includes("w-3.5 shrink-0"), "no always-on spacer (idle rows have none)");
|
|
const input = html.split('data-testid="session-rename-input"')[1]?.split("/>")[0] ?? "";
|
|
assert.ok(input.includes("px-0"), "input carries no left padding");
|
|
assert.ok(input.includes("border-b"), "the underline is the editing cue");
|
|
assert.ok(!input.includes("bg-background"), "no filled field box — text stays put");
|
|
});
|
|
});
|
|
|
|
describe("DeleteSessionDialog — the locked two-option copy (portals no-op in SSR; pin the pure seam)", () => {
|
|
it("closed (chat=null) renders nothing", () => {
|
|
const html = renderToStaticMarkup(
|
|
<DeleteSessionDialog chat={null} onClose={() => {}} onDeleted={() => {}} />,
|
|
);
|
|
assert.equal(html, "");
|
|
});
|
|
|
|
it("exactly two options, both modes covered, consequences in plain language", () => {
|
|
assert.equal(DELETE_OPTIONS.length, 2);
|
|
const modes = DELETE_OPTIONS.map((o) => o.mode).sort();
|
|
assert.deepEqual(modes, ["delete-nodes", "preserve-graph"]);
|
|
});
|
|
|
|
it("the graph-touching option says so; the session-only option promises the graph stays", () => {
|
|
const preserve = DELETE_OPTIONS.find((o) => o.mode === "preserve-graph");
|
|
const nodes = DELETE_OPTIONS.find((o) => o.mode === "delete-nodes");
|
|
assert.ok(preserve?.body.includes("graph stays"));
|
|
assert.ok(nodes?.body.includes("leave the graph"));
|
|
// shared-topics survival is stated on the destructive option
|
|
assert.ok(nodes?.body.includes("survive"));
|
|
});
|
|
}); |