amosblomqvist
b19e7e7eae
Owner-approved full pass (tooltip wave, 2026-09-25). Mechanism: icon/pill controls ride the styled Radix tooltip via a new Hint composition (components/ui/hint.tsx) — the shared primitive adopted as-is, no restyling; the shortcut appends as an em-dash suffix off the LIVE registry (a rebind in Settings → Keyboard changes the suffix): "Dictate — ⌘D". Surface-owned keys (Esc closes, Enter submits) ride a raw binding prop. Native title= stays only for truncation-reveals (dock spans, the rename field) and menu-interior abbreviations (MenuShell untouched). One em-dash pattern; per-state truth on the send square (busy = "Stop the reply — Esc", idle = "Send — ↵"), Enter on the plan verdict's accept, "Stop dictation (Esc)" kept verbatim per the owner's flag. Copy: the dev-speak cull — no pipeline/prober/tier/wave vocabulary anywhere a user reads. New pins in tests/tooltip-mechanism.test.tsx (hintText composition, asChild no-wrapper-DOM, the auto-update hint constant); dock truncation titles pinned native; graph-chrome + settings pins updated to the new copy. Live-verified on :3001 — 12.6ms hover appearance (no native 1s lag); glyphs render on every suffixed surface (⌘D, ⌘K, ⌘⇧F, ⌘,, ⌘B, F2, ↵, Esc); per-page probes confirm Settings entry, Home logo, session search, Start session, Close sidebar, model + thinking pills, stats summary, rename title, plan chip, coverage ring, send square, cost button, node search (⌘F), graph gear, settings close (Close — Esc), keyboard section "Fixed — part of this screen", auto-update hint, light-mode "Coming soon", the three slot rosters, graph-tools hint. Esc still closes the settings dialog.
61 lines
2.8 KiB
TypeScript
61 lines
2.8 KiB
TypeScript
/**
|
|
* Tooltip-wave mechanism pins (owner, 2026-09-25): the composition rule —
|
|
* icon/pill controls ride the styled Radix tooltip via Hint, the shortcut
|
|
* appended as an em-dash suffix off the LIVE registry (a rebind changes
|
|
* the suffix); truncation-reveals keep native title=; the copy carries no
|
|
* internal vocabulary. Node has no navigator → IS_MAC is false → the mod
|
|
* glyph renders "Ctrl+" here; the composition logic is the pin, not the
|
|
* platform glyph. (Node 26 ships navigator.platform — on this Mac the real
|
|
* ⌘/⇧ glyphs render, so they're pinned as-is.)
|
|
*/
|
|
|
|
import React from "react";
|
|
(globalThis as Record<string, unknown>).React = React;
|
|
|
|
import assert from "node:assert/strict";
|
|
import { describe, it } from "node:test";
|
|
import { createElement } from "react";
|
|
import { renderToStaticMarkup } from "react-dom/server";
|
|
import { Hint, hintText } from "../components/ui/hint.tsx";
|
|
import { AUTO_UPDATE_HINT } from "../components/settings/settings-dialog.tsx";
|
|
|
|
describe("hintText — the em-dash composition", () => {
|
|
it("a registry action appends the LIVE binding (override-aware source)", () => {
|
|
assert.equal(hintText("Dictate", "toggle-dictation"), "Dictate — ⌘D");
|
|
assert.equal(hintText("Settings", "open-settings"), "Settings — ⌘,");
|
|
assert.equal(hintText("Search sessions", "sessions-search"), "Search sessions — ⌘⇧F");
|
|
});
|
|
|
|
it("surface-owned keys ride the binding prop (no registry entry)", () => {
|
|
assert.equal(hintText("Close", undefined, "escape"), "Close — Esc");
|
|
assert.equal(hintText("Send", undefined, "enter"), "Send — ↵");
|
|
});
|
|
|
|
it("no shortcut = the label alone, no dangling dash", () => {
|
|
assert.equal(hintText("Home"), "Home");
|
|
assert.equal(hintText("Stop dictation (Esc)"), "Stop dictation (Esc)");
|
|
});
|
|
});
|
|
|
|
describe("spot-pins: the dev-speak cull (owner copy review at merge)", () => {
|
|
it("the auto-update hint is honest user language — no stream jargon", () => {
|
|
assert.equal(AUTO_UPDATE_HINT, "Automatic updates arrive in an upcoming release");
|
|
assert.ok(!AUTO_UPDATE_HINT.includes("wave"), "no stream vocabulary");
|
|
});
|
|
});
|
|
|
|
describe("Hint — the mechanism (SSR: the tooltip itself stays closed)", () => {
|
|
it("asChild: no wrapper DOM — the control keeps its own testid and classes", () => {
|
|
const html = renderToStaticMarkup(
|
|
createElement(Hint, {
|
|
label: "Dictate",
|
|
action: "toggle-dictation",
|
|
children: createElement("button", { "data-testid": "dictation-toggle", className: "the-quiet-chrome" }, "Dictate"),
|
|
}),
|
|
);
|
|
assert.match(html, /^<button/, "the trigger IS the button — nothing wraps it");
|
|
assert.ok(html.includes('data-testid="dictation-toggle"'));
|
|
assert.ok(html.includes("the-quiet-chrome"));
|
|
assert.ok(!html.includes("<span"), "no portal content renders while closed");
|
|
});
|
|
}); |