amosblomqvist
3e9a85d60f
The reported bug (2026-09-28): every chat ran glm-5.3-flash regardless of any pick, while composer and settings UIs agreed with each other and lied about the run. Root cause: a fossil default-settings record (settings.json chat section, frozen pre-slots-wave) was stamped verbatim into every new chat at birth by the new-session flow, and resolveConversationSpec prefers the per-chat record over the strong slot forever. Owner redesign — models are per session, always; the strong slot is the new-session default: - POST /api/chats stamps the newborn verbatim from the strong slot (model + thinking level); no client settings PUT on create anymore - the composer control is dual-bound: in-session it reads/writes the session's own record (GET /api/chats/:id, PUT .../settings); on the draft surfaces it binds the strong slot (picking there = changing the default) - thinking levels follow the identical mechanics (confirmed by owner) - the zombie default-settings system dies whole: useDefaultSettings, /api/settings/defaults, src/store/default-settings.ts, the chat section of UserSettings (sanitizer strips fossil copies), the legacy default-settings.json fold, and DEFAULT_SETTINGS_FILE - catalogDefaultsFor collapses to the strong slot alone - thinking display for a legacy unstamped session resolves exactly like the engine (session ?? strong ?? model ladder) Tests: new chat-birth-stamp suite pins the stamp, the unconfigured boot, the unset level, and the copy-not-live-view regression; defaults pins rewritten strong-only; legacy-migration suite deleted.
49 lines
2.0 KiB
TypeScript
49 lines
2.0 KiB
TypeScript
import {
|
|
clampChatLevel,
|
|
effectiveSettings,
|
|
getChat,
|
|
parseSettingsBody,
|
|
stores,
|
|
validateChatSettings,
|
|
} from "@/src/server";
|
|
import type { ChatSettings } from "@/src/core";
|
|
|
|
/**
|
|
* The per-chat model control (model-control wave): replace-whole settings —
|
|
* the picker sends the complete desired object ({} clears all overrides).
|
|
* PER-SESSION MODELS (owner, 2026-09-28): this route is THE in-session
|
|
* writer — the composer's control binds the session's own record; the
|
|
* strong slot is only the birth default and never reaches an existing
|
|
* session again.
|
|
* Validation is the catalog gate (src/server/model-catalog.ts): unknown
|
|
* provider/model is a 400. Thinking levels never reject (owner,
|
|
* interlude 2026-09-22): a pinned level clamps to the named model's
|
|
* nearest supported and the clamped value is stored. Effective next turn
|
|
* by construction (agents are stateless per turn).
|
|
*
|
|
* The body parsing itself is shared with the draft route
|
|
* (src/server/settings-body.ts, default-settings wave 2026-09-18).
|
|
*/
|
|
export async function PUT(req: Request, { params }: { params: Promise<{ id: string }> }) {
|
|
const { id } = await params;
|
|
if (!getChat(id)) return Response.json({ error: "Not found" }, { status: 404 });
|
|
|
|
const body = await req.json().catch(() => null);
|
|
const parsed = parseSettingsBody(body);
|
|
if (!parsed.ok) return Response.json({ error: parsed.error }, { status: 400 });
|
|
|
|
const verdict = validateChatSettings(parsed.settings);
|
|
if (!verdict.ok) {
|
|
return Response.json({ error: verdict.error, supported: verdict.supported }, { status: 400 });
|
|
}
|
|
|
|
// Replace-whole persists the validated, level-clamped object — no
|
|
// merges, so a stale client can never resurrect a cleared override.
|
|
// Clamp-on-write (owner, interlude 2026-09-22): a pinned thinking
|
|
// level never rejects — it clamps to the named model's nearest
|
|
// supported (body model, else the record's strong slot).
|
|
const settings = clampChatLevel(parsed.settings, effectiveSettings().models.strong);
|
|
stores.chatStore.saveSettings(id, settings);
|
|
return Response.json({ settings });
|
|
}
|